Subject: Re: bug#8744: Also use detect-coding-string?

From: Marco Pessotto <[email-masked]>
Date: Mon, 30 May 2011 16:18:47 +0200

Stefan Monnier <[email-masked]> writes:

>> The rcirc-decode-coding-system is by default set to 'utf-8, which is
>> (obviously a valid coding system), so the test, if i understand
>> correctly, would always be true.
>
>> My idea is that the client should try to detect automatically the
>> encoding used for each message received, using as first choices the
>> encodings set by the user. That's what all the major IRC clients do (like
>> irssi and weechat). 
>
> IIUC that's exactly what you'll get if you set
> rcirc-decode-coding-system to `undecided'.
>
>
>         Stefan

I tested this a bit and you're right. A line of documentation wouldn't
harm, anyway. Something like:

@@ -302,7 +302,9 @@ Called with 5 arguments, PROCESS, SENDER, RESPONSE, TARGET and TEXT."
   :group 'rcirc)
 
 (defcustom rcirc-decode-coding-system 'utf-8
-  "Coding system used to decode incoming irc messages."
+  "Coding system used to decode incoming irc messages.
+Set to 'undecided if you want the encoding of the incoming
+messages autodetected"
   :type 'coding-system
   :group 'rcirc)

Bests

-- 
Marco