GNU bug report logs - #8728
test 'stat-free-color' failed (latest git version v8.12-42-g7d44751)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8728 in the body.
You can then email your comments to 8728 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: test 'stat-free-color' failed (latest git version v8.12-42-g7d44751)
Date: Tue, 24 May 2011 22:09:43 +0200

[Message part 1 (text/plain, inline)]

The log of the failed test is attached.  I've not looked into it in any way.
Let me know if you need more information.

Regards,
  Stefano

[stat-free-color.log (text/x-log, inline)]

FAIL: ls/stat-free-color (exit: 1)
==================================

++ initial_cwd_=/home/stefano/src/coreutils/_build_bleeding/tests
++ fail=0
+++ testdir_prefix_
+++ printf gt
++ pfx_=gt
+++ mktempd_ /home/stefano/src/coreutils/_build_bleeding/tests gt-stat-free-color.XXXX
+++ case $# in
+++ destdir_=/home/stefano/src/coreutils/_build_bleeding/tests
+++ template_=gt-stat-free-color.XXXX
+++ MAX_TRIES_=4
+++ case $destdir_ in
+++ case $template_ in
++++ unset TMPDIR
++++ mktemp -d -t -p /home/stefano/src/coreutils/_build_bleeding/tests gt-stat-free-color.XXXX
+++ d=/home/stefano/src/coreutils/_build_bleeding/tests/gt-stat-free-color.r7or
+++ case $d in
+++ test -d /home/stefano/src/coreutils/_build_bleeding/tests/gt-stat-free-color.r7or
++++ ls -dgo /home/stefano/src/coreutils/_build_bleeding/tests/gt-stat-free-color.r7or
++++ tr S -
+++ perms='drwx------ 2 4096 May 24 21:58 /home/stefano/src/coreutils/_build_bleeding/tests/gt-stat-free-color.r7or'
+++ case $perms in
+++ test 0 = 0
+++ echo /home/stefano/src/coreutils/_build_bleeding/tests/gt-stat-free-color.r7or
+++ return
++ test_dir_=/home/stefano/src/coreutils/_build_bleeding/tests/gt-stat-free-color.r7or
++ cd /home/stefano/src/coreutils/_build_bleeding/tests/gt-stat-free-color.r7or
++ gl_init_sh_nl_='
'
++ IFS=' 	
'
++ for sig_ in 1 2 3 13 15
+++ expr 1 + 128
++ eval 'trap '\''Exit 129'\'' 1'
+++ trap 'Exit 129' 1
++ for sig_ in 1 2 3 13 15
+++ expr 2 + 128
++ eval 'trap '\''Exit 130'\'' 2'
+++ trap 'Exit 130' 2
++ for sig_ in 1 2 3 13 15
+++ expr 3 + 128
++ eval 'trap '\''Exit 131'\'' 3'
+++ trap 'Exit 131' 3
++ for sig_ in 1 2 3 13 15
+++ expr 13 + 128
++ eval 'trap '\''Exit 141'\'' 13'
+++ trap 'Exit 141' 13
++ for sig_ in 1 2 3 13 15
+++ expr 15 + 128
++ eval 'trap '\''Exit 143'\'' 15'
+++ trap 'Exit 143' 15
++ trap remove_tmp_ 0
+ path_prepend_ ../src
+ test 1 '!=' 0
+ path_dir_=../src
+ case $path_dir_ in
++ cd /home/stefano/src/coreutils/_build_bleeding/tests/../src
++ echo /home/stefano/src/coreutils/_build_bleeding/src
+ abs_path_dir_=/home/stefano/src/coreutils/_build_bleeding/src
+ case $abs_path_dir_ in
+ PATH=/home/stefano/src/coreutils/_build_bleeding/src:/home/stefano/src/coreutils/_build_bleeding/src:/home/stefano/go/bin:/home/stefano/bin/linux:/home/stefano/bin:/usr/local/bin:/opt/bin:/usr/lib/jvm/java-6-sun-1.6.0.20/bin:/usr/games:/usr/bin:/usr/sbin:/bin:/sbin
+ create_exe_shims_ /home/stefano/src/coreutils/_build_bleeding/src
+ case $EXEEXT in
+ return 0
+ shift
+ test 0 '!=' 0
+ export PATH
+ print_ver_ ls
+ test yes = yes
+ local i
+ for i in '$*'
+ env ls --version
ls (GNU coreutils) 8.12.42-7d447
Packaged by Bleeding Edge Support (v8.12-42-g7d44751)
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Richard M. Stallman and David MacKenzie.
+ require_strace_ stat
+ test 1 = 1
+ strace -V
+ strace -qe stat echo
+ require_dirent_d_type_
+ python
+ python /home/stefano/src/coreutils/_build_bleeding/../tests/d_type-check
+ ln -s nowhere dangle
+ cat
++ dircolors -b color-without-stat
+ eval 'LS_COLORS='\''rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:'\'';' export LS_COLORS
++ LS_COLORS='rs=0:di=01;34:ln=01;36:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=00:su=00:sg=00:ca=00:tw=00:ow=00:st=00:ex=00:mh=00:'
++ export LS_COLORS
+ strace -o log -e stat,lstat ls --color=always .
color-without-stat
dangle
log
++ wc -l
+ n_lines=0
+ test 0 = 1
+ fail=1
+ Exit 1
+ set +e
+ exit 1
+ exit 1
+ remove_tmp_
+ __st=1
+ cleanup_
+ :
+ cd /home/stefano/src/coreutils/_build_bleeding/tests
+ chmod -R u+rwx /home/stefano/src/coreutils/_build_bleeding/tests/gt-stat-free-color.r7or
+ rm -rf /home/stefano/src/coreutils/_build_bleeding/tests/gt-stat-free-color.r7or
+ exit 1

Message #8 received at 8728 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 8728 <at> debbugs.gnu.org
Subject: Re: bug#8728: test 'stat-free-color' failed (latest git version
	v8.12-42-g7d44751)
Date: Tue, 24 May 2011 23:10:41 +0200

Stefano Lattarini wrote:
> The log of the failed test is attached.  I've not looked into it in any way.
> Let me know if you need more information.
>
> Regards,
>   Stefano
>
> FAIL: ls/stat-free-color (exit: 1)
> ==================================
...
> + strace -o log -e stat,lstat ls --color=always .
> color-without-stat
...
> ++ wc -l
> + n_lines=0
> + test 0 = 1
> + fail=1

Hi Stefano,
Thanks for the report.
It would help to know why strace reported no matches.
Maybe it's due to alternate names like stat64?

If you apply the following patch and rerun that test,
it should provide that information:

    make check -C tests TESTS=ls/stat-free-color VERBOSE=yes

If my guess is correct, then adding ",stat64,lstat64"
to the strace command may be the solution:

   strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . || fail=1

From 06a94be331d7e31048f2bb4e659130159cd454f0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Tue, 24 May 2011 23:06:31 +0200
Subject: [PATCH] tests: stat-free-color: write more into the log upon failure

* tests/ls/stat-free-color: Print syscall log upon error,
to aid diagnosis.
---
 tests/ls/stat-free-color |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/ls/stat-free-color b/tests/ls/stat-free-color
index d11c6f4..f14beb9 100755
--- a/tests/ls/stat-free-color
+++ b/tests/ls/stat-free-color
@@ -49,6 +49,6 @@ eval $(dircolors -b color-without-stat)

 strace -o log -e stat,lstat ls --color=always . || fail=1
 n_lines=$(wc -l < log)
-test $n_lines = 1 || fail=1
+test $n_lines = 1 || { fail=1; cat log; }

 Exit $fail
--
1.7.5.2.585.gfbd48

Message #11 received at 8728 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 8728 <at> debbugs.gnu.org
Subject: Re: bug#8728: test 'stat-free-color' failed (latest git version
	v8.12-42-g7d44751)
Date: Tue, 24 May 2011 23:21:49 +0200

On Tuesday 24 May 2011, Jim Meyering wrote:
> Stefano Lattarini wrote:
> > The log of the failed test is attached.  I've not looked into it in any way.
> > Let me know if you need more information.
> >
> > Regards,
> >   Stefano
> >
> > FAIL: ls/stat-free-color (exit: 1)
> > ==================================
> ...
> > + strace -o log -e stat,lstat ls --color=always .
> > color-without-stat
> ...
> > ++ wc -l
> > + n_lines=0
> > + test 0 = 1
> > + fail=1
> 
> Hi Stefano,
> Thanks for the report.
> It would help to know why strace reported no matches.
> Maybe it's due to alternate names like stat64?
>
> If you apply the following patch and rerun that test,
> it should provide that information:
> 
>     make check -C tests TESTS=ls/stat-free-color VERBOSE=yes
>
The patch does not help to get more information IMHO, because the failure
is caused precisely by the fact that `log' is empty (as can be inferred by
the fact that n_lines=`wc -l <log` resulted in $n_lines being 0).

> If my guess is correct, then adding ",stat64,lstat64"
> to the strace command may be the solution:
> 
>    strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . || fail=1
>
Yes, this does indeed fix the failure.

> From 06a94be331d7e31048f2bb4e659130159cd454f0 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering <at> redhat.com>
> Date: Tue, 24 May 2011 23:06:31 +0200
> Subject: [PATCH] tests: stat-free-color: write more into the log upon failure
> 
> * tests/ls/stat-free-color: Print syscall log upon error,
> to aid diagnosis.
> ---
>  tests/ls/stat-free-color |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/ls/stat-free-color b/tests/ls/stat-free-color
> index d11c6f4..f14beb9 100755
> --- a/tests/ls/stat-free-color
> +++ b/tests/ls/stat-free-color
> @@ -49,6 +49,6 @@ eval $(dircolors -b color-without-stat)
> 
>  strace -o log -e stat,lstat ls --color=always . || fail=1
>  n_lines=$(wc -l < log)
> -test $n_lines = 1 || fail=1
> +test $n_lines = 1 || { fail=1; cat log; }
> 
>  Exit $fail
> --
> 1.7.5.2.585.gfbd48
> 

Thanks,
  Stefano

Message #16 received at 8728-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 8728-done <at> debbugs.gnu.org
Subject: Re: bug#8728: test 'stat-free-color' failed (latest git version
	v8.12-42-g7d44751)
Date: Wed, 25 May 2011 07:37:56 +0200

Stefano Lattarini wrote:
...
>> If my guess is correct, then adding ",stat64,lstat64"
>> to the strace command may be the solution:
>>
>>    strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . || fail=1
>>
> Yes, this does indeed fix the failure.

Thanks for confirming.  Here's the complete patch.

From 4cef42d22072899aae24b073016a5100981682b5 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Wed, 25 May 2011 07:35:59 +0200
Subject: [PATCH] tests: ls/stat-free-color: fix unwarranted failure on a
 32-bit system

* tests/ls/stat-free-color: Also check for stat64 and lstat64 syscalls.
This fixes a test failure reported by Stefano Lattarini.
---
 tests/ls/stat-free-color |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/ls/stat-free-color b/tests/ls/stat-free-color
index f14beb9..6bbd89c 100755
--- a/tests/ls/stat-free-color
+++ b/tests/ls/stat-free-color
@@ -47,7 +47,7 @@ MULTIHARDLINK 00
 EOF
 eval $(dircolors -b color-without-stat)

-strace -o log -e stat,lstat ls --color=always . || fail=1
+strace -o log -e stat,lstat,stat64,lstat64 ls --color=always . || fail=1
 n_lines=$(wc -l < log)
 test $n_lines = 1 || { fail=1; cat log; }

--
1.7.5.2.585.gfbd48

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.