GNU bug report logs - #8722
dbusbind.c fixes for integer issues, e.g., integer overflow

Previous Next

Full log

Message #8 received at 8722 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 8722 <at> debbugs.gnu.org
Subject: Re: bug#8722: dbusbind.c fixes for integer issues, e.g.,
	integer overflow
Date: Tue, 24 May 2011 09:04:49 +0200

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> I found some integer overflow issues in dbusbind.c and came up
> with the following patch which I'd like to install.  This doesn't
> fix all the integer overflow problems in dbusbind.c, but it makes
> some progress anyway.

On a raw look, it seems to be OK. Minor remark: Why do you need
xd_invalid_serial? You could call instead

  XD_SIGNAL2 (build_string ("Invalid dbus serial"), x);

which returns a `dbus-error', and which is more sensible when reading
DBus events.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.