From debbugs-submit-bounces@debbugs.gnu.org Thu May 19 04:08:16 2011 Received: (at submit) by debbugs.gnu.org; 19 May 2011 08:08:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMyHH-0004oD-S9 for submit@debbugs.gnu.org; Thu, 19 May 2011 04:08:16 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMyHG-0004nz-7t for submit@debbugs.gnu.org; Thu, 19 May 2011 04:08:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMyHA-00033d-1N for submit@debbugs.gnu.org; Thu, 19 May 2011 04:08:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RFC_ABUSE_POST, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:49270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMyH9-00033Z-W8 for submit@debbugs.gnu.org; Thu, 19 May 2011 04:08:07 -0400 Received: from eggs.gnu.org ([140.186.70.92]:52362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMyH9-00026a-1b for bug-gnu-emacs@gnu.org; Thu, 19 May 2011 04:08:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMyH8-00033P-4c for bug-gnu-emacs@gnu.org; Thu, 19 May 2011 04:08:07 -0400 Received: from mail-pz0-f41.google.com ([209.85.210.41]:47622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMyH7-00033L-VK for bug-gnu-emacs@gnu.org; Thu, 19 May 2011 04:08:06 -0400 Received: by pzk4 with SMTP id 4so1491990pzk.0 for ; Thu, 19 May 2011 01:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:x-debbugs-cc:date:message-id :mime-version:content-type; bh=ygBD0I4ovH/22KWcc9dBFDqDV9omdPv0Hzr+KABLjW4=; b=g5KST5RTN+lvmnGWZuRedlyIT7Iw7s8ik944Hz/ZjUenwt/+utjzai91EqQIfA0Xtv alIqath5F6XIWo5QUgnpnCcbDnVv0VCYJfZ20y4tianK434ldBCdVb4Gj1H+KmgdCw3P 28fC8Iat0F8Rba9LGHbloxXpkuZmKno39BKIw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; b=SpgjrjS+50T1UJteNE9bF+mZcSf9aUlzXBeaT4o2TRZz6rlTJZifuJUHsEYhFpI98h k5dGPgewn0zYs1RWabf5dQFyVapKMDtdzLxWwGrblS5uo/b/69BsoMkmynNTjWywwf8P P0jfNv47PnJzjYph6WqP9Bs16s3mfmRvTA0yA= Received: by 10.68.32.234 with SMTP id m10mr4109085pbi.13.1305792485117; Thu, 19 May 2011 01:08:05 -0700 (PDT) Received: from localhost ([123.123.249.163]) by mx.google.com with ESMTPS id r9sm1595007pbl.96.2011.05.19.01.08.02 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 19 May 2011 01:08:04 -0700 (PDT) From: Leo To: bug-gnu-emacs@gnu.org Subject: 23.3.50; [PATCH] Allow empty regions in transpose-region X-Debbugs-CC: Date: Thu, 19 May 2011 16:07:57 +0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) --=-=-= Content-Type: text/plain I found this odd primitive transpose-regions (which has not seen much use anywhere). I tried to use it a bit and found the annoying error when one of the two regions is empty. I wonder if the attached patch makes sense. Thanks. Leo --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Allow-empty-regions-in-transpose-region.patch Content-Description: 0001-Allow-empty-regions-in-transpose-region.patch >From 56cee3783dd30eaaf0b36f2fd8fa85525b6c4f2c Mon Sep 17 00:00:00 2001 Date: Sat, 14 May 2011 19:27:33 +0800 Subject: [PATCH] Allow empty regions in transpose-region --- src/editfns.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/editfns.c b/src/editfns.c index feae8316..1022b944 100644 --- a/src/editfns.c +++ b/src/editfns.c @@ -4411,8 +4411,9 @@ Transposing beyond buffer boundaries is an error. */) if (start2 < end1) error ("Transposed regions overlap"); - else if (start1 == end1 || start2 == end2) - error ("Transposed region has length 0"); + /* Nothing to change for adjacent regions with one being empty */ + else if ((start1 == end1 || start2 == end2) && end1 == start2) + return Qnil; /* The possibilities are: 1. Adjacent (contiguous) regions, or separate but equal regions -- 1.7.5-rc2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 18:50:21 2011 Received: (at submit) by debbugs.gnu.org; 25 May 2011 22:50:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QPMuD-0007D0-3z for submit@debbugs.gnu.org; Wed, 25 May 2011 18:50:21 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QPMuB-0007Ci-18 for submit@debbugs.gnu.org; Wed, 25 May 2011 18:50:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPMu5-0006TB-3o for submit@debbugs.gnu.org; Wed, 25 May 2011 18:50:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:54439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPMu5-0006T7-2V for submit@debbugs.gnu.org; Wed, 25 May 2011 18:50:13 -0400 Received: from eggs.gnu.org ([140.186.70.92]:60800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPMu4-00031G-Eb for bug-gnu-emacs@gnu.org; Wed, 25 May 2011 18:50:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPMu3-0006Ss-Lp for bug-gnu-emacs@gnu.org; Wed, 25 May 2011 18:50:12 -0400 Received: from lo.gmane.org ([80.91.229.12]:42922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPMu3-0006SR-Gh for bug-gnu-emacs@gnu.org; Wed, 25 May 2011 18:50:11 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QPMu1-0000qI-Rc for bug-gnu-emacs@gnu.org; Thu, 26 May 2011 00:50:09 +0200 Received: from th041074.ip.tsinghua.edu.cn ([59.66.41.74]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 26 May 2011 00:50:09 +0200 Received: from sdl.web by th041074.ip.tsinghua.edu.cn with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 26 May 2011 00:50:09 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Subject: Re: bug#8699: 23.3.50; [PATCH] Allow empty regions in transpose-region Date: Thu, 26 May 2011 06:49:58 +0800 Lines: 13 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: th041074.ip.tsinghua.edu.cn Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) Cancel-Lock: sha1:WsEkZzwymp4l68JEcq5FIaRqfvc= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) On 2011-05-19 16:07 +0800, Leo wrote: > Date: Sat, 14 May 2011 19:27:33 +0800 > Subject: [PATCH] Allow empty regions in transpose-region > > --- > src/editfns.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) No one seems to object to this patch. So I will put it in trunk later today. Thanks. Leo From debbugs-submit-bounces@debbugs.gnu.org Thu May 26 01:38:33 2011 Received: (at 8699-done) by debbugs.gnu.org; 26 May 2011 05:38:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QPTHF-0000fD-DB for submit@debbugs.gnu.org; Thu, 26 May 2011 01:38:33 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QPTHD-0000f2-MF for 8699-done@debbugs.gnu.org; Thu, 26 May 2011 01:38:32 -0400 Received: by pvh18 with SMTP id 18so159642pvh.3 for <8699-done@debbugs.gnu.org>; Wed, 25 May 2011 22:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=hJtk/vPJcMeIkXB414HtVLXwhuu/c/oK4FD/j+rIRf4=; b=BmRTD2EBMIAodejZ8mdI1gd4bw7IaY1FGvQw3XWuW7PPcYzw8mzUxntU04A4gep5hM OHdohpQjfJ+5Rn2sLosHutrW9PxC0UvLoitZJkyG/ZyXTs4uA7IsNJ6VBO41azAmx5mT w14El/4SuqfpF181K18wdfENxWFVpxJA3FQ84= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; b=YxKfmYsbuyZyfPFs9B/sEPiHRBqfzYVygnLX9lgJuPbwTDK033JN2itMif74Ldc4TB 8vJSKPKb28M1lYygk8Ty2+SeGBlQHCLouJDoNcWTyJyA6i7x61F1OJnbhLgsAFEIizN0 oM47ibQpF/ZXPWXXmKfzJR1cemWtaNnYEkwxE= Received: by 10.68.44.73 with SMTP id c9mr172630pbm.163.1306388305717; Wed, 25 May 2011 22:38:25 -0700 (PDT) Received: from localhost (th041107.ip.tsinghua.edu.cn [59.66.41.107]) by mx.google.com with ESMTPS id h1sm713145pbi.42.2011.05.25.22.38.22 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2011 22:38:24 -0700 (PDT) From: Leo To: 8699-done@debbugs.gnu.org Subject: Re: bug#8699: 23.3.50; [PATCH] Allow empty regions in transpose-region References: Date: Thu, 26 May 2011 13:38:16 +0800 In-Reply-To: (Leo's message of "Thu, 19 May 2011 16:07:57 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: 8699-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) version 24.1 From unknown Mon Jun 23 23:54:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Jun 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator