From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 21:33:20 2011 Received: (at submit) by debbugs.gnu.org; 19 May 2011 01:33:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMs76-0001fO-0U for submit@debbugs.gnu.org; Wed, 18 May 2011 21:33:20 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMs73-0001f9-B7 for submit@debbugs.gnu.org; Wed, 18 May 2011 21:33:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMs6x-0002V2-BV for submit@debbugs.gnu.org; Wed, 18 May 2011 21:33:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:43762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMs6x-0002Uy-AD for submit@debbugs.gnu.org; Wed, 18 May 2011 21:33:11 -0400 Received: from eggs.gnu.org ([140.186.70.92]:57156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMs6w-0006n6-Az for bug-gnu-emacs@gnu.org; Wed, 18 May 2011 21:33:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMs6v-0002Uj-0D for bug-gnu-emacs@gnu.org; Wed, 18 May 2011 21:33:10 -0400 Received: from mx1.aist.go.jp ([150.29.246.133]:55451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMs6u-0002Ub-Gj for bug-gnu-emacs@gnu.org; Wed, 18 May 2011 21:33:08 -0400 Received: from rqsmtp2.aist.go.jp (rqsmtp2.aist.go.jp [150.29.254.123]) by mx1.aist.go.jp with ESMTP id p4J1Wtf4022733; Thu, 19 May 2011 10:32:55 +0900 (JST) env-from (handa@m17n.org) Received: from smtp2.aist.go.jp by rqsmtp2.aist.go.jp with ESMTP id p4J1WtmX016548; Thu, 19 May 2011 10:32:55 +0900 (JST) env-from (handa@m17n.org) Received: by smtp2.aist.go.jp with ESMTP id p4J1Ws9e002722; Thu, 19 May 2011 10:32:54 +0900 (JST) env-from (handa@m17n.org) Received: from handa by etlken with local (Exim 4.71) (envelope-from ) id 1QMs6g-0000iz-GW; Thu, 19 May 2011 10:32:54 +0900 From: handa To: Paul Eggert Subject: Re: possibly-uninitialized variables in find_automatic_composition In-Reply-To: <4D841112.50403@cs.ucla.edu> (message from Paul Eggert on Fri, 18 Mar 2011 19:12:34 -0700) Importance: high Date: Thu, 19 May 2011 10:32:54 +0900 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Solaris 9 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) Very sorry for the late response on this matter. In article <4D841112.50403@cs.ucla.edu>, Paul Eggert writes: > In the Emacs trunk, src/composite.c's find_automatic_composition has > two local variables 'check' and 'prev' that gcc -Wuninitialized warns > as being possibly being uninitialized when used. This function has > multiple gotos and dependencies on data structures that I don't > understand, so it's not clear to me that GCC is wrong here. So I'm > filing a bug report in the hopes that someone more expert can look at it. > I plan to work around the diagnostic by committing the following > change, which adds a FIXME comment asking for initial value if needed, > and for the comment to be removed if the code is OK as-is. IF_LINT > is used to tell GCC not to issue a warning here, for now. > I'm CC:ing this to Kenichi Handa, who committed the code in question, > to give him a heads-up about the problem. Actually, those local variables are surely initialized when used. But as they are initialized under a specific condition (e.g. check_val is set to non-nil) and used under the same condition, it's difficult for gcc to detect that. Anyway, I've just committed an inproved version of find_automatic_composition, and gcc won't complain about it now. 2011-05-18 Kenichi Handa * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency. (BACKWARD_CHAR): Wrap the arg STOP by parenthesis. (find_automatic_composition): Mostly rewrite for efficiency. --- Kenichi Handa handa@m17n.org From debbugs-submit-bounces@debbugs.gnu.org Thu May 19 01:41:10 2011 Received: (at control) by debbugs.gnu.org; 19 May 2011 05:41:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMvyv-0007NA-SS for submit@debbugs.gnu.org; Thu, 19 May 2011 01:41:10 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMvyu-0007Mt-BB for control@debbugs.gnu.org; Thu, 19 May 2011 01:41:08 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QMvyo-0007HQ-VM for control@debbugs.gnu.org; Thu, 19 May 2011 01:41:03 -0400 Date: Thu, 19 May 2011 01:41:02 -0400 Message-Id: Subject: control message for bug 8697 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) unarchive 8290 forcemerge 8290 8697 From unknown Tue Jun 24 19:09:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 18 Jun 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator