From debbugs-submit-bounces@debbugs.gnu.org Tue May 17 11:52:26 2011 Received: (at submit) by debbugs.gnu.org; 17 May 2011 15:52:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMMZO-00030c-0O for submit@debbugs.gnu.org; Tue, 17 May 2011 11:52:26 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMMZM-00030Q-C6 for submit@debbugs.gnu.org; Tue, 17 May 2011 11:52:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMMZF-00076l-V7 for submit@debbugs.gnu.org; Tue, 17 May 2011 11:52:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RFC_ABUSE_POST, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:38273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMMZF-00076h-TX for submit@debbugs.gnu.org; Tue, 17 May 2011 11:52:17 -0400 Received: from eggs.gnu.org ([140.186.70.92]:37087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMMZE-0004hA-Dc for bug-gnu-emacs@gnu.org; Tue, 17 May 2011 11:52:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMMZC-00076L-VQ for bug-gnu-emacs@gnu.org; Tue, 17 May 2011 11:52:16 -0400 Received: from mail-qy0-f169.google.com ([209.85.216.169]:40601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMMZC-00076E-Pe for bug-gnu-emacs@gnu.org; Tue, 17 May 2011 11:52:14 -0400 Received: by qyk2 with SMTP id 2so2644492qyk.0 for ; Tue, 17 May 2011 08:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=MbPwsuW1FwYFqDM1fBPhnYcP1+fizvrFtAyICAbat94=; b=ZEpnsuQsxrtd3zRMfOV4E0ZATNg65N+NfK3BXPbfvsOT+eZhuuJCQ3R1w+lET/UCOn tsqz0SW+lfaWt5ugwz1XKPnRuz5NLxvB3P53itsKv/+/Siq45Ai8cYBChYYKKFH5c/AA 3UEtSzMQOEkCh04dryTVpTk2saE93RF6q9boU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=JJ5OfRAN1N+JWCe1E4amjYyPZTR/ALfM2xIGlfxqqJ9b3d/rHgMlBL05kKQ9RyqwXs oIDmJpTOv00zxejYRqLSjietRrfj7nCnM7mqVvhjUCaggf1bJwY/FvitIzL9ZvzWP6Nr roK8X1srEO9+QY11b/5Ewly6PxqfTgJPg9FGs= MIME-Version: 1.0 Received: by 10.229.37.7 with SMTP id v7mr559345qcd.299.1305647533231; Tue, 17 May 2011 08:52:13 -0700 (PDT) Received: by 10.229.189.85 with HTTP; Tue, 17 May 2011 08:52:12 -0700 (PDT) Date: Tue, 17 May 2011 08:52:12 -0700 Message-ID: Subject: 24.0.50; Grep mode trips up on Entering directory lines From: Brent Goodrick To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) This bug report will be sent to the Free Software Foundation, not to your local site managers! Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your report will be posted to the bug-gnu-emacs@gnu.org mailing list and the gnu.emacs.bug news group, and at http://debbugs.gnu.org. Please describe exactly what actions triggered the bug and the precise symptoms of the bug.=A0 If you can, give a recipe starting from `emacs -Q': When you are searching build logs for matches using M-x grep, and the resulting grep matches lines of the form: =A0 Entering directory `/some/bogus/directory/here' And if you then click on lines _after_ the line such as the "Entering directory" line, then you get a prompt asking about "Find this grep hit in" which is not correct grep mode like it probably is correct in compile mode. For some reason, this seems to only occur for cases where the grep buffer is saved to a file and then reloaded, but I have seen this occur in my non-"-Q" session for my own scripts I use to run grep (versus running grep directly), and I have not debugged it further than this bug I am reporting now that relies upon first saving the grep mode buffer to a file and reloading it (see below). You can reproduce this on Emacs built from scratch by following the following recipe that simulates it: 1. On Linux, cut and paste the following into a file called =A0=A0 /tmp/demo-bug.el: --- cut here --- (let* ((tmpdir (expand-file-name (make-temp-name "emacs-bug-demo-dir") temporary-file-directory)) =A0=A0=A0=A0=A0=A0 (fn1 (expand-file-name "somefile1.txt" tmpdir)) =A0=A0=A0=A0=A0=A0 (fn2 (expand-file-name "somefile2.txt" tmpdir)) =A0=A0=A0=A0=A0=A0 (saved-grep-file (expand-file-name "somegrep.txt" tmpdir= ))) =A0 (make-directory tmpdir t) =A0 (with-temp-file fn1 =A0=A0=A0 (insert "# | make[3]: Entering directory `/some/bogus/directory/h= ere'")) =A0 (with-temp-file fn2 =A0=A0=A0 (insert "This is a line that also has the Entering word on it. Click on this line in grep mode.")) =A0 ;; For debugging, just wipe out all other grep buffers from the current =A0 ;; session: =A0 (mapc (lambda (buffer) =A0=A0=A0 =A0 (with-current-buffer buffer =A0=A0=A0 =A0=A0=A0 (when (eq major-mode 'grep-mode) =A0=A0=A0 =A0=A0=A0=A0=A0 (kill-buffer buffer)))) =A0=A0=A0 (buffer-list)) =A0 ;; Force default-directory in some buffer to be that where our temporar= y files =A0 ;; reside, e.g., fn2 is good enough: =A0 (with-current-buffer (progn =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0(find-file fn2) =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0(current-buffer)) =A0=A0=A0 (grep "grep -n Entering *.txt") =A0=A0=A0 ;; Let the grep finish: =A0=A0=A0 (accept-process-output nil 1)) =A0 (with-current-buffer (get-buffer "*grep*") =A0=A0=A0 (let ((contents (buffer-string))) =A0=A0=A0=A0=A0 ;; Store the grep contents into a file (without this, the e= rror does not =A0=A0=A0=A0=A0 ;; reproduce ... I do not know why): =A0=A0=A0=A0=A0 (with-temp-file saved-grep-file =A0=A0=A0 (insert contents)) =A0=A0=A0=A0=A0 (find-file saved-grep-file) =A0=A0=A0=A0=A0 (goto-char (point-min)) =A0=A0=A0=A0=A0 (re-search-forward "Click on this line in grep mode") =A0=A0=A0=A0=A0 (call-interactively 'compile-goto-error)))) --- cut here --- 2. Execute the above file via this command: =A0=A0 emacs -Q -l /tmp/demo-bug.el: Notice that I call `compile-goto-error' interactively above to simulate what you would do if you hit the RETurn key on that line. You should expect to see a prompt for "Find this grep hit in" versus what it should do which is drive straight to that line that contains the "Click on this line in grep mode" string shown. Theory of cause: I conjecture that the fault lies in the fact that grep mode needs to define a variable called `grep-directory-matcher' that is the analog of `compilation-directory-matcher' which is deployed as a buffer local variable when the grep mode is defined with its call to `define-compilation-mode'. I have proved this by my hackaround this bug that I have in place right now, which is this in my .emacs: ;; Require grep mode first (require 'grep) ;; Hack in our definition of grep-directory-matcher and force grep mode to ;; use it. We have to do this after the above require of grep: (defvar grep-directory-matcher nil) (let* ((base (find-lisp-object-file-name 'grep (symbol-function 'grep))) =A0=A0=A0=A0=A0=A0 (grep-defining-elisp-file =A0=A0=A0 (car =A0=A0=A0 =A0(remove-if-not (lambda (fn) =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0 (file-exists-p fn)) =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 (list base =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0=A0=A0 (concat base ".gz")))))) =A0 (unless grep-defining-elisp-file =A0=A0=A0 (error "ASSERTION FAILED: Could not find grep defining file in order to hack it")) =A0 ;; Force the file to load which forces another evaluation of the call t= o =A0 ;; define-compilation-mode from within that file. This is the only way = I could =A0 ;; figure out how to hack around this problem other than globally setti= ng =A0 ;; compilation-directory-matcher to nil which is not right for all comp= ilation =A0 ;; mode buffers in general: =A0 (load grep-defining-elisp-file)) Thanks, bgoodr If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: =A0=A0=A0 `bt full' and `xbacktrace'. For information about debugging Emacs, please read the file /home/brentg/install/Linux.x86_64/share/emacs/24.0.50/etc/DEBUG. In GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1) =A0of 2011-01-15 on hungover Windowing system distributor `The X.Org Foundation', version 11.0.10707000 configured using `configure=A0 '--with-x-toolkit' '--with-xft' '--prefix=3D/home/brentg/install/Linux.x86_64'' Important settings: =A0 value of $LC_ALL: nil =A0 value of $LC_COLLATE: nil =A0 value of $LC_CTYPE: nil =A0 value of $LC_MESSAGES: nil =A0 value of $LC_MONETARY: nil =A0 value of $LC_NUMERIC: nil =A0 value of $LC_TIME: nil =A0 value of $LANG: en_US.UTF-8 =A0 value of $XMODIFIERS: nil =A0 locale-coding-system: utf-8-unix =A0 default enable-multibyte-characters: t Major mode: Grep Minor modes in effect: =A0 tooltip-mode: t =A0 mouse-wheel-mode: t =A0 tool-bar-mode: t =A0 menu-bar-mode: t =A0 file-name-shadow-mode: t =A0 global-font-lock-mode: t =A0 font-lock-mode: t =A0 blink-cursor-mode: t =A0 auto-composition-mode: t =A0 auto-encryption-mode: t =A0 auto-compression-mode: t =A0 line-number-mode: t =A0 transient-mark-mode: t Recent input: C-g M-x r e p o r t - e m a Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Grep finished (matches found) Mark set Quit Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr message sendmail rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug grep compile comint regexp-opt ring tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Tue May 17 14:15:38 2011 Received: (at 8684) by debbugs.gnu.org; 17 May 2011 18:15:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMOny-0006TX-3D for submit@debbugs.gnu.org; Tue, 17 May 2011 14:15:38 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMOnw-0006TL-6V for 8684@debbugs.gnu.org; Tue, 17 May 2011 14:15:36 -0400 Received: from [190.175.112.168] (port=10657 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QMOnq-0005G9-A7; Tue, 17 May 2011 14:15:30 -0400 Received: by ceviche.home (Postfix, from userid 20848) id EFD0166131; Tue, 17 May 2011 15:15:25 -0300 (ART) From: Stefan Monnier To: Brent Goodrick Subject: Re: bug#8684: 24.0.50; Grep mode trips up on Entering directory lines Message-ID: References: Date: Tue, 17 May 2011 15:15:25 -0300 In-Reply-To: (Brent Goodrick's message of "Tue, 17 May 2011 08:52:12 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8684 Cc: 8684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) > When you are searching build logs for matches using M-x grep, and the > resulting grep matches lines of the form: > =A0 Entering directory `/some/bogus/directory/here' > And if you then click on lines _after_ the line such as the "Entering > directory" line, then you get a prompt asking about "Find this grep > hit in" which is not correct grep mode like it probably is correct in > compile mode. Does the patch below help? Stefan =3D=3D=3D modified file 'lisp/progmodes/grep.el' --- lisp/progmodes/grep.el 2011-05-12 15:10:17 +0000 +++ lisp/progmodes/grep.el 2011-05-17 18:07:41 +0000 @@ -698,6 +698,7 @@ grep-hit-face) (set (make-local-variable 'compilation-error-regexp-alist) grep-regexp-alist) + (set (make-local-variable 'compilation-directory-matcher) nil) (set (make-local-variable 'compilation-process-setup-function) 'grep-process-setup) (set (make-local-variable 'compilation-disable-input) t) From debbugs-submit-bounces@debbugs.gnu.org Tue May 17 15:33:55 2011 Received: (at 8684) by debbugs.gnu.org; 17 May 2011 19:33:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMQ1j-0008Cy-5C for submit@debbugs.gnu.org; Tue, 17 May 2011 15:33:55 -0400 Received: from mail-qy0-f172.google.com ([209.85.216.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMQ1h-0008Cm-Es for 8684@debbugs.gnu.org; Tue, 17 May 2011 15:33:54 -0400 Received: by qyk29 with SMTP id 29so2417364qyk.3 for <8684@debbugs.gnu.org>; Tue, 17 May 2011 12:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=qcBBBwjICfD/tMsDQz6uRV41IxI0C/cCnPmHHC/GwqM=; b=xFEIAHGzSeYyOVaGwF/cVYqwZn2Ks342Td1VP5W7B3Ww7bUbyCNDscFlY4VvTZKdPX eLRANDRLzRwKKowvr0XELO//fALR1/eUSOTmZ95MUIDTBTE7lMCOI4NvDL9K7YnB7OCj Zpwc5mEGWdxD7H03L1dRuyP+WL0CcNVU54/0s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=NTja6Ow0A4X1b3q4EiZ4ZE0m6tzLfdYyvm233knFDQlZ8aEbsOui3PDnJ29Twyqkfn uVXByc0H9MlmoFOBzPT94kjxlK6YIOdLzah/VD5U912y7Hj0nxn00QntFXeDvjUiZJgt YZD4YJ0ebn8gXB2RsVjukLNL4RxYiLCKcUbV8= MIME-Version: 1.0 Received: by 10.229.214.204 with SMTP id hb12mr738846qcb.261.1305660827900; Tue, 17 May 2011 12:33:47 -0700 (PDT) Received: by 10.229.189.85 with HTTP; Tue, 17 May 2011 12:33:47 -0700 (PDT) In-Reply-To: References: Date: Tue, 17 May 2011 12:33:47 -0700 Message-ID: Subject: Re: bug#8684: 24.0.50; Grep mode trips up on Entering directory lines From: Brent Goodrick To: Stefan Monnier Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8684 Cc: 8684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) Hi Stefan, Yes, that does fix the issue and seems like an acceptable fix IMO. Thanks, bg On Tue, May 17, 2011 at 11:15 AM, Stefan Monnier wrote: >> When you are searching build logs for matches using M-x grep, and the >> resulting grep matches lines of the form: > >> =A0 Entering directory `/some/bogus/directory/here' > >> And if you then click on lines _after_ the line such as the "Entering >> directory" line, then you get a prompt asking about "Find this grep >> hit in" which is not correct grep mode like it probably is correct in >> compile mode. > > Does the patch below help? > > > =A0 =A0 =A0 =A0Stefan > > > =3D=3D=3D modified file 'lisp/progmodes/grep.el' > --- lisp/progmodes/grep.el =A0 =A0 =A02011-05-12 15:10:17 +0000 > +++ lisp/progmodes/grep.el =A0 =A0 =A02011-05-17 18:07:41 +0000 > @@ -698,6 +698,7 @@ > =A0 =A0 =A0 =A0grep-hit-face) > =A0 (set (make-local-variable 'compilation-error-regexp-alist) > =A0 =A0 =A0 =A0grep-regexp-alist) > + =A0(set (make-local-variable 'compilation-directory-matcher) nil) > =A0 (set (make-local-variable 'compilation-process-setup-function) > =A0 =A0 =A0 =A0'grep-process-setup) > =A0 (set (make-local-variable 'compilation-disable-input) t) > > From debbugs-submit-bounces@debbugs.gnu.org Tue May 17 16:56:42 2011 Received: (at 8684-done) by debbugs.gnu.org; 17 May 2011 20:56:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMRJp-0001dC-Ki for submit@debbugs.gnu.org; Tue, 17 May 2011 16:56:41 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QMRJo-0001d0-Fs for 8684-done@debbugs.gnu.org; Tue, 17 May 2011 16:56:41 -0400 Received: from [190.175.112.168] (port=11920 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QMRJi-00079p-S2; Tue, 17 May 2011 16:56:35 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 06D5766131; Tue, 17 May 2011 17:56:31 -0300 (ART) From: Stefan Monnier To: Brent Goodrick Subject: Re: bug#8684: 24.0.50; Grep mode trips up on Entering directory lines Message-ID: References: Date: Tue, 17 May 2011 17:56:31 -0300 In-Reply-To: (Brent Goodrick's message of "Tue, 17 May 2011 12:33:47 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8684-done Cc: 8684-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) > Yes, that does fix the issue and seems like an acceptable fix IMO. Thank you, installed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 20 19:19:51 2011 Received: (at 8684) by debbugs.gnu.org; 20 May 2011 23:19:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QNYz0-0005OT-F5 for submit@debbugs.gnu.org; Fri, 20 May 2011 19:19:50 -0400 Received: from m13-179.163.com ([220.181.13.179]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QNYyu-0005O6-Va for 8684@debbugs.gnu.org; Fri, 20 May 2011 19:19:48 -0400 Received: from tom.smith ( [72.12.199.29] ) by ajax-webmail-wmsvr179 (Coremail) ; Sat, 21 May 2011 07:19:30 +0800 (CST) Date: Sat, 21 May 2011 07:19:30 +0800 (CST) From: sss To: 8684@debbugs.gnu.org Message-ID: Subject: The fix introduce another bug MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_4008_910446008.1305933570339" X-Originating-IP: [72.12.199.29] X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 110420(13372.3725.3724) Copyright (c) 2002-2011 www.mailtech.cn 163com X-CM-CTRLDATA: NoLEBmZvb3Rlcl9odG09MTkzOjgx X-CM-TRANSID: s8GowKBLGbED99ZN4kobAA--.107W X-CM-SenderInfo: xwrph2hplwxqqrwthudrp/1tbiLhtF3U0vIP63pAACsA X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 8684 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) ------=_Part_4008_910446008.1305933570339 Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: 7bit When type enter key in *grep* buffer, the following message will showed. compilation-next-error: No grep hit here. If I revert the change, the message disappears. ------=_Part_4008_910446008.1305933570339 Content-Type: text/html; charset=GBK Content-Transfer-Encoding: 7bit When type enter key in *grep* buffer, the following message will showed.

compilation-next-error: No grep hit here.

If I revert the change, the message disappears.



------=_Part_4008_910446008.1305933570339-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 19:19:48 2011 Received: (at 8684) by debbugs.gnu.org; 21 May 2011 23:19:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QNvSV-0004qj-Hg for submit@debbugs.gnu.org; Sat, 21 May 2011 19:19:48 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QNvSO-0004qO-8a for 8684@debbugs.gnu.org; Sat, 21 May 2011 19:19:45 -0400 Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:37620 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QNvSG-00041d-PV; Sat, 21 May 2011 19:19:33 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 03CC866131; Sat, 21 May 2011 20:19:29 -0300 (ART) From: Stefan Monnier To: sss Subject: Re: bug#8684: The fix introduce another bug Message-ID: References: Date: Sat, 21 May 2011 20:19:28 -0300 In-Reply-To: (sss's message of "Sat, 21 May 2011 07:19:30 +0800 (CST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8684 Cc: 8684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) > When type enter key in *grep* buffer, the following message will showed. > compilation-next-error: No grep hit here. > If I revert the change, the message disappears. I've installed the patch below which should hopefully fix the original problem as well as the new one. Stefan === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2011-05-21 22:33:12 +0000 +++ lisp/ChangeLog 2011-05-21 23:17:35 +0000 @@ -1,3 +1,7 @@ +2011-05-21 Stefan Monnier + + * progmodes/grep.el (grep-mode): Fix last change (bug#8684). + 2011-05-21 Glenn Morris * files.el (hack-local-variables-prop-line, hack-local-variables): === modified file 'lisp/progmodes/grep.el' --- lisp/progmodes/grep.el 2011-05-17 18:14:30 +0000 +++ lisp/progmodes/grep.el 2011-05-21 23:13:56 +0000 @@ -698,7 +698,9 @@ grep-hit-face) (set (make-local-variable 'compilation-error-regexp-alist) grep-regexp-alist) - (set (make-local-variable 'compilation-directory-matcher) nil) + ;; compilation-directory-matcher can't be nil, so we set it to a regexp that + ;; can never match. + (set (make-local-variable 'compilation-directory-matcher) "\\`a\\`") (set (make-local-variable 'compilation-process-setup-function) 'grep-process-setup) (set (make-local-variable 'compilation-disable-input) t) From unknown Sun Jun 22 08:11:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 Jun 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator