GNU bug report logs - #8664
* keyboard.c (make_lispy_event): Fix problem in integer overflow.

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Thu, 12 May 2011 19:59:02 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 8664 <at> debbugs.gnu.org
Subject: bug#8664: Being more-systematic about user-interface timestamps
Date: Sat, 14 May 2011 12:09:29 -0700
On 05/14/11 02:41, Eli Zaretskii wrote:
> people will understand if you botch their build trying to
> keep it from breaking

Sure, but in this case the change cannot possibly fix anything,
and might break the build, which is why I omitted it.  But since
you're saying it's OK I'll fold the following change in when
I merge.

* msdos.c (mouse_get_pos): Likewise.
* w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
=== modified file 'src/msdos.c'
--- src/msdos.c	2011-04-24 12:48:30 +0000
+++ src/msdos.c	2011-05-14 19:00:49 +0000
@@ -287,7 +287,7 @@
 void
 mouse_get_pos (FRAME_PTR *f, int insist, Lisp_Object *bar_window,
 	       enum scroll_bar_part *part, Lisp_Object *x, Lisp_Object *y,
-	       unsigned long *time)
+	       Time *time)
 {
   int ix, iy;
   Lisp_Object frame, tail;

=== modified file 'src/w32inevt.c'
--- src/w32inevt.c	2011-03-25 15:39:59 +0000
+++ src/w32inevt.c	2011-05-14 19:01:44 +0000
@@ -45,7 +45,7 @@

 /* Info for last mouse motion */
 static COORD movement_pos;
-static DWORD movement_time;
+static Time movement_time;

 /* from w32fns.c */
 extern unsigned int map_keypad_keys (unsigned int, unsigned int);
@@ -544,7 +544,7 @@
 			    enum scroll_bar_part *part,
 			    Lisp_Object *x,
 			    Lisp_Object *y,
-			    unsigned long *time)
+			    Time *time)
 {
   BLOCK_INPUT;

@@ -756,4 +756,3 @@
   UNBLOCK_INPUT;
   return ret;
 }
-





This bug report was last modified 14 years and 7 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.