GNU bug report logs - #8657
24.0.50; Emacs code that seems to use `*-single-char-property-change' incorrectly

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Wed, 11 May 2011 20:56:02 UTC

Severity: minor

Tags: notabug

Found in version 24.0.50

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Chong Yidong <cyd <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 8657 <at> debbugs.gnu.org
Subject: bug#8657: 24.0.50; Emacs code that seems to use `*-single-char-property-change' incorrectly
Date: Tue, 07 Feb 2012 07:56:54 +0900

Chong Yidong wrote:
> Eli Zaretskii <eliz <at> gnu.org> writes:
>>> The behavior might have changed at some point in time, explaining the
>>> above code.
>>
>> Or maybe the author was confusing next-single-char-property-change
>> with next-single-property-change.
>>
>> In any case, those tests are redundant, because
>> next-single-char-property-change already returns point-max when it
>> finds no change in properties.

> I went ahead and fixed them accordingly.

But in XEmacs next-single-char-property-change will return nil
if no property change is found.  So I've modified the gnus-sum.el
code into:

  (if (featurep 'xemacs)
      (or (next-single-char-property-change end 'invisible)
          (point-max))
    (next-single-char-property-change end 'invisible))
This bug report was last modified 13 years and 106 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.