GNU bug report logs - #864
23.0.60; Info-dir-remove-duplicates fails to remove duplicates

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: martin rudalics <rudalics <at> gmx.at>
Subject: bug#864: marked as done (23.0.60; Info-dir-remove-duplicates 
 fails to remove duplicates)

[Message part 1 (text/plain, inline)]

Your message dated Sun, 07 Sep 2008 12:05:31 +0200
with message-id <48C3A76B.1020604 <at> gmx.at>
and subject line Re: bug#864: 23.0.60;	Info-dir-remove-duplicates fails to remove duplicates
has caused the Emacs bug report #864,
regarding 23.0.60; Info-dir-remove-duplicates fails to remove duplicates
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don <at> donarmstrong.com
immediately.)


-- 
864: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=864
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Joshua S." <viking_r <at> george24.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; Info-dir-remove-duplicates fails to remove duplicates
Date: Wed, 03 Sep 2008 00:26:19 +0900

Hi,
I use NTEmacs with Cygwin, and something like this in my ~/.emacs.
    (setq Info-directory-list (list (expand-file-name "../info" 
data-directory) "c:/cygwin/usr/share/info"))
Then the Info Directory Node lists some duplicated items.

I did bellow patch to fix this. (You know, I am not a good Lisp programmer.)

Index: lisp/info.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/info.el,v
retrieving revision 1.541
diff -u -d -w -r1.541 info.el
--- lisp/info.el    30 Aug 2008 20:16:36 -0000    1.541
+++ lisp/info.el    2 Sep 2008 15:05:54 -0000
@@ -1222,9 +1222,10 @@
           ;; Fold case straight away; `member-ignore-case' here wasteful.
           (let ((x (downcase (match-string 1))))
           (if (member x seen)
-              (delete-region (match-beginning 0)
+              (progn (delete-region (match-beginning 0)
                      (progn (re-search-forward "^[^ \t]" nil t)
                         (match-beginning 0)))
+                   (forward-line 0))
             (push x seen))))))))))

 ;; Note that on entry to this function the current-buffer must be the

[Message part 3 (message/rfc822, inline)]

From: martin rudalics <rudalics <at> gmx.at>
To: 864-done <at> debbugs.gnu.org
Cc: "Joshua S." <viking_r <at> george24.com>
Subject: Re: bug#864: 23.0.60;	Info-dir-remove-duplicates fails to remove
 duplicates
Date: Sun, 07 Sep 2008 12:05:31 +0200

Fixed as

2008-09-04  Martin Rudalics  <rudalics <at> gmx.at>

	* info.el (Info-dir-remove-duplicates): Narrow buffer when
	removing duplicate entries under same heading.  Don't skip char
	matching anything but a space or tab at bol.  (Bug#864)

Thanks

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.