GNU bug report logs - #8619
23.3.50; CCL coding system encoder doesn't run CCL_EOF_CODE on zero length string

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8619 in the body.
You can then email your comments to 8619 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.3.50;
	CCL coding system encoder doesn't run CCL_EOF_CODE on zero length
	string
Date: Thu, 05 May 2011 11:35:36 +0900

When I start emacs (emacs-23 branch and trunk) with -Q and evaluate
below code, I receive unexpected result.

(let ((string ""))
  (define-ccl-program ccl-test
    '(1
      ((read r0))
      ((write "[EOF]"))))
  (make-coding-system 'ccl-test-cs 4 ?T "CCL_EOF_BLOCK tester"
		      '(ccl-test . ccl-test))
  (list
   (ccl-execute-on-string 'ccl-test (make-vector 9 0) string)
   (decode-coding-string string 'ccl-test-cs)
   (encode-coding-string string 'ccl-test-cs)))

It returns

("[EOF]" "[EOF]" "")

But emacs22 returns

("[EOF]" "[EOF]" "[EOF]")

and I expect such result.

-- 
Kazuhiro Ito

Message #8 received at 8619 <at> debbugs.gnu.org (full text, mbox):

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: 8619 <at> debbugs.gnu.org
Subject: Re: bug#8619: 23.3.50;
	CCL coding system encoder doesn't run CCL_EOF_CODE on zero length
	string
Date: Sat, 28 May 2011 06:46:07 +0900

[Message part 1 (text/plain, inline)]

I think the cause of the problem is that encode_codin_ccl() does not
call ccl_driver() for zero length string.  Please see the attached
patch.

> When I start emacs (emacs-23 branch and trunk) with -Q and evaluate
> below code, I receive unexpected result.
> 
> (let ((string ""))
>   (define-ccl-program ccl-test
>     '(1
>       ((read r0))
>       ((write "[EOF]"))))
>   (make-coding-system 'ccl-test-cs 4 ?T "CCL_EOF_BLOCK tester"
> 		      '(ccl-test . ccl-test))
>   (list
>    (ccl-execute-on-string 'ccl-test (make-vector 9 0) string)
>    (decode-coding-string string 'ccl-test-cs)
>    (encode-coding-string string 'ccl-test-cs)))
> 
> It returns
>   ("[EOF]" "[EOF]" "")
> But emacs22 returns
>   ("[EOF]" "[EOF]" "[EOF]")
> and I expect such result.

-- 
Kazuhiro Ito

[coding.c.diff (application/octet-stream, attachment)]

Message #11 received at 8619 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kenichi Handa <handa <at> m17n.org>
Cc: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>, 8619 <at> debbugs.gnu.org
Subject: Re: bug#8619: 23.3.50;
	CCL coding system encoder doesn't run CCL_EOF_CODE on zero length
	string
Date: Mon, 30 May 2011 13:07:22 -0300

> I think the cause of the problem is that encode_codin_ccl() does not
> call ccl_driver() for zero length string.  Please see the attached patch.

That sounds right.  Handa, could you confirm?


        Stefan


>> When I start emacs (emacs-23 branch and trunk) with -Q and evaluate
>> below code, I receive unexpected result.
>> 
>> (let ((string ""))
>> (define-ccl-program ccl-test
>> '(1
>> ((read r0))
>> ((write "[EOF]"))))
>> (make-coding-system 'ccl-test-cs 4 ?T "CCL_EOF_BLOCK tester"
>> '(ccl-test . ccl-test))
>> (list
>> (ccl-execute-on-string 'ccl-test (make-vector 9 0) string)
>> (decode-coding-string string 'ccl-test-cs)
>> (encode-coding-string string 'ccl-test-cs)))
>> 
>> It returns
>> ("[EOF]" "[EOF]" "")
>> But emacs22 returns
>> ("[EOF]" "[EOF]" "[EOF]")
>> and I expect such result.

> -- 
> Kazuhiro Ito

Message #14 received at 8619 <at> debbugs.gnu.org (full text, mbox):

From: Kenichi Handa <handa <at> m17n.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: kzhr <at> d1.dion.ne.jp, 8619 <at> debbugs.gnu.org
Subject: Re: bug#8619: 23.3.50;
	CCL coding system encoder doesn't run CCL_EOF_CODE on zero length
	string
Date: Fri, 09 Dec 2011 14:26:40 +0900

In article <jwvfwnw18dd.fsf-monnier+emacs <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> > I think the cause of the problem is that encode_codin_ccl() does not
> > call ccl_driver() for zero length string.  Please see the attached patch.

> That sounds right.  Handa, could you confirm?

Yes, his patch is correct.  I've committed it.

---
Kenichi Handa
handa <at> m17n.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.