From unknown Sat Jun 14 18:53:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8593: mail/mail-utils.el (mail-strip-quoted-names): check all whitespace address Resent-From: Jari Aalto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Apr 2011 15:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8593 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 8593@debbugs.gnu.org X-Debbugs-Original-To: submit@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130417591116426 (code B ref -1); Sat, 30 Apr 2011 15:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Apr 2011 15:05:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGBjK-0004Gt-LV for submit@debbugs.gnu.org; Sat, 30 Apr 2011 11:05:10 -0400 Received: from emh06.mail.saunalahti.fi ([62.142.5.116]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGBjG-0004GN-90 for submit@debbugs.gnu.org; Sat, 30 Apr 2011 11:05:08 -0400 Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96]) by emh06-2.mail.saunalahti.fi (Postfix) with SMTP id 7D6BBC7DD0 for ; Sat, 30 Apr 2011 18:04:59 +0300 (EEST) Received: from emh01.mail.saunalahti.fi ([62.142.5.107]) by vs3-12.mail.saunalahti.fi ([62.142.5.96]) with SMTP (gateway) id A06C9C6E730; Sat, 30 Apr 2011 18:04:59 +0300 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh01.mail.saunalahti.fi (Postfix) with ESMTP id 5560E403E for ; Sat, 30 Apr 2011 18:04:57 +0300 (EEST) From: Jari Aalto Date: Fri, 17 Dec 2010 20:25:27 +0200 Message-ID: <87mxo41cko.fsf@picasso.cante.net> Mail-Copies-To: poster User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: VAMS X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Package: emacs Version: 23.2+1-5.1 Severity: wishlist Tags: patch The following is optimization for the mail-strip-quoted-names: it returns immediately if there is nothing to do. The patch is against Git: 9344a2b 2010-12-17 Merge branch 'master' of git://git.sv.gnu.org/emacs 2010-12-17 Jari Aalto * mail/mail-utils.el (mail-strip-quoted-names): If address is all whitespace, return immediately with nil. (rmail-dont-reply-to): Add check that `naked-address' is a string. Needed due to change in `mail-strip-quoted-names'. -- System Information Debian Release: squeeze/sid APT Prefers testing APT policy: (990, testing) (500, unstable) (1, experimental) Architecture: amd64 Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux Locale: LANG=en_DK.UTF-8 -- Versions of packages `emacs depends on'. Depends: emacs23 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-lucid 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-nox 23.2+1-5.1 GNU Emacs is the extensible self-documenting --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-mail-mail-utils.el-mail-strip-quoted-names-Return-on.patch >From 3d3737886b7f39556cddf0804521a1c44a6f81e3 Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Fri, 17 Dec 2010 20:12:54 +0200 Subject: [PATCH] mail/mail-utils.el (mail-strip-quoted-names): Return on all whitespace Organization: Private Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit In ` (mail-strip-quoted-names)' if address is all whitespace, return immediately with nil. In `rmail-dont-reply-to' Add check that `naked-address' is a string. Needed due to change in `mail-strip-quoted-names'. Signed-off-by: Jari Aalto --- lisp/mail/mail-utils.el | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/mail/mail-utils.el b/lisp/mail/mail-utils.el index a8d8451..7e87276 100644 --- a/lisp/mail/mail-utils.el +++ b/lisp/mail/mail-utils.el @@ -175,7 +175,10 @@ as Rmail does." "Delete comments and quoted strings in an address list ADDRESS. Also delete leading/trailing whitespace and replace FOO with just BAR. Return a modified address list." - (if (null address) + (if (or (null address) + (and (stringp address) + ;; Effectively empty + (string-match "^[[:space:]]*\\'" address))) nil (if mail-use-rfc822 (progn (require 'rfc822) @@ -284,7 +287,8 @@ the comma-separated list. The pruned list is returned." (setq cur-pos start-pos))) (let* ((address (substring destinations start-pos cur-pos)) (naked-address (mail-strip-quoted-names address))) - (if (string-match rmail-dont-reply-to-names naked-address) + (if (and (stringp naked-address) + (string-match rmail-dont-reply-to-names naked-address)) (setq destinations (concat (substring destinations 0 start-pos) (and cur-pos (substring destinations (1+ cur-pos)))) -- 1.7.2.3 --=-=-=-- From unknown Sat Jun 14 18:53:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8593: mail/mail-utils.el (mail-strip-quoted-names): check all whitespace address Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 May 2011 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8593 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jari Aalto Cc: 8593@debbugs.gnu.org Received: via spool by 8593-submit@debbugs.gnu.org id=B8593.13043459236527 (code B ref 8593); Mon, 02 May 2011 14:19:02 +0000 Received: (at 8593) by debbugs.gnu.org; 2 May 2011 14:18:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGtxT-0001hE-Fz for submit@debbugs.gnu.org; Mon, 02 May 2011 10:18:43 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGtxR-0001h2-79 for 8593@debbugs.gnu.org; Mon, 02 May 2011 10:18:41 -0400 Received: from 121-249-126-200.fibertel.com.ar ([200.126.249.121]:51457 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QGtxL-0001DM-AP; Mon, 02 May 2011 10:18:35 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 3D12766140; Mon, 2 May 2011 11:18:24 -0300 (ART) From: Stefan Monnier Message-ID: References: <87mxo41cko.fsf@picasso.cante.net> Date: Mon, 02 May 2011 11:18:24 -0300 In-Reply-To: <87mxo41cko.fsf@picasso.cante.net> (Jari Aalto's message of "Fri, 17 Dec 2010 20:25:27 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) > The following is optimization for the mail-strip-quoted-names: it returns > immediately if there is nothing to do. The patch is against Git: What for? Stefan From unknown Sat Jun 14 18:53:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8593: mail/mail-utils.el (mail-strip-quoted-names): check all whitespace address Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Apr 2012 19:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8593 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jari Aalto Cc: 8593@debbugs.gnu.org Received: via spool by 8593-submit@debbugs.gnu.org id=B8593.13342589303016 (code B ref 8593); Thu, 12 Apr 2012 19:29:01 +0000 Received: (at 8593) by debbugs.gnu.org; 12 Apr 2012 19:28:50 +0000 Received: from localhost ([127.0.0.1]:54771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIPhJ-0000mb-RG for submit@debbugs.gnu.org; Thu, 12 Apr 2012 15:28:50 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:51118) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIPhH-0000mT-Kj for 8593@debbugs.gnu.org; Thu, 12 Apr 2012 15:28:48 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SIPfz-000824-9i; Thu, 12 Apr 2012 21:27:27 +0200 From: Lars Magne Ingebrigtsen References: <87mxo41cko.fsf@picasso.cante.net> X-Now-Playing: His Name Is Alive's _ECLIPX_: "After Death" Date: Thu, 12 Apr 2012 21:27:26 +0200 In-Reply-To: <87mxo41cko.fsf@picasso.cante.net> (Jari Aalto's message of "Fri, 17 Dec 2010 20:25:27 +0200") Message-ID: User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SIPfz-000824-9i X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334863647.58626@lMiwZNrtR7IZ3kEGsiuWFA X-Spam-Status: No X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Jari Aalto writes: > The following is optimization for the mail-strip-quoted-names: it returns > immediately if there is nothing to do. I don't quite see what's the point of this, so I'm closing the report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 15:28:55 2012 Received: (at control) by debbugs.gnu.org; 12 Apr 2012 19:28:55 +0000 Received: from localhost ([127.0.0.1]:54774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIPhP-0000mt-6R for submit@debbugs.gnu.org; Thu, 12 Apr 2012 15:28:55 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:51124) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIPhO-0000mn-AZ for control@debbugs.gnu.org; Thu, 12 Apr 2012 15:28:54 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SIPg6-00082P-Ko for control@debbugs.gnu.org; Thu, 12 Apr 2012 21:27:34 +0200 Date: Thu, 12 Apr 2012 21:27:33 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #8593 X-MailScanner-ID: 1SIPg6-00082P-Ko X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334863654.74986@nDWXbw2X4ki79Rte5vuHmw X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) tags 8593 wontfix close 8593