GNU bug report logs - #858
Conflict between ERC mode tracking and ibuffer window shrinking

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 858 in the body.
You can then email your comments to 858 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Antoine Levitt" <smeuuh <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Conflict between ERC mode tracking and ibuffer window shrinking
Date: Tue, 2 Sep 2008 01:26:52 +0200

[Message part 1 (text/plain, inline)]

Hi,
There is a bug when using conjointly these two features. Here are the
relevant portions of configuration :
;;make ibuffer resize itself to its buffer size
(setq ibuffer-use-other-window t)
(setq ibuffer-default-shrink-to-minimum-size t)

No specific configuration for erc, just enabling tracker is enough.
Then, run erc, and, in any erc buffer, call ibuffer. The screen briefly
flashes as an ERC window opens then disappears, and the ibuffer window is
reduced to a much smaller size than what it would be outside ERC. I think
the issue is erc's hook to window-configuration-change somehow messing with
ibuffer, but I'm not experienced enough to find where the bug is.

Antoine Levitt

[Message part 2 (text/html, inline)]

Message #10 received at 858 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: John Paul Wallington <jpw <at> gnu.org>, Michael Olson <mwolson <at> gnu.org>
Cc: "Antoine Levitt" <smeuuh <at> gmail.com>, 858 <at> debbugs.gnu.org
Subject: Re: Conflict between ERC mode tracking and ibuffer window shrinking
Date: Tue, 02 Sep 2008 12:30:20 -0400

Hi guys,

Could you take a look at this bug report?  I'm not sure whether ERC or
ibuffer needs fixing.

> There is a bug when using conjointly these two features. Here are the
> relevant portions of configuration :
>
> ;;make ibuffer resize itself to its buffer size
> (setq ibuffer-use-other-window t)
> (setq ibuffer-default-shrink-to-minimum-size t)
>
> No specific configuration for erc, just enabling tracker is enough.
> Then, run erc, and, in any erc buffer, call ibuffer. The screen
> briefly flashes as an ERC window opens then disappears, and the
> ibuffer window is reduced to a much smaller size than what it would be
> outside ERC. I think the issue is erc's hook to
> window-configuration-change somehow messing with ibuffer, but I'm not
> experienced enough to find where the bug is.

Message #15 received at 858 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Antoine Levitt" <smeuuh <at> gmail.com>
To: "Chong Yidong" <cyd <at> stupidchicken.com>
Cc: "John Paul Wallington" <jpw <at> gnu.org>, "Michael Olson" <mwolson <at> gnu.org>,
        858 <at> debbugs.gnu.org
Subject: Re: Conflict between ERC mode tracking and ibuffer window shrinking
Date: Tue, 2 Sep 2008 18:46:18 +0200

[Message part 1 (text/plain, inline)]

Another related problem (fixing one will probably fix the other, but I'm
posting just in case) : doing the same manipulation resets the count of
unseen messages
2008/9/2 Chong Yidong <cyd <at> stupidchicken.com>

> Hi guys,
>
> Could you take a look at this bug report?  I'm not sure whether ERC or
> ibuffer needs fixing.
>
> > There is a bug when using conjointly these two features. Here are the
> > relevant portions of configuration :
> >
> > ;;make ibuffer resize itself to its buffer size
> > (setq ibuffer-use-other-window t)
> > (setq ibuffer-default-shrink-to-minimum-size t)
> >
> > No specific configuration for erc, just enabling tracker is enough.
> > Then, run erc, and, in any erc buffer, call ibuffer. The screen
> > briefly flashes as an ERC window opens then disappears, and the
> > ibuffer window is reduced to a much smaller size than what it would be
> > outside ERC. I think the issue is erc's hook to
> > window-configuration-change somehow messing with ibuffer, but I'm not
> > experienced enough to find where the bug is.
>

[Message part 2 (text/html, inline)]

Message #20 received at 858 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Chong Yidong <cyd <at> stupidchicken.com>, 858 <at> debbugs.gnu.org
Cc: John Paul Wallington <jpw <at> gnu.org>, Michael Olson <mwolson <at> gnu.org>,
        Keegan Carruthers-Smith <keegan.csmith <at> gmail.com>
Subject: Re: bug#858: Conflict between ERC mode tracking and ibuffer window
 shrinking
Date: Wed, 03 Sep 2008 11:36:17 +0200

CC-ing Keegan because Bug #466 describes another problem with ERC and
windows.

>> There is a bug when using conjointly these two features. Here are the
>> relevant portions of configuration :
>>
>> ;;make ibuffer resize itself to its buffer size
>> (setq ibuffer-use-other-window t)
>> (setq ibuffer-default-shrink-to-minimum-size t)
>>
>> No specific configuration for erc, just enabling tracker is enough.
>> Then, run erc, and, in any erc buffer, call ibuffer. The screen
>> briefly flashes as an ERC window opens then disappears, and the
>> ibuffer window is reduced to a much smaller size than what it would be
>> outside ERC. I think the issue is erc's hook to
>> window-configuration-change somehow messing with ibuffer, but I'm not
>> experienced enough to find where the bug is.

Can't offer much insight but processing window-configuration-change
hooks has changed with Emacs 23.  So this

(defun erc-track-modified-channels ()
  "Hook function for `erc-insert-post-hook' to check if the current
buffer should be added to the modeline as a hidden, modified
channel.  Assumes it will only be called when current-buffer
is in `erc-mode'."
  (let ((this-channel (or (erc-default-target)
			  (buffer-name (current-buffer)))))
    ...			

might have been broken for some reason.  To verify, someone would have
to try with Emacs 22 and 23 inserting just before the `let' something
like

(unless (eq major-mode 'erc-mode)
  (message "Not in erc-mode ..."))

and look whether it triggers.

martin

Message #25 received at 858 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Antoine Levitt" <smeuuh <at> gmail.com>
To: "martin rudalics" <rudalics <at> gmx.at>, 858 <at> debbugs.gnu.org
Cc: "Chong Yidong" <cyd <at> stupidchicken.com>,
        "Keegan Carruthers-Smith" <keegan.csmith <at> gmail.com>,
        "Michael Olson" <mwolson <at> gnu.org>,
        "John Paul Wallington" <jpw <at> gnu.org>
Subject: Re: bug#858: Conflict between ERC mode tracking and ibuffer window shrinking
Date: Thu, 4 Sep 2008 16:14:08 +0200

[Message part 1 (text/plain, inline)]

Hi,
I did some testing, and the bug was not in tracker as I suspected, it's in
scrolltobottom, in erc-goodies.el. This should be much easier for you to
debug: it's only a few lines long. I strongly suspect the part following
this comment is responsible :
      ;; Temporarily bind resize-mini-windows to nil so that users who have
it
      ;; set to a non-nil value will not suffer from premature minibuffer
      ;; shrinkage due to the below recenter call.  I have no idea why this
      ;; works, but it solves the problem, and has no negative side effects.
      ;; (Fran Litterio, 2003/01/07)

Looks like it does have side effects after all :-)
2008/9/3 martin rudalics <rudalics <at> gmx.at>

> CC-ing Keegan because Bug #466 describes another problem with ERC and
> windows.
>
> >> There is a bug when using conjointly these two features. Here are the
> >> relevant portions of configuration :
> >>
> >> ;;make ibuffer resize itself to its buffer size
> >> (setq ibuffer-use-other-window t)
> >> (setq ibuffer-default-shrink-to-minimum-size t)
> >>
> >> No specific configuration for erc, just enabling tracker is enough.
> >> Then, run erc, and, in any erc buffer, call ibuffer. The screen
> >> briefly flashes as an ERC window opens then disappears, and the
> >> ibuffer window is reduced to a much smaller size than what it would be
> >> outside ERC. I think the issue is erc's hook to
> >> window-configuration-change somehow messing with ibuffer, but I'm not
> >> experienced enough to find where the bug is.
>
> Can't offer much insight but processing window-configuration-change
> hooks has changed with Emacs 23.  So this
>
> (defun erc-track-modified-channels ()
>  "Hook function for `erc-insert-post-hook' to check if the current
> buffer should be added to the modeline as a hidden, modified
> channel.  Assumes it will only be called when current-buffer
> is in `erc-mode'."
>  (let ((this-channel (or (erc-default-target)
>                          (buffer-name (current-buffer)))))
>    ...
>
> might have been broken for some reason.  To verify, someone would have
> to try with Emacs 22 and 23 inserting just before the `let' something
> like
>
> (unless (eq major-mode 'erc-mode)
>  (message "Not in erc-mode ..."))
>
> and look whether it triggers.
>
> martin
>
>
>
>
>
>

[Message part 2 (text/html, inline)]

Message #30 received at 858 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: jpw <at> pobox.com (John Paul Wallington)
To: "Antoine Levitt" <smeuuh <at> gmail.com>
Cc: rudalics <at> gmx.at, 858 <at> debbugs.gnu.org, cyd <at> stupidchicken.com,
        keegan.csmith <at> gmail.com, mwolson <at> gnu.org
Subject: Re: bug#858: Conflict between ERC mode tracking and ibuffer window
 shrinking
Date: Thu, 04 Sep 2008 23:48:46 +0100

> Hi,

Hi Antoine,

> I did some testing, and the bug was not in tracker as I suspected, it's in
> scrolltobottom, in erc-goodies.el. This should be much easier for you to
> debug: it's only a few lines long. I strongly suspect the part following
> this comment is responsible :
>       ;; Temporarily bind resize-mini-windows to nil so that users who have
> it
>       ;; set to a non-nil value will not suffer from premature minibuffer
>       ;; shrinkage due to the below recenter call.  I have no idea why this
>       ;; works, but it solves the problem, and has no negative side effects.
>       ;; (Fran Litterio, 2003/01/07)
> 
> Looks like it does have side effects after all :-)

Sorry, I'm having difficulties reproducing the bug.

Could you try getting rid of the code that binds
`resize-mini-windows', perhaps using the function below, and test
whether your suspicion is correct?


(defun erc-scroll-to-bottom (window display-start)
  "Changed to see whether not let binding `resize-mini-windows' to nil
doesn't cause the bug."
  (if (window-live-p window)
      (erc-with-selected-window window
        (save-restriction
          (widen)
          (when (and erc-insert-marker
                     ;; we're editing a line. Scroll.
                     (> (point) erc-insert-marker))
            (save-excursion
              (goto-char (point-max))
              (recenter (or erc-input-line-position -1))
              (sit-for 0)))))))

Message #35 received at 858 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Antoine Levitt" <smeuuh <at> gmail.com>
To: "John Paul Wallington" <jpw <at> pobox.com>
Cc: rudalics <at> gmx.at, 858 <at> debbugs.gnu.org, cyd <at> stupidchicken.com,
        keegan.csmith <at> gmail.com, mwolson <at> gnu.org
Subject: Re: bug#858: Conflict between ERC mode tracking and ibuffer window shrinking
Date: Fri, 5 Sep 2008 01:09:37 +0200

[Message part 1 (text/plain, inline)]

My suspicion was wrong, the binding doesn't change anything. I just said
that by looking at the comment, but didn't try. Sorry about that.
However, (defun erc-scroll-to-bottom (window display-start) nil) removes the
bug.
The bug should be reproducable with emacs -Q, the ibuffer configuration
lines I gave in the first bug report, and scroll-to-bottom mode on. I'm
using latest CVS, the bug also happens with a build from july.
Best of luck
Antoine
2008/9/5 John Paul Wallington <jpw <at> pobox.com>

> > Hi,
>
> Hi Antoine,
>
> > I did some testing, and the bug was not in tracker as I suspected, it's
> in
> > scrolltobottom, in erc-goodies.el. This should be much easier for you to
> > debug: it's only a few lines long. I strongly suspect the part following
> > this comment is responsible :
> >       ;; Temporarily bind resize-mini-windows to nil so that users who
> have
> > it
> >       ;; set to a non-nil value will not suffer from premature minibuffer
> >       ;; shrinkage due to the below recenter call.  I have no idea why
> this
> >       ;; works, but it solves the problem, and has no negative side
> effects.
> >       ;; (Fran Litterio, 2003/01/07)
> >
> > Looks like it does have side effects after all :-)
>
> Sorry, I'm having difficulties reproducing the bug.
>
> Could you try getting rid of the code that binds
> `resize-mini-windows', perhaps using the function below, and test
> whether your suspicion is correct?
>
>
> (defun erc-scroll-to-bottom (window display-start)
>  "Changed to see whether not let binding `resize-mini-windows' to nil
> doesn't cause the bug."
>  (if (window-live-p window)
>      (erc-with-selected-window window
>        (save-restriction
>          (widen)
>          (when (and erc-insert-marker
>                     ;; we're editing a line. Scroll.
>                     (> (point) erc-insert-marker))
>            (save-excursion
>              (goto-char (point-max))
>              (recenter (or erc-input-line-position -1))
>              (sit-for 0)))))))
>

[Message part 2 (text/html, inline)]

Message #40 received at 858-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Michael Olson <mwolson <at> gnu.org>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: John Paul Wallington <jpw <at> gnu.org>, "Antoine Levitt" <smeuuh <at> gmail.com>,
        858-done <at> debbugs.gnu.org
Subject: Re: Conflict between ERC mode tracking and ibuffer window shrinking
Date: Tue, 07 Oct 2008 22:07:00 -0700

Chong Yidong <cyd <at> stupidchicken.com> writes:

> Hi guys,
>
> Could you take a look at this bug report?  I'm not sure whether ERC or
> ibuffer needs fixing.

The problem was that just before fit-window-to-buffer was called in
`ibuffer-shrink-to-fit', the display was showing a split frame with
both windows displaying the same ERC buffer, even though the current
buffer was actually *Ibuffer*.  I added a (redisplay t) call to force
the display to be up-to-date before fit-window-to-buffer is called,
which fixes the problem.

-- 
|       Michael Olson  |  FSF Associate Member #652     |
| http://mwolson.org/  |  Hobbies: Lisp, HCoop          |
| Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |
`-------------------------------------------------------'

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.