From unknown Sun Aug 17 22:00:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8556 <8556@debbugs.gnu.org> To: bug#8556 <8556@debbugs.gnu.org> Subject: Status: recent gnutls.c changes broke build on Ubuntu 10.10 Reply-To: bug#8556 <8556@debbugs.gnu.org> Date: Mon, 18 Aug 2025 05:00:21 +0000 retitle 8556 recent gnutls.c changes broke build on Ubuntu 10.10 reassign 8556 emacs submitter 8556 Paul Eggert severity 8556 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 03:18:34 2011 Received: (at submit) by debbugs.gnu.org; 26 Apr 2011 07:18:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEcXa-0006NG-BW for submit@debbugs.gnu.org; Tue, 26 Apr 2011 03:18:34 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEcXY-0006N2-Bp for submit@debbugs.gnu.org; Tue, 26 Apr 2011 03:18:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEcXS-0007nc-9m for submit@debbugs.gnu.org; Tue, 26 Apr 2011 03:18:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:33012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEcXS-0007nY-89 for submit@debbugs.gnu.org; Tue, 26 Apr 2011 03:18:26 -0400 Received: from eggs.gnu.org ([140.186.70.92]:34063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEcXR-0006Bh-Ae for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2011 03:18:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEcXQ-0007nB-8q for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2011 03:18:25 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:40058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEcXQ-0007mw-2U for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2011 03:18:24 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 0BAB039E80F5; Tue, 26 Apr 2011 00:18:22 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AR2eXhD38iOy; Tue, 26 Apr 2011 00:18:21 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 6F95E39E8083; Tue, 26 Apr 2011 00:18:21 -0700 (PDT) Message-ID: <4DB671B8.5010702@cs.ucla.edu> Date: Tue, 26 Apr 2011 00:18:16 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: recent gnutls.c changes broke build on Ubuntu 10.10 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: submit Cc: Ted Zlatanov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) bzr 103998 introduced a bug in emacs_gnutls_handshake: it has a 'return;' statement in a function returning an integer, which violates the C standard. I plan to fix this with the following patch, for lack of a better idea, but it would be nice if someone with more expertise in gnutls could double-check this. * gnutls.c (emacs_gnutls_handshake): Always return a value. Expect the caller to check whether GNUTLS_STAGE_HANDSHAKE_CANDO <= proc->gnutls_initstage, if the check is needed. The check isn't needed for one caller, Fgnutls_boot. (emacs_gnutls_read): Do that check. This is the other caller. === modified file 'src/gnutls.c' --- src/gnutls.c 2011-04-26 06:17:52 +0000 +++ src/gnutls.c 2011-04-26 07:05:42 +0000 @@ -73,9 +73,6 @@ gnutls_session_t state = proc->gnutls_state; int ret; - if (proc->gnutls_initstage < GNUTLS_STAGE_HANDSHAKE_CANDO) - return; - if (proc->gnutls_initstage < GNUTLS_STAGE_TRANSPORT_POINTERS_SET) { #ifdef WINDOWSNT @@ -179,7 +176,8 @@ if (proc->gnutls_initstage != GNUTLS_STAGE_READY) { - emacs_gnutls_handshake (proc); + if (GNUTLS_STAGE_HANDSHAKE_CANDO <= proc->gnutls_initstage) + emacs_gnutls_handshake (proc); return -1; } rtnval = gnutls_read (state, buf, nbyte); From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 09:05:25 2011 Received: (at submit) by debbugs.gnu.org; 26 Apr 2011 13:05:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEhxE-0006Yw-FC for submit@debbugs.gnu.org; Tue, 26 Apr 2011 09:05:24 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEhxC-0006Yl-KU for submit@debbugs.gnu.org; Tue, 26 Apr 2011 09:05:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEhx3-0001eC-Gj for submit@debbugs.gnu.org; Tue, 26 Apr 2011 09:05:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:59374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEhx3-0001e8-CP for submit@debbugs.gnu.org; Tue, 26 Apr 2011 09:05:13 -0400 Received: from eggs.gnu.org ([140.186.70.92]:47511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEhx1-0002PM-Rg for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2011 09:05:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEhws-0001Vp-MU for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2011 09:05:11 -0400 Received: from z.lifelogs.com ([173.255.230.239]:36784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEhws-0001VC-Kk for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2011 09:05:02 -0400 Received: from heechee (c-67-186-102-106.hsd1.il.comcast.net [67.186.102.106]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tzz) by z.lifelogs.com (Postfix) with ESMTPSA id 5EDFB6209A; Tue, 26 Apr 2011 13:05:01 +0000 (UTC) From: Ted Zlatanov To: Paul Eggert Subject: Re: recent gnutls.c changes broke build on Ubuntu 10.10 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <4DB671B8.5010702@cs.ucla.edu> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Date: Tue, 26 Apr 2011 08:05:00 -0500 In-Reply-To: <4DB671B8.5010702@cs.ucla.edu> (Paul Eggert's message of "Tue, 26 Apr 2011 00:18:16 -0700") Message-ID: <87aafd40zn.fsf@lifelogs.com> User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) On Tue, 26 Apr 2011 00:18:16 -0700 Paul Eggert wrote: PE> bzr 103998 introduced a bug in emacs_gnutls_handshake: it has PE> a 'return;' statement in a function returning an integer, which PE> violates the C standard. I plan to fix this with the following PE> patch, for lack of a better idea, but it would be nice if someone PE> with more expertise in gnutls could double-check this. I committed a different fix, because I *think* your fix would loop forever: we just return -1 instead, now (this doesn't overlap with EAGAIN or GNUTLS_E_AGAIN). But maybe I misunderstood something in your suggestion. I won't be able to commit for a few days so if you still think your fix is better or have further suggestions, please go ahead and make them. Thanks Ted From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 13:57:49 2011 Received: (at 8556-done) by debbugs.gnu.org; 26 Apr 2011 17:57:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEmWD-0004td-8x for submit@debbugs.gnu.org; Tue, 26 Apr 2011 13:57:49 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEmW9-0004tL-Sn for 8556-done@debbugs.gnu.org; Tue, 26 Apr 2011 13:57:46 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 0D81739E80F9; Tue, 26 Apr 2011 10:57:40 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pE6CqooGcRBV; Tue, 26 Apr 2011 10:57:39 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id AC21639E80F8; Tue, 26 Apr 2011 10:57:39 -0700 (PDT) Message-ID: <4DB70793.8050800@cs.ucla.edu> Date: Tue, 26 Apr 2011 10:57:39 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: Ted Zlatanov Subject: Re: recent gnutls.c changes broke build on Ubuntu 10.10 References: <4DB671B8.5010702@cs.ucla.edu> <87aafd40zn.fsf@lifelogs.com> In-Reply-To: <87aafd40zn.fsf@lifelogs.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 8556-done Cc: 8556-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) On 04/26/11 06:05, Ted Zlatanov wrote: > I committed a different fix, because I *think* your fix would loop > forever Thanks for looking into it. I'm sure your fix is better, because I didn't really follow the code. I'll mark this bug as done. From unknown Sun Aug 17 22:00:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 May 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator