From unknown Mon Aug 18 02:31:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8539: default value of Buffer-menu-buffer-column hard-coded in places Resent-From: Alp Aker Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Apr 2011 02:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8539 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8539@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130352658218769 (code B ref -1); Sat, 23 Apr 2011 02:44:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Apr 2011 02:43:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QDSoI-0004sg-Ld for submit@debbugs.gnu.org; Fri, 22 Apr 2011 22:43:02 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QDSoG-0004sE-Nh for submit@debbugs.gnu.org; Fri, 22 Apr 2011 22:43:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QDSoA-0000iU-PJ for submit@debbugs.gnu.org; Fri, 22 Apr 2011 22:42:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:48632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QDSoA-0000iQ-NT for submit@debbugs.gnu.org; Fri, 22 Apr 2011 22:42:54 -0400 Received: from eggs.gnu.org ([140.186.70.92]:56901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QDSoA-0001aa-3I for bug-gnu-emacs@gnu.org; Fri, 22 Apr 2011 22:42:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QDSo9-0000iE-3l for bug-gnu-emacs@gnu.org; Fri, 22 Apr 2011 22:42:54 -0400 Received: from exprod7og124.obsmtp.com ([64.18.2.26]:39404) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1QDSo8-0000i4-QA for bug-gnu-emacs@gnu.org; Fri, 22 Apr 2011 22:42:53 -0400 Received: from mb2i1.ns.pitt.edu ([136.142.11.153]) by exprod7ob124.postini.com ([64.18.6.12]) with SMTP ID DSNKTbI8qdRrX/7D1jI4Nx2N7XYy0tKX1IWe@postini.com; Fri, 22 Apr 2011 19:42:52 PDT Received: from unixs1.cis.pitt.edu ([136.142.4.246]) by pitt.edu (PMDF V6.3-x11 #31505) with ESMTP id <0LK300HVI3JD78@mb2i1.ns.pitt.edu> for bug-gnu-emacs@gnu.org; Fri, 22 Apr 2011 22:42:49 -0400 (EDT) Date: Fri, 22 Apr 2011 22:42:49 -0400 (EDT) From: Alp Aker X-X-Sender: aker@unixs1.cis.pitt.edu Message-id: MIME-version: 1.0 Content-type: TEXT/PLAIN; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Buffer-menu-buffer-column's default value of 4 is hard-coded into several functions from buff-menu.el. As of 24.0.50, this is true of Buffer-menu-sort and Buffer-menu-revert-function. This is not strictly speaking a bug, but it is an anti-pattern, and it can unexpectedly bite someone hacking on buff-menu.el. So it would perhaps be good practice to make the following changes: === modified file 'lisp/buff-menu.el' --- lisp/buff-menu.el 2011-04-19 13:44:55 +0000 +++ lisp/buff-menu.el 2011-04-23 02:30:41 +0000 @@ -278,7 +278,7 @@ (let ((opoint (point)) (eobp (eobp)) (ocol (current-column)) - (oline (progn (move-to-column 4) + (oline (progn (move-to-column Buffer-menu-buffer-column) (get-text-property (point) 'buffer))) (prop (point-min)) ;; do not make undo records for the reversion. @@ -703,7 +703,7 @@ (save-excursion (Buffer-menu-beginning) (while (not (eobp)) - (when (buffer-live-p (setq buf (get-text-property (+ (point) 4) 'buffer))) + (when (buffer-live-p (setq buf (get-text-property (+ (point) Buffer-menu-buffer-column) 'buffer))) (setq m1 (char-after) m1 (if (memq m1 '(?> ?D)) m1) m2 (char-after (+ (point) 2)) @@ -715,7 +715,7 @@ (save-excursion (Buffer-menu-beginning) (while (not (eobp)) - (when (setq buf (assq (get-text-property (+ (point) 4) 'buffer) l)) + (when (setq buf (assq (get-text-property (+ (point) Buffer-menu-buffer-column) 'buffer) l)) (setq m1 (cadr buf) m2 (cadr (cdr buf))) (when m1 From unknown Mon Aug 18 02:31:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8539: default value of Buffer-menu-buffer-column hard-coded in places Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 May 2011 19:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8539 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alp Aker Cc: 8539@debbugs.gnu.org Received: via spool by 8539-submit@debbugs.gnu.org id=B8539.13066100037233 (code B ref 8539); Sat, 28 May 2011 19:14:01 +0000 Received: (at 8539) by debbugs.gnu.org; 28 May 2011 19:13:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQOws-0001sb-Qn for submit@debbugs.gnu.org; Sat, 28 May 2011 15:13:23 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQOwq-0001sQ-IM for 8539@debbugs.gnu.org; Sat, 28 May 2011 15:13:20 -0400 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p4SJDE82023583 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 28 May 2011 15:13:14 -0400 Received: by furball (Postfix, from userid 1000) id E2E4716031F; Sat, 28 May 2011 15:13:13 -0400 (EDT) From: Chong Yidong References: Date: Sat, 28 May 2011 15:13:13 -0400 In-Reply-To: (Alp Aker's message of "Fri, 22 Apr 2011 22:42:49 -0400 (EDT)") Message-ID: <87lixqprjq.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Alp Aker writes: > Buffer-menu-buffer-column's default value of 4 is hard-coded into > several functions from buff-menu.el. As of 24.0.50, this is true of > Buffer-menu-sort and Buffer-menu-revert-function. Thanks, committed. From debbugs-submit-bounces@debbugs.gnu.org Sat May 28 15:13:36 2011 Received: (at control) by debbugs.gnu.org; 28 May 2011 19:13:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQOx6-0001t1-My for submit@debbugs.gnu.org; Sat, 28 May 2011 15:13:36 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQOx4-0001so-Am for control@debbugs.gnu.org; Sat, 28 May 2011 15:13:34 -0400 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p4SJDSqJ023153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 28 May 2011 15:13:28 -0400 Received: by furball (Postfix, from userid 1000) id DE01D16031F; Sat, 28 May 2011 15:13:27 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 8539 Date: Sat, 28 May 2011 15:13:27 -0400 Message-ID: <87tyce1vvs.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) close 8539 thanks From unknown Mon Aug 18 02:31:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8539: default value of Buffer-menu-buffer-column hard-coded in places Resent-From: Alp Aker Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 May 2011 19:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8539 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: 8539@debbugs.gnu.org Received: via spool by 8539-submit@debbugs.gnu.org id=B8539.130661165715899 (code B ref 8539); Sat, 28 May 2011 19:41:02 +0000 Received: (at 8539) by debbugs.gnu.org; 28 May 2011 19:40:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQPNZ-00048M-7l for submit@debbugs.gnu.org; Sat, 28 May 2011 15:40:57 -0400 Received: from exprod7og112.obsmtp.com ([64.18.2.177]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QQPNW-000489-F7 for 8539@debbugs.gnu.org; Sat, 28 May 2011 15:40:55 -0400 Received: from mb2i1.ns.pitt.edu ([136.142.11.153]) by exprod7ob112.postini.com ([64.18.6.12]) with SMTP ID DSNKTeFPwLG+fisClZzuEPJE2dnenBDT/QjT@postini.com; Sat, 28 May 2011 12:40:54 PDT Received: from unixs1.cis.pitt.edu ([136.142.4.246]) by pitt.edu (PMDF V6.3-x11 #31505) with ESMTP id <0LLX00LJI7ZZC0@mb2i1.ns.pitt.edu> for 8539@debbugs.gnu.org; Sat, 28 May 2011 15:40:48 -0400 (EDT) Date: Sat, 28 May 2011 15:40:47 -0400 (EDT) From: Alp Aker In-reply-to: <87lixqprjq.fsf@stupidchicken.com> X-X-Sender: aker@unixs1.cis.pitt.edu Message-id: MIME-version: 1.0 Content-type: TEXT/PLAIN; format=flowed; charset=US-ASCII References: <87lixqprjq.fsf@stupidchicken.com> X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Just a quick follow-up: After posting the bug report I noticed the same problem in Buffer-menu-buffer+size. In the display spec (space :align-to ,(+ 4 name+space-width) at the end of the function, that "4" should also be replaced with "Buffer-menu-buffer-column". On Sat, 28 May 2011, Chong Yidong wrote: > Alp Aker writes: > >> Buffer-menu-buffer-column's default value of 4 is hard-coded into >> several functions from buff-menu.el. As of 24.0.50, this is true of >> Buffer-menu-sort and Buffer-menu-revert-function. > > Thanks, committed. > From unknown Mon Aug 18 02:31:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8539: default value of Buffer-menu-buffer-column hard-coded in places Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 May 2011 20:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8539 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alp Aker Cc: 8539@debbugs.gnu.org Received: via spool by 8539-submit@debbugs.gnu.org id=B8539.130661329921351 (code B ref 8539); Sat, 28 May 2011 20:09:01 +0000 Received: (at 8539) by debbugs.gnu.org; 28 May 2011 20:08:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQPo3-0005YJ-Lz for submit@debbugs.gnu.org; Sat, 28 May 2011 16:08:19 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQPo2-0005Y8-2K for 8539@debbugs.gnu.org; Sat, 28 May 2011 16:08:18 -0400 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p4SK8C9b031565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 28 May 2011 16:08:12 -0400 Received: by furball (Postfix, from userid 1000) id 9A30816031F; Sat, 28 May 2011 16:08:11 -0400 (EDT) From: Chong Yidong References: <87lixqprjq.fsf@stupidchicken.com> Date: Sat, 28 May 2011 16:08:11 -0400 In-Reply-To: (Alp Aker's message of "Sat, 28 May 2011 15:40:47 -0400 (EDT)") Message-ID: <8739jypp04.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Alp Aker writes: > Just a quick follow-up: After posting the bug report I noticed the > same problem in Buffer-menu-buffer+size. In the display spec > > (space :align-to ,(+ 4 name+space-width) > > at the end of the function, that "4" should also be replaced with > "Buffer-menu-buffer-column". Thanks, applied.