From unknown Mon Aug 18 06:56:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8534: 24.0.50; Documentation bug in ns-read-file-name Resent-From: Harald Hanche-Olsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Apr 2011 10:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8534@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130346945816296 (code B ref -1); Fri, 22 Apr 2011 10:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Apr 2011 10:50:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QDDwv-0004En-12 for submit@debbugs.gnu.org; Fri, 22 Apr 2011 06:50:57 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QDDwr-0004EZ-6i for submit@debbugs.gnu.org; Fri, 22 Apr 2011 06:50:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QDDwl-0002GO-HL for submit@debbugs.gnu.org; Fri, 22 Apr 2011 06:50:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:43070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QDDwl-0002GK-D8 for submit@debbugs.gnu.org; Fri, 22 Apr 2011 06:50:47 -0400 Received: from eggs.gnu.org ([140.186.70.92]:49220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QDDwk-0003A2-BJ for bug-gnu-emacs@gnu.org; Fri, 22 Apr 2011 06:50:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QDDwj-0002GA-CX for bug-gnu-emacs@gnu.org; Fri, 22 Apr 2011 06:50:46 -0400 Received: from anne.math.ntnu.no ([129.241.15.150]:52049) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1QDDwi-0002G0-Ug for bug-gnu-emacs@gnu.org; Fri, 22 Apr 2011 06:50:45 -0400 Received: (qmail 15999 invoked from network); 22 Apr 2011 10:50:41 -0000 Received: from gauss.math.ntnu.no (HELO localhost) (hanche@129.241.15.58) by anne.math.ntnu.no with ESMTPA; 22 Apr 2011 10:50:41 -0000 Date: Fri, 22 Apr 2011 12:50:36 +0200 (CEST) Message-Id: <20110422.125036.50362026316335083.hanche@math.ntnu.no> From: Harald Hanche-Olsen X-URL: http://www.math.ntnu.no/~hanche/ X-Mailer: Mew version 6.3.50 on Emacs 24.0.50 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) The doc string for ns-read-file-name (defined in src/nsfns.m) says Optional arg ISLOAD, if non-nil, means read a file name for saving. However the exact opposite is true, as the name of the variable also indicates. On a side note, when the function is called (with ISLOAD = nil) and you select an existing file, the usual warning pane about overwriting an existing file pops up briefly before the dialog vanishes and the function returns the chosen filename. It is not clear to me if this is the intended behaviour, but I find it confusing. It would have been better, I think, to let the save dialog do its usual thing, and then for the caller of ns-read-file-name to assume that the user has authorized the overwriting of a pre-existing file with the same name. In GNU Emacs 24.0.50.1 (x86_64-apple-darwin10.7.0, NS apple-appkit-1038.35) of 2011-04-21 on mack Windowing system distributor `Apple', version 10.3.1038 configured using `configure '--with-ns'' - Harald From unknown Mon Aug 18 06:56:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8534: 24.0.50; Documentation bug in ns-read-file-name Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Apr 2011 17:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8534 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: To: Harald Hanche-Olsen Cc: 8534@debbugs.gnu.org Received: via spool by 8534-submit@debbugs.gnu.org id=B8534.13036674954096 (code B ref 8534); Sun, 24 Apr 2011 17:52:01 +0000 Received: (at 8534) by debbugs.gnu.org; 24 Apr 2011 17:51:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QE3T5-000141-HA for submit@debbugs.gnu.org; Sun, 24 Apr 2011 13:51:35 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QE3T3-00013q-4A for 8534@debbugs.gnu.org; Sun, 24 Apr 2011 13:51:33 -0400 Received: from furball (dhcp128036225098.central.yale.edu [128.36.225.98]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p3OHpR5M009695 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 24 Apr 2011 13:51:27 -0400 Received: by furball (Postfix, from userid 1000) id 1902016055B; Sun, 24 Apr 2011 13:51:22 -0400 (EDT) From: Chong Yidong References: <20110422.125036.50362026316335083.hanche@math.ntnu.no> Date: Sun, 24 Apr 2011 13:51:21 -0400 In-Reply-To: <20110422.125036.50362026316335083.hanche@math.ntnu.no> (Harald Hanche-Olsen's message of "Fri, 22 Apr 2011 12:50:36 +0200 (CEST)") Message-ID: <87sjt7wnae.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Harald Hanche-Olsen writes: > The doc string for ns-read-file-name (defined in src/nsfns.m) says > > Optional arg ISLOAD, if non-nil, means read a file name for saving. > > However the exact opposite is true, as the name of the variable also > indicates. I can patch up the docstring if you explain to me what the opposite of "read a file name for saving" is, and what is the difference between the two kinds of file dialogs (I don't use OSX). From unknown Mon Aug 18 06:56:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8534: 24.0.50; Documentation bug in ns-read-file-name Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Apr 2011 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8534 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: To: Chong Yidong Cc: hanche@math.ntnu.no, 8534@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 8534-submit@debbugs.gnu.org id=B8534.13036697327234 (code B ref 8534); Sun, 24 Apr 2011 18:29:02 +0000 Received: (at 8534) by debbugs.gnu.org; 24 Apr 2011 18:28:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QE439-0001sd-Pb for submit@debbugs.gnu.org; Sun, 24 Apr 2011 14:28:52 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QE436-0001sM-1m for 8534@debbugs.gnu.org; Sun, 24 Apr 2011 14:28:49 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LK6004005Y8HP00@a-mtaout23.012.net.il> for 8534@debbugs.gnu.org; Sun, 24 Apr 2011 21:28:41 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.127.55.52]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LK6004V35ZRDE20@a-mtaout23.012.net.il>; Sun, 24 Apr 2011 21:28:41 +0300 (IDT) Date: Sun, 24 Apr 2011 21:28:42 +0300 From: Eli Zaretskii In-reply-to: <87sjt7wnae.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il Message-id: <831v0rbj1h.fsf@gnu.org> References: <20110422.125036.50362026316335083.hanche@math.ntnu.no> <87sjt7wnae.fsf@stupidchicken.com> X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.7 (-) > X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 > autolearn=unavailable version=3.3.1 > Resent-From: Chong Yidong > Original-Sender: debbugs-submit-bounces@debbugs.gnu.org > Resent-To: owner@debbugs.gnu.org > Resent-CC: bug-gnu-emacs@gnu.org > Resent-Sender: help-debbugs@gnu.org > From: Chong Yidong > Date: Sun, 24 Apr 2011 13:51:21 -0400 > Cc: 8534@debbugs.gnu.org > > Harald Hanche-Olsen writes: > > > The doc string for ns-read-file-name (defined in src/nsfns.m) says > > > > Optional arg ISLOAD, if non-nil, means read a file name for saving. > > > > However the exact opposite is true, as the name of the variable also > > indicates. > > I can patch up the docstring if you explain to me what the opposite of > "read a file name for saving" is, and what is the difference between the > two kinds of file dialogs (I don't use OSX). I guess it means that "non-nil" is backwards, as this part of ns-read-file-name shows: panel = NILP (isLoad) ? (id)[EmacsSavePanel savePanel] : (id)[EmacsOpenPanel openPanel]; This seems to say that if isLoad is non-nil, we pop up a File Open dialog, while when it's nil, we pop up a File Save dialog. From unknown Mon Aug 18 06:56:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8534: 24.0.50; Documentation bug in ns-read-file-name Resent-From: Harald Hanche-Olsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Apr 2011 20:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8534 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: To: eliz@gnu.org Cc: cyd@stupidchicken.com, 8534@debbugs.gnu.org Received: via spool by 8534-submit@debbugs.gnu.org id=B8534.130367730524379 (code B ref 8534); Sun, 24 Apr 2011 20:36:02 +0000 Received: (at 8534) by debbugs.gnu.org; 24 Apr 2011 20:35:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QE61I-0006LA-Qy for submit@debbugs.gnu.org; Sun, 24 Apr 2011 16:35:05 -0400 Received: from anne.math.ntnu.no ([129.241.15.150]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QE61G-0006Kh-VM for 8534@debbugs.gnu.org; Sun, 24 Apr 2011 16:35:04 -0400 Received: (qmail 28573 invoked from network); 24 Apr 2011 20:34:57 -0000 Received: from gauss.math.ntnu.no (HELO localhost) (hanche@129.241.15.58) by anne.math.ntnu.no with ESMTPA; 24 Apr 2011 20:34:56 -0000 Date: Sun, 24 Apr 2011 22:34:49 +0200 (CEST) Message-Id: <20110424.223449.2244487291930552343.hanche@math.ntnu.no> From: Harald Hanche-Olsen In-Reply-To: <831v0rbj1h.fsf@gnu.org> References: <20110422.125036.50362026316335083.hanche@math.ntnu.no> <87sjt7wnae.fsf@stupidchicken.com> <831v0rbj1h.fsf@gnu.org> X-URL: http://www.math.ntnu.no/~hanche/ X-Mailer: Mew version 6.3.50 on Emacs 24.0.50 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) [Eli Zaretskii (2011-04-24 18:28:42 UTC)] > > I can patch up the docstring if you explain to me what the opposite of > > "read a file name for saving" is, and what is the difference between the > > two kinds of file dialogs (I don't use OSX). > > I guess it means that "non-nil" is backwards, as this part of > ns-read-file-name shows: > > panel = NILP (isLoad) ? > (id)[EmacsSavePanel savePanel] : (id)[EmacsOpenPanel openPanel]; > > This seems to say that if isLoad is non-nil, we pop up a File Open > dialog, while when it's nil, we pop up a File Save dialog. That is exactly correct. And the former dialog only lets you select an existing file, while the latter lets you navigate to a folder and type a filename. - Harald From unknown Mon Aug 18 06:56:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8534: 24.0.50; Documentation bug in ns-read-file-name Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Apr 2011 22:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8534 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: To: Harald Hanche-Olsen Cc: eliz@gnu.org, 8534@debbugs.gnu.org Received: via spool by 8534-submit@debbugs.gnu.org id=B8534.130368556811088 (code B ref 8534); Sun, 24 Apr 2011 22:53:01 +0000 Received: (at 8534) by debbugs.gnu.org; 24 Apr 2011 22:52:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QE8Aa-0002sl-8u for submit@debbugs.gnu.org; Sun, 24 Apr 2011 18:52:48 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QE8AX-0002sV-Rb for 8534@debbugs.gnu.org; Sun, 24 Apr 2011 18:52:46 -0400 Received: from furball (dhcp128036226127.central.yale.edu [128.36.226.127]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p3OMqdDQ017450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 24 Apr 2011 18:52:40 -0400 Received: by furball (Postfix, from userid 1000) id 97C3A16055B; Sun, 24 Apr 2011 18:52:39 -0400 (EDT) From: Chong Yidong References: <20110422.125036.50362026316335083.hanche@math.ntnu.no> <87sjt7wnae.fsf@stupidchicken.com> <831v0rbj1h.fsf@gnu.org> <20110424.223449.2244487291930552343.hanche@math.ntnu.no> Date: Sun, 24 Apr 2011 18:52:39 -0400 In-Reply-To: <20110424.223449.2244487291930552343.hanche@math.ntnu.no> (Harald Hanche-Olsen's message of "Sun, 24 Apr 2011 22:34:49 +0200 (CEST)") Message-ID: <871v0rs1mw.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Harald Hanche-Olsen writes: >> panel = NILP (isLoad) ? >> (id)[EmacsSavePanel savePanel] : (id)[EmacsOpenPanel openPanel]; >> >> This seems to say that if isLoad is non-nil, we pop up a File Open >> dialog, while when it's nil, we pop up a File Save dialog. > > That is exactly correct. And the former dialog only lets you select an > existing file, while the latter lets you navigate to a folder and type > a filename. OK. Does the following patch make sense? It renames `isLoad' to `mustmatch', to be like x-file-dialog. (It sure would have been nice if ns-read-file-name had been named x-file-dialog, and given the same arguments. If anyone with access to Mac OS wants to clean it up properly.) === modified file 'src/nsfns.m' *** src/nsfns.m 2011-04-07 03:34:05 +0000 --- src/nsfns.m 2011-04-24 22:46:40 +0000 *************** *** 1416,1424 **** DEFUN ("ns-read-file-name", Fns_read_file_name, Sns_read_file_name, 1, 4, 0, doc: /* Use a graphical panel to read a file name, using prompt PROMPT. Optional arg DIR, if non-nil, supplies a default directory. ! Optional arg ISLOAD, if non-nil, means read a file name for saving. Optional arg INIT, if non-nil, provides a default file name to use. */) ! (Lisp_Object prompt, Lisp_Object dir, Lisp_Object isLoad, Lisp_Object init) { static id fileDelegate = nil; int ret; --- 1416,1425 ---- DEFUN ("ns-read-file-name", Fns_read_file_name, Sns_read_file_name, 1, 4, 0, doc: /* Use a graphical panel to read a file name, using prompt PROMPT. Optional arg DIR, if non-nil, supplies a default directory. ! Optional arg MUSTMATCH, if non-nil, means the returned file or ! directory must exist. Optional arg INIT, if non-nil, provides a default file name to use. */) ! (Lisp_Object prompt, Lisp_Object dir, Lisp_Object mustmatch, Lisp_Object init) { static id fileDelegate = nil; int ret; *************** *** 1443,1449 **** if ([dirS characterAtIndex: 0] == '~') dirS = [dirS stringByExpandingTildeInPath]; ! panel = NILP (isLoad) ? (id)[EmacsSavePanel savePanel] : (id)[EmacsOpenPanel openPanel]; [panel setTitle: promptS]; --- 1444,1450 ---- if ([dirS characterAtIndex: 0] == '~') dirS = [dirS stringByExpandingTildeInPath]; ! panel = NILP (mustmatch) ? (id)[EmacsSavePanel savePanel] : (id)[EmacsOpenPanel openPanel]; [panel setTitle: promptS]; *************** *** 1457,1463 **** panelOK = 0; BLOCK_INPUT; ! if (NILP (isLoad)) { ret = [panel runModalForDirectory: dirS file: initS]; } --- 1458,1464 ---- panelOK = 0; BLOCK_INPUT; ! if (NILP (mustmatch)) { ret = [panel runModalForDirectory: dirS file: initS]; } From unknown Mon Aug 18 06:56:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8534: 24.0.50; Documentation bug in ns-read-file-name Resent-From: Harald Hanche-Olsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Apr 2011 09:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8534 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: To: cyd@stupidchicken.com Cc: eliz@gnu.org, 8534@debbugs.gnu.org Received: via spool by 8534-submit@debbugs.gnu.org id=B8534.1303722026938 (code B ref 8534); Mon, 25 Apr 2011 09:01:02 +0000 Received: (at 8534) by debbugs.gnu.org; 25 Apr 2011 09:00:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEHeb-0000F5-Dn for submit@debbugs.gnu.org; Mon, 25 Apr 2011 05:00:25 -0400 Received: from anne.math.ntnu.no ([129.241.15.150]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QEHeY-0000Ep-4j for 8534@debbugs.gnu.org; Mon, 25 Apr 2011 05:00:23 -0400 Received: (qmail 18741 invoked from network); 25 Apr 2011 09:00:16 -0000 Received: from gauss.math.ntnu.no (HELO localhost) (hanche@129.241.15.58) by anne.math.ntnu.no with ESMTPA; 25 Apr 2011 09:00:16 -0000 Date: Mon, 25 Apr 2011 11:00:16 +0200 (CEST) Message-Id: <20110425.110016.156400462945815559.hanche@math.ntnu.no> From: Harald Hanche-Olsen In-Reply-To: <871v0rs1mw.fsf@stupidchicken.com> References: <831v0rbj1h.fsf@gnu.org> <20110424.223449.2244487291930552343.hanche@math.ntnu.no> <871v0rs1mw.fsf@stupidchicken.com> X-URL: http://www.math.ntnu.no/~hanche/ X-Mailer: Mew version 6.3.50 on Emacs 24.0.50 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) [Chong Yidong (2011-04-24 22:52:39 UTC)] > OK. Does the following patch make sense? It renames `isLoad' to > `mustmatch', to be like x-file-dialog. Yes, I think that is good. > (It sure would have been nice if ns-read-file-name had been named > x-file-dialog, and given the same arguments. If anyone with access to > Mac OS wants to clean it up properly.) I have access, but lack the Objective-C-fu (for the time being, anyhow). - Harald From unknown Mon Aug 18 06:56:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8534: 24.0.50; Documentation bug in ns-read-file-name Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Apr 2011 13:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8534 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: To: Chong Yidong Cc: Harald Hanche-Olsen , 8534@debbugs.gnu.org Received: via spool by 8534-submit@debbugs.gnu.org id=B8534.130373646524321 (code B ref 8534); Mon, 25 Apr 2011 13:02:02 +0000 Received: (at 8534) by debbugs.gnu.org; 25 Apr 2011 13:01:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QELPU-0006KD-GY for submit@debbugs.gnu.org; Mon, 25 Apr 2011 09:01:04 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QELPS-0006Jh-4w for 8534@debbugs.gnu.org; Mon, 25 Apr 2011 09:01:02 -0400 Received: from 121-249-126-200.fibertel.com.ar ([200.126.249.121]:34543 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QELPM-0003uD-Eb; Mon, 25 Apr 2011 09:00:56 -0400 Received: by ceviche.home (Postfix, from userid 20848) id AB9226618A; Mon, 25 Apr 2011 10:00:54 -0300 (ART) From: Stefan Monnier Message-ID: References: <20110422.125036.50362026316335083.hanche@math.ntnu.no> <87sjt7wnae.fsf@stupidchicken.com> <831v0rbj1h.fsf@gnu.org> <20110424.223449.2244487291930552343.hanche@math.ntnu.no> <871v0rs1mw.fsf@stupidchicken.com> Date: Mon, 25 Apr 2011 10:00:54 -0300 In-Reply-To: <871v0rs1mw.fsf@stupidchicken.com> (Chong Yidong's message of "Sun, 24 Apr 2011 18:52:39 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) > (It sure would have been nice if ns-read-file-name had been named > x-file-dialog, and given the same arguments. If anyone with access to No, it should be ns-file-dialog. I know we have a lot of "x-" used as "generic GUI functions", but that's a bad habit which we should aim to fix. Stefan From unknown Mon Aug 18 06:56:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8534: 24.0.50; Documentation bug in ns-read-file-name Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Apr 2011 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8534 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: To: Harald Hanche-Olsen Cc: eliz@gnu.org, 8534@debbugs.gnu.org Received: via spool by 8534-submit@debbugs.gnu.org id=B8534.130384270022082 (code B ref 8534); Tue, 26 Apr 2011 18:32:02 +0000 Received: (at 8534) by debbugs.gnu.org; 26 Apr 2011 18:31:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEn2x-0005k7-UF for submit@debbugs.gnu.org; Tue, 26 Apr 2011 14:31:40 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEn2w-0005jn-NX for 8534@debbugs.gnu.org; Tue, 26 Apr 2011 14:31:39 -0400 Received: from furball (dhcp128036014005.central.yale.edu [128.36.14.5]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p3QIVVIw008324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 26 Apr 2011 14:31:32 -0400 Received: by furball (Postfix, from userid 1000) id 898F1160452; Tue, 26 Apr 2011 14:31:31 -0400 (EDT) From: Chong Yidong References: <831v0rbj1h.fsf@gnu.org> <20110424.223449.2244487291930552343.hanche@math.ntnu.no> <871v0rs1mw.fsf@stupidchicken.com> <20110425.110016.156400462945815559.hanche@math.ntnu.no> Date: Tue, 26 Apr 2011 14:31:31 -0400 In-Reply-To: <20110425.110016.156400462945815559.hanche@math.ntnu.no> (Harald Hanche-Olsen's message of "Mon, 25 Apr 2011 11:00:16 +0200 (CEST)") Message-ID: <87liywvp8c.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Harald Hanche-Olsen writes: > [Chong Yidong (2011-04-24 22:52:39 UTC)] > >> OK. Does the following patch make sense? It renames `isLoad' to >> `mustmatch', to be like x-file-dialog. > > Yes, I think that is good. OK, committed to the emacs-23 branch. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 14:31:52 2011 Received: (at control) by debbugs.gnu.org; 26 Apr 2011 18:31:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEn3A-0005ko-5h for submit@debbugs.gnu.org; Tue, 26 Apr 2011 14:31:52 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEn38-0005kR-Tx for control@debbugs.gnu.org; Tue, 26 Apr 2011 14:31:51 -0400 Received: from furball (dhcp128036014005.central.yale.edu [128.36.14.5]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p3QIVist014389 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Tue, 26 Apr 2011 14:31:45 -0400 Received: by furball (Postfix, from userid 1000) id A1D11160452; Tue, 26 Apr 2011 14:31:44 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 8534 Date: Tue, 26 Apr 2011 14:31:44 -0400 Message-ID: <87liywlv8v.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 8534 thanks