Subject: bug#8532: closed (Re: bug#8532: FAIL: cp/sparse-fiemap)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 22 Apr 2011 09:16:02 +0000

Your bug report

#8532: FAIL: cp/sparse-fiemap

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
8532: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8532
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#8532: FAIL: cp/sparse-fiemap
From: Jim Meyering <[email-masked]>
To: "Alan Curry" <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Fri, 22 Apr 2011 11:15:06 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Alan Curry wrote:
> Jim Meyering writes:
>>
>> Dennis Clarke wrote:
>> > FAIL: cp/sparse-fiemap
>> ...
>> > + awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""}'
>> > awk: cmd. line:1: /^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END
>> > {print ""}
>> > awk: cmd. line:1:                                     ^ syntax error
>> > + sed 's/ [a-z,][a-z,]*$//' ff1
>>
>> Thank you for the report.
>> What awk program and version are you using?
>> I.e., awk --version might help.
>> Also, what distribution are you using?
>
> I can't figure out what version he's using, but Mr. Kernighan's awk doesn't
> like that syntax either. Notice that if you changed the '<' to a '>' it would
> be an output redirection for the printf. Using the '<' as a comparison
> operator in the same position is awfully fragile.
>
> Parenthesizing the ternary expression makes it happy again.
>
>> BTW, that syntax works for me using the latest gawk with or without -W compat,
>> and with the mawk and nawk programs from debian unstable.
>
> apt-get install original-awk

Thanks.
This patch fixes it, and I've closed the ticket.

Alan, I'll wait for you to "ack" before pushing it,
since I've listed you as the author.

From 302cfcaeab531138d59e4835ef77020a750e71f9 Mon Sep 17 00:00:00 2001
From: Alan Curry <[email-masked]>
Date: Fri, 22 Apr 2011 11:08:50 +0200
Subject: [PATCH] tests: sparse-fiemap: adjust syntax to accommodate older awk

* tests/cp/sparse-fiemap: Parenthesize ternary expression used
as an argument to awk's printf.  Otherwise, gawk 3.0.1 and the
one from debian stable's original-awk would get a syntax error.
Reported by Dennis Clarke.

Copyright note: tiny change
---
 THANKS.in              |    1 +
 tests/cp/sparse-fiemap |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/THANKS.in b/THANKS.in
index bd8645f..342a52c 100644
--- a/THANKS.in
+++ b/THANKS.in
@@ -151,6 +151,7 @@ Deepak Goel                         [email-masked]
 Denis Excoffier                     [email-masked]
 Denis McKeon                        [email-masked]
 Dennis Henriksen                    [email-masked]
+Dennis Clarke                       [email-masked]
 Dennis Smit                         [email-masked]
 Derek Clegg                         [email-masked]
 Dick Streefland                     [email-masked]
diff --git a/tests/cp/sparse-fiemap b/tests/cp/sparse-fiemap
index 1394060..64668ed 100755
--- a/tests/cp/sparse-fiemap
+++ b/tests/cp/sparse-fiemap
@@ -64,7 +64,7 @@ fi
 f()
 {
   sed 's/ [a-z,][a-z,]*$//' $@ \
-    | awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""}'
+    | awk '/^ *[0-9]/ {printf "%d %d ", $2, (NF<5 ? $NF : $5) } END {print ""}'
 }

 for i in $(seq 1 2 21); do
--
1.7.5.rc3.291.g63e4e

Subject: FAIL: cp/sparse-fiemap
From: Dennis Clarke <[email-masked]>
To: [email-masked]
Date: Thu, 21 Apr 2011 13:30:10 -0400 (EDT)
List-Id: <debbugs-submit.debbugs.gnu.org>

FAIL: cp/sparse-fiemap

.
.
.

======================================
1 of 388 tests failed
(64 tests were not run)
See tests/test-suite.log
Please report to [email-masked]
======================================

said file reports :

==============================================
   GNU coreutils 8.11: tests/test-suite.log
==============================================

1 of 388 tests failed.  (64 tests were not run).

.. contents:: :depth: 2

.
.
.

FAIL: cp/sparse-fiemap (exit: 1)
================================

++ initial_cwd_=/home/dclarke/build/coreutils-8.11.001/tests
++ fail=0
+++ testdir_prefix_
+++ printf gt
++ pfx_=gt
+++ mktempd_ /home/dclarke/build/coreutils-8.11.001/tests
gt-sparse-fiemap.XXXX
+++ case $# in
+++ destdir_=/home/dclarke/build/coreutils-8.11.001/tests
+++ template_=gt-sparse-fiemap.XXXX
+++ MAX_TRIES_=4
+++ case $destdir_ in
+++ case $template_ in
++++ unset TMPDIR
++++ mktemp -d -t -p /home/dclarke/build/coreutils-8.11.001/tests
gt-sparse-fiemap.XXXX
+++ d=/home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL
+++ case $d in
+++ test -d
/home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL
++++ tr S -
++++ ls -dgo
/home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL
+++ perms='drwx------ 2 4096 Apr 21 17:19
/home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL'
+++ case $perms in
+++ test 0 = 0
+++ echo /home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL
+++ return
++
test_dir_=/home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL
++ cd /home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL
++ gl_init_sh_nl_='
'
++ IFS='
'
++ for sig_ in 1 2 3 13 15
+++ expr 1 + 128
++ eval 'trap '\''Exit 129'\'' 1'
+++ trap 'Exit 129' 1
++ for sig_ in 1 2 3 13 15
+++ expr 2 + 128
++ eval 'trap '\''Exit 130'\'' 2'
+++ trap 'Exit 130' 2
++ for sig_ in 1 2 3 13 15
+++ expr 3 + 128
++ eval 'trap '\''Exit 131'\'' 3'
+++ trap 'Exit 131' 3
++ for sig_ in 1 2 3 13 15
+++ expr 13 + 128
++ eval 'trap '\''Exit 141'\'' 13'
+++ trap 'Exit 141' 13
++ for sig_ in 1 2 3 13 15
+++ expr 15 + 128
++ eval 'trap '\''Exit 143'\'' 15'
+++ trap 'Exit 143' 15
++ trap remove_tmp_ 0
+ path_prepend_ ../src
+ test 1 '!=' 0
+ path_dir_=../src
+ case $path_dir_ in
++ cd /home/dclarke/build/coreutils-8.11.001/tests/../src
++ echo /home/dclarke/build/coreutils-8.11.001/src
+ abs_path_dir_=/home/dclarke/build/coreutils-8.11.001/src
+ case $abs_path_dir_ in
+
PATH=/home/dclarke/build/coreutils-8.11.001/src:/home/dclarke/build/coreutils-8.11.001/src:/usr/local/bin:/usr/bin:/sbin:/bin:/usr/sbin:/opt/schily/bin
+ create_exe_shims_ /home/dclarke/build/coreutils-8.11.001/src
+ case $EXEEXT in
+ return 0
+ shift
+ test 0 '!=' 0
+ export PATH
+ print_ver_ cp
+ test yes = yes
+ local i
+ for i in '$*'
+ env cp --version
cp (GNU coreutils) 8.11
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Torbj"orn Granlund, David MacKenzie, and Jim Meyering.
+ perl -e 1
+ touch fiemap_chk
+ fiemap_capable_ fiemap_chk
+ python
+ python /home/dclarke/build/coreutils-8.11.001/tests/fiemap-capable
fiemap_chk
+ df -t ext3 .
df: no file systems processed
+ :
++ seq 1 2 21
+ for i in '$(seq 1 2 21)'
+ for j in 1 2 31 100
+ perl -e 'BEGIN { $n = 1 * 1024; *F = *STDOUT }' -e 'for (1..1) { sysseek
(*F, $n, 1)' -e '&& syswrite (*F, chr($_)x$n) or die "$!"}'
+ cp --sparse=always j1 j2
+ cmp j1 j2
+ grep -F extent
+ filefrag -vs j1
+ filefrag -v j1
+ filefrag -vs j2
+ perl /home/dclarke/build/coreutils-8.11.001/tests/filefrag-extent-compare
+ f ff1
+ awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""}'
awk: cmd. line:1: /^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END
{print ""}
awk: cmd. line:1:                                     ^ syntax error
+ sed 's/ [a-z,][a-z,]*$//' ff1
+ f ff2
+ awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""}'
+ sed 's/ [a-z,][a-z,]*$//' ff2
awk: cmd. line:1: /^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END
{print ""}
awk: cmd. line:1:                                     ^ syntax error
filefrag-extent-compare: expected exactly two input lines; got 0
+ fail=1
+ test 1 = 1
+ break 2
+ Exit 1
+ set +e
+ exit 1
+ exit 1
+ remove_tmp_
+ __st=1
+ cleanup_
+ :
+ cd /home/dclarke/build/coreutils-8.11.001/tests
+ chmod -R u+rwx
/home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL
+ rm -rf /home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL
+ exit 1

-- 
Dennis Clarke
[email-masked]  <- Email related to the open source Solaris
[email-masked]   <- Email related to open source for Solaris