From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 21 13:37:33 2011 Received: (at submit) by debbugs.gnu.org; 21 Apr 2011 17:37:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QCxoq-0006rx-HP for submit@debbugs.gnu.org; Thu, 21 Apr 2011 13:37:33 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QCxhx-0006ii-Er for submit@debbugs.gnu.org; Thu, 21 Apr 2011 13:30:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCxhr-0002VK-4R for submit@debbugs.gnu.org; Thu, 21 Apr 2011 13:30:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:55957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCxhr-0002VG-2q for submit@debbugs.gnu.org; Thu, 21 Apr 2011 13:30:19 -0400 Received: from eggs.gnu.org ([140.186.70.92]:59059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCxhp-0001Kn-Ru for bug-coreutils@gnu.org; Thu, 21 Apr 2011 13:30:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCxho-0002V5-EK for bug-coreutils@gnu.org; Thu, 21 Apr 2011 13:30:17 -0400 Received: from comm.purplecow.org ([210.87.62.131]:55803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCxhn-0002UM-JL for bug-coreutils@gnu.org; Thu, 21 Apr 2011 13:30:16 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=iso-8859-1 Received: from interact.purplecow.org ([127.0.0.1]) by comm.purplecow.org (Sun Java(tm) System Messaging Server 6.3-6.03 (built Mar 14 2008; 32bit)) with ESMTPA id <0LK0002H7JAAE720@comm.purplecow.org> for bug-coreutils@gnu.org; Fri, 22 Apr 2011 03:30:10 +1000 (EST) Received: from interact.purplecow.org ([10.0.66.17] helo=interact.purplecow.org) with IPv4:25 by ASSP.nospam; Fri, 22 Apr 2011 03:30:10 +1000 Received: from 10.0.66.17 (proxying for unknown) (SquirrelMail authenticated user dclarke@blastwave.org) by interact.purplecow.org with HTTP; Thu, 21 Apr 2011 13:30:10 -0400 (EDT) Message-id: <55791.10.0.66.17.1303407010.squirrel@interact.purplecow.org> Date: Thu, 21 Apr 2011 13:30:10 -0400 (EDT) Subject: FAIL: cp/sparse-fiemap From: Dennis Clarke To: bug-coreutils@gnu.org User-Agent: SquirrelMail/1.4.11 X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 21 Apr 2011 13:37:31 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: dclarke@blastwave.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) FAIL: cp/sparse-fiemap . . . ====================================== 1 of 388 tests failed (64 tests were not run) See tests/test-suite.log Please report to bug-coreutils@gnu.org ====================================== said file reports : ============================================== GNU coreutils 8.11: tests/test-suite.log ============================================== 1 of 388 tests failed. (64 tests were not run). .. contents:: :depth: 2 . . . FAIL: cp/sparse-fiemap (exit: 1) ================================ ++ initial_cwd_=/home/dclarke/build/coreutils-8.11.001/tests ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /home/dclarke/build/coreutils-8.11.001/tests gt-sparse-fiemap.XXXX +++ case $# in +++ destdir_=/home/dclarke/build/coreutils-8.11.001/tests +++ template_=gt-sparse-fiemap.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR ++++ mktemp -d -t -p /home/dclarke/build/coreutils-8.11.001/tests gt-sparse-fiemap.XXXX +++ d=/home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL +++ case $d in +++ test -d /home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL ++++ tr S - ++++ ls -dgo /home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL +++ perms='drwx------ 2 4096 Apr 21 17:19 /home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL' +++ case $perms in +++ test 0 = 0 +++ echo /home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL +++ return ++ test_dir_=/home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL ++ cd /home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ../src + test 1 '!=' 0 + path_dir_=../src + case $path_dir_ in ++ cd /home/dclarke/build/coreutils-8.11.001/tests/../src ++ echo /home/dclarke/build/coreutils-8.11.001/src + abs_path_dir_=/home/dclarke/build/coreutils-8.11.001/src + case $abs_path_dir_ in + PATH=/home/dclarke/build/coreutils-8.11.001/src:/home/dclarke/build/coreutils-8.11.001/src:/usr/local/bin:/usr/bin:/sbin:/bin:/usr/sbin:/opt/schily/bin + create_exe_shims_ /home/dclarke/build/coreutils-8.11.001/src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ cp + test yes = yes + local i + for i in '$*' + env cp --version cp (GNU coreutils) 8.11 Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Torbj"orn Granlund, David MacKenzie, and Jim Meyering. + perl -e 1 + touch fiemap_chk + fiemap_capable_ fiemap_chk + python + python /home/dclarke/build/coreutils-8.11.001/tests/fiemap-capable fiemap_chk + df -t ext3 . df: no file systems processed + : ++ seq 1 2 21 + for i in '$(seq 1 2 21)' + for j in 1 2 31 100 + perl -e 'BEGIN { $n = 1 * 1024; *F = *STDOUT }' -e 'for (1..1) { sysseek (*F, $n, 1)' -e '&& syswrite (*F, chr($_)x$n) or die "$!"}' + cp --sparse=always j1 j2 + cmp j1 j2 + grep -F extent + filefrag -vs j1 + filefrag -v j1 + filefrag -vs j2 + perl /home/dclarke/build/coreutils-8.11.001/tests/filefrag-extent-compare + f ff1 + awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""}' awk: cmd. line:1: /^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""} awk: cmd. line:1: ^ syntax error + sed 's/ [a-z,][a-z,]*$//' ff1 + f ff2 + awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""}' + sed 's/ [a-z,][a-z,]*$//' ff2 awk: cmd. line:1: /^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""} awk: cmd. line:1: ^ syntax error filefrag-extent-compare: expected exactly two input lines; got 0 + fail=1 + test 1 = 1 + break 2 + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /home/dclarke/build/coreutils-8.11.001/tests + chmod -R u+rwx /home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL + rm -rf /home/dclarke/build/coreutils-8.11.001/tests/gt-sparse-fiemap.FrbL + exit 1 -- Dennis Clarke dclarke@opensolaris.ca <- Email related to the open source Solaris dclarke@blastwave.org <- Email related to open source for Solaris From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 21 14:49:09 2011 Received: (at 8532) by debbugs.gnu.org; 21 Apr 2011 18:49:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QCyw8-0008R7-9z for submit@debbugs.gnu.org; Thu, 21 Apr 2011 14:49:09 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QCyw6-0008Qf-Ql for 8532@debbugs.gnu.org; Thu, 21 Apr 2011 14:49:07 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id BD7F2601A4; Thu, 21 Apr 2011 20:49:00 +0200 (CEST) From: Jim Meyering To: dclarke@blastwave.org Subject: Re: bug#8532: FAIL: cp/sparse-fiemap In-Reply-To: <55791.10.0.66.17.1303407010.squirrel@interact.purplecow.org> (Dennis Clarke's message of "Thu, 21 Apr 2011 13:30:10 -0400 (EDT)") References: <55791.10.0.66.17.1303407010.squirrel@interact.purplecow.org> Date: Thu, 21 Apr 2011 20:49:00 +0200 Message-ID: <87bozzsan7.fsf@rho.meyering.net> Lines: 16 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: 8532 Cc: 8532@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Dennis Clarke wrote: > FAIL: cp/sparse-fiemap ... > + awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""}' > awk: cmd. line:1: /^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END > {print ""} > awk: cmd. line:1: ^ syntax error > + sed 's/ [a-z,][a-z,]*$//' ff1 Thank you for the report. What awk program and version are you using? I.e., awk --version might help. Also, what distribution are you using? BTW, that syntax works for me using the latest gawk with or without -W compat, and with the mawk and nawk programs from debian unstable. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 21 16:12:44 2011 Received: (at 8532) by debbugs.gnu.org; 21 Apr 2011 20:12:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QD0F2-0001ps-0M for submit@debbugs.gnu.org; Thu, 21 Apr 2011 16:12:44 -0400 Received: from comm.purplecow.org ([210.87.62.131]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QD0Ez-0001pe-VL for 8532@debbugs.gnu.org; Thu, 21 Apr 2011 16:12:43 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=iso-8859-1 Received: from interact.purplecow.org ([127.0.0.1]) by comm.purplecow.org (Sun Java(tm) System Messaging Server 6.3-6.03 (built Mar 14 2008; 32bit)) with ESMTPA id <0LK000M2EQSYLD00@comm.purplecow.org> for 8532@debbugs.gnu.org; Fri, 22 Apr 2011 06:12:34 +1000 (EST) Received: from interact.purplecow.org ([10.0.66.17] helo=interact.purplecow.org) with IPv4:25 by ASSP.nospam; Fri, 22 Apr 2011 06:12:34 +1000 Received: from 10.0.66.17 (proxying for unknown) (SquirrelMail authenticated user dclarke@blastwave.org) by interact.purplecow.org with HTTP; Thu, 21 Apr 2011 16:12:34 -0400 (EDT) Message-id: <59810.10.0.66.17.1303416754.squirrel@interact.purplecow.org> Date: Thu, 21 Apr 2011 16:12:34 -0400 (EDT) Subject: What awk program and version are you using? From: Dennis Clarke To: 8532@debbugs.gnu.org User-Agent: SquirrelMail/1.4.11 X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: 8532 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: dclarke@blastwave.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) > Thank you for the report. > What awk program and version are you using? aster $ which awk /usr/local/bin/awk aster $ which gawk /usr/local/bin/gawk aster $ aster $ ls -lapin /usr/local/bin/awk /usr/local/bin/gawk 2796264 lrwxrwxrwx 1 16411 1002 4 Mar 3 01:48 /usr/local/bin/awk -> gawk 2796230 -rwxrwxr-x 2 16411 1002 279270 Dec 26 18:54 /usr/local/bin/gawk aster $ awk --version GNU Awk 3.0.1 Copyright (C) 1989, 1991-1996 Free Software Foundation. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. aster $ > Also, what distribution are you using? aster $ cat /proc/version Linux version 2.6.32-5-amd64 (Debian 2.6.32-31) (ben@decadent.org.uk) (gcc version 4.3.5 (Debian 4.3.5-4) ) #1 SMP Mon Mar 7 21:35:22 UTC 2011 Debian Linux stable ( squeeze ) on Sun Ultra 20 workstation hardware, 8G memory and the usual bits. Let me know if I can help in any way on this. -- Dennis Clarke dclarke@opensolaris.ca <- Email related to the open source Solaris dclarke@blastwave.org <- Email related to open source for Solaris From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 21 16:43:49 2011 Received: (at 8532) by debbugs.gnu.org; 21 Apr 2011 20:43:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QD0j7-0002XE-3I for submit@debbugs.gnu.org; Thu, 21 Apr 2011 16:43:49 -0400 Received: from c-67-162-90-113.hsd1.in.comcast.net ([67.162.90.113] helo=kosh.dhis.org) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QD0j5-0002X3-BT for 8532@debbugs.gnu.org; Thu, 21 Apr 2011 16:43:47 -0400 Received: (qmail 5083 invoked by uid 1000); 21 Apr 2011 20:43:41 -0000 Message-ID: <20110421204341.5082.qmail@kosh.dhis.org> From: "Alan Curry" Subject: Re: bug#8532: FAIL: cp/sparse-fiemap To: jim@meyering.net (Jim Meyering) Date: Thu, 21 Apr 2011 15:43:41 -0500 (GMT+5) In-Reply-To: <87bozzsan7.fsf@rho.meyering.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 8532 Cc: 8532@debbugs.gnu.org, dclarke@blastwave.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.6 (/) Jim Meyering writes: > > Dennis Clarke wrote: > > FAIL: cp/sparse-fiemap > ... > > + awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""}' > > awk: cmd. line:1: /^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END > > {print ""} > > awk: cmd. line:1: ^ syntax error > > + sed 's/ [a-z,][a-z,]*$//' ff1 > > Thank you for the report. > What awk program and version are you using? > I.e., awk --version might help. > Also, what distribution are you using? I can't figure out what version he's using, but Mr. Kernighan's awk doesn't like that syntax either. Notice that if you changed the '<' to a '>' it would be an output redirection for the printf. Using the '<' as a comparison operator in the same position is awfully fragile. Parenthesizing the ternary expression makes it happy again. > > BTW, that syntax works for me using the latest gawk with or without -W compat, > and with the mawk and nawk programs from debian unstable. apt-get install original-awk -- Alan Curry From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 22 05:15:17 2011 Received: (at 8532-done) by debbugs.gnu.org; 22 Apr 2011 09:15:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QDCSK-00025d-IR for submit@debbugs.gnu.org; Fri, 22 Apr 2011 05:15:16 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QDCSH-00025N-2o for 8532-done@debbugs.gnu.org; Fri, 22 Apr 2011 05:15:14 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 1520860220; Fri, 22 Apr 2011 11:15:07 +0200 (CEST) From: Jim Meyering To: "Alan Curry" Subject: Re: bug#8532: FAIL: cp/sparse-fiemap In-Reply-To: <20110421204341.5082.qmail@kosh.dhis.org> (Alan Curry's message of "Thu, 21 Apr 2011 15:43:41 -0500 (GMT+5)") References: <20110421204341.5082.qmail@kosh.dhis.org> Date: Fri, 22 Apr 2011 11:15:06 +0200 Message-ID: <87sjtaprz9.fsf@rho.meyering.net> Lines: 78 MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8532-done Cc: 8532-done@debbugs.gnu.org, dclarke@blastwave.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) Alan Curry wrote: > Jim Meyering writes: >> >> Dennis Clarke wrote: >> > FAIL: cp/sparse-fiemap >> ... >> > + awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print= ""}' >> > awk: cmd. line:1: /^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 }= END >> > {print ""} >> > awk: cmd. line:1: ^ syntax error >> > + sed 's/ [a-z,][a-z,]*$//' ff1 >> >> Thank you for the report. >> What awk program and version are you using? >> I.e., awk --version might help. >> Also, what distribution are you using? > > I can't figure out what version he's using, but Mr. Kernighan's awk doesn= 't > like that syntax either. Notice that if you changed the '<' to a '>' it w= ould > be an output redirection for the printf. Using the '<' as a comparison > operator in the same position is awfully fragile. > > Parenthesizing the ternary expression makes it happy again. > >> BTW, that syntax works for me using the latest gawk with or without -W c= ompat, >> and with the mawk and nawk programs from debian unstable. > > apt-get install original-awk Thanks. This patch fixes it, and I've closed the ticket. Alan, I'll wait for you to "ack" before pushing it, since I've listed you as the author. From=20302cfcaeab531138d59e4835ef77020a750e71f9 Mon Sep 17 00:00:00 2001 From: Alan Curry Date: Fri, 22 Apr 2011 11:08:50 +0200 Subject: [PATCH] tests: sparse-fiemap: adjust syntax to accommodate older a= wk * tests/cp/sparse-fiemap: Parenthesize ternary expression used as an argument to awk's printf. Otherwise, gawk 3.0.1 and the one from debian stable's original-awk would get a syntax error. Reported by Dennis Clarke. Copyright note: tiny change =2D-- THANKS.in | 1 + tests/cp/sparse-fiemap | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/THANKS.in b/THANKS.in index bd8645f..342a52c 100644 =2D-- a/THANKS.in +++ b/THANKS.in @@ -151,6 +151,7 @@ Deepak Goel deego@gnufans.org Denis Excoffier denis.excoffier@airbus.com Denis McKeon dmckeon@swcp.com Dennis Henriksen opus@flamingo.osrl.dk +Dennis Clarke dclarke@blastwave.org Dennis Smit ds@nerds-incorporated.org Derek Clegg dclegg@next.com Dick Streefland dick_streefland@tasking.com diff --git a/tests/cp/sparse-fiemap b/tests/cp/sparse-fiemap index 1394060..64668ed 100755 =2D-- a/tests/cp/sparse-fiemap +++ b/tests/cp/sparse-fiemap @@ -64,7 +64,7 @@ fi f() { sed 's/ [a-z,][a-z,]*$//' $@ \ =2D | awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {pri= nt ""}' + | awk '/^ *[0-9]/ {printf "%d %d ", $2, (NF<5 ? $NF : $5) } END {print= ""}' } for i in $(seq 1 2 21); do =2D- 1.7.5.rc3.291.g63e4e From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 22 05:43:41 2011 Received: (at 8532) by debbugs.gnu.org; 22 Apr 2011 09:43:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QDCto-0002iB-Gg for submit@debbugs.gnu.org; Fri, 22 Apr 2011 05:43:40 -0400 Received: from c-67-162-90-113.hsd1.in.comcast.net ([67.162.90.113] helo=kosh.dhis.org) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QDCtn-0002hz-H4 for 8532@debbugs.gnu.org; Fri, 22 Apr 2011 05:43:39 -0400 Received: (qmail 12717 invoked by uid 1000); 22 Apr 2011 09:43:33 -0000 Message-ID: <20110422094333.12716.qmail@kosh.dhis.org> From: "Alan Curry" Subject: Re: bug#8532: FAIL: cp/sparse-fiemap To: jim@meyering.net (Jim Meyering) Date: Fri, 22 Apr 2011 04:43:33 -0500 (GMT+5) In-Reply-To: <87sjtaprz9.fsf@rho.meyering.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 8532 Cc: 8532@debbugs.gnu.org, dclarke@blastwave.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.6 (/) Jim Meyering writes: > > Alan Curry wrote: > > > > Parenthesizing the ternary expression makes it happy again. > > > >> BTW, that syntax works for me using the latest gawk with or without -W c= > ompat, > >> and with the mawk and nawk programs from debian unstable. > > > > apt-get install original-awk > > Thanks. > This patch fixes it, and I've closed the ticket. > > Alan, I'll wait for you to "ack" before pushing it, > since I've listed you as the author. Yeah, it looks right. I looked over the POSIX grammar for awk and I believe it requires some parentheses here, either around the whole ternary expression or around the comparison part of it. The key is the difference between non_unary_expr and non_unary_print_expr. The "print" version is in effect wherever a redirection operator might appear, and it doesn't have any of the 6 comparison operators < = > <= >= != The ability to do a comparison (other than '>') without parentheses in an argument to print is an extension. From a quick peek at the gawk ChangeLog I'd guess that it happened here: Sun Feb 2 15:32:42 2003 Stepan Kasal [...] The redirection of print statements reworked. The idea comes from mawk-1.3.3; much thanks to Michael Brennan! which puts it between gawk 3.1.1 and 3.1.2. I noticed that Dennis Clarke reports he's using gawk 3.0.1 out of /usr/local/bin on a Debian squeeze system, which should have gawk 3.1.7 in /usr/bin. Seems like an odd thing to do. Installed the local version a long time ago and forgot to remove it when the version in /usr/bin surpassed it? Something like that has happened to me at least once before. -- Alan Curry From unknown Wed Aug 20 02:46:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 20 May 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator