GNU bug report logs - #8526
[GNU Bison 2.4.588-2f658] testsuite: 74 75 76 77 78 79 80 81 82 141 149 185 186 188 189 190 191 195 247 250 287 289 291 293 295 296 297 298 299 300 301 302 304 305 306 307 310 311 failed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8526 in the body.
You can then email your comments to 8526 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: "Joel E. Denny" <joeldenny <at> joeldenny.org>
Cc: bug-automake <at> gnu.org, Bison Bugs <bug-bison <at> gnu.org>
Subject: Re: [GNU Bison 2.4.588-2f658] testsuite: 74 75 76 77 78 79 80 81 82
	141 149 185 186 188 189 190 191 195 247 250 287 289 291 293 295
	296 297 298 299 300 301 302 304 305 306 307 310 311 failed
Date: Wed, 20 Apr 2011 14:43:46 +0200

[TL;DR using automake.git, bison.git fails "make distcheck"s non-srcdir build]

Joel E. Denny wrote:
> On Mon, 18 Apr 2011, Jim Meyering wrote:
>
>> FYI, now, using the latest sources from git,
>> when I bootstrap, run ./configure --enable-gcc-warnings
>> and then make and "make distcheck", I see this:
>>
>> /bin/sh ../build-aux/ylwrap ../src/parse-gram.y y.tab.c
>> src/parse-gram.c y.tab.h src/parse-gram.h y.output
>> src/parse-gram.output -- tests/bison -y -dv --warnings=all,error
>> --report=all
>> /bin/sh ../build-aux/ylwrap ../src/scan-code.l lex.yy.c src/scan-code.c -- flex
>> /bin/sh ../build-aux/ylwrap ../src/scan-gram.l lex.yy.c src/scan-gram.c -- flex
>> /bin/sh ../build-aux/ylwrap ../src/scan-skel.l lex.yy.c src/scan-skel.c -- flex
>> /w/bison/bison-2.4.593-a78a/_build/tests/bison: line 11:
>> /w/bison/bison-2.4.593-a78a/_build/src/bison: No such file or
>> directory
>> Can't open y.tab.[ch]: No such file or directory.
>> make[1]: *** [src/parse-gram.c] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make[1]: Leaving directory `/w/bison/bison-2.4.593-a78a/_build'
>> make: *** [distcheck] Error 1
>
> This doesn't happen for me.  Somehow your tarball's parse-gram.y must have
> a later time stamp than parse-gram.c or parse-gram.h.  Is your "make dist"
> setting the time stamps inappropriately for some reason?  If so, perhaps
> we need a dist-hook to fix that.  Or are the time stamps being set
> inappropriately upon extraction from the tarball?

Hi Joel,

I figure it's something different about my build environment.
That doesn't seem to be the problem:

  $ tar tvf bison-2.4.593-a78a.tar.gz|grep parse-gram
  -rw-r--r-- 0/0    21804 2011-03-17 18:00 bison-2.4.593-a78a/src/parse-gram.y
  -rw-r--r-- 0/0   103025 2011-04-18 21:59 bison-2.4.593-a78a/src/parse-gram.c
  -rw-r--r-- 0/0     5845 2011-04-18 21:59 bison-2.4.593-a78a/src/parse-gram.h

I can reproduce it by running "make dist", unpacking the result
and then using it to perform a non-srcdir build.

  tar xf bison-2.4.593-a78a.tar.bz2
  cd bison-2.4.593-a78a
  mkdir .j && cd .j && ../configure && make
  ...

/bin/sh ../build-aux/ylwrap ../src/parse-gram.y y.tab.c src/parse-gram.c y.tab.h src/parse-gram.h y.output src/parse-gram.output -- tests/bison -y -dv --warnings=all,error --report=all
/bin/sh ../build-aux/ylwrap ../src/scan-code.l lex.yy.c src/scan-code.c -- flex
/bin/sh ../build-aux/ylwrap ../src/scan-gram.l lex.yy.c src/scan-gram.c -- flex
/bin/sh ../build-aux/ylwrap ../src/scan-skel.l lex.yy.c src/scan-skel.c -- flex
/h/j/w/co/bison/bison-2.4.593-a78a/.j/tests/bison: line 11: /h/j/w/co/bison/bison-2.4.593-a78a/.j/src/bison: No such file or directory
Can't open y.tab.[ch]: No such file or directory.
make: *** [src/parse-gram.c] Error 1
make: *** Waiting for unfinished jobs....
[Exit 2]

FYI, I've just  bootstrapped bison from scratch, but without using
e.g., personally-installed automake build from automake.git's master.
That solved the problem, but I don't know precisely why yet.
I'll investigate, eventually.

Message #8 received at 8526 <at> debbugs.gnu.org (full text, mbox):

From: "Ralf Wildenhues" <Ralf.Wildenhues <at> gmx.de>
To: Jim Meyering <jim <at> meyering.net>
Cc: 8526 <at> debbugs.gnu.org, bug-bison <at> gnu.org,
	"Joel E. Denny" <joeldenny <at> joeldenny.org>
Subject: Re: bug#8526: [GNU Bison 2.4.588-2f658] testsuite: 74 75 76 77 78 79
	80 81 82 141 149 185 186 188 189 190 191 195 247 250 287 289 291 293
	295 296 297 298 299 300 301 302 304 305 306 307 310 311 failed
Date: Wed, 20 Apr 2011 15:13:15 +0200

* Jim Meyering wrote on Wed, Apr 20, 2011 at 02:43:46PM CEST:
> [TL;DR using automake.git, bison.git fails "make distcheck"s non-srcdir build]

> >> /bin/sh ../build-aux/ylwrap ../src/scan-skel.l lex.yy.c src/scan-skel.c -- flex
> >> /w/bison/bison-2.4.593-a78a/_build/tests/bison: line 11:
> >> /w/bison/bison-2.4.593-a78a/_build/src/bison: No such file or
> >> directory
> >> Can't open y.tab.[ch]: No such file or directory.
> >> make[1]: *** [src/parse-gram.c] Error 1

Likely dupe of http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8485
regression introduced in v1.11-328-ge87c030/

> FYI, I've just  bootstrapped bison from scratch, but without using
> e.g., personally-installed automake build from automake.git's master.
> That solved the problem, but I don't know precisely why yet.

Explained by above.

Thanks,
Ralf

Message #11 received at 8526 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: "Ralf Wildenhues" <Ralf.Wildenhues <at> gmx.de>
Cc: 8526 <at> debbugs.gnu.org, bug-bison <at> gnu.org,
	"Joel E. Denny" <joeldenny <at> joeldenny.org>
Subject: Re: bug#8526: [GNU Bison 2.4.588-2f658] testsuite: 74 75 76 77 78 79
	80 81 82 141 149 185 186 188 189 190 191 195 247 250 287 289
	291 293 295 296 297 298 299 300 301 302 304 305 306 307 310 311 failed
Date: Wed, 20 Apr 2011 15:52:50 +0200

Ralf Wildenhues wrote:
> * Jim Meyering wrote on Wed, Apr 20, 2011 at 02:43:46PM CEST:
>> [TL;DR using automake.git, bison.git fails "make distcheck"s non-srcdir build]
>
>> >> /bin/sh ../build-aux/ylwrap ../src/scan-skel.l lex.yy.c src/scan-skel.c -- flex
>> >> /w/bison/bison-2.4.593-a78a/_build/tests/bison: line 11:
>> >> /w/bison/bison-2.4.593-a78a/_build/src/bison: No such file or
>> >> directory
>> >> Can't open y.tab.[ch]: No such file or directory.
>> >> make[1]: *** [src/parse-gram.c] Error 1
>
> Likely dupe of http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8485
> regression introduced in v1.11-328-ge87c030/
>
>> FYI, I've just  bootstrapped bison from scratch, but without using
>> e.g., personally-installed automake build from automake.git's master.
>> That solved the problem, but I don't know precisely why yet.
>
> Explained by above.

Thanks.  That does indeed look like the same problem.

Message #16 received at 8526 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: automake-patches <at> gnu.org
Cc: 8526 <at> debbugs.gnu.org, 8485 <at> debbugs.gnu.org
Subject: [PATCH] {maint} deps: partially revert commit `v1.11-512-geeee551'
Date: Thu, 20 Oct 2011 22:33:59 +0200

This change partly reverts commit "Create subdirs for generated
sources even when not dep tracking", of 2011-04-02.

That commit had caused the bugs #8485 and #8526.  Since we are
nearing the bug-fixing automake release 1.11.2, the safest policy
at the moment is to just revert the problematic hunks: an older,
known bug is better than a regression.

I will wait until Sunday before pushing, to allow for reviews
and objections.

Regards,
  Stefano

---
 ChangeLog         |   14 ++++++++++++++
 automake.in       |    9 ---------
 tests/Makefile.am |    2 +-
 tests/Makefile.in |    2 +-
 4 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index a022b09..64284f8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2011-10-20  Stefano Lattarini  <stefano.lattarini <at> gmail.com>
+
+	deps: partially revert commit `v1.11-512-geeee551'
+	This change partly reverts commit "Create subdirs for generated
+	sources even when not dep tracking", of 2011-04-02.
+	That commit had caused the bugs #8485 and #8526.  Since we are
+	nearing the bug-fixing automake release 1.11.2, the safest policy
+	at the moment is to just revert the problematic hunks: an older,
+	known bug is better than a regression.
+	* automake.in (handle_single_transform): Don't add a dirstamp
+	dependency, even when $object is derived and lands in a subdir.
+	* tests/Makefile.am (XFAIL_TESTS): Add lex-subobj-nodep.test,
+	remove yacc-dist-nobuild-subdir.test.
+
 2011-10-18  Stefano Lattarini  <stefano.lattarini <at> gmail.com>
 
 	tests: fix spurious failure with FreeBSD make and Yacc in VPATH
diff --git a/automake.in b/automake.in
index 516e594..db7f3c6 100755
--- a/automake.in
+++ b/automake.in
@@ -2053,15 +2053,6 @@ sub handle_single_transform ($$$$$%)
 	    # derived from is not.
 	    &push_dist_common ($object)
 	      unless ($topparent =~ /^(?:nobase_)?nodist_/);
-
-	    # If resulting derived source is in a subdir, we need to make
-	    # sure the subdir exists at build time.
-	    if ($object =~ /\//)
-	      {
-		my $dirstamp = require_build_directory_maybe ($object);
-		depend ($object, $dirstamp)
-		  if ($dirstamp);
-	      }
 	    next;
 	  }
 
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 36ac88e..45e50f8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -25,7 +25,7 @@ dist-auxfile-2.test \
 gcj6.test \
 java-nobase.test \
 pr8365-remake-timing.test \
-yacc-dist-nobuild-subdir.test \
+lex-subobj-nodep.test \
 vala-vpath.test \
 txinfo5.test
 
diff --git a/tests/Makefile.in b/tests/Makefile.in
index 8bdd107..be98a4e 100644
--- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -296,7 +296,7 @@ dist-auxfile-2.test \
 gcj6.test \
 java-nobase.test \
 pr8365-remake-timing.test \
-yacc-dist-nobuild-subdir.test \
+lex-subobj-nodep.test \
 vala-vpath.test \
 txinfo5.test
 
-- 
1.7.2.3

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-automake <at> gnu.org
Cc: 8526 <at> debbugs.gnu.org, automake-patches <at> gnu.org, 8485 <at> debbugs.gnu.org
Subject: Re: bug#8526: [PATCH] {maint} deps: partially revert commit
	`v1.11-512-geeee551'
Date: Mon, 24 Oct 2011 19:51:23 +0200

[Message part 1 (text/plain, inline)]

tags 8485 patch
tags 8526 patch
close 8485
close 8526
thanks

On Thursday 20 October 2011, Stefano Lattarini wrote:
> This change partly reverts commit "Create subdirs for generated
> sources even when not dep tracking", of 2011-04-02.
> 
> That commit had caused the bugs #8485 and #8526.  Since we are
> nearing the bug-fixing automake release 1.11.2, the safest policy
> at the moment is to just revert the problematic hunks: an older,
> known bug is better than a regression.
> 
> I will wait until Sunday before pushing, to allow for reviews
> and objections.
> 
Pushed now.  I'm thus closing the relevant bug reports.

OTOH, I've opened a new bug report, to keep track of the old
bug my patch has re-introduced.  See automake bug#9859.

Regards,
  Stefano

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.