From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 20 03:36:48 2011 Received: (at submit) by debbugs.gnu.org; 20 Apr 2011 07:36:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QCRxv-0001z7-V6 for submit@debbugs.gnu.org; Wed, 20 Apr 2011 03:36:48 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QCRC4-0000tW-4E for submit@debbugs.gnu.org; Wed, 20 Apr 2011 02:47:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCRBy-0004wH-8m for submit@debbugs.gnu.org; Wed, 20 Apr 2011 02:47:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, T_TVD_MIME_NO_HEADERS autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:35681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCRBy-0004wD-70 for submit@debbugs.gnu.org; Wed, 20 Apr 2011 02:47:14 -0400 Received: from eggs.gnu.org ([140.186.70.92]:59994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCRBx-0008AK-6u for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2011 02:47:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCRBw-0004vo-10 for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2011 02:47:13 -0400 Received: from ip51.strelice.net ([217.66.176.51]:1114 helo=zamazal.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCRBv-0004vk-Rl for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2011 02:47:11 -0400 Received: from blackbird.nest.zamazal.org ([192.168.129.12]) by zamazal.org with esmtp (Exim 4.72) (envelope-from ) id 1QCRBu-0001LK-SN for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2011 08:47:10 +0200 Received: from pdm by blackbird.nest.zamazal.org with local (Exim 4.72) (envelope-from ) id 1QCRBi-0000eE-Ve for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2011 08:46:58 +0200 From: Milan Zamazal To: bug-gnu-emacs@gnu.org Subject: New glasses.el customization option glasses-separate-capital-groups-p Date: Wed, 20 Apr 2011 08:46:58 +0200 Message-ID: <871v0xju71.fsf@blackbird.nest.zamazal.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 20 Apr 2011 03:36:47 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) --=-=-= This adds a new customization option for a feature requested by a glasses.el user. 2011-04-20 Milan Zamazal * progmodes/glasses.el (glasses-separate-capital-groups-p): New customization option. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=glasses.el.patch --- glasses.el.orig 2011-01-08 18:45:14.000000000 +0100 +++ glasses.el 2011-04-18 21:45:03.482155846 +0200 @@ -117,6 +117,15 @@ :group 'glasses :type '(repeat regexp)) +(defcustom glasses-separate-capital-groups-p t + "If non-nil, try to separate groups of capital letters. +When the value is non-nil, HTMLSomething and IPv6 are displayed +as HTML_Something and I_Pv6 respectively. Set the value to nil +if you prefer to display them unchanged." + :group 'glasses + :type 'boolean + :version "23.4") + (defcustom glasses-uncapitalize-p nil "If non-nil, downcase embedded capital letters in identifiers. Only identifiers starting with lower case letters are affected, letters inside @@ -213,8 +222,11 @@ 'glasses-init)) ;; Face + separator (goto-char beg) - (while (re-search-forward "[a-z]\\([A-Z]\\)\\|[A-Z]\\([A-Z]\\)[a-z]" - end t) + (while (re-search-forward + (if glasses-separate-capital-groups-p + "[a-z]\\([A-Z]\\)\\|[A-Z]\\([A-Z]\\)[a-z]" + "[a-z]\\([A-Z]\\)") + end t) (let* ((n (if (match-string 1) 1 2)) (o (glasses-make-overlay (match-beginning n) (match-end n)))) (goto-char (match-beginning n)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 22:07:50 2011 Received: (at 8524) by debbugs.gnu.org; 4 May 2011 02:07:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QHRVF-0003dW-Tb for submit@debbugs.gnu.org; Tue, 03 May 2011 22:07:50 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QHRVE-0003d3-1D for 8524@debbugs.gnu.org; Tue, 03 May 2011 22:07:48 -0400 Received: from localhost ([127.0.0.1]:47962) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHRV8-0003e7-Dz; Tue, 03 May 2011 22:07:42 -0400 From: Glenn Morris To: Milan Zamazal Subject: Re: bug#8524: New glasses.el customization option glasses-separate-capital-groups-p References: <871v0xju71.fsf@blackbird.nest.zamazal.org> X-Spook: anarchy InfoSec UMTS SP4 Saudi Arabia RSA Blowfish CNCIS X-Ran: s+Y0A)-VC-!~4?VQ6uTs User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 8524 Cc: 8524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Milan Zamazal wrote: > +(defcustom glasses-separate-capital-groups-p t I was going to say: boolean options should not have names ending in `-p' (I see the existing glasses ones do, but no reason to continue doing it). `-p' is the recommended suffix for a predicate *function*. `-flag' was recommended for boolean options, but this recommendation has gone away (eg because you might want to extend a boolean option to a 3-state one in future). So an appropriate name for this option might be just `glasses-separate-capital-groups'. But then I noticed that several other files have options ending in `-p', so maybe I'm wrong about this... From debbugs-submit-bounces@debbugs.gnu.org Wed May 04 08:40:44 2011 Received: (at 8524) by debbugs.gnu.org; 4 May 2011 12:40:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QHbNj-0002O6-Pr for submit@debbugs.gnu.org; Wed, 04 May 2011 08:40:44 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QHbNg-0002Nu-UW for 8524@debbugs.gnu.org; Wed, 04 May 2011 08:40:41 -0400 Received: from 121-249-126-200.fibertel.com.ar ([200.126.249.121]:8593 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QHbNa-0004cp-F4; Wed, 04 May 2011 08:40:34 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 48FD8662FC; Wed, 4 May 2011 09:40:30 -0300 (ART) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#8524: New glasses.el customization option glasses-separate-capital-groups-p Message-ID: References: <871v0xju71.fsf@blackbird.nest.zamazal.org> Date: Wed, 04 May 2011 09:40:30 -0300 In-Reply-To: (Glenn Morris's message of "Tue, 03 May 2011 22:07:42 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8524 Cc: Milan Zamazal , 8524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >> +(defcustom glasses-separate-capital-groups-p t > I was going to say: boolean options should not have names ending in `-p' > (I see the existing glasses ones do, but no reason to continue doing > it). `-p' is the recommended suffix for a predicate *function*. `-flag' > was recommended for boolean options, but this recommendation has gone > away (eg because you might want to extend a boolean option to a 3-state > one in future). So an appropriate name for this option might be just > `glasses-separate-capital-groups'. > But then I noticed that several other files have options ending in `-p', > so maybe I'm wrong about this... No, you're absolutely right. These other files are wrong. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 04 09:33:19 2011 Received: (at 8524) by debbugs.gnu.org; 4 May 2011 13:33:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QHcCc-0003eF-Ni for submit@debbugs.gnu.org; Wed, 04 May 2011 09:33:19 -0400 Received: from ip51.strelice.net ([217.66.176.51] helo=zamazal.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QHcCY-0003e1-RM for 8524@debbugs.gnu.org; Wed, 04 May 2011 09:33:16 -0400 Received: from blackbird.nest.zamazal.org ([192.168.129.12]) by zamazal.org with esmtp (Exim 4.72) (envelope-from ) id 1QHcCS-0004C7-Hf; Wed, 04 May 2011 15:33:08 +0200 Received: from pdm by blackbird.nest.zamazal.org with local (Exim 4.72) (envelope-from ) id 1QHcC9-0005a1-LJ; Wed, 04 May 2011 15:32:49 +0200 From: Milan Zamazal To: Glenn Morris Subject: Re: bug#8524: New glasses.el customization option glasses-separate-capital-groups-p References: <871v0xju71.fsf@blackbird.nest.zamazal.org> Date: Wed, 04 May 2011 15:32:49 +0200 In-Reply-To: (sfid-) (Glenn Morris's message of "Tue, 03 May 2011 22:07:42 -0400") Message-ID: <87tydah9q6.fsf@blackbird.nest.zamazal.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 8524 Cc: 8524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) --=-=-= >>>>> "GM" == Glenn Morris writes: GM> boolean options should not have names ending in `-p' Here is a corrected patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=glasses.el.patch --- glasses.el.orig 2011-01-08 18:45:14.000000000 +0100 +++ glasses.el 2011-04-18 21:45:03.482155846 +0200 @@ -117,6 +117,15 @@ :group 'glasses :type '(repeat regexp)) +(defcustom glasses-separate-capital-groups t + "If non-nil, try to separate groups of capital letters. +When the value is non-nil, HTMLSomething and IPv6 are displayed +as HTML_Something and I_Pv6 respectively. Set the value to nil +if you prefer to display them unchanged." + :group 'glasses + :type 'boolean + :version "23.4") + (defcustom glasses-uncapitalize-p nil "If non-nil, downcase embedded capital letters in identifiers. Only identifiers starting with lower case letters are affected, letters inside @@ -213,8 +222,11 @@ 'glasses-init)) ;; Face + separator (goto-char beg) - (while (re-search-forward "[a-z]\\([A-Z]\\)\\|[A-Z]\\([A-Z]\\)[a-z]" - end t) + (while (re-search-forward + (if glasses-separate-capital-groups + "[a-z]\\([A-Z]\\)\\|[A-Z]\\([A-Z]\\)[a-z]" + "[a-z]\\([A-Z]\\)") + end t) (let* ((n (if (match-string 1) 1 2)) (o (glasses-make-overlay (match-beginning n) (match-end n)))) (goto-char (match-beginning n)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 04 23:27:14 2011 Received: (at 8524-done) by debbugs.gnu.org; 5 May 2011 03:27:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QHpDe-0001tn-FI for submit@debbugs.gnu.org; Wed, 04 May 2011 23:27:14 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QHpDc-0001tc-On for 8524-done@debbugs.gnu.org; Wed, 04 May 2011 23:27:13 -0400 Received: from localhost ([127.0.0.1]:37482) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHpDX-00016m-IY; Wed, 04 May 2011 23:27:07 -0400 From: Glenn Morris To: 8524-done@debbugs.gnu.org Subject: Re: bug#8524: New glasses.el customization option glasses-separate-capital-groups-p References: <871v0xju71.fsf@blackbird.nest.zamazal.org> <87tydah9q6.fsf@blackbird.nest.zamazal.org> X-Spook: csim global computer terrorism Abbas keyhole X-Ran: |QIH}dQ`bbh5s#<14j}GS'gj'k#,D<:x/+x,^Rwpkn^e)bOpBkMg*RW"!3kay8!($]k\_w X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 04 May 2011 23:27:07 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 8524-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) Version: 24.1 Thanks; applied. From debbugs-submit-bounces@debbugs.gnu.org Thu May 05 13:43:07 2011 Received: (at control) by debbugs.gnu.org; 5 May 2011 17:43:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QI2Zv-0000dG-6X for submit@debbugs.gnu.org; Thu, 05 May 2011 13:43:07 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QI2Zt-0000ck-KP for control@debbugs.gnu.org; Thu, 05 May 2011 13:43:06 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QI2Zn-00040E-W8 for control@debbugs.gnu.org; Thu, 05 May 2011 13:43:00 -0400 Date: Thu, 05 May 2011 13:42:59 -0400 Message-Id: Subject: control message for bug 8524 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) found 8524 23.3 From unknown Fri Jun 20 07:18:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Jun 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator