From unknown Fri Jun 20 07:11:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8523 <8523@debbugs.gnu.org> To: bug#8523 <8523@debbugs.gnu.org> Subject: Status: 24.0.50; `dired-mark-if': wrong message if unmarking or unflagging Reply-To: bug#8523 <8523@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:36 +0000 retitle 8523 24.0.50; `dired-mark-if': wrong message if unmarking or unflag= ging reassign 8523 emacs submitter 8523 "Drew Adams" severity 8523 minor tag 8523 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 19 15:46:48 2011 Received: (at submit) by debbugs.gnu.org; 19 Apr 2011 19:46:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QCGsq-0003AP-9x for submit@debbugs.gnu.org; Tue, 19 Apr 2011 15:46:48 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QCGso-0003AE-BI for submit@debbugs.gnu.org; Tue, 19 Apr 2011 15:46:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCGsh-00036q-1v for submit@debbugs.gnu.org; Tue, 19 Apr 2011 15:46:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:59435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCGsg-00036g-W8 for submit@debbugs.gnu.org; Tue, 19 Apr 2011 15:46:39 -0400 Received: from eggs.gnu.org ([140.186.70.92]:46434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCGsg-0006dY-3o for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2011 15:46:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCGsf-00036I-4w for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2011 15:46:38 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:41521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCGse-00035v-W4 for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2011 15:46:37 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p3JJkVrc023696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Apr 2011 19:46:33 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p3JJkUcG027798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 19 Apr 2011 19:46:31 GMT Received: from abhmt021.oracle.com (abhmt021.oracle.com [141.146.116.30]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p3JJkPLW030449 for ; Tue, 19 Apr 2011 14:46:25 -0500 Received: from dradamslap1 (/10.159.44.151) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 19 Apr 2011 12:46:25 -0700 From: "Drew Adams" To: Subject: 24.0.50; `dired-mark-if': wrong message if unmarking or unflagging Date: Tue, 19 Apr 2011 12:46:26 -0700 Message-ID: <21D6E4BD07BC4102A952CF14DB19B461@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acv+yng+DutpFbmQRxyrCAn8QOG5jQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6090 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) `dired-mark-if' is used for marking, flagging (for deletion), and unflagging. The particular behavior depends on the value of `dired-marker-char'. The final message reflects this variation correctly, by testing `dired-marker-char'. But the initial message does not. It always says "Marking ...". That's strictly true, since marking with a space char amounts to unmarking. Still, the message could be more user-friendly. Here's a fix. Change the code: (if ,msg "Marking %ss..." ,msg) to this: (when ,msg (message "%s %ss%s..." ,(cond ((eq ?\040 dired-marker-char) "Unmarking") ((eq dired-del-marker dired-marker-char) "Flagging") (t "Marking")) ,msg ,(if (eq dired-del-marker dired-marker-char) " for deletion" ""))) In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-04-18 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.5) --no-opt --cflags -Ic:/imagesupport/include' From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 09:29:55 2011 Received: (at 8523) by debbugs.gnu.org; 2 Jul 2011 13:29:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qd0Gh-0004Hg-6e for submit@debbugs.gnu.org; Sat, 02 Jul 2011 09:29:55 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qd0Gf-0004HL-0u for 8523@debbugs.gnu.org; Sat, 02 Jul 2011 09:29:54 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qd0GT-0005JZ-7i; Sat, 02 Jul 2011 15:29:41 +0200 From: Lars Magne Ingebrigtsen To: "Drew Adams" Subject: Re: bug#8523: 24.0.50; `dired-mark-if': wrong message if unmarking or unflagging In-Reply-To: <21D6E4BD07BC4102A952CF14DB19B461@us.oracle.com> (Drew Adams's message of "Tue, 19 Apr 2011 12:46:26 -0700") Date: Sat, 02 Jul 2011 15:29:25 +0200 Message-ID: References: <21D6E4BD07BC4102A952CF14DB19B461@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWIYGFdNDm2ranh49uo hYIQBgeffCkgAAACUElEQVQ4jU2SzXbjIAyFhUP2qIn3LtB9Cu6eEHlft8P7v8pc4Z8ZzvEx8HF1 kQT5kCRk76fWR3hEqcOUPHkvwUuaxg38PPxQpyklwv7jSelj22/rI0n1qhhCCkOuyw6aR9iQA0Il c5nL7QQhYwDR9KyzsXn8B9KQc4o01fk55HSCt5BjBKVQjIH2BH8Ix6ZXJs+DBr3qjZhbu6RJcoZH 7m5JgRMDgMX8giJvQ4EVM7ZXX1qhnA6wSjxB9hRi1cl7a99SeM8DgxLujMXc1tWadeR8gHcPnc+p MVlnePNMPpAvNiAnPzqpjviStFSqqEg0ItRivVjh26aAOdmQovX500ZPZbyhaSIT4bqR4CD1YUWI xpdFO1RCqNc0aOEcADPipxQlEqlVkDmkQmI4pipz9EiatjtoP2F9n7M/8tgnyV+kmMtnOBPc/0m+ ZzGJ306wRcIV213suJ6EtCA+isi10bUx8+tQ+FiIALTtbxNI3c0jsUNyol1ckQnzPXRQ2BVRkId5 dOSUgVAko4FEwvyLJYBhdqGDopHk9XnDayIDkcHLoWLJ6H69fIU8G5VA4wLp6KEuHzk/ABDaOK47 gP0Ae+lLILb4WSvqosW5U1EXJh476O5PVObuNqCvAkC6yQKLu0MInD9AT3B55S+9Uges4E6ioZZb Xoj/B872BJefPOIQgNGC6USoK9bcCh1gi9kV1za14nZg+sR1cm1j2zzMum6hDtCaznF+bQp465Ms HbCC/um8F/F5Kpwt2GTUyx6gjNpAVycFa09+V4x6Eq/Y8F9KELP1uqDPowAAAABJRU5ErkJggg== X-Now-Playing: Prince's _Controversy_: "Jack U Off" X-Hashcash: 1:23:110702:drew.adams@oracle.com::0to7HZ+3LyNAojeo:0000000000000000000000000000000000000000K9/h X-Hashcash: 1:23:110702:8523@debbugs.gnu.org::hg4GqVQOtY/mxkw/:00000000000000000000000000000000000000000N+IA MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qd0GT-0005JZ-7i X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310218181.54814@NJn65W0idVGRR7Do33Xi/g X-Spam-Status: No X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 8523 Cc: 8523@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) "Drew Adams" writes: > Here's a fix. Change the code: (if ,msg "Marking %ss..." ,msg) > to this: Thanks; applied to Emacs 24. (With some slight "," fixes.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 09:29:49 2011 Received: (at control) by debbugs.gnu.org; 2 Jul 2011 13:29:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qd0Ga-0004HP-PS for submit@debbugs.gnu.org; Sat, 02 Jul 2011 09:29:49 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qd0GY-0004H9-NS for control@debbugs.gnu.org; Sat, 02 Jul 2011 09:29:47 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qd0GN-0005JR-Ef for control@debbugs.gnu.org; Sat, 02 Jul 2011 15:29:35 +0200 Date: Sat, 02 Jul 2011 15:29:34 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #8523 X-MailScanner-ID: 1Qd0GN-0005JR-Ef X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310218175.53149@bvX9EUoKs3NV/j36qSw7Fw X-Spam-Status: No X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) tags 8523 fixed close 8523 From unknown Fri Jun 20 07:11:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 31 Jul 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator