GNU bug report logs - #8523
24.0.50; `dired-mark-if': wrong message if unmarking or unflagging

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Tue, 19 Apr 2011 19:47:01 UTC

Severity: minor

Tags: fixed

Found in version 24.0.50

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8523 in the body.
You can then email your comments to 8523 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8523; Package emacs. (Tue, 19 Apr 2011 19:47:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to "Drew Adams" <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 19 Apr 2011 19:47:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.50; `dired-mark-if': wrong message if unmarking or unflagging
Date: Tue, 19 Apr 2011 12:46:26 -0700

`dired-mark-if' is used for marking, flagging (for deletion), and
unflagging.  The particular behavior depends on the value of
`dired-marker-char'.
 
The final message reflects this variation correctly, by testing
`dired-marker-char'.  But the initial message does not.  It always says
"Marking <blah blah>...".  That's strictly true, since marking with a
space char amounts to unmarking.  Still, the message could be more
user-friendly.
 
Here's a fix.  Change the code: (if ,msg "Marking %ss..." ,msg)
to this:
 
(when ,msg
  (message "%s %ss%s..."
           ,(cond ((eq ?\040 dired-marker-char) "Unmarking")
                  ((eq dired-del-marker dired-marker-char)
                   "Flagging")
                  (t "Marking"))
           ,msg
           ,(if (eq dired-del-marker dired-marker-char)
                " for deletion"
              "")))
 

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-04-18 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/imagesupport/include'
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8523; Package emacs. (Sat, 02 Jul 2011 13:30:02 GMT) Full text and rfc822 format available.

Message #8 received at 8523 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 8523 <at> debbugs.gnu.org
Subject: Re: bug#8523: 24.0.50;
	`dired-mark-if': wrong message if unmarking or unflagging
Date: Sat, 02 Jul 2011 15:29:25 +0200

"Drew Adams" <drew.adams <at> oracle.com> writes:

> Here's a fix.  Change the code: (if ,msg "Marking %ss..." ,msg)
> to this:

Thanks; applied to Emacs 24.  (With some slight "," fixes.)

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/
Added tag(s) fixed. Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 02 Jul 2011 13:30:03 GMT) Full text and rfc822 format available.
bug closed, send any further explanations to 8523 <at> debbugs.gnu.org and "Drew Adams" <drew.adams <at> oracle.com> Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 02 Jul 2011 13:30:04 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 31 Jul 2011 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 13 years and 327 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.