From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 20:44:18 2011 Received: (at submit) by debbugs.gnu.org; 11 Apr 2011 00:44:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q95En-0006Zu-CM for submit@debbugs.gnu.org; Sun, 10 Apr 2011 20:44:18 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q947v-00052q-SP for submit@debbugs.gnu.org; Sun, 10 Apr 2011 19:33:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q947p-0002BM-LL for submit@debbugs.gnu.org; Sun, 10 Apr 2011 19:33:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:50701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q947p-0002AJ-Id for submit@debbugs.gnu.org; Sun, 10 Apr 2011 19:33:01 -0400 Received: from [140.186.70.92] (port=36217 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q947o-0000d4-LR for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 19:33:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q947n-00028H-FC for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 19:33:00 -0400 Received: from exprod7og115.obsmtp.com ([64.18.2.217]:42957) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Q947n-00028A-6U for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 19:32:59 -0400 Received: from mb2i1.ns.pitt.edu ([136.142.11.153]) by exprod7ob115.postini.com ([64.18.6.12]) with SMTP ID DSNKTaI+J8BB24/g/CEN7eb6izsFCy976Iez@postini.com; Sun, 10 Apr 2011 16:32:59 PDT Received: from unixs1.cis.pitt.edu ([136.142.4.246]) by pitt.edu (PMDF V6.3-x11 #31505) with ESMTP id <0LJG00BC4MQV2X@mb2i1.ns.pitt.edu> for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 19:32:55 -0400 (EDT) Date: Sun, 10 Apr 2011 19:32:55 -0400 (EDT) From: Alp Aker Subject: ns_dumpglyphs_stretch creates display artifacts X-X-Sender: aker@unixs1.cis.pitt.edu To: bug-gnu-emacs@gnu.org Message-id: MIME-version: 1.0 Content-type: TEXT/PLAIN; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 10 Apr 2011 20:44:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) ns_dumpglyphs_stretch (in nsterm.m) checks to make sure that it doesn't overwrite a window's right fringe or scroll bar. It doesn't perform an analogous check for overruns on the left. This can cause display artifacts to appear when a window is horizontally scrolled. Here is a screenshot showing an extreme example of what can happen: http://www.pitt.edu/~aker/screenshot.png The problem has been around since at least 23.2.1 and still exists in the trunk. The following patch (against the latest nsterm.m) appears to fix the problem: *** nsterm.m 2011-04-10 19:21:28.000000000 -0400 --- nsterm-rev.m 2011-04-10 19:23:54.000000000 -0400 *************** *** 2981,2986 **** --- 2981,2995 ---- - (WINDOW_BOX_RIGHT_EDGE_X (s->w) - WINDOW_RIGHT_FRINGE_WIDTH (s->w))); r[i].size.width -= overrun; + + /* truncate to avoid overwriting to left of the window box */ + int leftoverrun = (WINDOW_BOX_LEFT_EDGE_X (s->w) + + WINDOW_LEFT_FRINGE_WIDTH (s->w)) - s->x; + if (0 < leftoverrun) + { + r[i].origin.x += leftoverrun; + r[i].size.width -= leftoverrun; + } /* XXX: Try to work between problem where a stretch glyph on a partially-visible bottom row will clear part of the From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 28 14:41:38 2011 Received: (at 8470) by debbugs.gnu.org; 28 Jul 2011 18:41:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QmVWb-0003hr-DX for submit@debbugs.gnu.org; Thu, 28 Jul 2011 14:41:38 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QmVWW-0003hg-8b for 8470@debbugs.gnu.org; Thu, 28 Jul 2011 14:41:33 -0400 Received: from furball ([128.36.14.95]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p6SIfUYa026615 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 28 Jul 2011 14:41:31 -0400 From: Chong Yidong To: Alp Aker Subject: Re: bug#8470: ns_dumpglyphs_stretch creates display artifacts References: Date: Thu, 28 Jul 2011 14:41:30 -0400 In-Reply-To: (Alp Aker's message of "Sun, 10 Apr 2011 19:32:55 -0400 (EDT)") Message-ID: <87ipqml02t.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 8470 Cc: 8470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Alp Aker writes: > ns_dumpglyphs_stretch (in nsterm.m) checks to make sure that it > doesn't overwrite a window's right fringe or scroll bar. It doesn't > perform an analogous check for overruns on the left. This can cause > display artifacts to appear when a window is horizontally scrolled. > Here is a screenshot showing an extreme example of what can happen: > > http://www.pitt.edu/~aker/screenshot.png > > The problem has been around since at least 23.2.1 and still exists in > the trunk. > > The following patch (against the latest nsterm.m) appears to fix the > problem: Thanks, applied to trunk. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 28 14:41:54 2011 Received: (at control) by debbugs.gnu.org; 28 Jul 2011 18:41:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QmVWr-0003iH-BW for submit@debbugs.gnu.org; Thu, 28 Jul 2011 14:41:53 -0400 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QmVWp-0003iB-GR for control@debbugs.gnu.org; Thu, 28 Jul 2011 14:41:52 -0400 Received: from furball ([128.36.14.95]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id p6SIfoj7010325 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Thu, 28 Jul 2011 14:41:50 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 8470 Date: Thu, 28 Jul 2011 14:41:50 -0400 Message-ID: <87zkjys0wh.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 8470 thanks From unknown Wed Jun 25 05:43:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 26 Aug 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator