From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 04:15:34 2011 Received: (at submit) by debbugs.gnu.org; 10 Apr 2011 08:15:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8pny-0004l9-0n for submit@debbugs.gnu.org; Sun, 10 Apr 2011 04:15:34 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8pnv-0004kx-N4 for submit@debbugs.gnu.org; Sun, 10 Apr 2011 04:15:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8pnp-0006Dx-Ck for submit@debbugs.gnu.org; Sun, 10 Apr 2011 04:15:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL, T_TVD_MIME_NO_HEADERS autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:47572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8pnp-0006De-1p for submit@debbugs.gnu.org; Sun, 10 Apr 2011 04:15:25 -0400 Received: from [140.186.70.92] (port=34918 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8pnn-0005hv-As for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 04:15:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8pnk-0006BL-Br for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 04:15:21 -0400 Received: from mail-iw0-f169.google.com ([209.85.214.169]:46122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8pnk-0006AM-1E for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 04:15:20 -0400 Received: by iwg8 with SMTP id 8so6321578iwg.0 for ; Sun, 10 Apr 2011 01:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:x-debbugs-cc:date:message-id :mime-version:content-type; bh=4ptzm3BhUkiey8EMmVXDA4ID1v88weiW/vp1SKUEZXI=; b=OZGeK5CHrBczBg59QGlsxHJ3fjBziTrxe1n1GqPR5hxkkykUriEk4tD0kb/gKmGugA cLZ6RdLOzo+Q44pP9T/TJfaxIEqtxt2k96WYFeCM8+qvgGVgDj9FaLXOSSdfE6RFfRqG i9dlkgB/w0TXoGfwpl891c8MrNUZnIOtyMJ+k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; b=trD8PQklaMBVNm8rs1RtptJC28YywQZYB9jRzhu48Dyzqph3oJL1J8WXYDiTU0+o/4 kBQYdQQ3l4TTPbaSNc5MOXfKWyyUzpTDNlITnorzw/Dg0jailV/BBpU2eHjoWe3qz5di WHmYGlaTSQhIx83Br+jux5RBiimAdLVX3FDjk= Received: by 10.231.181.137 with SMTP id by9mr4107955ibb.60.1302423318396; Sun, 10 Apr 2011 01:15:18 -0700 (PDT) Received: from th041153.ip.tsinghua.edu.cn ([114.249.204.95]) by mx.google.com with ESMTPS id o3sm3277569ibd.10.2011.04.10.01.15.06 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 10 Apr 2011 01:15:17 -0700 (PDT) From: Leo To: bug-gnu-emacs@gnu.org Subject: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer X-Debbugs-CC: Daniel Colascione Date: Sun, 10 Apr 2011 16:14:53 +0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) --=-=-= I have extended the occur feature in Emacs to allow direct editing in the *Occur* buffer by propagating the changes to the original buffers. With the attached preliminary patch, one can press `C-x C-q' or `C-c C-c' to enter occur-edit-mode and start editing. Pressing `C-x C-q' or `C-c C-c' again finishes the edit. Comments are highly welcomed. Thanks in advance. Leo --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=occur.diff === modified file 'lisp/replace.el' --- lisp/replace.el 2011-04-08 03:05:58 +0000 +++ lisp/replace.el 2011-04-10 08:02:15 +0000 @@ -761,7 +761,8 @@ (let ((map (make-sparse-keymap))) ;; We use this alternative name, so we can use \\[occur-mode-mouse-goto]. (define-key map [mouse-2] 'occur-mode-mouse-goto) - (define-key map "\C-c\C-c" 'occur-mode-goto-occurrence) + (define-key map "\C-c\C-c" 'occur-edit-mode) + (define-key map "\C-x\C-q" 'occur-edit-mode) (define-key map "\C-m" 'occur-mode-goto-occurrence) (define-key map "o" 'occur-mode-goto-occurrence-other-window) (define-key map "\C-o" 'occur-mode-display-occurrence) @@ -815,6 +816,18 @@ map) "Keymap for `occur-mode'.") +(defvar occur-edit-mode-map + (let ((map (make-sparse-keymap))) + (define-key map [mouse-2] 'occur-mode-mouse-goto) + (define-key map "\C-c\C-c" 'occur-edit-mode-finish) + (define-key map "\C-x\C-q" 'occur-edit-mode-finish) + (define-key map "\C-m" 'occur-mode-goto-occurrence) + (define-key map "\C-o" 'occur-mode-display-occurrence) + (define-key map "\M-n" 'occur-next) + (define-key map "\M-p" 'occur-prev) + (define-key map "\C-c\C-f" 'next-error-follow-minor-mode) + map)) + (defvar occur-revert-arguments nil "Arguments to pass to `occur-1' to revert an Occur mode buffer. See `occur-revert-function'.") @@ -849,6 +862,59 @@ (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) (setq next-error-function 'occur-next-error)) +(defun occur-edit-mode () + (interactive) + (setq buffer-read-only nil) + (use-local-map occur-edit-mode-map) + (setq major-mode 'occur-edit-mode + mode-name "Occur-Edit") + (add-hook 'after-change-functions 'occur-after-change-function nil t) + (force-mode-line-update)) + +(defvar occur-edit-modified-buffers nil) +(make-variable-buffer-local 'occur-edit-modified-buffers) + +(defun occur-edit-mode-finish () + (interactive) + (mapc (lambda (buf) + (and (buffer-file-name buf) + (with-current-buffer buf + (save-buffer)))) + occur-edit-modified-buffers) + (setq buffer-read-only t) + (kill-local-variable 'occur-edit-modified-buffers) + (remove-hook 'after-change-functions 'occur-after-change-function t) + (set-buffer-modified-p nil) + (use-local-map occur-mode-map) + (setq major-mode 'occur-mode + mode-name "Occur")) + +(defun occur-after-change-function (beg end length) + (let* ((m (get-text-property (point) 'occur-target)) + (buf (marker-buffer m)) + (col (current-column))) + (when (and (markerp m) (buffer-live-p buf)) + (let ((line (- (line-number-at-pos) + (line-number-at-pos (window-start)))) + (readonly (with-current-buffer buf buffer-read-only)) + (win (or (get-buffer-window buf) + (display-buffer buf t))) + (text (save-excursion + (forward-line 0) + (search-forward ":" nil t) + (setq col (- col (current-column))) + (buffer-substring-no-properties (point) (line-end-position))))) + (and (not readonly) + (add-to-list 'occur-edit-modified-buffers buf)) + (with-selected-window win + (goto-char m) + (recenter line) + (if readonly + (message "Buffer `%s' is read only." buf) + (delete-region (line-beginning-position) (line-end-position)) + (insert text)) + (move-to-column col)))))) + (defun occur-revert-function (ignore1 ignore2) "Handle `revert-buffer' for Occur mode buffers." (apply 'occur-1 (append occur-revert-arguments (list (buffer-name))))) @@ -1273,6 +1339,7 @@ `(font-lock-face prefix-face)) `(occur-prefix t mouse-face (highlight) occur-target ,marker follow-link t + read-only t help-echo "mouse-2: go to this occurrence")))) (match-str ;; We don't put `mouse-face' on the newline, @@ -1333,13 +1400,15 @@ (goto-char headerpt) (let ((beg (point)) end) - (insert (format "%d match%s%s in buffer: %s\n" - matches (if (= matches 1) "" "es") - ;; Don't display regexp for multi-buffer. - (if (> (length buffers) 1) - "" (format " for \"%s\"" - (query-replace-descr regexp))) - (buffer-name buf))) + (insert (propertize + (format "%d match%s%s in buffer: %s\n" + matches (if (= matches 1) "" "es") + ;; Don't display regexp for multi-buffer. + (if (> (length buffers) 1) + "" (format " for \"%s\"" + (query-replace-descr regexp))) + (buffer-name buf)) + 'read-only t)) (setq end (point)) (add-text-properties beg end (append --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 22:06:56 2011 Received: (at 8463) by debbugs.gnu.org; 15 Apr 2011 02:06:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QAYQx-0001EH-Sj for submit@debbugs.gnu.org; Thu, 14 Apr 2011 22:06:56 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QAYQw-0001E4-94 for 8463@debbugs.gnu.org; Thu, 14 Apr 2011 22:06:54 -0400 Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:45880 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QAYQq-0003zT-9Z; Thu, 14 Apr 2011 22:06:48 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 1F2FF66396; Thu, 14 Apr 2011 23:06:44 -0300 (ART) From: Stefan Monnier To: Leo Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer In-Reply-To: (Leo's message of "Sun, 10 Apr 2011 16:14:53 +0800") Date: Thu, 14 Apr 2011 22:11:06 -0300 Message-ID: References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) > @@ -761,7 +761,8 @@ > (let ((map (make-sparse-keymap))) > ;; We use this alternative name, so we can use \\[occur-mode-mouse-goto]. > (define-key map [mouse-2] 'occur-mode-mouse-goto) > - (define-key map "\C-c\C-c" 'occur-mode-goto-occurrence) > + (define-key map "\C-c\C-c" 'occur-edit-mode) > + (define-key map "\C-x\C-q" 'occur-edit-mode) > (define-key map "\C-m" 'occur-mode-goto-occurrence) > (define-key map "o" 'occur-mode-goto-occurrence-other-window) > (define-key map "\C-o" 'occur-mode-display-occurrence) I haven't had a chance to look much at the code, but while the functionality generally sounds good, the C-c C-c binding above doesn't look right to me. I think C-x C-q is sufficient and there's no need to introduce such an incompatibility (not with code but with users). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 28 19:05:10 2011 Received: (at 8463) by debbugs.gnu.org; 28 May 2011 23:05:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQSZC-0001jQ-52 for submit@debbugs.gnu.org; Sat, 28 May 2011 19:05:10 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQSZA-0001jF-3v for 8463@debbugs.gnu.org; Sat, 28 May 2011 19:05:08 -0400 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p4SN52oA030906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 28 May 2011 19:05:02 -0400 Received: by furball (Postfix, from userid 1000) id 3694E16031F; Sat, 28 May 2011 19:05:01 -0400 (EDT) From: Chong Yidong To: Leo Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: Date: Sat, 28 May 2011 19:05:01 -0400 In-Reply-To: (Leo's message of "Sun, 10 Apr 2011 16:14:53 +0800") Message-ID: <87pqn2xw82.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Leo writes: > I have extended the occur feature in Emacs to allow direct editing in > the *Occur* buffer by propagating the changes to the original buffers. > > With the attached preliminary patch, one can press `C-x C-q' or `C-c > C-c' to enter occur-edit-mode and start editing. Pressing `C-x C-q' or > `C-c C-c' again finishes the edit. > > Comments are highly welcomed. Thanks in advance. Looks good. I've made a couple of tweaks, and have committed it to trunk. The C-c c-c binding was removed in favor of just C-x C-q, as Stefan suggested. For now, I also left out the part where C-x C-q in Occur Edit mode saves the associated buffers, because this doesn't seem to be properly thought out; what if the buffers have no associated files? Also, I added a small fix to occur-after-change-function to avoid screwing up the Occur Edit buffer when multi-line text is inserted. Since we can't create new Occur entries, this just ignores everything after the inserted newline. If you want to try and handle this properly (i.e. by inserting a new Occur entry for each inserted line), go ahead. From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 00:04:57 2011 Received: (at 8463) by debbugs.gnu.org; 29 May 2011 04:04:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQXFI-0002IO-EV for submit@debbugs.gnu.org; Sun, 29 May 2011 00:04:56 -0400 Received: from mail-pw0-f44.google.com ([209.85.160.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQXFF-0002ID-UO for 8463@debbugs.gnu.org; Sun, 29 May 2011 00:04:54 -0400 Received: by pwi5 with SMTP id 5so1281568pwi.3 for <8463@debbugs.gnu.org>; Sat, 28 May 2011 21:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=m2hjAnl04QKtC7dz8iQsJ3yHXJRmQbgvr+/mY2zdA4I=; b=oLxRBpVVHiPUWtB/JcuV1/WDGGfBPxLYvddzBs33yClDYnhfsVoLQ/cseo5Dt7gdCe Fp2w0J3rqsisBypu1s8C0ql8vidojv+ZsPKNKFwm596LJDCqXzGd/KAWRx8taei/VH57 ZGkRsVQeckRxKvLYuIM9xFgxdJpMI3PodNMHo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=U/9ysx1NUpsQs4Z2ikt06UnNhFlfzoc0O5ihRDjc8hpu6jd5xDir6yNujp3HVpDVE/ tNkW4NNdSl7fIc7jJCOapo2TlRHJrLOiGu4uAq9O3Q6Bo7rDgem1EZX4YbuovJ5Bo7XE mN/izRMP2gYuZTv39X8T8+bAIN31jny/w98x8= Received: by 10.68.0.7 with SMTP id 7mr1635885pba.188.1306641888033; Sat, 28 May 2011 21:04:48 -0700 (PDT) Received: from localhost ([123.114.55.92]) by mx.google.com with ESMTPS id i7sm1780529pbj.90.2011.05.28.21.04.43 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 28 May 2011 21:04:46 -0700 (PDT) From: Leo To: Chong Yidong Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: <87pqn2xw82.fsf@stupidchicken.com> Date: Sun, 29 May 2011 12:04:36 +0800 In-Reply-To: <87pqn2xw82.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 28 May 2011 19:05:01 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, Daniel Colascione , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.4 (----) On 2011-05-29 07:05 +0800, Chong Yidong wrote: [snipped 11 lines] > Looks good. I've made a couple of tweaks, and have committed it to > trunk. The C-c c-c binding was removed in favor of just C-x C-q, as > Stefan suggested. For now, I also left out the part where C-x C-q in > Occur Edit mode saves the associated buffers, because this doesn't seem > to be properly thought out; what if the buffers have no associated > files? > > Also, I added a small fix to occur-after-change-function to avoid > screwing up the Occur Edit buffer when multi-line text is inserted. > Since we can't create new Occur entries, this just ignores everything > after the inserted newline. If you want to try and handle this properly > (i.e. by inserting a new Occur entry for each inserted line), go ahead. Yidong, many thanks for the tweaks and fixes. Let's keep this bug open for a bit longer. I am thinking of generalising occur-edit-mode (probably rename it to match-line-edit) so that it covers buffers from grep and the like. Leo From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 10:04:41 2011 Received: (at 8463) by debbugs.gnu.org; 30 May 2011 14:04:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QR35F-00016U-GI for submit@debbugs.gnu.org; Mon, 30 May 2011 10:04:41 -0400 Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QR35D-00016I-62 for 8463@debbugs.gnu.org; Mon, 30 May 2011 10:04:39 -0400 Received: by iyn15 with SMTP id 15so3507511iyn.3 for <8463@debbugs.gnu.org>; Mon, 30 May 2011 07:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=WE7h4Ad00W73gc+IAGwCP2Rm+/e+2fDeEi8irtZBen4=; b=RH0Xt9fbT2zHWXa2r7W3I+l3iRGhamGNuumok/rGf/iYxVMjZSFKUkHxrrlJj3/6WY i7UNRUJnD9zOR+UMLO9Z13MLaxYgOo0OGiqlWF8TkjspdJ2EiBfQjzekxDOexI8jI0Ek XGUHrLwkQVj+9KhZ9XwJJph2bImI+0JIFmNWs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=SM2fvvNVxRKhKwGrhYDl93zPl5b9e6U7jizuMHFxmnaQ1hzku1371k4Kpy9K+pFfLR 2b9t/ziukDd0r+PcjTCAswF6/34WTfU/wIrE1O8D0yerKLJKLsXSFOV9Vt+4XGKrtPjP fq0fE4XkZ1gXaowH7HMynp7jP3tHhTAWugnpY= MIME-Version: 1.0 Received: by 10.42.158.67 with SMTP id g3mr7411324icx.94.1306764273128; Mon, 30 May 2011 07:04:33 -0700 (PDT) Received: by 10.42.173.1 with HTTP; Mon, 30 May 2011 07:04:33 -0700 (PDT) In-Reply-To: References: Date: Mon, 30 May 2011 17:04:33 +0300 Message-ID: Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer From: "Andrew W. Nosenko" To: Leo Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) On Sun, Apr 10, 2011 at 11:14, Leo wrote: > I have extended the occur feature in Emacs to allow direct editing in > the *Occur* buffer by propagating the changes to the original buffers. > > With the attached preliminary patch, one can press `C-x C-q' or `C-c > C-c' to enter occur-edit-mode and start editing. Pressing `C-x C-q' or > `C-c C-c' again finishes the edit. > > Comments are highly welcomed. Thanks in advance. Is there a way to _disable_ this feature? I'm quite often edit the *Occur* and *grep* buffers for line-up results, etc, just for easier understanding results, but I don't want these edits to be mirrored into original lines or files from where they are come. -- Andrew W. Nosenko From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 19:10:58 2011 Received: (at 8463) by debbugs.gnu.org; 30 May 2011 23:10:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QRBbu-0004SF-LD for submit@debbugs.gnu.org; Mon, 30 May 2011 19:10:58 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QRBbs-0004S3-TZ for 8463@debbugs.gnu.org; Mon, 30 May 2011 19:10:57 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QRBbn-0000qI-Dm; Mon, 30 May 2011 19:10:51 -0400 Date: Mon, 30 May 2011 19:10:51 -0400 Message-Id: Content-Type: text/plain; charset=ISO-8859-15 From: Richard Stallman To: "Andrew W. Nosenko" In-reply-to: (andrew.w.nosenko@gmail.com) Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, dan.colascione@gmail.com, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: rms@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > I have extended the occur feature in Emacs to allow direct editing in > the *Occur* buffer by propagating the changes to the original buffers. I am not surprised you want to disable it. Maybe it should be disabled by default. -- Dr Richard Stallman President, Free Software Foundation 51 Franklin St Boston MA 02110 USA www.fsf.org, www.gnu.org Skype: No way! That's nonfree (freedom-denying) software. Use free telephony http://directory.fsf.org/category/tel/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 01 19:03:45 2011 Received: (at 8463) by debbugs.gnu.org; 1 Jun 2011 23:03:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QRuS0-0001Fh-Kt for submit@debbugs.gnu.org; Wed, 01 Jun 2011 19:03:45 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QRuRy-0001FN-Lq for 8463@debbugs.gnu.org; Wed, 01 Jun 2011 19:03:43 -0400 Received: from localhost ([127.0.0.1]:34195) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRuRt-0006oW-Bs; Wed, 01 Jun 2011 19:03:37 -0400 From: Glenn Morris To: "Andrew W. Nosenko" Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: X-Spook: Osama eavesdropping PET assassination 9/11 csim Yukon X-Ran: KK`}s8[9H3~.Q"'KF(hu$|~py]YctM(MoUZ7Z=I!3=Iwf:?<=h=U4Q"!0"?u?svm",W6TH X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 01 Jun 2011 19:03:36 -0400 In-Reply-To: (Andrew W. Nosenko's message of "Mon, 30 May 2011 17:04:33 +0300") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, Daniel Colascione , Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) "Andrew W. Nosenko" wrote: > Is there a way to _disable_ this feature? I'm quite often edit the > *Occur* and *grep* buffers for line-up results, etc, just for easier > understanding results, but I don't want these edits to be mirrored > into original lines or files from where they are come. Me too. I expect C-x C-q to toggle the read-only state of a buffer, not switch me into some unusual mode. I suggest binding this new mode to some other key. Other issues with this: 1. After C-x C-q, I can no longer kill entire lines in the occur buffer. Trying to do so reports "Text is read-only". 2. After C-x C-q, If I delete some text in the occur buffer, then use "undo", when I reach the point at which there is no more to undo, I get: "Wrong type argument: markerp, nil" rather than "No further undo information". Debugger entered--Lisp error: (wrong-type-argument markerp nil) marker-buffer(nil) occur-after-change-function(1 40 39) primitive-undo(1 ((nil font-lock-face underline 1 . 40) (t 0 . 0))) undo-more(1) undo(nil) call-interactively(undo nil nil) 3. After C-x C-q, M-x revert-buffer in the occur buffer triggers an error: apply: Wrong number of arguments: #[(regexp nlines bufs &optional buf-name) occur-1("*Occur*") apply(occur-1 "*Occur*") occur-revert-function(t nil) revert-buffer(t) call-interactively(revert-buffer t nil) execute-extended-command(nil) call-interactively(execute-extended-command nil nil) I guess the mode change clobbers occur-revert-arguments. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 22:36:16 2011 Received: (at 8463) by debbugs.gnu.org; 3 Jun 2011 02:36:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSKFE-0001j5-7B for submit@debbugs.gnu.org; Thu, 02 Jun 2011 22:36:16 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSKFC-0001it-J9 for 8463@debbugs.gnu.org; Thu, 02 Jun 2011 22:36:15 -0400 Received: by pzk5 with SMTP id 5so670807pzk.3 for <8463@debbugs.gnu.org>; Thu, 02 Jun 2011 19:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=5yKlRYGiytj4Y509rYJs82Suk02mZnVHzQkqw4YzJKk=; b=FZYlrhltpyFgAr1B3/SYC8iUGK7OYsDKLjBSOhG9cAp3AKyTbriqNKZZSOrlYo3JNP FHpqstmsg4DpUs3JyYa5uhAc4e0NtUyrf1Yt4946tqTbBnDeWWGsNH8H7neHHfmDeJlF REh0Fpqdhse7FcFXWXpy3EQGGxdWCx/SEQBrI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=DanYOJel/0k18eXsWdxSG/dumf2hznnIx9h7gL1sNMYbgyOo+dW7ndHwXu2FWkpDDZ KnIdPYionFzGDUdvsTik17mAECiy+g2NBTJZj9kBx81UwT4jQOr4U7v12ubXnFvImT6o M0FhntIKrdjNPkAsP1as8a/FZZ2LRVSMPJwXs= Received: by 10.68.18.170 with SMTP id x10mr612841pbd.469.1307068568664; Thu, 02 Jun 2011 19:36:08 -0700 (PDT) Received: from localhost (static-ip-194-128-66-202.rev.dyxnet.com [202.66.128.194]) by mx.google.com with ESMTPS id c3sm1051769pbk.45.2011.06.02.19.36.04 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 02 Jun 2011 19:36:06 -0700 (PDT) From: Leo To: Glenn Morris Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: Date: Fri, 03 Jun 2011 10:36:02 +0800 In-Reply-To: (Glenn Morris's message of "Wed, 01 Jun 2011 19:03:36 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, "Andrew W. Nosenko" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On 2011-06-02 07:03 +0800, Glenn Morris wrote: [snipped 50 lines] Thank you for this feedback. I will try to address these issues when I am back from a trip on Tuesday. Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 03 11:38:19 2011 Received: (at 8463) by debbugs.gnu.org; 3 Jun 2011 15:38:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSWS3-00060M-3r for submit@debbugs.gnu.org; Fri, 03 Jun 2011 11:38:19 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSWS1-000608-O0 for 8463@debbugs.gnu.org; Fri, 03 Jun 2011 11:38:18 -0400 Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:49407 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QSWRv-0000TO-8q; Fri, 03 Jun 2011 11:38:11 -0400 Received: by ceviche.home (Postfix, from userid 20848) id A8491660DD; Fri, 3 Jun 2011 12:38:07 -0300 (ART) From: Stefan Monnier To: Leo Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Message-ID: References: Date: Fri, 03 Jun 2011 12:38:07 -0300 In-Reply-To: (Leo's message of "Fri, 03 Jun 2011 10:36:02 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8463 Cc: Glenn Morris , 8463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) > Thank you for this feedback. I will try to address these issues when I > am back from a trip on Tuesday. I think it makes sense to bind the occur-edit feature to some other key than C-x C-q. While C-x C-q is a cute binding for it, it does hide a command that is also useful. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 17:34:22 2011 Received: (at 8463) by debbugs.gnu.org; 4 Jun 2011 21:34:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSyUA-0005lu-KF for submit@debbugs.gnu.org; Sat, 04 Jun 2011 17:34:22 -0400 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QSyU8-0005lh-So for 8463@debbugs.gnu.org; Sat, 04 Jun 2011 17:34:21 -0400 Received: from furball ([64.134.101.122]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id p54LYFrR019973 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 4 Jun 2011 17:34:15 -0400 Received: by furball (Postfix, from userid 1000) id 8573C16051D; Sat, 4 Jun 2011 17:34:14 -0400 (EDT) From: Chong Yidong To: Stefan Monnier Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: Date: Sat, 04 Jun 2011 17:34:14 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 03 Jun 2011 12:38:07 -0300") Message-ID: <87d3itp9gp.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8463 Cc: Glenn Morris , 8463@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stefan Monnier writes: >> Thank you for this feedback. I will try to address these issues when I >> am back from a trip on Tuesday. > > I think it makes sense to bind the occur-edit feature to some other > key than C-x C-q. While C-x C-q is a cute binding for it, it does > hide a command that is also useful. Unfortunately, C-x C-q is consistent with the command for switching to wdired mode. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 05:34:58 2011 Received: (at 8463) by debbugs.gnu.org; 5 Jun 2011 09:34:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QT9jW-0007gM-29 for submit@debbugs.gnu.org; Sun, 05 Jun 2011 05:34:58 -0400 Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QT9jT-0007g9-PB for 8463@debbugs.gnu.org; Sun, 05 Jun 2011 05:34:56 -0400 Received: by fxm15 with SMTP id 15so1954231fxm.3 for <8463@debbugs.gnu.org>; Sun, 05 Jun 2011 02:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type :content-transfer-encoding; bh=FQ+4iKxYZyp5BAfaU6YXre3dyblqdD26EEa/1uH0Ccw=; b=DJGJBbjTP278hczEgHOa+I5Fq0tCL2FElpmFtO5umc0i3LsZcbI7rNnBWFX3pCUb04 //wKuhq4v173N8uQpWJI3jHpHR2ZxFzyvHaFyV0XThG3JOv4T7HLlVCy6O9epA1tsJPq nYiWd61iDO5loquBE+BzzG/O3TYHdRBCcezUw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type:content-transfer-encoding; b=EmX+FN/l6WqdkGDwyShvszQ9mB16VUoWpFBTv7+DmDnRVSlVBkxK8aKwm48HUnmWXv 3amNNE2ksMV22d3skciwhkOl7NCfNpwwDmLC3rJW6FGODWWuW8tStpHLJG1+asvq9K60 voqQPQqd3iOjlflGyq0vUfcQBYR9T2R72BRHY= Received: by 10.223.33.6 with SMTP id f6mr535214fad.85.1307266489900; Sun, 05 Jun 2011 02:34:49 -0700 (PDT) Received: from localhost (176.119.broadband10.iol.cz [90.177.119.176]) by mx.google.com with ESMTPS id b25sm982153fab.28.2011.06.05.02.34.48 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Jun 2011 02:34:48 -0700 (PDT) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: Chong Yidong Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer In-Reply-To: <87d3itp9gp.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 04 Jun 2011 17:34:14 -0400") References: <87d3itp9gp.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Date: Sun, 05 Jun 2011 11:30:57 +0200 Message-ID: <87ipskr5f2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, Stefan Monnier , Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) Chong Yidong writes: > Stefan Monnier writes: > >>> Thank you for this feedback. I will try to address these issues when I >>> am back from a trip on Tuesday. >> >> I think it makes sense to bind the occur-edit feature to some other >> key than C-x C-q. While C-x C-q is a cute binding for it, it does >> hide a command that is also useful. > > Unfortunately, C-x C-q is consistent with the command for switching to > wdired mode. I don't think this argument is really valid. First of all, C-x C-q is consistent with the command to switch read-only-ness of a buffer, and that's apparently what at least some people still expect and are used to in this case. It might have made sense to override it for Wdired, but not necessarily here. =C5=A0t=C4=9Bp=C3=A1n From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 11:34:52 2011 Received: (at 8463) by debbugs.gnu.org; 6 Jun 2011 15:34:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QTbpL-0001sn-Hp for submit@debbugs.gnu.org; Mon, 06 Jun 2011 11:34:51 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QTbpF-0001sU-Al for 8463@debbugs.gnu.org; Mon, 06 Jun 2011 11:34:50 -0400 Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:39410 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QTbp9-0008BN-2a; Mon, 06 Jun 2011 11:34:39 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 54DF566189; Mon, 6 Jun 2011 12:34:36 -0300 (ART) From: Stefan Monnier To: Chong Yidong Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Message-ID: References: <87d3itp9gp.fsf@stupidchicken.com> Date: Mon, 06 Jun 2011 12:34:36 -0300 In-Reply-To: <87d3itp9gp.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 04 Jun 2011 17:34:14 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8463 Cc: Glenn Morris , 8463@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >>> Thank you for this feedback. I will try to address these issues when I >>> am back from a trip on Tuesday. >> I think it makes sense to bind the occur-edit feature to some other >> key than C-x C-q. While C-x C-q is a cute binding for it, it does >> hide a command that is also useful. > Unfortunately, C-x C-q is consistent with the command for switching to > wdired mode. Right, but wdired and occur-edit are two different things. Editing a dired buffer in wdired does not have any other side effect (at least not until you "commit" those changes), so its behavior is still pretty close to toggle-read-only. Occur-edit is somewhat reminiscent of wdired, but does not match the behavior of toggle-read-only quite as closely. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 09 00:47:37 2011 Received: (at 8463) by debbugs.gnu.org; 9 Jun 2011 04:47:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUX9c-0003AO-Dg for submit@debbugs.gnu.org; Thu, 09 Jun 2011 00:47:36 -0400 Received: from mail-px0-f170.google.com ([209.85.212.170]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUX9a-0003AC-Rs for 8463@debbugs.gnu.org; Thu, 09 Jun 2011 00:47:35 -0400 Received: by pxi19 with SMTP id 19so866049pxi.29 for <8463@debbugs.gnu.org>; Wed, 08 Jun 2011 21:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=6jZCTDIBi6iYiRyWYGvNLBpq9Om024fB5hXzzLx6ac0=; b=LmU5naITqMuDr0gQZ+dSbKtO2KqE0/7z1wGXpYzsRz73b/5LwXqblQl+06oxTKDGZN ct/V4a5Bs+fyh9xsQok+KAUJdfmyVbL2PyTIGpCmDIYbX0F7tsQiOD8t0QsXZ4D2bAGL 0eazt1XqUhX9yTWW8ZjJeo/REbrG+CBlfD6lA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=CWIS126pwCx313tFuOr2iuWQ3P3sc1h5Vu8e2w/jL2lX+EP+RTWJn3iqZ4cUgWFRQ4 iqddk+80kJmR5Ijlxz7yU7g0cRQNSgeo9+mLBPQHbMS91IFhX7JVHntTFNcCJvFurabD s/F6djYSK2OfKqlE/XXKJ3BCieZ5zNPCWUKQQ= Received: by 10.68.65.75 with SMTP id v11mr116376pbs.56.1307594848960; Wed, 08 Jun 2011 21:47:28 -0700 (PDT) Received: from localhost ([123.114.55.183]) by mx.google.com with ESMTPS id p5sm1076069pbd.76.2011.06.08.21.47.15 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 08 Jun 2011 21:47:27 -0700 (PDT) From: Leo To: Glenn Morris Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: Date: Thu, 09 Jun 2011 12:47:00 +0800 In-Reply-To: (Glenn Morris's message of "Wed, 01 Jun 2011 19:03:36 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 8463 Cc: Chong Yidong , 8463@debbugs.gnu.org, Richard Stallman , "Andrew W. Nosenko" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) On 2011-06-02 07:03 +0800, Glenn Morris wrote: > 2. After C-x C-q, If I delete some text in the occur buffer, then use > "undo", when I reach the point at which there is no more to undo, I get: > "Wrong type argument: markerp, nil" rather than "No further undo information". > > Debugger entered--Lisp error: (wrong-type-argument markerp nil) > marker-buffer(nil) > occur-after-change-function(1 40 39) > primitive-undo(1 ((nil font-lock-face underline 1 . 40) (t 0 . 0))) > undo-more(1) > undo(nil) > call-interactively(undo nil nil) This can be fixed with: diff --git a/lisp/replace.el b/lisp/replace.el index 0578ed09..fc2db2ec 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -882,11 +882,11 @@ (define-derived-mode occur-edit-mode occur-mode "Occur-Edit" (defun occur-after-change-function (beg end length) (save-excursion - (goto-char beg) (let* ((m (get-text-property (line-beginning-position) 'occur-target)) (buf (marker-buffer m)) (col (current-column))) (when (= length 0) + (goto-char beg) ;; Apply occur-target property to inserted (e.g. yanked) text. (put-text-property beg end 'occur-target m) ;; Did we insert a newline? Occur Edit mode can't create new The cause: When switching major-mode (in this case occur-edit-mode), an undo entry containing text-property only change is added due to this line in occur-mode: (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) That line seems useless due to change made in revid 22063400b. If no one objects, I intend to also remove it. Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 09 01:14:27 2011 Received: (at 8463) by debbugs.gnu.org; 9 Jun 2011 05:14:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUXZb-0003kL-6r for submit@debbugs.gnu.org; Thu, 09 Jun 2011 01:14:27 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUXZZ-0003kA-JD for 8463@debbugs.gnu.org; Thu, 09 Jun 2011 01:14:26 -0400 Received: from localhost ([127.0.0.1]:52622) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUXZS-0006yj-Kv; Thu, 09 Jun 2011 01:14:18 -0400 From: Glenn Morris To: Leo Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: X-Spook: SRI ammunition lynch e-bomb Indigo SP4 bemd Bellcore X-Ran: oo-N\Dx+.2ZP9AlHH,3lA87{d1j1iL+4.)z1(Vjb`oUORuq2KA1byVj6.w($D8%6du*.qi X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 09 Jun 2011 01:14:18 -0400 In-Reply-To: (Leo's message of "Thu, 09 Jun 2011 12:47:00 +0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, "Andrew W. Nosenko" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Leo wrote: > revid 22063400b. Speaking for myself, I have no idea what that means. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 09 05:43:16 2011 Received: (at 8463) by debbugs.gnu.org; 9 Jun 2011 09:43:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUblj-00016s-O6 for submit@debbugs.gnu.org; Thu, 09 Jun 2011 05:43:16 -0400 Received: from mail-pw0-f44.google.com ([209.85.160.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUblh-00016d-Oa for 8463@debbugs.gnu.org; Thu, 09 Jun 2011 05:43:14 -0400 Received: by pwi5 with SMTP id 5so656367pwi.3 for <8463@debbugs.gnu.org>; Thu, 09 Jun 2011 02:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=8j0mUTDWj8l6M7cpVGA6nKSrMb7oavbIFFzU963UzZ4=; b=hRDO8E0OEh7f8vPDSvpBozQDGgc50jdBLx0NoFQ39fwTbdd1SynSSOFLcBfJCeNVdI Gr4QUDvm7Az3j2Y7utRnqMAnCt7Q4aLWxAQp+tq3lE30LGR3OuwL61E4DdnJgVCEDJM7 1JGf2OwU6LzCFXA67CelB9/hS0R8oaBCYLR8s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=Cev3S90yldN1NsvwuVMLLg42awPWTiewzNQKU51SBBjumgs7l0/ATuAxHufMPHixos /Uf8aTf1Hb+0qIIhzDSiodrO35YE0GnOv0ixPZNEDIiZTkVQPDS4CYn3fVt/nJFTv+JX eiXRyD6LwyYAVTpQWw/S3m3nyp5wB75ehkypE= Received: by 10.142.178.3 with SMTP id a3mr76857wff.53.1307612587873; Thu, 09 Jun 2011 02:43:07 -0700 (PDT) Received: from localhost ([123.114.55.183]) by mx.google.com with ESMTPS id o1sm1545759wfd.20.2011.06.09.02.43.00 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 09 Jun 2011 02:43:06 -0700 (PDT) From: Leo To: Glenn Morris Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: Date: Thu, 09 Jun 2011 17:42:47 +0800 In-Reply-To: (Glenn Morris's message of "Wed, 01 Jun 2011 19:03:36 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: 8463 Cc: Chong Yidong , 8463@debbugs.gnu.org, Stefan Monnier , "Andrew W. Nosenko" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) --=-=-= Content-Type: text/plain I think maybe we should assign C-c C-c to occur-edit-mode instead. 1. After C-x C-q, I can no longer kill entire lines in the occur buffer. Trying to do so reports "Text is read-only". The text properties are now added when entering occur-edit-mode. 2. After C-x C-q, If I delete some text in the occur buffer, then use "undo", when I reach the point at which there is no more to undo, I get: "Wrong type argument: markerp, nil" rather than "No further undo information". Debugger entered--Lisp error: (wrong-type-argument markerp nil) marker-buffer(nil) occur-after-change-function(1 40 39) primitive-undo(1 ((nil font-lock-face underline 1 . 40) (t 0 . 0))) undo-more(1) undo(nil) call-interactively(undo nil nil) Fixed. 3. After C-x C-q, M-x revert-buffer in the occur buffer triggers an error occur-revert-arguments is killed after any major-mode change. In the patch this has been made permanent-local. Comments welcome. Thanks. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=occur-edit.diff Content-Description: occur-edit.diff === modified file 'lisp/replace.el' --- lisp/replace.el 2011-05-28 22:56:14 +0000 +++ lisp/replace.el 2011-06-09 09:28:09 +0000 @@ -826,6 +826,8 @@ (defvar occur-revert-arguments nil "Arguments to pass to `occur-1' to revert an Occur mode buffer. See `occur-revert-function'.") +(make-variable-buffer-local 'occur-revert-arguments) +(put 'occur-revert-arguments 'permanent-local t) (defcustom occur-mode-hook '(turn-on-font-lock) "Hook run when entering Occur mode." @@ -853,8 +855,6 @@ \\{occur-mode-map}" (set (make-local-variable 'revert-buffer-function) 'occur-revert-function) - (make-local-variable 'occur-revert-arguments) - (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) (setq next-error-function 'occur-next-error)) @@ -865,7 +865,7 @@ (set-keymap-parent map text-mode-map) (define-key map [mouse-2] 'occur-mode-mouse-goto) (define-key map "\C-c\C-c" 'occur-mode-goto-occurrence) - (define-key map "\C-x\C-q" 'occur-mode) + (define-key map "\C-x\C-q" 'occur-edit-finish) (define-key map "\C-c\C-f" 'next-error-follow-minor-mode) (define-key map [menu-bar occur] (cons (purecopy "Occur") occur-menu-map)) map) @@ -878,40 +878,59 @@ To return to ordinary Occur mode, use \\[occur-mode]." (setq buffer-read-only nil) + (put 'occur-noneditable 'read-only t) + (put 'occur-noneditable 'face 'shadow) + (save-excursion + (save-restriction + (widen) + (goto-char (point-min)) + (while (re-search-forward "^[ \t0-9]+:\\|\n" nil t) + (with-silent-modifications + (put-text-property (match-beginning 0) (match-end 0) + 'category 'occur-noneditable))))) (add-hook 'after-change-functions 'occur-after-change-function nil t)) +(defun occur-edit-finish () + (interactive) + (put 'occur-noneditable 'read-only nil) + (put 'occur-noneditable 'face nil) + (occur-mode)) + (defun occur-after-change-function (beg end length) - (save-excursion - (goto-char beg) - (let* ((m (get-text-property (line-beginning-position) 'occur-target)) - (buf (marker-buffer m)) - (col (current-column))) - (when (= length 0) - ;; Apply occur-target property to inserted (e.g. yanked) text. - (put-text-property beg end 'occur-target m) - ;; Did we insert a newline? Occur Edit mode can't create new - ;; Occur entries; just discard everything after the newline. + (let ((m (save-excursion + (goto-char beg) + (get-text-property (line-beginning-position) 'occur-target)))) + (when (and (markerp m) (buffer-live-p (marker-buffer m))) + (when (zerop length) (save-excursion + ;; Apply occur-target property to inserted (e.g. yanked) text. + (put-text-property beg end 'occur-target m) + ;; Did we insert a newline? Occur Edit mode can't create new + ;; Occur entries; just discard everything after the newline. + (goto-char beg) (and (search-forward "\n" end t) (delete-region (1- (point)) end)))) - (let ((line (- (line-number-at-pos) - (line-number-at-pos (window-start)))) - (readonly (with-current-buffer buf buffer-read-only)) - (win (or (get-buffer-window buf) - (display-buffer buf t))) - (text (save-excursion - (forward-line 0) - (search-forward ":" nil t) - (setq col (- col (current-column))) - (buffer-substring-no-properties (point) (line-end-position))))) - (with-selected-window win - (goto-char m) - (recenter line) - (if readonly - (message "Buffer `%s' is read only." buf) - (delete-region (line-beginning-position) (line-end-position)) - (insert text)) - (move-to-column col)))))) + (save-excursion + (let* ((buf (marker-buffer m)) + (col (current-column)) + (line (- (line-number-at-pos) + (line-number-at-pos (window-start)))) + (readonly (with-current-buffer buf buffer-read-only)) + (win (or (get-buffer-window buf) + (display-buffer buf t))) + (text (save-excursion + (forward-line 0) + (search-forward ":" nil t) + (setq col (- col (current-column))) + (buffer-substring-no-properties (point) (line-end-position))))) + (with-selected-window win + (goto-char m) + (recenter line) + (if readonly + (message "Buffer `%s' is read only." buf) + (delete-region (line-beginning-position) (line-end-position)) + (insert text)) + (move-to-column col))))))) (defun occur-revert-function (_ignore1 _ignore2) @@ -1341,7 +1360,6 @@ `(font-lock-face prefix-face)) `(occur-prefix t mouse-face (highlight) occur-target ,marker follow-link t - read-only t help-echo "mouse-2: go to this occurrence")))) (match-str ;; We don't put `mouse-face' on the newline, @@ -1401,15 +1419,13 @@ (goto-char headerpt) (let ((beg (point)) end) - (insert (propertize - (format "%d match%s%s in buffer: %s\n" - matches (if (= matches 1) "" "es") - ;; Don't display regexp for multi-buffer. - (if (> (length buffers) 1) - "" (format " for \"%s\"" - (query-replace-descr regexp))) - (buffer-name buf)) - 'read-only t)) + (insert (format "%d match%s%s in buffer: %s\n" + matches (if (= matches 1) "" "es") + ;; Don't display regexp for multi-buffer. + (if (> (length buffers) 1) + "" (format " for \"%s\"" + (query-replace-descr regexp))) + (buffer-name buf))) (setq end (point)) (add-text-properties beg end (append --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 09 05:44:37 2011 Received: (at 8463) by debbugs.gnu.org; 9 Jun 2011 09:44:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUbn2-000190-Mf for submit@debbugs.gnu.org; Thu, 09 Jun 2011 05:44:37 -0400 Received: from mail-pw0-f44.google.com ([209.85.160.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUbn1-00018i-Gu for 8463@debbugs.gnu.org; Thu, 09 Jun 2011 05:44:36 -0400 Received: by pwi5 with SMTP id 5so656839pwi.3 for <8463@debbugs.gnu.org>; Thu, 09 Jun 2011 02:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=PQTvCVmmdamWqBpcP/CcCscqGaGVI8L//+P43xloH4E=; b=rnamnOtyKPk8F+4Gm5mV3aq5qv39OndfagqHQrM0iG8Af46eFm78crFASJldRXVUMz NFqAUO6ThuCQPsjjg1DgC0KDZweL+NP8zkEyizONKWhqB2yKHuC5qFmLIaJZMfN1Z1KK EVViV5g2VYvlMWWE8EAUvKnVUc4eR8SKJTMz0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=Ew1UgIWbdTy645tmUv/kliNE3maLf2fAKuuGHyhKuLQ591GZPn7l2mY9fhBMcbSts9 2h+HiSoS4vr2CdqjrZlMDWqZmcVfToq9S+S9ss10Ee+3LWrpvf59VNaDbc7vn3rbcB6a SJLC3b6S5qc7EQGR6W+SKsWXgOydcuy2oK5Mo= Received: by 10.68.49.167 with SMTP id v7mr171973pbn.122.1307612669784; Thu, 09 Jun 2011 02:44:29 -0700 (PDT) Received: from localhost ([123.114.55.183]) by mx.google.com with ESMTPS id p5sm199919pbd.44.2011.06.09.02.44.20 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 09 Jun 2011 02:44:29 -0700 (PDT) From: Leo To: Glenn Morris Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: Date: Thu, 09 Jun 2011 17:44:11 +0800 In-Reply-To: (Glenn Morris's message of "Thu, 09 Jun 2011 01:14:18 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) On 2011-06-09 13:14 +0800, Glenn Morris wrote: >> revid 22063400b. > > Speaking for myself, I have no idea what that means. That's what I saw on the annotation buffer (from C-x v g). I was able to view the diff there with 'd'. Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 09 05:54:58 2011 Received: (at 8463) by debbugs.gnu.org; 9 Jun 2011 09:54:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUbx3-0001OV-MB for submit@debbugs.gnu.org; Thu, 09 Jun 2011 05:54:57 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUbx1-0001OJ-1w for 8463@debbugs.gnu.org; Thu, 09 Jun 2011 05:54:55 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LMI00400NK5IJ00@a-mtaout20.012.net.il> for 8463@debbugs.gnu.org; Thu, 09 Jun 2011 12:54:47 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.223.140]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LMI003HKOV9FJD0@a-mtaout20.012.net.il>; Thu, 09 Jun 2011 12:54:46 +0300 (IDT) Date: Thu, 09 Jun 2011 12:54:49 +0300 From: Eli Zaretskii Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer In-reply-to: X-012-Sender: halo1@inter.net.il To: Leo Message-id: <83oc27ba8m.fsf@gnu.org> References: X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 8463 Cc: rgm@gnu.org, 8463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Leo > Date: Thu, 09 Jun 2011 17:44:11 +0800 > Cc: 8463@debbugs.gnu.org > > On 2011-06-09 13:14 +0800, Glenn Morris wrote: > >> revid 22063400b. > > > > Speaking for myself, I have no idea what that means. > > That's what I saw on the annotation buffer (from C-x v g). I was able to > view the diff there with 'd'. Git sha values are generally not useful for someone who uses bzr. It would be nice if people who report problems could also mention the bzr revision or revid. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 09 05:59:22 2011 Received: (at 8463) by debbugs.gnu.org; 9 Jun 2011 09:59:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUc1J-0001Ua-C6 for submit@debbugs.gnu.org; Thu, 09 Jun 2011 05:59:21 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUc1H-0001UP-HH for 8463@debbugs.gnu.org; Thu, 09 Jun 2011 05:59:19 -0400 Received: by pvh18 with SMTP id 18so664098pvh.3 for <8463@debbugs.gnu.org>; Thu, 09 Jun 2011 02:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=2WlSFoG0sGJUnQ8MoQ854x4P/bflLqcCBQoGnipIrpo=; b=IusrpW+ZVoKHkUinsgPdDNqXoAF1kyOoBp3NNlwBWkMIjq+cFJwUAtG2FyGnv+EL4A H7K9MrYBTQEJplpeRi/HLvha2zeZ2+TeZHyepOuDJ+xN0n9BoTW9oRuWU06GBrJCtjn4 08wcBZLZ9QiKqk6tnL42WkN28iTd/+b2nogQc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=AxgGgrra+V1brCBccKr4x6E23LCAA37YpZ8Zru43V1Yf0A5i35YjxpPigh4pjrN4N4 bPXevKE8b/8Jdp0crpW6WxHtST5RCgFy/VyHhX6getoHXT8NCn7TR3WAjcySrl6FcIhQ LYihPQ46aQqSKfW76pOSBwy6Ei77LVn/LNw+8= Received: by 10.142.229.4 with SMTP id b4mr108024wfh.171.1307613553731; Thu, 09 Jun 2011 02:59:13 -0700 (PDT) Received: from localhost ([123.114.55.183]) by mx.google.com with ESMTPS id k2sm1562006wfe.15.2011.06.09.02.59.09 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 09 Jun 2011 02:59:13 -0700 (PDT) From: Leo To: Eli Zaretskii Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: <83oc27ba8m.fsf@gnu.org> Date: Thu, 09 Jun 2011 17:58:57 +0800 In-Reply-To: <83oc27ba8m.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Jun 2011 12:54:49 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) On 2011-06-09 17:54 +0800, Eli Zaretskii wrote: >> That's what I saw on the annotation buffer (from C-x v g). I was able to >> view the diff there with 'd'. > > Git sha values are generally not useful for someone who uses bzr. It > would be nice if people who report problems could also mention the bzr > revision or revid. My bad. I thought I was on the bzr repo. Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 09 14:09:58 2011 Received: (at 8463) by debbugs.gnu.org; 9 Jun 2011 18:09:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUjg5-0004eE-K8 for submit@debbugs.gnu.org; Thu, 09 Jun 2011 14:09:58 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QUjg4-0004e3-FV for 8463@debbugs.gnu.org; Thu, 09 Jun 2011 14:09:56 -0400 Received: from localhost ([127.0.0.1]:54296) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUjfx-00014A-Vs; Thu, 09 Jun 2011 14:09:50 -0400 From: Glenn Morris To: Leo Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: X-Spook: SP4 UMTS Treasury Aldergrove Yukon diwn PET 22nd SAS X-Ran: ~9]~x&%,P(]'hdpBV]dtcVaW>3!4+/1k,{(NlTgak"/U/54(K0t>c2}QhVg2o6GD@E3wVB X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 09 Jun 2011 14:09:49 -0400 In-Reply-To: (Leo's message of "Thu, 09 Jun 2011 17:42:47 +0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 8463 Cc: Chong Yidong , 8463@debbugs.gnu.org, Stefan Monnier , "Andrew W. Nosenko" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Leo wrote: > I think maybe we should assign C-c C-c to occur-edit-mode instead. Or "e" (for edit; like in Rmail). > 1. After C-x C-q, I can no longer kill entire lines in the occur buffer. > Trying to do so reports "Text is read-only". > > The text properties are now added when entering occur-edit-mode. I don't understand if that means it's fixed. Deleting whole or even multiple lines is an operation I might want to do in occur-edit-mode. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 09:59:27 2011 Received: (at 8463) by debbugs.gnu.org; 10 Jun 2011 13:59:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QV2FD-00023C-4p for submit@debbugs.gnu.org; Fri, 10 Jun 2011 09:59:27 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QV2FB-000230-JI for 8463@debbugs.gnu.org; Fri, 10 Jun 2011 09:59:26 -0400 Received: from [190.177.196.60] (port=13128 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QV2F5-0000xk-6s; Fri, 10 Jun 2011 09:59:19 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 27383667EF; Fri, 10 Jun 2011 10:59:16 -0300 (ART) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Message-ID: References: Date: Fri, 10 Jun 2011 10:59:16 -0300 In-Reply-To: (Glenn Morris's message of "Thu, 09 Jun 2011 14:09:49 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8463 Cc: Chong Yidong , 8463@debbugs.gnu.org, Leo , "Andrew W. Nosenko" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >> I think maybe we should assign C-c C-c to occur-edit-mode instead. I don't like that: C-c C-c means "done" usually so it'd be OK to leave edit mode, but not to enter it. > Or "e" (for edit; like in Rmail). That sounds good. >> 1. After C-x C-q, I can no longer kill entire lines in the occur buffer. >> Trying to do so reports "Text is read-only". >> The text properties are now added when entering occur-edit-mode. > I don't understand if that means it's fixed. Deleting whole or even > multiple lines is an operation I might want to do in occur-edit-mode. But its meaning is unclear and we get to choose what is allowed and what is not in edit mode since it's a new mode that the user requested explicitly. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 12:14:27 2011 Received: (at 8463) by debbugs.gnu.org; 10 Jun 2011 16:14:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QV4Lr-0005Ac-4M for submit@debbugs.gnu.org; Fri, 10 Jun 2011 12:14:27 -0400 Received: from chirelay1o.jumptrading.com ([38.98.147.153] helo=chirelay1.jumptrading.com) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QV4Lp-0005AQ-3K for 8463@debbugs.gnu.org; Fri, 10 Jun 2011 12:14:25 -0400 Received: from chirelay1.jumptrading.com (unknown [127.0.0.1]) by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id 9CB88320030 for <8463@debbugs.gnu.org>; Fri, 10 Jun 2011 11:14:19 -0500 (CDT) X-AuditID: 26629395-9f689bb000001002-8c-4df242dbca02 Received: from chiexchange02.w2k.jumptrading.com (unknown [38.98.147.140]) by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id 7B8652DC007 for <8463@debbugs.gnu.org>; Fri, 10 Jun 2011 11:14:19 -0500 (CDT) Received: from internalsmtp.w2k.jumptrading.com (10.2.4.29) by chiexchange02.w2k.jumptrading.com (10.2.4.71) with Microsoft SMTP Server id 8.1.291.1; Fri, 10 Jun 2011 11:14:18 -0500 Received: from tzlatanov-ubuntu-desktop.jumptrading.com ([10.2.14.81]) by internalsmtp.w2k.jumptrading.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 10 Jun 2011 11:14:18 -0500 From: Ted Zlatanov To: Stefan Monnier Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Fri, 10 Jun 2011 11:14:16 -0500 In-Reply-To: (Stefan Monnier's message of "Fri, 10 Jun 2011 10:59:16 -0300") Message-ID: <87aadpek9z.fsf@lifelogs.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-OriginalArrivalTime: 10 Jun 2011 16:14:18.0750 (UTC) FILETIME=[736E19E0:01CC2789] X-Brightmail-Tracker: AAAAAA== X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 8463 Cc: Glenn Morris , Chong Yidong , 8463@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) On Fri, 10 Jun 2011 10:59:16 -0300 Stefan Monnier wrote: >>> 1. After C-x C-q, I can no longer kill entire lines in the occur buffer. >>> Trying to do so reports "Text is read-only". >>> The text properties are now added when entering occur-edit-mode. >> I don't understand if that means it's fixed. Deleting whole or even >> multiple lines is an operation I might want to do in occur-edit-mode. SM> But its meaning is unclear and we get to choose what is allowed and what SM> is not in edit mode since it's a new mode that the user SM> requested explicitly. I'd suggest binding `d' to "delete entire line" outside the edit mode, so the edit mode does not need to provide it and still it's available in a convenient way. Ted From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 11 05:58:49 2011 Received: (at 8463) by debbugs.gnu.org; 11 Jun 2011 09:58:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QVKxt-00061O-E1 for submit@debbugs.gnu.org; Sat, 11 Jun 2011 05:58:49 -0400 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QVKxr-00061C-Sm for 8463@debbugs.gnu.org; Sat, 11 Jun 2011 05:58:48 -0400 Received: by iwn39 with SMTP id 39so3032008iwn.3 for <8463@debbugs.gnu.org>; Sat, 11 Jun 2011 02:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=KoDmRank4uBjbb6UIvXqJl8PCbe3as05ao8BOgoHl5U=; b=a8HJ7ap7WcbsUoZjoFnOKJDuHoxh/bZhAfX06vMt79MEGtCWh9Yn0BuD4xbt1UWbOZ Wmqln6cjc96VgUO+c0F+A4eehnYB+7D530Wqwe2eJE8BTZ5Lt3QVM8H2X522H0g7gzV5 fnCzctQfYwesbxTEP5+coPZimy7ilglCRGJb0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=M4mvoocpH+wjRp9Be+nQ7u1FBbF8FXyri+rk6IrgQ7GFufV7QvP2hU1uPxSpmXB5tI T1sEQqheB96AAYsjIeJqOHfSH3lvdbz5Z0msEMPHIH5/0O9UOhlH8Ugb+/W7h5nWQiSG rUsVbKAirDRVL6unZ2wWwUAwUm3pTP6dtwKlk= MIME-Version: 1.0 Received: by 10.42.157.69 with SMTP id c5mr3288592icx.309.1307786321793; Sat, 11 Jun 2011 02:58:41 -0700 (PDT) Received: by 10.43.53.68 with HTTP; Sat, 11 Jun 2011 02:58:41 -0700 (PDT) In-Reply-To: References: Date: Sat, 11 Jun 2011 12:58:41 +0300 Message-ID: Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer From: "Andrew W. Nosenko" To: Stefan Monnier Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 8463 Cc: Glenn Morris , Chong Yidong , 8463@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) On Fri, Jun 10, 2011 at 16:59, Stefan Monnier wrote: >>> I think maybe we should assign C-c C-c to occur-edit-mode instead. > > I don't like that: C-c C-c means "done" usually so it'd be OK to leave > edit mode, but not to enter it. > >> Or "e" (for edit; like in Rmail). > > That sounds good. But not for case, when user already switched the *Occur* buffer into read/write mode for editing the buffer itself (not the underlying files/buffers, where occurrences come from). The same applied for Ted's proposal for 'd' key and any other keys that used for regular text typing. -- Andrew W. Nosenko From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 11 14:09:32 2011 Received: (at 8463) by debbugs.gnu.org; 11 Jun 2011 18:09:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QVScl-0001vs-VW for submit@debbugs.gnu.org; Sat, 11 Jun 2011 14:09:32 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QVSck-0001ve-6j for 8463@debbugs.gnu.org; Sat, 11 Jun 2011 14:09:30 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id A68A86E8077; Sat, 11 Jun 2011 11:09:24 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 2C2DB451C225; Sat, 11 Jun 2011 11:09:22 -0700 (PDT) From: Juri Linkov To: "Andrew W. Nosenko" Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Organization: JURTA References: Date: Sat, 11 Jun 2011 22:00:23 +0400 In-Reply-To: (Andrew W. Nosenko's message of "Sat, 11 Jun 2011 12:58:41 +0300") Message-ID: <87vcwctfig.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8463 Cc: Chong Yidong , 8463@debbugs.gnu.org, Stefan Monnier , Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >>> Or "e" (for edit; like in Rmail). >> >> That sounds good. > > But not for case, when user already switched the *Occur* buffer into > read/write mode for editing the buffer itself (not the underlying > files/buffers, where occurrences come from). Then maybe `M-e' (like in isearch mode)? > The same applied for Ted's proposal for 'd' key and any other keys > that used for regular text typing. There is already `C-k' to do this. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 12 19:10:18 2011 Received: (at 8463) by debbugs.gnu.org; 12 Jun 2011 23:10:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QVtnN-0002jY-Et for submit@debbugs.gnu.org; Sun, 12 Jun 2011 19:10:17 -0400 Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QVtnL-0002jK-4n for 8463@debbugs.gnu.org; Sun, 12 Jun 2011 19:10:15 -0400 Received: by iyn15 with SMTP id 15so3807341iyn.3 for <8463@debbugs.gnu.org>; Sun, 12 Jun 2011 16:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=8nDmylv7yXA4bkhYWpJZUNK+lok30LnxXqhLEhhBkQA=; b=dlQCC7S0v1+lPdCq0TWW2PYGLSjLEtmmGH0wQDYgaNm3DqOqEGNnqRXtncV2MTpoN4 JzdnivrkE6BhSbiiXH9wxIPHqwG6DEPNVLI+f9yCzuDy3YbEqv4oFppSQB1kWSYDShFD Xb5fRg67jcuGtjlqTyivsQnRun8DHzhMAJlnI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=CEkC56Iqt5d2wa5HODFA8kbFAIbJvNrAMK+2WP9Y8+/enoC65d+mdS3tnhbD+I9OIH OU2JIvTmqQ/4CTw0EeWqSiwmGtr89w0M/3s3hYQS6eKh0uoXG6PDog9VbzjjJmeLVSP7 rYsTdsuF8VvdBBi2KUEhxVezu3OcSoxZ0YPJo= MIME-Version: 1.0 Received: by 10.42.150.1 with SMTP id y1mr6248273icv.41.1307920207875; Sun, 12 Jun 2011 16:10:07 -0700 (PDT) Received: by 10.43.53.68 with HTTP; Sun, 12 Jun 2011 16:10:07 -0700 (PDT) In-Reply-To: <87vcwctfig.fsf@mail.jurta.org> References: <87vcwctfig.fsf@mail.jurta.org> Date: Mon, 13 Jun 2011 02:10:07 +0300 Message-ID: Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer From: "Andrew W. Nosenko" To: Juri Linkov Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 8463 Cc: Chong Yidong , 8463@debbugs.gnu.org, Stefan Monnier , Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) On Sat, Jun 11, 2011 at 21:00, Juri Linkov wrote: >>>> Or "e" (for edit; like in Rmail). >>> >>> That sounds good. >> >> But not for case, when user already switched the *Occur* buffer into >> read/write mode for editing the buffer itself (not the underlying >> files/buffers, where occurrences come from). > > Then maybe `M-e' (like in isearch mode)? If separate apply-changes-to-underlying-buffers action to the own function (may be even it already implemented in that way) then all controversy will gone. -- Enter to read-write mode -- the same, editing commands -- the same, all other behavior -- the same. Just because there will work one and the same code in the one and the same mode. Difference is only one between my usage model and usage model of Leo (original author) -- after finishing I simple kill the occur buffer, while Leo call the "apply-cachanges-to-underlying-buffers" for "commit" the final results. IMHO anyone can benefit from solving the problem in that way. -- Andrew W. Nosenko From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 15:35:50 2011 Received: (at 8463) by debbugs.gnu.org; 18 Jun 2011 19:35:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QY1J7-0003d7-W5 for submit@debbugs.gnu.org; Sat, 18 Jun 2011 15:35:50 -0400 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QY1J5-0003cu-UJ for 8463@debbugs.gnu.org; Sat, 18 Jun 2011 15:35:48 -0400 Received: from furball (dhcp128036226133.central.yale.edu [128.36.226.133]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id p5IJZg9N030466 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 18 Jun 2011 15:35:42 -0400 Received: by furball (Postfix, from userid 1000) id E998216041A; Sat, 18 Jun 2011 15:35:41 -0400 (EDT) From: Chong Yidong To: "Andrew W. Nosenko" Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: Date: Sat, 18 Jun 2011 15:35:41 -0400 In-Reply-To: (Andrew W. Nosenko's message of "Sat, 11 Jun 2011 12:58:41 +0300") Message-ID: <8739j7nd9u.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 8463 Cc: Glenn Morris , 8463@debbugs.gnu.org, Stefan Monnier , Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) "Andrew W. Nosenko" writes: >>> Or "e" (for edit; like in Rmail). >> >> That sounds good. > > But not for case, when user already switched the *Occur* buffer into > read/write mode for editing the buffer itself (not the underlying > files/buffers, where occurrences come from). That's already the case with "r" (occur-rename-buffer), "c" (clone-buffer), and "o" (occur-mode-goto-occurrence-other-window). From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 16:36:57 2011 Received: (at 8463) by debbugs.gnu.org; 18 Jun 2011 20:36:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QY2GG-00082J-H7 for submit@debbugs.gnu.org; Sat, 18 Jun 2011 16:36:56 -0400 Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QY2GF-000825-5V for 8463@debbugs.gnu.org; Sat, 18 Jun 2011 16:36:55 -0400 Received: by fxm15 with SMTP id 15so485343fxm.3 for <8463@debbugs.gnu.org>; Sat, 18 Jun 2011 13:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=xS6qGSNhV/G36WZqDmrWD9cGvV1Od6vThMZGJ8JNSqg=; b=NHaotxEdOZhCyKB0OSVGoe0cYuPUOuUjbjXLo8gtixhMhHLWr9OaBtq8uA5mgXycOH 8O5pLUwUle8C9nnmN3PtbBYAXaEjq3MgGC7yTKqCDJxQXctJfz8QzF7OlsXj1wK4uXpn Ir53IQH6dgFm0NqVKfF0o6pvROwtjqIq6tyA4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=v/jq6115B6ibhOGopzDwyTTV9SKrGhOqRCEeHs24ykzUGkqgVkGxH5cbHPfr0kalmv V1PVb29yybZaFKii9Es7uWaer2Ob2999uwt5kIBZA8P+wx4hvoNv/0Lj6jz5tieGtcOf gmTm4p/aaD5hyM30klSBz0/Q+oh1WvP9jHjpA= MIME-Version: 1.0 Received: by 10.223.74.83 with SMTP id t19mr1439642faj.149.1308429409302; Sat, 18 Jun 2011 13:36:49 -0700 (PDT) Received: by 10.223.103.4 with HTTP; Sat, 18 Jun 2011 13:36:49 -0700 (PDT) In-Reply-To: <8739j7nd9u.fsf@stupidchicken.com> References: <8739j7nd9u.fsf@stupidchicken.com> Date: Sat, 18 Jun 2011 23:36:49 +0300 Message-ID: Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer From: "Andrew W. Nosenko" To: Chong Yidong Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 8463 Cc: Glenn Morris , 8463@debbugs.gnu.org, Stefan Monnier , Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) On Sat, Jun 18, 2011 at 22:35, Chong Yidong wrote: > "Andrew W. Nosenko" writes: > >>>> Or "e" (for edit; like in Rmail). >>> >>> That sounds good. >> >> But not for case, when user already switched the *Occur* buffer into >> read/write mode for editing the buffer itself (not the underlying >> files/buffers, where occurrences come from). > > That's already the case with "r" (occur-rename-buffer), "c" > (clone-buffer), and "o" (occur-mode-goto-occurrence-other-window). > Yes, but: (1) these actions aren't destructive in respect to the original data, and (2) I would to prefer to see the number of such bindings decreasing, not increasing. -- Andrew W. Nosenko From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 09 07:48:01 2011 Received: (at 8463) by debbugs.gnu.org; 9 Sep 2011 11:48:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R1zYu-0000ro-V5 for submit@debbugs.gnu.org; Fri, 09 Sep 2011 07:48:01 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R1zYs-0000rf-SH for 8463@debbugs.gnu.org; Fri, 09 Sep 2011 07:47:59 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 230FF6E80A2; Fri, 9 Sep 2011 04:43:54 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 3DF0C451C46D; Fri, 9 Sep 2011 04:43:53 -0700 (PDT) From: Juri Linkov To: Leo Subject: Re: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Organization: JURTA References: Date: Fri, 09 Sep 2011 14:39:23 +0300 In-Reply-To: (Leo's message of "Sun, 10 Apr 2011 16:14:53 +0800") Message-ID: <87k49i6izg.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) I appreciate this new feature Occur-Edit. It's especially powerful with the ability of syncing replacements made by `query-replace' from the *Occur* buffer to the source buffer. It could provide a special keybinding to start making replacements with the same regexp as used to run `occur' like grep-x.el does in http://thread.gmane.org/gmane.emacs.devel/66418 and in http://thread.gmane.org/gmane.emacs.devel/108202/focus=108229 Also it has one little drawback: it adds too many undo boundaries, so to undo changes in the source buffer, it requires too many `C-_'. There is no such problem in all.el (from ELPA) because `all-after-change-function' doesn't call `recenter' and `move-to-column'. But there is a greater drawback: stealing the `C-x C-q' keybinding from `toggle-read-only' and putting read-only properties on the *Occur* buffer is unacceptable. I'm used to run `flush-lines' and `keep-lines' to narrow the search results, but can't do this anymore. This is a regression. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 14 15:18:58 2011 Received: (at 8463) by debbugs.gnu.org; 14 Sep 2011 19:18:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R3uz2-0007JI-OG for submit@debbugs.gnu.org; Wed, 14 Sep 2011 15:18:57 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R3uyq-0007Iv-7L for 8463@debbugs.gnu.org; Wed, 14 Sep 2011 15:18:44 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id D212A6E8056; Wed, 14 Sep 2011 12:14:09 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id F1CCF451C47C; Wed, 14 Sep 2011 12:14:08 -0700 (PDT) From: Juri Linkov To: Leo Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Organization: JURTA References: <87k49i6izg.fsf@mail.jurta.org> Date: Wed, 14 Sep 2011 22:04:30 +0300 In-Reply-To: <87k49i6izg.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 09 Sep 2011 14:39:23 +0300") Message-ID: <87vcsvlzcx.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) There is 2011-06-18 ChangeLog entry added by revno:104628 without actual code changes: * replace.el (occur-mode-map): Set occur-edit-mode binding to "e". I guess it was supposed to bind "e" to `occur-edit-mode' in `occur-mode-map'? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 17 17:33:09 2011 Received: (at 8463) by debbugs.gnu.org; 17 Sep 2011 21:33:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R52VY-0002EM-FW for submit@debbugs.gnu.org; Sat, 17 Sep 2011 17:33:08 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R52VW-0002EF-DG for 8463@debbugs.gnu.org; Sat, 17 Sep 2011 17:33:07 -0400 Received: from furball (dhcp-128-36-14-81.central.yale.edu [128.36.14.81]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p8HLSDak029763 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 17 Sep 2011 17:28:14 -0400 From: Chong Yidong To: Juri Linkov Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: <87k49i6izg.fsf@mail.jurta.org> Date: Sat, 17 Sep 2011 17:28:13 -0400 In-Reply-To: <87k49i6izg.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 09 Sep 2011 14:39:23 +0300") Message-ID: <8762kqzwnm.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Juri Linkov writes: > But there is a greater drawback: stealing the `C-x C-q' keybinding > from `toggle-read-only' and putting read-only properties on the > *Occur* buffer is unacceptable. I'm used to run `flush-lines' and > `keep-lines' to narrow the search results, but can't do this anymore. > This is a regression. OK, I rebound occur-edit-mode to "e" and removed the read-only properties, with some additional code changes to make Occur Edit mode work without requiring read-only text. As for the other issue of single-char commands not being usable in non-read-only Occur mode, we could handle it in a way similar to diff mode (via minor-mode-overriding-map-alist), but that is for another day. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 17 17:33:28 2011 Received: (at control) by debbugs.gnu.org; 17 Sep 2011 21:33:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R52Vs-0002Eu-4z for submit@debbugs.gnu.org; Sat, 17 Sep 2011 17:33:28 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R52Vq-0002Eo-Qs for control@debbugs.gnu.org; Sat, 17 Sep 2011 17:33:27 -0400 Received: from furball (dhcp-128-36-14-81.central.yale.edu [128.36.14.81]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p8HLSYDX029852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Sat, 17 Sep 2011 17:28:34 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 8463 Date: Sat, 17 Sep 2011 17:28:34 -0400 Message-ID: <87aaa2hn99.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 8463 thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 15:39:52 2011 Received: (at 8463) by debbugs.gnu.org; 18 Sep 2011 19:39:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5NDT-0000sz-Nt for submit@debbugs.gnu.org; Sun, 18 Sep 2011 15:39:52 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5NDR-0000sq-Mz for 8463@debbugs.gnu.org; Sun, 18 Sep 2011 15:39:50 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 0A16D6E8065; Sun, 18 Sep 2011 12:34:52 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9A36E451C46A; Sun, 18 Sep 2011 12:34:50 -0700 (PDT) From: Juri Linkov To: Chong Yidong Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Organization: JURTA References: <87k49i6izg.fsf@mail.jurta.org> <8762kqzwnm.fsf@stupidchicken.com> Date: Sun, 18 Sep 2011 22:33:14 +0300 In-Reply-To: <8762kqzwnm.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 17 Sep 2011 17:28:13 -0400") Message-ID: <87ty8924l1.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > OK, I rebound occur-edit-mode to "e" and removed the read-only > properties, with some additional code changes to make Occur Edit mode > work without requiring read-only text. Thanks, this is fine now except one little problem: after finishing Occur-Edit, `g' (`revert-buffer') fails with "Wrong number of arguments: #[(regexp nlines bufs &optional buf-name)..." There is a fix in http://debbugs.gnu.org/8463#47 that makes `occur-revert-arguments' permanent-local. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 14:58:14 2011 Received: (at 8463) by debbugs.gnu.org; 19 Sep 2011 18:58:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5j2f-0007my-IK for submit@debbugs.gnu.org; Mon, 19 Sep 2011 14:58:14 -0400 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5j2X-0007mO-Oj for 8463@debbugs.gnu.org; Mon, 19 Sep 2011 14:58:07 -0400 Received: from furball (dhcp-128-36-169-222.central.yale.edu [128.36.169.222]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p8JIqwew026527 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 19 Sep 2011 14:52:58 -0400 From: Chong Yidong To: Juri Linkov Subject: Re: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer References: <87k49i6izg.fsf@mail.jurta.org> <8762kqzwnm.fsf@stupidchicken.com> <87ty8924l1.fsf@mail.jurta.org> Date: Mon, 19 Sep 2011 14:52:58 -0400 In-Reply-To: <87ty8924l1.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 18 Sep 2011 22:33:14 +0300") Message-ID: <871uvcweid.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 8463 Cc: 8463@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Juri Linkov writes: > Thanks, this is fine now except one little problem: > after finishing Occur-Edit, `g' (`revert-buffer') fails with > "Wrong number of arguments: #[(regexp nlines bufs &optional buf-name)..." > > There is a fix in http://debbugs.gnu.org/8463#47 > that makes `occur-revert-arguments' permanent-local. Ah, I somehow missed that patch. I will incorporate it. Thanks. From unknown Mon Sep 08 08:10:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 18 Oct 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator