From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: 24.0; Emacs does not apply additional custom faces from theme Resent-From: Christoph Scholtes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Apr 2011 03:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8454@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130232109119614 (code B ref -1); Sat, 09 Apr 2011 03:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 9 Apr 2011 03:51:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8PCs-00056J-JZ for submit@debbugs.gnu.org; Fri, 08 Apr 2011 23:51:31 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8PCp-000565-6X for submit@debbugs.gnu.org; Fri, 08 Apr 2011 23:51:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8PCi-0004w7-VS for submit@debbugs.gnu.org; Fri, 08 Apr 2011 23:51:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RFC_ABUSE_POST, T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:59041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8PCi-0004w1-SN for submit@debbugs.gnu.org; Fri, 08 Apr 2011 23:51:20 -0400 Received: from [140.186.70.92] (port=32945 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8PCh-0004PO-95 for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2011 23:51:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8PCf-0004vD-Ol for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2011 23:51:18 -0400 Received: from mail-iy0-f169.google.com ([209.85.210.169]:42819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8PCf-0004ur-Cj for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2011 23:51:17 -0400 Received: by iyf13 with SMTP id 13so5324667iyf.0 for ; Fri, 08 Apr 2011 20:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:from:to:subject:user-agent:date:message-id :mime-version:content-type; bh=nIOseb5wba/RhJlpxnIkailNZ+wlsYedDzgDp5TmWss=; b=yHhKOM5EHSPh/m8BqXmIHVxfhKxtKU7ew3Xz21QQZ/oYaL+sMEbKS7mxaWIkKgObbJ F69BBl8HtTgixhGBGl8Pe3dS4udhYVVXI6wbJ2CEkRDsLHl7YQcGHT7JFsd4nRp7lZS2 JK/1y4n1NnnaLInGLN7SP1BuCcbJly4RKeV78= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:subject:user-agent:date:message-id:mime-version :content-type; b=U1yV9U8FdTjPH+r7mZ1ehO/EKgbJWZGKaOTpQyMUlMm92PiFq+wD9EiPtBS5AySE8L 0QmbePnblswtlnsAugsrlSSNM6M9LsZ5UQiesHAjMPwLNy0sZrIlY2Es6NxyEay5di0y QxB3smQRUafo4JlChI+xuWP7Rltyb8Q1fyLws= Received: by 10.43.70.204 with SMTP id yh12mr3712253icb.430.1302321076152; Fri, 08 Apr 2011 20:51:16 -0700 (PDT) Received: from localhost (70-59-0-207.hlrn.qwest.net [70.59.0.207]) by mx.google.com with ESMTPS id i20sm2316063iby.14.2011.04.08.20.51.13 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Apr 2011 20:51:15 -0700 (PDT) From: Christoph Scholtes User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0 (windows-nt) Date: Fri, 08 Apr 2011 21:51:05 -0600 Message-ID: <867hb45bh2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) I downloaded a custom theme from elpa (http://elpa.gnu.org/themes/2lzrreXz) and added some faces at the bottom: ; erc '(erc-default-face ((t (:inherit default)))) '(erc-my-nick-face ((t (:inherit font-lock-variable-name-face)))) '(erc-current-nick-face ((t (:inherit font-lock-string-face)))) '(erc-input-face ((t (:inherit font-lock-type-face)))) '(erc-keyword-face ((t (:inherit font-lock-keyword-face)))) '(erc-timestamp-face ((t (:inherit font-lock-builtin-face)))) '(erc-notice-face ((t (:inherit font-lock-comment-face)))) These faces inherit their values from the faces set in the custom theme. The problem is, none of the custom faces for erc are actually applied. Emacs still has the original erc faces. In GNU Emacs 24.0.50 (i386-mingw-nt6.1.7600) of 2011-04-06 on MARVIN Windowing system distributor `Microsoft Corp.', version 6.1.7600 configured using `configure --with-gcc (4.5) --cflags -IC:/Progra~2/GnuWin32/include -ID:/devel/emacs/libXpm-3.5.8/include -ID:/devel/emacs/libXpm-3.5.8/src' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ENU value of $XMODIFIERS: nil locale-coding-system: cp1252 default enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: erc-list-mode: t erc-menu-mode: t erc-ring-mode: t erc-networks-mode: t erc-button-mode: t erc-fill-mode: t erc-netsplit-mode: t paredit-mode: t erc-autojoin-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-pcomplete-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t recentf-mode: t desktop-save-mode: t autopair-mode: t autopair-global-mode: t ido-everywhere: t yas/global-mode: t yas/minor-mode: t global-auto-revert-mode: t delete-selection-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t Recent input: C-e C-a C-x C-f p l u g t h e C-s C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-k C-k C-k C-x C-s C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-x RET C-g C-x C-f M-p M-p e r c e r c . e l C-v C-x RET l o a d e v a l - v u b u f f e r C-h v e r c - d e f f a f a C-g M-g M-g 1 1 3 9 C-h v e r c - h e a d e r - l i n e C-g C-h v e r c - i n p u t - f a C-g C-x k C-n C-n C-n C-n C-n C-n C-SPC C-SPC C-n C-n C-n C-n C-n C-n C-n C-n M-w C-x m c s u t o u s t o m - t e h e m e SPC n o t SPC e m a c s C-x k y C-x m r e p o r t C-x k y C-x RET r e p o r t Recent messages: Loading vc-bzr...done Disabling `erc-pcomplete' Quit Mark set Making completion list... Quit [2 times] Mark set Mark activated Auto-saving...done Buffer *unsent mail* modified; kill anyway? (y or n) y [2 times] Load-path shadows: c:/Users/Christoph/AppData/Roaming/.emacs.d/plugins/python hides d:/devel/emacs/emacs-bzr/trunk_readonly/lisp/progmodes/python Features: (shadow sort mail-extr emacsbug url-util url-parse url-vars gnus-cite gnus-msg gnus-art mm-uu mml2015 epg-config mm-view mml-smime smime dig mailcap vc-bzr tramp warnings tramp-compat auth-source eieio byte-opt bytecomp byte-compile cconv password-cache tramp-loaddefs vc-hg network-stream starttls tls erc-menu erc-ring comint ring erc-networks erc-button erc-fill erc-netsplit paredit my-zenburn-theme sha1 hex-util erc-join erc-track erc-match erc-pcomplete pcomplete erc-stamp erc-goodies erc erc-backend erc-compat thingatpt bookmark+ dired-x dired bookmark+-1 nnir gnus-sum macroexp nnoo gnus-group gnus-undo nnmail mail-source gnus-start gnus-spec gnus-int gnus-range message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus gnus-ems nnheader gnus-util time-date mail-utils mm-util mail-prsvr bookmark+-bmu help-mode view bookmark+-lit pp+ bookmark+-mac bookmark pp recentf tree-widget wid-edit midnight desktop ibuffer uniquify autopair cc-styles cc-align cc-engine cc-vars cc-defs browse-kill-ring+ browse-kill-ring second-sel ido yasnippet dropdown-list easymenu assoc org-install server advice advice-preload autorevert delsel tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32 disp-table ls-lisp w32-win w32-vars tool-bar dnd fontset image fringe edmacro kmacro lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock regexp-opt syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic ccl indian cyrillic chinese case-table epa-hook jka-cmpr-hook help help-macro simple derived abbrev minibuffer easy-mmode loaddefs button faces cus-face files help-fns text-properties overlay md5 base64 format env cl code-pages mule cus-start custom widget hashtable-print-readable backquote make-network-process multi-tty emacs) From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: deftheme, :inherit & overriding existing values Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 May 2011 19:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Christoph Scholtes Cc: 8454@debbugs.gnu.org, "Dirk-Jan C. Binnema" Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.130488240521434 (code B ref 8454); Sun, 08 May 2011 19:21:01 +0000 Received: (at 8454) by debbugs.gnu.org; 8 May 2011 19:20:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ9WP-0005Zf-1j for submit@debbugs.gnu.org; Sun, 08 May 2011 15:20:05 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ9WM-0005Z6-8M for 8454@debbugs.gnu.org; Sun, 08 May 2011 15:20:02 -0400 Received: from furball (dhcp128036225146.central.yale.edu [128.36.225.146]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p48JJumZ028190 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 8 May 2011 15:19:56 -0400 Received: by furball (Postfix, from userid 1000) id 313E4160603; Sun, 8 May 2011 15:19:56 -0400 (EDT) From: Chong Yidong References: <20110507091706.DC97939C792@djcbsoftware.nl> <4DC54D3D.7090409@gmail.com> Date: Sun, 08 May 2011 15:19:56 -0400 In-Reply-To: <4DC54D3D.7090409@gmail.com> (Christoph Scholtes's message of "Sat, 07 May 2011 07:46:37 -0600") Message-ID: <87r58980f7.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Christoph Scholtes writes: > On 5/7/2011 3:17 AM, Dirk-Jan C. Binnema wrote: > >> Overall it works well if I start the theme from my .emacs startup, >> but it works less well if I load a theme after some other >> packages. E.g., deftheme before wanderlust works, but not the other >> way around. > > [snip] > >> Apparently, :inherit does not really work as I expected... > > I think this might be similar behavior to what I reported here: > > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8454 I'm afraid both bug reports are too vague for me to figure out exactly what is supposed to be going wrong. Could someone provide a precise, step-by-step recipe for reproducing the problem? In the case of Christoph's report (Bug#8454), the statement "none of the custom faces for erc are actually applied" isn't specific, and when I tried to reproduce this, the buffer produced by M-x erc RET RET RET seems to display erc-default-face using the Zenburn default. A more precise description of the problem is needed. As for Dirk-Jan's report, it is very inconvenient to reference external packages like Wanderlust. Please provide a recipe using something in Emacs itself. From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: deftheme, :inherit & overriding existing values Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 May 2011 20:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Christoph Scholtes Cc: 8454@debbugs.gnu.org, "Dirk-Jan C. Binnema" Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.130488570326025 (code B ref 8454); Sun, 08 May 2011 20:16:02 +0000 Received: (at 8454) by debbugs.gnu.org; 8 May 2011 20:15:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJANa-0006lb-Ek for submit@debbugs.gnu.org; Sun, 08 May 2011 16:15:02 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJANY-0006lI-9g for 8454@debbugs.gnu.org; Sun, 08 May 2011 16:15:00 -0400 Received: from furball (dhcp128036225146.central.yale.edu [128.36.225.146]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p48KEsCB017080 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 8 May 2011 16:14:54 -0400 Received: by furball (Postfix, from userid 1000) id D88D0160603; Sun, 8 May 2011 16:14:53 -0400 (EDT) From: Chong Yidong References: <20110507091706.DC97939C792@djcbsoftware.nl> <4DC54D3D.7090409@gmail.com> <87r58980f7.fsf@stupidchicken.com> Date: Sun, 08 May 2011 16:14:53 -0400 In-Reply-To: <87r58980f7.fsf@stupidchicken.com> (Chong Yidong's message of "Sun, 08 May 2011 15:19:56 -0400") Message-ID: <87mxix7xvm.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Chong Yidong writes: > I'm afraid both bug reports are too vague for me to figure out exactly > what is supposed to be going wrong. Could someone provide a precise, > step-by-step recipe for reproducing the problem? OK, I found a bug in the case where defface is called after loading a theme with settings for that face. The defface settings were not being applied; I've checked a fix into the trunk. However, I'm not sure this is the issue you are talking about, since this bug was not specific to the :inherit property. Could you check if your problem is fixed? One possible source of confusion, which may apply to Dirk-Jan's report, is that :inherit only tells Emacs to consult the parent face if a face attribute is unspecified. If the attribute is specified, it overrides the inheritance. So if your Custom theme want to "cancel out", say, any existing foreground attribute setting, you need something like '(froob ((t (:foreground unspecified :inherit parent-face)))) From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: deftheme, :inherit & overriding existing values Resent-From: Dirk-Jan C. Binnema Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2011 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: Christoph Scholtes , 8454@debbugs.gnu.org Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.13049737094165 (code B ref 8454); Mon, 09 May 2011 20:42:02 +0000 Received: (at 8454) by debbugs.gnu.org; 9 May 2011 20:41:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJXH2-000158-CS for submit@debbugs.gnu.org; Mon, 09 May 2011 16:41:48 -0400 Received: from vs12.mail.saunalahti.fi ([195.197.172.107]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJXGz-00014t-PZ for 8454@debbugs.gnu.org; Mon, 09 May 2011 16:41:46 -0400 Received: from saunalahti-vams (localhost [127.0.0.1]) by vs12.mail.saunalahti.fi (Postfix) with SMTP id 8E53524003F; Mon, 9 May 2011 23:41:38 +0300 (EEST) Received: from vs12.mail.saunalahti.fi ([127.0.0.1]) by vs12.mail.saunalahti.fi ([195.197.172.107]) with SMTP (gateway) id A0501C8C574; Mon, 09 May 2011 23:41:38 +0300 Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi [195.197.172.115]) by vs12.mail.saunalahti.fi (Postfix) with ESMTP id 84FDD24003F; Mon, 9 May 2011 23:41:38 +0300 (EEST) Received: from djcbsoftware.nl (a88-112-253-18.elisa-laajakaista.fi [88.112.253.18]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by gw01.mail.saunalahti.fi (Postfix) with ESMTP id 2CD9715152E; Mon, 9 May 2011 23:41:34 +0300 (EEST) Received: from cthulhu.mindcrime.djcbsoftware.nl (cthulhu [127.0.0.1]) by djcbsoftware.nl (Postfix) with ESMTP id 4AFEE39C5D4; Mon, 9 May 2011 23:41:34 +0300 (EEST) Date: Mon, 09 May 2011 23:41:34 +0300 From: Dirk-Jan C. Binnema In-Reply-To: <87mxix7xvm.fsf@stupidchicken.com> References: <20110507091706.DC97939C792@djcbsoftware.nl> <4DC54D3D.7090409@gmail.com> <87r58980f7.fsf@stupidchicken.com> <87mxix7xvm.fsf@stupidchicken.com> Mail-Reply-To: djcb@djcbsoftware.nl User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/24.0 Mule/6.0 (HANACHIRUSATO) Organization: DJCBSoftware MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Message-Id: <20110509204134.4AFEE39C5D4@djcbsoftware.nl> X-Antivirus: VAMS X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) Hi, >>>>> On Sun, 08 May 2011 16:14:53 -0400, Chong Yidong ("CYD") wrote: CYD> Chong Yidong writes: >> I'm afraid both bug reports are too vague for me to figure out exactly >> what is supposed to be going wrong. Could someone provide a precise, >> step-by-step recipe for reproducing the problem? Sorry about the 'vagueness' - but glad you found it out anyhow. CYD> OK, I found a bug in the case where defface is called after loading a CYD> theme with settings for that face. The defface settings were not being CYD> applied; I've checked a fix into the trunk. However, I'm not sure this CYD> is the issue you are talking about, since this bug was not specific to CYD> the :inherit property. Could you check if your problem is fixed? No, it does solve the problem, but I guess below confirms my suspicion.. CYD> One possible source of confusion, which may apply to Dirk-Jan's report, CYD> is that :inherit only tells Emacs to consult the parent face if a face CYD> attribute is unspecified. If the attribute is specified, it overrides CYD> the inheritance. So if your Custom theme want to "cancel out", say, any CYD> existing foreground attribute setting, you need something like CYD> '(froob ((t (:foreground unspecified :inherit parent-face)))) Ok, yes that is what happens. I guess this could work, but in practice it makes :inherit rather suboptimal -- imagine switching from one theme to another, you'd have to explicitly cancel out every attribute the other theme may have set. Best wishes, Dirk. -- Dirk-Jan C. Binnema Helsinki, Finland e:djcb@djcbsoftware.nl w:www.djcbsoftware.nl pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: deftheme, :inherit & overriding existing values Resent-From: Christoph Scholtes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 May 2011 03:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: 8454@debbugs.gnu.org, "Dirk-Jan C. Binnema" Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.130499752810102 (code B ref 8454); Tue, 10 May 2011 03:19:02 +0000 Received: (at 8454) by debbugs.gnu.org; 10 May 2011 03:18:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJdTD-0002ct-JW for submit@debbugs.gnu.org; Mon, 09 May 2011 23:18:47 -0400 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJdTB-0002ch-9e for 8454@debbugs.gnu.org; Mon, 09 May 2011 23:18:46 -0400 Received: by iwn39 with SMTP id 39so5104393iwn.3 for <8454@debbugs.gnu.org>; Mon, 09 May 2011 20:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=QrA2AcI6jU6/NYCJU8GMuWqYbCsYqjax00vfKHGpUVU=; b=RzBhjJoGtLpq+w/49QxyAz8gjBTS7jbuFz+E5pAjsS1iTAloNpAnQv/H1xMRYg5yCE +BdQcVQI1eoM8u7vhr8tCZ6NV3RbKUdYcdaAeFCGWQbnLevp4CRk+KmNRxGZ24UOVNfD b5kOyj93nJYziHmURM0CDMD6744PfW4LKLkR0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=jJD2kXTB+FB0NIH8RGgi14nKReKhOfqwxHMY7XrKTbUuECuNKINeowhWazzcL3YGiv qGTjZg9WZSPRYXN+pHqgAjT9Ti1rbzLcgOIjxdY3Vtze14+2HAsSCZSWuMtKBuolqWPb JgqBYMNxyRgTA28wx1LOrz2Zj9xAddR9geRHY= Received: by 10.42.29.137 with SMTP id r9mr753078icc.227.1304997519217; Mon, 09 May 2011 20:18:39 -0700 (PDT) Received: from [192.168.1.4] (70-59-12-84.hlrn.qwest.net [70.59.12.84]) by mx.google.com with ESMTPS id gx2sm2908154ibb.26.2011.05.09.20.18.32 (version=SSLv3 cipher=OTHER); Mon, 09 May 2011 20:18:38 -0700 (PDT) Message-ID: <4DC8AE81.5070704@gmail.com> Date: Mon, 09 May 2011 21:18:25 -0600 From: Christoph Scholtes User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 References: <20110507091706.DC97939C792@djcbsoftware.nl> <4DC54D3D.7090409@gmail.com> <87r58980f7.fsf@stupidchicken.com> <87mxix7xvm.fsf@stupidchicken.com> In-Reply-To: <87mxix7xvm.fsf@stupidchicken.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.8 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.4 (----) On 5/8/2011 2:14 PM, Chong Yidong wrote: > OK, I found a bug in the case where defface is called after loading a > theme with settings for that face. The defface settings were not being > applied; I've checked a fix into the trunk. However, I'm not sure this > is the issue you are talking about, since this bug was not specific to > the :inherit property. Could you check if your problem is fixed? > > One possible source of confusion, which may apply to Dirk-Jan's report, > is that :inherit only tells Emacs to consult the parent face if a face > attribute is unspecified. If the attribute is specified, it overrides > the inheritance. So if your Custom theme want to "cancel out", say, any > existing foreground attribute setting, you need something like > > '(froob ((t (:foreground unspecified :inherit parent-face)))) This did not fix it for me. I think Dirk-Jan and I have the same issue, though, which is the behavior of :inherit. One example from my custom theme: '(erc-default-face ((t (:inherit default)))) This is supposed to inherit from '(default ((t (:background "#3f3f3f" :foreground "#dcdccc")))) but it does not work. This is probably related to what you describe above, but I don't really understand it. foregound in erc-default-face is unspecified, right? Should the inherit get the attributes from default or not? I figured out a way to make my custom theme work, though. Loading it through customize does not work, but if I open the theme file and eval the buffer, it works and erc shows the my custom faces. Maybe this helps to troubleshoot the problem? Christoph From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: deftheme, :inherit & overriding existing values Resent-From: Dirk-Jan C. Binnema Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 May 2011 04:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Christoph Scholtes Cc: 8454@debbugs.gnu.org, Chong Yidong Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.130526222131731 (code B ref 8454); Fri, 13 May 2011 04:51:01 +0000 Received: (at 8454) by debbugs.gnu.org; 13 May 2011 04:50:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QKkKT-0008Fk-B2 for submit@debbugs.gnu.org; Fri, 13 May 2011 00:50:21 -0400 Received: from vs11.mail.saunalahti.fi ([195.197.172.106]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QKkKP-0008FV-1Z for 8454@debbugs.gnu.org; Fri, 13 May 2011 00:50:18 -0400 Received: from saunalahti-vams (localhost [127.0.0.1]) by vs11.mail.saunalahti.fi (Postfix) with SMTP id 85211C0041; Fri, 13 May 2011 07:50:10 +0300 (EEST) Received: from vs11.mail.saunalahti.fi ([127.0.0.1]) by vs11.mail.saunalahti.fi ([195.197.172.106]) with SMTP (gateway) id A0302A82B43; Fri, 13 May 2011 07:50:10 +0300 Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi [195.197.172.116]) by vs11.mail.saunalahti.fi (Postfix) with ESMTP id 7C55AC0041; Fri, 13 May 2011 07:50:10 +0300 (EEST) Received: from djcbsoftware.nl (a88-112-253-18.elisa-laajakaista.fi [88.112.253.18]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by gw02.mail.saunalahti.fi (Postfix) with ESMTP id 3FCBD13951A; Fri, 13 May 2011 07:50:06 +0300 (EEST) Received: from cthulhu.mindcrime.djcbsoftware.nl (cthulhu [127.0.0.1]) by djcbsoftware.nl (Postfix) with ESMTP id D91E339C792; Fri, 13 May 2011 07:50:05 +0300 (EEST) Date: Fri, 13 May 2011 07:50:05 +0300 From: Dirk-Jan C. Binnema In-Reply-To: <4DC8AE81.5070704@gmail.com> References: <20110507091706.DC97939C792@djcbsoftware.nl> <4DC54D3D.7090409@gmail.com> <87r58980f7.fsf@stupidchicken.com> <87mxix7xvm.fsf@stupidchicken.com> <4DC8AE81.5070704@gmail.com> Mail-Reply-To: djcb@djcbsoftware.nl User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/24.0 Mule/6.0 (HANACHIRUSATO) Organization: DJCBSoftware MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Message-Id: <20110513045005.D91E339C792@djcbsoftware.nl> X-Antivirus: VAMS X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) Hi, >>>>> On Mon, 09 May 2011 21:18:25 -0600, Christoph Scholtes ("CS") wrote: CS> On 5/8/2011 2:14 PM, Chong Yidong wrote: >> OK, I found a bug in the case where defface is called after loading a >> theme with settings for that face. The defface settings were not being >> applied; I've checked a fix into the trunk. However, I'm not sure this >> is the issue you are talking about, since this bug was not specific to >> the :inherit property. Could you check if your problem is fixed? >> >> One possible source of confusion, which may apply to Dirk-Jan's report, >> is that :inherit only tells Emacs to consult the parent face if a face >> attribute is unspecified. If the attribute is specified, it overrides >> the inheritance. So if your Custom theme want to "cancel out", say, any >> existing foreground attribute setting, you need something like >> >> '(froob ((t (:foreground unspecified :inherit parent-face)))) CS> This did not fix it for me. CS> I think Dirk-Jan and I have the same issue, though, which is the CS> behavior of :inherit. Yes -- in fact, before this change, the theme would look as expected if I loaded it before - say - Wanderlust. However, with this change, that does not work either anymore. CS> One example from my custom theme: CS> '(erc-default-face ((t (:inherit default)))) CS> This is supposed to inherit from CS> '(default ((t (:background "#3f3f3f" :foreground "#dcdccc")))) CS> but it does not work. CS> This is probably related to what you describe above, but I don't CS> really understand it. foregound in erc-default-face is unspecified, CS> right? Should the inherit get the attributes from default or not? CS> I figured out a way to make my custom theme work, though. Loading it CS> through customize does not work, but if I open the theme file and eval CS> the buffer, it works and erc shows the my custom faces. Maybe this CS> helps to troubleshoot the problem? Yes, indeed, that is what I do too now: (defun zenburn() (interactive) (load-theme 'zenburn) (load-library "~/.emacs.d/elisp/themes/zenburn-theme.el")) In general, it might make sense to first go back to 'factory settings' before changing the theme, as it's quite unlikely that theme2 always overrides everything from theme1 -- e.g. zenburn redefines hundreds of faces. Best wishes, Dirk. -- Dirk-Jan C. Binnema Helsinki, Finland e:djcb@djcbsoftware.nl w:www.djcbsoftware.nl pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: I can't reproduce this References: <867hb45bh2.fsf@gmail.com> In-Reply-To: <867hb45bh2.fsf@gmail.com> Resent-From: Dave Abrahams Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Oct 2011 17:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8454@debbugs.gnu.org Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.131938922510761 (code B ref 8454); Sun, 23 Oct 2011 17:01:01 +0000 Received: (at 8454) by debbugs.gnu.org; 23 Oct 2011 17:00:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RI1PM-0002nW-TS for submit@debbugs.gnu.org; Sun, 23 Oct 2011 13:00:25 -0400 Received: from mail-qw0-f44.google.com ([209.85.216.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RI1PK-0002nI-OK for 8454@debbugs.gnu.org; Sun, 23 Oct 2011 13:00:23 -0400 Received: by qadc10 with SMTP id c10so1904059qad.3 for <8454@debbugs.gnu.org>; Sun, 23 Oct 2011 09:58:50 -0700 (PDT) Received: by 10.224.213.197 with SMTP id gx5mr16879605qab.34.1319389130650; Sun, 23 Oct 2011 09:58:50 -0700 (PDT) Received: from pluto.luannocracy.com (207-172-223-249.c3-0.smr-ubr3.sbo-smr.ma.static.cable.rcn.com. [207.172.223.249]) by mx.google.com with ESMTPS id l20sm196112qal.21.2011.10.23.09.58.49 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 23 Oct 2011 09:58:49 -0700 (PDT) Received: by pluto.luannocracy.com (Postfix, from userid 501) id A9DE81197AC1; Sun, 23 Oct 2011 12:58:48 -0400 (EDT) From: Dave Abrahams Date: Sun, 23 Oct 2011 12:58:48 -0400 Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.3 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) --=-=-= Content-Type: text/plain In emacs 23.3, I tried to build a minimal test case that would exhibit some of the problems cited here, and failed. What I wrote is below, and loading it with `emacs -Q -l test.el' seems to produce the expected results. If there *is* a real problem, it seems to me, some simple variation on this code should show it. --=-=-= Content-Type: text/emacs-lisp Content-Disposition: inline; filename=test.el Content-Description: test.el ;; define a couple of faces to be used in the theme (defface face1 '((t :background "pink")) "first test face") (defface face2 '((t :background "yellow")) "second test face") ;; simulate (load 'theme1) (deftheme theme1 "1st test theme") (custom-theme-set-faces 'theme1 '(face2 ((t (:slant italic :inherit (face1))))) '(face3 ((t (:background "yellow")))) '(face4 ((t (:inherit (face3)))))) (provide-theme 'theme1) ;; done loading theme1 ;; define some more faces used in the theme (defface face3 '((t :background "pink")) "3rd test face") (defface face4 '((t :slant italic)) "4th test face") ;; inspect the faces (setq inhibit-startup-screen t) (customize-apropos-faces "^face[0-9]") --=-=-=-- From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: Themes can't work right due to design References: <867hb45bh2.fsf@gmail.com> In-Reply-To: <867hb45bh2.fsf@gmail.com> Resent-From: Chris Hanson Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2011 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8454@debbugs.gnu.org Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.132310519716632 (code B ref 8454); Mon, 05 Dec 2011 17:14:02 +0000 Received: (at 8454) by debbugs.gnu.org; 5 Dec 2011 17:13:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXc6O-0004KC-1I for submit@debbugs.gnu.org; Mon, 05 Dec 2011 12:13:16 -0500 Received: from mail-qy0-f172.google.com ([209.85.216.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXSS5-000507-5L for 8454@debbugs.gnu.org; Mon, 05 Dec 2011 01:55:01 -0500 Received: by qcsf15 with SMTP id f15so1259085qcs.3 for <8454@debbugs.gnu.org>; Sun, 04 Dec 2011 22:54:30 -0800 (PST) Received: by 10.224.31.66 with SMTP id x2mr6826054qac.27.1323068070164; Sun, 04 Dec 2011 22:54:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.124.136 with HTTP; Sun, 4 Dec 2011 22:54:09 -0800 (PST) From: Chris Hanson Date: Sun, 4 Dec 2011 22:54:09 -0800 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -3.6 (---) X-Mailman-Approved-At: Mon, 05 Dec 2011 12:13:14 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) I've just started using Emacs 24 (pretest 3), and have run into problems getting Zenburn to work right. Previously in Emacs 23 I used the color-theme package and a zenburn theme designed for that package. It needed a little tweaking but is otherwise fine. In Emacs 24, using custom-theme and a similar zenburn theme designed for that package, I'm having trouble getting the theme to work properly. I believe there are two underlying problems causing this behavior. The first is that :inherit isn't very useful as a way to say "make the current face like the specified one". Because color-theme clobbers face-defface-spec, it effectively erases any previous face settings, so that the theme settings are self-contained. There is no equivalent way to do this with custom-theme, which has led me to write things like `(font-lock-type-face ,zenburn-primary-3) rather than `(font-lock-type-face ((t (:inherit zenburn-primary-3)))) . This works but is somewhat unsatisfying. The second is that a face attribute that's explicitly set can't be overridden by a custom theme, for reasons I'm not completely clear on. For example, "cc-fonts.el" contains (set-face-foreground 'c-annotation-face "blue") and the theme doesn't seem to be able to override this foreground under any circumstances, even with an explicitly set :foreground attribute. This just seems like a bug. I'll probably just go back to using color-theme, since at least it works. I was hoping that Emacs 24 would allow me get good behavior without it, but alas... Let me know if you need help debugging anything. From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: Themes can't work right due to design Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2011 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Chris Hanson'" , <8454@debbugs.gnu.org> Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.132310757723112 (code B ref 8454); Mon, 05 Dec 2011 17:53:02 +0000 Received: (at 8454) by debbugs.gnu.org; 5 Dec 2011 17:52:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXcim-00060j-FR for submit@debbugs.gnu.org; Mon, 05 Dec 2011 12:52:56 -0500 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXcij-00060Z-CJ for 8454@debbugs.gnu.org; Mon, 05 Dec 2011 12:52:53 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id pB5HqHLb027424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 5 Dec 2011 17:52:18 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id pB5HqGtS025999 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 5 Dec 2011 17:52:17 GMT Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id pB5HqAxM017249; Mon, 5 Dec 2011 11:52:10 -0600 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 05 Dec 2011 09:52:10 -0800 From: "Drew Adams" References: <867hb45bh2.fsf@gmail.com> Date: Mon, 5 Dec 2011 09:52:10 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Acyzc09NQxVGWHcETX+SSOC4Sea3bwAAh0Ag X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090203.4EDD04D2.00CB,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.2 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > :inherit isn't very useful as a way to say "make the > current face like the specified one". +1. It's a sledge hammer, and it is way overused (& increasingly so). (Just one opinion.) See also http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg00067.html From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: Themes can't work right due to design Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2011 19:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chris Hanson Cc: 8454@debbugs.gnu.org Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.132311185229565 (code B ref 8454); Mon, 05 Dec 2011 19:05:02 +0000 Received: (at 8454) by debbugs.gnu.org; 5 Dec 2011 19:04:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXdph-0007gm-VS for submit@debbugs.gnu.org; Mon, 05 Dec 2011 14:04:11 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXdpg-0007gf-6t for 8454@debbugs.gnu.org; Mon, 05 Dec 2011 14:04:09 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id pB5J3WN7021316; Mon, 5 Dec 2011 14:03:32 -0500 Received: by pastel.home (Postfix, from userid 20848) id 0F4025938C; Mon, 5 Dec 2011 14:03:32 -0500 (EST) From: Stefan Monnier Message-ID: References: <867hb45bh2.fsf@gmail.com> Date: Mon, 05 Dec 2011 14:03:32 -0500 In-Reply-To: (Chris Hanson's message of "Sun, 4 Dec 2011 22:54:09 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4062=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4062> : streams <708067> : uri <1022312> X-Spam-Score: -4.5 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) > The first is that :inherit isn't very useful as a way to say "make the > current face like the specified one". Because color-theme clobbers > face-defface-spec, it effectively erases any previous face settings, > so that the theme settings are self-contained. There is no equivalent > way to do this with custom-theme, which has led me to write things > like `(font-lock-type-face ,zenburn-primary-3) rather than > `(font-lock-type-face ((t (:inherit zenburn-primary-3)))) . This > works but is somewhat unsatisfying. I don't really understand the problem here, probably because I'm not sufficiently versed in themes, but just in case, you may want to give a more specific example of what behavior you're trying to get, what you tried (presumably something like ((t (:inherit foo)))) and what you don't like about the resulting behavior. > The second is that a face attribute that's explicitly set can't be > overridden by a custom theme, for reasons I'm not completely clear on. That's the way the interaction between custom settings and Lisp settings are defined, because it seems like the only "sane" way to handle it. > For example, "cc-fonts.el" contains (set-face-foreground > 'c-annotation-face "blue") Probably something that should be fixed. Stefan From unknown Sat Aug 16 19:22:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8454: Themes can't work right due to design Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Dec 2011 02:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 8454@debbugs.gnu.org, Chris Hanson Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.13231382199491 (code B ref 8454); Tue, 06 Dec 2011 02:24:01 +0000 Received: (at 8454) by debbugs.gnu.org; 6 Dec 2011 02:23:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXkgz-0002T1-R0 for submit@debbugs.gnu.org; Mon, 05 Dec 2011 21:23:38 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXkgx-0002Sp-3I for 8454@debbugs.gnu.org; Mon, 05 Dec 2011 21:23:36 -0500 Received: from bb121-6-69-237.singnet.com.sg ([121.6.69.237]:52381 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1RXkgN-0008Vg-1Q; Mon, 05 Dec 2011 21:22:59 -0500 From: Chong Yidong References: <867hb45bh2.fsf@gmail.com> Date: Tue, 06 Dec 2011 10:22:46 +0800 In-Reply-To: (Stefan Monnier's message of "Mon, 05 Dec 2011 14:03:32 -0500") Message-ID: <87pqg2v3pl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Stefan Monnier writes: >> For example, "cc-fonts.el" contains (set-face-foreground >> 'c-annotation-face "blue") > > Probably something that should be fixed. I've committed a fix for this. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 21:02:01 2012 Received: (at control) by debbugs.gnu.org; 29 Jan 2012 02:02:01 +0000 Received: from localhost ([127.0.0.1]:42701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrK5e-0006j8-Rw for submit@debbugs.gnu.org; Sat, 28 Jan 2012 21:02:00 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:53064 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RrK5c-0006j1-7I for control@debbugs.gnu.org; Sat, 28 Jan 2012 21:01:56 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RrK5b-0001Vv-2M for control@debbugs.gnu.org; Sat, 28 Jan 2012 21:01:55 -0500 Date: Sat, 28 Jan 2012 21:01:55 -0500 Message-Id: Subject: control message for bug 10630 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) merge 8454 10630