From unknown Wed Jun 25 09:06:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8450 <8450@debbugs.gnu.org> To: bug#8450 <8450@debbugs.gnu.org> Subject: Status: 23.2.1 fails to start on GNU/Hurd due to bogus code in term.c Reply-To: bug#8450 <8450@debbugs.gnu.org> Date: Wed, 25 Jun 2025 16:06:23 +0000 retitle 8450 23.2.1 fails to start on GNU/Hurd due to bogus code in term.c reassign 8450 emacs submitter 8450 svante.signell@telia.com severity 8450 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 08 12:17:00 2011 Received: (at submit) by debbugs.gnu.org; 8 Apr 2011 16:17:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8EMm-0003tA-2Z for submit@debbugs.gnu.org; Fri, 08 Apr 2011 12:17:00 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q88yw-0003kp-69 for submit@debbugs.gnu.org; Fri, 08 Apr 2011 06:32:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q88yq-0000ec-ES for submit@debbugs.gnu.org; Fri, 08 Apr 2011 06:31:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:44323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q88yq-0000eO-8x for submit@debbugs.gnu.org; Fri, 08 Apr 2011 06:31:56 -0400 Received: from [140.186.70.92] (port=34753 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q88yl-0005g1-Cs for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2011 06:31:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q88yi-0000dM-6J for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2011 06:31:49 -0400 Received: from smtp-out21.han.skanova.net ([195.67.226.208]:45412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q88yh-0000d6-UZ for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2011 06:31:48 -0400 Received: from [130.237.20.66] (130.237.20.66) by smtp-out21.han.skanova.net (8.5.133) (authenticated as u84406617) id 4D6517A10115EE4C; Fri, 8 Apr 2011 12:31:45 +0200 Subject: 23.2.1 fails to start on GNU/Hurd due to bogus code in term.c From: Svante Signell To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Organization: Hemma Date: Fri, 08 Apr 2011 12:31:45 +0200 Message-ID: <1302258705.32453.187.camel@s1499.it.kth.se> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 08 Apr 2011 12:16:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: svante.signell@telia.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Starting Debian emacs 23.2+1-7 in non-window system mode on GNU/Hurd fails due to bogus code: #:~ emacs -nw emacs: Not a tty device: /dev/tty src/term.c: #ifdef O_IGNORE_CTTY if (!ctty) /* Open the terminal device. Don't recognize it as our controlling terminal, and don't make it the controlling tty if we don't have one at the moment. */ fd = emacs_open (name, O_RDWR | O_IGNORE_CTTY | O_NOCTTY, 0); else #else /* Alas, O_IGNORE_CTTY is a GNU extension that seems to be only defined on Hurd. On other systems, we need to explicitly dissociate ourselves from the controlling tty when we want to open a frame on the same terminal. */ fd = emacs_open (name, O_RDWR | O_NOCTTY, 0); #endif /* O_IGNORE_CTTY */ tty->name = xstrdup (name); When O_IGNORE_CTTY is defined (which is the case only on GNU/Hurd...), the else branch is actually tty->name = xstrdup(name); ... The obvious fix is attached (provided by Samuel Thibault) --- src/term.c.orig 2011-01-20 02:14:50.000000000 +0100 +++ src/term.c 2011-01-20 02:15:43.000000000 +0100 @@ -3428,13 +3428,12 @@ init_tty (char *name, char *terminal_typ if we don't have one at the moment. */ fd = emacs_open (name, O_RDWR | O_IGNORE_CTTY | O_NOCTTY, 0); else -#else +#endif /* O_IGNORE_CTTY */ /* Alas, O_IGNORE_CTTY is a GNU extension that seems to be only defined on Hurd. On other systems, we need to explicitly dissociate ourselves from the controlling tty when we want to open a frame on the same terminal. */ fd = emacs_open (name, O_RDWR | O_NOCTTY, 0); -#endif /* O_IGNORE_CTTY */ tty->name = xstrdup (name); terminal->name = xstrdup (name); Is this fixed in 23.3 already? GNU Emacs 23.2.1 (i486-pc-gnu) of 2011-01-20 on kvm-hurd, modified by Debian From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 08 14:46:21 2011 Received: (at 8450) by debbugs.gnu.org; 8 Apr 2011 18:46:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8GhG-0000ba-6v for submit@debbugs.gnu.org; Fri, 08 Apr 2011 14:46:21 -0400 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8GhD-0000bI-9N for 8450@debbugs.gnu.org; Fri, 08 Apr 2011 14:46:15 -0400 Received: from furball (dhcp128036014187.central.yale.edu [128.36.14.187]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p38Ik7I5020122 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 8 Apr 2011 14:46:09 -0400 Received: by furball (Postfix, from userid 1000) id 726F11604EB; Fri, 8 Apr 2011 14:46:07 -0400 (EDT) From: Chong Yidong To: svante.signell@telia.com Subject: Re: bug#8450: 23.2.1 fails to start on GNU/Hurd due to bogus code in term.c References: <1302258705.32453.187.camel@s1499.it.kth.se> Date: Fri, 08 Apr 2011 14:46:07 -0400 In-Reply-To: <1302258705.32453.187.camel@s1499.it.kth.se> (Svante Signell's message of "Fri, 08 Apr 2011 12:31:45 +0200") Message-ID: <87mxk0oa34.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 8450 Cc: 8450@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Svante Signell writes: > When O_IGNORE_CTTY is defined (which is the case only on GNU/Hurd...), > the else branch is actually tty->name = xstrdup(name); ... The obvious > fix is attached (provided by Samuel Thibault) Thanks, committed. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 08 14:46:39 2011 Received: (at control) by debbugs.gnu.org; 8 Apr 2011 18:46:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8Ghb-0000cC-JY for submit@debbugs.gnu.org; Fri, 08 Apr 2011 14:46:39 -0400 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8Gha-0000bz-1a for control@debbugs.gnu.org; Fri, 08 Apr 2011 14:46:38 -0400 Received: from furball (dhcp128036014187.central.yale.edu [128.36.14.187]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id p38IkWhj024419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Fri, 8 Apr 2011 14:46:32 -0400 Received: by furball (Postfix, from userid 1000) id A78411604EB; Fri, 8 Apr 2011 14:46:32 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 8450 Date: Fri, 08 Apr 2011 14:46:32 -0400 Message-ID: <87aag0h987.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) merge 8450 8451 close 8450 thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 09 13:19:00 2011 Received: (at control) by debbugs.gnu.org; 9 Apr 2011 17:19:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8boK-0007AQ-Dp for submit@debbugs.gnu.org; Sat, 09 Apr 2011 13:19:00 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8bo2-0007A0-FI for control@debbugs.gnu.org; Sat, 09 Apr 2011 13:18:59 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Q8bnw-0007Et-Oz for control@debbugs.gnu.org; Sat, 09 Apr 2011 13:18:36 -0400 Date: Sat, 09 Apr 2011 13:18:36 -0400 Message-Id: Subject: control message for bug 8455 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) forcemerge 8450 8455 From unknown Wed Jun 25 09:06:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 08 May 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator