From unknown Tue Jun 24 15:38:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8447 <8447@debbugs.gnu.org> To: bug#8447 <8447@debbugs.gnu.org> Subject: Status: Undoing M-x revert-buffer Reply-To: bug#8447 <8447@debbugs.gnu.org> Date: Tue, 24 Jun 2025 22:38:36 +0000 retitle 8447 Undoing M-x revert-buffer reassign 8447 emacs submitter 8447 Hrvoje Nik=C5=A1i=C4=87 severity 8447 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 08 12:16:09 2011 Received: (at submit) by debbugs.gnu.org; 8 Apr 2011 16:16:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8ELo-0003qs-7R for submit@debbugs.gnu.org; Fri, 08 Apr 2011 12:16:09 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8E12-0003M6-T4 for submit@debbugs.gnu.org; Fri, 08 Apr 2011 11:54:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8E0w-0007Dy-TX for submit@debbugs.gnu.org; Fri, 08 Apr 2011 11:54:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:47718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8E0w-0007Dr-KJ for submit@debbugs.gnu.org; Fri, 08 Apr 2011 11:54:26 -0400 Received: from [140.186.70.92] (port=56415 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8E0u-0003Fd-VA for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2011 11:54:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8E0s-0007Bk-Tj for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2011 11:54:24 -0400 Received: from mail-yx0-f169.google.com ([209.85.213.169]:52734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8E0s-0007BP-QK for bug-gnu-emacs@gnu.org; Fri, 08 Apr 2011 11:54:22 -0400 Received: by yxt33 with SMTP id 33so1802382yxt.0 for ; Fri, 08 Apr 2011 08:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=bhAoQ1Ylma1/nBMqLs/gWoF7IGZ2YGaCALSjArcjCyc=; b=Nih0fKvvKgugcFlU4Tek92h6WKyiaiGppSB5CiHamVanPVlbYmK1O9oLeHmE00me7Z M9Qa5m/5YHnUXd+QaIuO2Ql0hwaL0+V9MOH9xRmgmH8npduJwNi3Jnc75RfKI2ecJJOp WcKhOCgnqg3domEXu2CCXrwZwVcaqRptVqlh0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=lux+4xGMFVZeRcUQ5220LsvZKw2qWkmi0V+sDn/5zJvMS1FrN0RYnoBRORc3U9YiDg 1YLrlF9+Cw0NmPsrdX0mTgPSjJgZrSMESDeDW69mdu3BYBB2G33yYQTLu1Xt3KxJaNDS XZamQfPTzh7whN4bRbzVv62XYR+gRMoBsWmaQ= MIME-Version: 1.0 Received: by 10.91.69.37 with SMTP id w37mr2116896agk.196.1302278061676; Fri, 08 Apr 2011 08:54:21 -0700 (PDT) Received: by 10.90.63.17 with HTTP; Fri, 8 Apr 2011 08:54:21 -0700 (PDT) Date: Fri, 8 Apr 2011 17:54:21 +0200 Message-ID: Subject: Undoing M-x revert-buffer From: =?UTF-8?B?SHJ2b2plIE5pa8WhacSH?= To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 08 Apr 2011 12:15:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) It would be nice to be able to undo a revert-buffer operation. I've just had a situation where I used M-x revert-buffer, and immediately wanted to see the old version again. (I wanted to briefly compare the old and new contents, which only differed in several characters.) I routinely pressed C-_, and got a "no undo data" message in the echo area. For the shortest instant I was surprised, but I quickly remembered that M-x revert-buffer clears the undo stack, and that it has always worked that way. But I would like to question this design choice. What I wanted to do was not really unreasonable. The buffer held several kilobytes of data, and my computer has gigabytes of memory at its disposal, enough room to hold the buffer contents literally a million times over. If you think about it, reverting an existing buffer is just another operation on buffer text, not that different than M-x erase-buffer followed by M-x insert-file, which would happily remember everything. If the maintainers agree in principle, I'd like to look into patching revert-buffer so it records the revert as it would any other change to the buffer text. Hrvoje From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 08 21:50:05 2011 Received: (at 8447) by debbugs.gnu.org; 9 Apr 2011 01:50:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8NJN-0002T1-1I for submit@debbugs.gnu.org; Fri, 08 Apr 2011 21:50:05 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8NJL-0002SV-FF for 8447@debbugs.gnu.org; Fri, 08 Apr 2011 21:50:03 -0400 Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:52816 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1Q8NJF-0007IR-S1; Fri, 08 Apr 2011 21:49:58 -0400 Received: by ceviche.home (Postfix, from userid 20848) id D3985660B0; Fri, 8 Apr 2011 21:49:54 -0400 (EDT) From: Stefan Monnier To: Hrvoje =?utf-8?B?TmlrxaFpxIc=?= Subject: Re: bug#8447: Undoing M-x revert-buffer Message-ID: References: Date: Fri, 08 Apr 2011 22:49:54 -0300 In-Reply-To: ("Hrvoje =?utf-8?B?TmlrxaFpxIciJ3M=?= message of "Fri, 8 Apr 2011 17:54:21 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 8447 Cc: 8447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) > It would be nice to be able to undo a revert-buffer operation. So do I. I've been using a local patch to do that, actually. IIRC back when I wrote it, RMS opposed the change. I think my change only affected the "revert while keeping the same major-mode" such as the revert performed silently by auto-revert-mode and VC operations. It has bit-rotted somewhat, but I remember that the current code works hard at forgetting the undo data (it does it once at the Lisp level and another time inside insert-file-contents). Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 12 00:25:59 2011 Received: (at submit) by debbugs.gnu.org; 12 Apr 2011 04:25:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q9VAt-0001tV-CE for submit@debbugs.gnu.org; Tue, 12 Apr 2011 00:25:59 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q9VAq-0001tK-Ui for submit@debbugs.gnu.org; Tue, 12 Apr 2011 00:25:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9VAl-0004re-2u for submit@debbugs.gnu.org; Tue, 12 Apr 2011 00:25:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from [140.186.70.17] (port=59960 helo=lists.gnu.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9VAl-0004rY-0V for submit@debbugs.gnu.org; Tue, 12 Apr 2011 00:25:51 -0400 Received: from eggs.gnu.org ([140.186.70.92]:41431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9VAk-00047O-6l for bug-gnu-emacs@gnu.org; Tue, 12 Apr 2011 00:25:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9VAj-0004r3-DR for bug-gnu-emacs@gnu.org; Tue, 12 Apr 2011 00:25:50 -0400 Received: from lo.gmane.org ([80.91.229.12]:37160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9VAj-0004qh-6E for bug-gnu-emacs@gnu.org; Tue, 12 Apr 2011 00:25:49 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Q9VAe-0005Hc-Fp for bug-gnu-emacs@gnu.org; Tue, 12 Apr 2011 06:25:45 +0200 Received: from c-24-8-96-241.hsd1.co.comcast.net ([24.8.96.241]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 12 Apr 2011 06:25:44 +0200 Received: from kevin.d.rodgers by c-24-8-96-241.hsd1.co.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 12 Apr 2011 06:25:44 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Kevin Rodgers Subject: Re: bug#8447: Undoing M-x revert-buffer Date: Mon, 11 Apr 2011 22:25:39 -0600 Lines: 30 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: c-24-8-96-241.hsd1.co.comcast.net User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) On 4/8/11 9:54 AM, Hrvoje Nikšić wrote: > It would be nice to be able to undo a revert-buffer operation. > > I've just had a situation where I used M-x revert-buffer, and > immediately wanted to see the old version again. (I wanted to briefly > compare the old and new contents, which only differed in several > characters.) I routinely pressed C-_, and got a "no undo data" message > in the echo area. For the shortest instant I was surprised, but I > quickly remembered that M-x revert-buffer clears the undo stack, and > that it has always worked that way. > > But I would like to question this design choice. What I wanted to do > was not really unreasonable. The buffer held several kilobytes of data, > and my computer has gigabytes of memory at its disposal, enough room to > hold the buffer contents literally a million times over. If you think > about it, reverting an existing buffer is just another operation on > buffer text, not that different than M-x erase-buffer followed by M-x > insert-file, which would happily remember everything. > > If the maintainers agree in principle, I'd like to look into patching > revert-buffer so it records the revert as it would any other change to > the buffer text. In the short term, or if the maintainers do not agree to Hrvoje's proposal, how about adding a warning to the "Revert buffer from file FILE? " yes-or-no-p prompt? -- Kevin Rodgers Denver, Colorado, USA From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 09 22:07:52 2012 Received: (at control) by debbugs.gnu.org; 10 Feb 2012 03:07:52 +0000 Received: from localhost ([127.0.0.1]:34346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rvgpz-0002ZD-SP for submit@debbugs.gnu.org; Thu, 09 Feb 2012 22:07:52 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:38727 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rvgpy-0002Z5-4k for control@debbugs.gnu.org; Thu, 09 Feb 2012 22:07:50 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Rvgoo-0005GP-VF for control@debbugs.gnu.org; Thu, 09 Feb 2012 22:06:39 -0500 Date: Thu, 09 Feb 2012 22:06:38 -0500 Message-Id: Subject: control message for bug 10776 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) merge 8447 10776 From debbugs-submit-bounces@debbugs.gnu.org Tue May 28 21:10:18 2013 Received: (at 8447) by debbugs.gnu.org; 29 May 2013 01:10:19 +0000 Received: from localhost ([127.0.0.1]:38371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhUuA-00065Z-In for submit@debbugs.gnu.org; Tue, 28 May 2013 21:10:18 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:25369) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhUu8-00065I-Ko for 8447@debbugs.gnu.org; Tue, 28 May 2013 21:10:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQMABK/CFFMCpOt/2dsb2JhbABEg0O7Sxdzgns+NCYYDYhIoAuRFJAOjWGDKQOkeoFegxM X-IPAS-Result: ApQMABK/CFFMCpOt/2dsb2JhbABEg0O7Sxdzgns+NCYYDYhIoAuRFJAOjWGDKQOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="14996299" Received: from 76-10-147-173.dsl.teksavvy.com (HELO pastel.home) ([76.10.147.173]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 28 May 2013 21:08:44 -0400 Received: by pastel.home (Postfix, from userid 20848) id 8596A67DA9; Tue, 28 May 2013 21:08:47 -0400 (EDT) From: Stefan Monnier To: 8447@debbugs.gnu.org Subject: Re: Undoing M-x revert-buffer Message-ID: Date: Tue, 28 May 2013 21:08:47 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 8447 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.4 (/) I just installed into the trunk a patch which should make revert-buffer undoable. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue May 28 23:17:22 2013 Received: (at 8447) by debbugs.gnu.org; 29 May 2013 03:17:22 +0000 Received: from localhost ([127.0.0.1]:38505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhWt7-0002YQ-Sl for submit@debbugs.gnu.org; Tue, 28 May 2013 23:17:22 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:30404) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhWt6-0002Y9-1Z for 8447@debbugs.gnu.org; Tue, 28 May 2013 23:17:20 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r4T3FnTJ001115 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 29 May 2013 03:15:50 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4T3Fo5M025114 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 29 May 2013 03:15:51 GMT Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by userz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4T3Fo9u025104; Wed, 29 May 2013 03:15:50 GMT MIME-Version: 1.0 Message-ID: <96119924-8d40-4c32-a1c8-57e9df719e73@default> Date: Tue, 28 May 2013 20:15:49 -0700 (PDT) From: Drew Adams To: Stefan Monnier , 8447@debbugs.gnu.org Subject: RE: bug#8447: Undoing M-x revert-buffer References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 8447 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) > I just installed into the trunk a patch which should make > revert-buffer undoable. FWIW, see my comment on this in the help list: http://lists.gnu.org/archive/html/help-gnu-emacs/2013-05/msg00671.html In sum, why? And why no discussion? Where was the "bug"? From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 02:16:31 2013 Received: (at submit) by debbugs.gnu.org; 29 May 2013 06:16:31 +0000 Received: from localhost ([127.0.0.1]:38709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhZgV-0000RA-2N for submit@debbugs.gnu.org; Wed, 29 May 2013 02:16:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42717) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhZgS-0000Qy-Lj for submit@debbugs.gnu.org; Wed, 29 May 2013 02:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhZey-0005pq-DE for submit@debbugs.gnu.org; Wed, 29 May 2013 02:15:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:44352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhZey-0005pl-AS for submit@debbugs.gnu.org; Wed, 29 May 2013 02:14:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhZet-0007Mm-MM for bug-gnu-emacs@gnu.org; Wed, 29 May 2013 02:14:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhZel-0005o5-Ja for bug-gnu-emacs@gnu.org; Wed, 29 May 2013 02:14:51 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:53448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhZel-0005o0-A9 for bug-gnu-emacs@gnu.org; Wed, 29 May 2013 02:14:43 -0400 Received: from [192.168.178.21] (brln-4db9e3d3.pool.mediaWays.net [77.185.227.211]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0Ll1ub-1U6rOW3G1V-00aeoL; Wed, 29 May 2013 08:14:42 +0200 Message-ID: <51A59D77.9040709@easy-emacs.de> Date: Wed, 29 May 2013 08:17:27 +0200 From: =?ISO-8859-1?Q?Andreas_R=F6hler?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: Re: bug#8447: Undoing M-x revert-buffer References: <96119924-8d40-4c32-a1c8-57e9df719e73@default> In-Reply-To: <96119924-8d40-4c32-a1c8-57e9df719e73@default> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:6ohIlbLjFyg+CzOX+16Js+g8dFZ4Kuf58rFJHuKz3oH B1Q7aeMVfC+kP0fHekwu6S03NBCAIlEBYiOJ8WrsZV1TjE3CCl SjAJivEeoqeo0+UiN7jdGt1tmWG/0wCsH3I+HUfF2y4YzeDj1I Qvq0UZA99Ce2gjlHxGQoI/o1UxhocYs85lZ5gNH20A/WLHZs5k k52qt3yaVLQFks/yxLplk9NrLckxZwF/4Z3affagnh5M9TVCQL iMVThposkPxyt8zE7dhb3VIqOk6iDXcV/0IS/Xbd7DkgayFM3b pjQTEwXbOux9iT3uxi9fIC6lmlJQHY92GzJUK/MU4eJbApuC2R FKPf9SJscW9MgqdvRIcg70CSOP4QvDvGYM6gG4jji X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: submit Cc: Stefan Monnier , Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Am 29.05.2013 05:15, schrieb Drew Adams: >> I just installed into the trunk a patch which should make >> revert-buffer undoable. > > FWIW, see my comment on this in the help list: > http://lists.gnu.org/archive/html/help-gnu-emacs/2013-05/msg00671.html > > In sum, why? And why no discussion? Where was the "bug"? > > > > Hi Drew, as it happened, run sometimes into this: reverting the buffer, which turned out not the right thing - but undo-history was lost. Consider it a useful change, thanks. Andreas From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 09:29:31 2013 Received: (at submit) by debbugs.gnu.org; 29 May 2013 13:29:31 +0000 Received: from localhost ([127.0.0.1]:39424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhgRV-0008RF-Q3 for submit@debbugs.gnu.org; Wed, 29 May 2013 09:29:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46759) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhgRM-0008Qr-Oz for submit@debbugs.gnu.org; Wed, 29 May 2013 09:29:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhgPu-000705-GX for submit@debbugs.gnu.org; Wed, 29 May 2013 09:27:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-103.4 required=5.0 tests=BAYES_20, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhgPu-000701-Cw for submit@debbugs.gnu.org; Wed, 29 May 2013 09:27:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhgPt-0004fV-1v for bug-gnu-emacs@gnu.org; Wed, 29 May 2013 09:27:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhgPr-0006yo-Lb for bug-gnu-emacs@gnu.org; Wed, 29 May 2013 09:27:48 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:37318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhgPr-0006xL-FV for bug-gnu-emacs@gnu.org; Wed, 29 May 2013 09:27:47 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r4TDRgFo021642 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 29 May 2013 13:27:43 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4TDRfFk026805 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 29 May 2013 13:27:42 GMT Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4TDRf6s028267; Wed, 29 May 2013 13:27:41 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 29 May 2013 06:27:40 -0700 (PDT) From: Drew Adams To: =?iso-8859-1?B?QW5kcmVhcyBS9mhsZXI=?= , bug-gnu-emacs@gnu.org Subject: RE: bug#8447: Undoing M-x revert-buffer References: <96119924-8d40-4c32-a1c8-57e9df719e73@default> <51A59D77.9040709@easy-emacs.de> In-Reply-To: <51A59D77.9040709@easy-emacs.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: submit Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > >> I just installed into the trunk a patch which should make > >> revert-buffer undoable. > > > > FWIW, see my comment on this in the help list: > > http://lists.gnu.org/archive/html/help-gnu-emacs/2013-05/msg00671.html > > > > In sum, why? And why no discussion? Where was the "bug"? > as it happened, run sometimes into this: > reverting the buffer, which turned out not the right thing - but undo- > history was lost. Consider it a useful change, thanks. By "turned out not the right thing" I guess you mean that someone used `rev= ert-buffer' interactively and by mistake. And by mistake also _confirmed_ = reverting. Yes, it can happen (to anyone). So define a command `revert-buffer-keeping-undo', and use that interactivel= y instead of `revert-buffer'. Or define a variable (option or internal) `r= evert-buffer-keeps-undo'. What you cite is a user-interface issue - i.e., only for interactive use of= the command. Such a change, to safeguard against mistaken reverting, is a= kin to removing files to a trash bin instead of deleting them. But we did = not just willy nilly change the behavior of the basic function (command) `d= elete-file' when we added support for a recycle/trash bin. That's not the = right approach. With extra interactive protection as the only reason, this is also akin to = some users (me, for instance) wanting `C-w' to prompt for confirmation if t= he region is over a certain size (as in wimpy-del.el). Certainly such safe= guard features can be useful. But this change goes way beyond offering users optional extra protection. = `revert-buffer' is also used in basic code. The right way to add such protection against mistaken reversion is to creat= e a separate command or option, letting users choose to use it or not. And= leave the basic `revert-buffer' alone. FWIW, I agree that such a feature can be useful for reverting interactively= . And why no discussion before making such a change? From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 11:23:00 2013 Received: (at control) by debbugs.gnu.org; 29 May 2013 15:23:01 +0000 Received: from localhost ([127.0.0.1]:40141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhiDM-000696-I5 for submit@debbugs.gnu.org; Wed, 29 May 2013 11:23:00 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:44256 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhiDK-00068y-Nu for control@debbugs.gnu.org; Wed, 29 May 2013 11:22:59 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UhiBy-00041L-1w for control@debbugs.gnu.org; Wed, 29 May 2013 11:21:34 -0400 Date: Wed, 29 May 2013 11:21:34 -0400 Message-Id: Subject: control message for bug 8447 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) close 8447 24.4 From debbugs-submit-bounces@debbugs.gnu.org Thu May 30 12:56:42 2013 Received: (at submit) by debbugs.gnu.org; 30 May 2013 16:56:42 +0000 Received: from localhost ([127.0.0.1]:42586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ui69X-0007VK-9Y for submit@debbugs.gnu.org; Thu, 30 May 2013 12:56:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49636) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ui69T-0007Ub-3h for submit@debbugs.gnu.org; Thu, 30 May 2013 12:56:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ui67q-0003AF-W9 for submit@debbugs.gnu.org; Thu, 30 May 2013 12:54:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.0 required=5.0 tests=BAYES_40, RCVD_IN_DNSWL_NONE, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:46044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui67q-0003AB-Rn for submit@debbugs.gnu.org; Thu, 30 May 2013 12:54:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui67l-0004MV-MV for bug-gnu-emacs@gnu.org; Thu, 30 May 2013 12:54:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ui67g-00037L-Ha for bug-gnu-emacs@gnu.org; Thu, 30 May 2013 12:54:49 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:58574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui67g-000373-7I for bug-gnu-emacs@gnu.org; Thu, 30 May 2013 12:54:44 -0400 Received: from [192.168.178.21] (brln-4db9f259.pool.mediaWays.net [77.185.242.89]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0LeS5t-1U5FGv3I2H-00pwU5; Thu, 30 May 2013 18:54:41 +0200 Message-ID: <51A784FD.3040700@easy-emacs.de> Date: Thu, 30 May 2013 18:57:33 +0200 From: =?ISO-8859-1?Q?Andreas_R=F6hler?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Drew Adams Subject: Re: bug#8447: Undoing M-x revert-buffer References: <96119924-8d40-4c32-a1c8-57e9df719e73@default> <51A59D77.9040709@easy-emacs.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:U9n8yCHJ6+iLuZ07kwmGCfkvN59O0pKjOPHqeeWvFr/ vsqqZjbS+eNHMFjdGCFLuaJd+2GcrVynTYUAj879j5xdAcWrDr bFrjjYM/JoBfH/np2Uiu4kMxdAhD0+BgM8yYaOgBFIeodxdQen VbY6JMSqcBA3JN8e0tBx8gBVnBSVNOOqLAPuCJ9tXAlBMbr6Qq yg4AFXMbKmAhfKv4EM8iTJAhHuqDubt8Sp+pbQVP5pNcGE3Z7N 8lYjMJqbVMfvScnTC5gJRh/ajxaPSfJml3vumiyoQPDZnUR6A3 +AebFmo+4O2jKeSe3opreBJoo9C9fhdvugqYbqHxUAp/nvDzgH 1AQswKSKtAdUx4ys0KTV5YPtbxqW6X9HUGzHe5wig X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Am 29.05.2013 15:27, schrieb Drew Adams: >>>> I just installed into the trunk a patch which should make >>>> revert-buffer undoable. >>> >>> FWIW, see my comment on this in the help list: >>> http://lists.gnu.org/archive/html/help-gnu-emacs/2013-05/msg00671.html >>> >>> In sum, why? And why no discussion? Where was the "bug"? > >> as it happened, run sometimes into this: >> reverting the buffer, which turned out not the right thing - but undo- >> history was lost. Consider it a useful change, thanks. > > By "turned out not the right thing" I guess you mean that someone used `revert-buffer' interactively and by mistake. And by mistake also _confirmed_ reverting. Yes, it can happen (to anyone). > > So define a command `revert-buffer-keeping-undo', and use that interactively instead of `revert-buffer'. Or define a variable (option or internal) `revert-buffer-keeps-undo'. > > What you cite is a user-interface issue - i.e., only for interactive use of the command. Such a change, to safeguard against mistaken reverting, is akin to removing files to a trash bin instead of deleting them. But we did not just willy nilly change the behavior of the basic function (command) `delete-file' when we added support for a recycle/trash bin. That's not the right approach. > > With extra interactive protection as the only reason, this is also akin to some users (me, for instance) wanting `C-w' to prompt for confirmation if the region is over a certain size (as in wimpy-del.el). Certainly such safeguard features can be useful. > > But this change goes way beyond offering users optional extra protection. `revert-buffer' is also used in basic code. > > The right way to add such protection against mistaken reversion is to create a separate command or option, letting users choose to use it or not. And leave the basic `revert-buffer' alone. > > FWIW, I agree that such a feature can be useful for reverting interactively. > > And why no discussion before making such a change? > Hi Drew, thanks, okay, you are right opposing it then. Mistook the matter so far. Cheers, Andreas From unknown Tue Jun 24 15:38:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Jun 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator