GNU bug report logs - #8416
easy-mmode.el -- enhance define-minor-mode to define turn-on-* and turn-off-* functions

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#8416: closed (easy-mmode.el -- enhance define-minor-mode to
 define turn-on-* and turn-off-* functions)
Date: Mon, 04 Apr 2011 14:33:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 04 Apr 2011 10:32:03 -0400
with message-id <jwvzko61451.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#8416: easy-mmode.el -- enhance define-minor-mode to define turn-on-* and turn-off-* functions
has caused the GNU bug report #8416,
regarding easy-mmode.el -- enhance define-minor-mode to define turn-on-* and turn-off-* functions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
8416: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8416
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jari Aalto <jari.aalto <at> cante.net>
To: submit <at> debbugs.gnu.org
Subject: easy-mmode.el -- enhance define-minor-mode to define turn-on-* and
	turn-off-* functions
Date: Sun, 03 Apr 2011 16:42:03 +0300

Package: emacs
Version: 23.2+1-7
Severity: wishlist

It would be nice if the define-minor-mode would also define functions:

    turn-on-*
    turn-off-*

An example:

    ;; lisp/hl-line.el
    (define-minor-mode hl-line-mode ...)

That would make it possible to add to ~/.emacs:

    (add-hook 'nroff-mode-hook 'turn-on-hl-line-mode)

    ;; Or later:
    (remove-hook 'nroff-mode-hook 'turn-on-hl-line-mode)

This would be much more cleaner than what is needed now:

    (add-hook 'nroff-mode-hook '(lambda () (turn-on-hl-line-mode 1)))
    ...
    ;; the hook removal command is as messy


-- System Information
Debian Release: wheezy/sid
  APT Prefers testing
  APT policy: (990, testing) (500, unstable) (1, experimental)
Architecture: amd64
Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Wed Jan 12 03:40:32 UTC 2011 x86_64 GNU/Linux
Locale: LANG=en_DK.UTF-8

-- Versions of packages `emacs depends on'.
Depends:
emacs23         23.2+1-7        GNU Emacs is the extensible self-documenting
emacs23-lucid   23.2+1-7        GNU Emacs is the extensible self-documenting
emacs23-nox     23.2+1-7        GNU Emacs is the extensible self-documenting

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: 8416-done <at> debbugs.gnu.org
Subject: Re: bug#8416: easy-mmode.el -- enhance define-minor-mode to define
	turn-on-* and turn-off-* functions
Date: Mon, 04 Apr 2011 10:32:03 -0400

> It would be nice if the define-minor-mode would also define functions:

>     turn-on-*
>     turn-off-*

In Emacs-24, the `foo-mode' function of a minor mode *is* the
turn-on-foo-mode function (at least when called non-interactively
without an argument, e.g. on a normal hook).

> This would be much more cleaner than what is needed now:
>     (add-hook 'nroff-mode-hook '(lambda () (turn-on-hl-line-mode 1)))

As mentioned, the above is not needed any more:

  (add-hook 'nroff-mode-hook 'hl-line-mode)

will work just fine.

The turn-off-foo is rarely needed in my experience.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.