GNU bug report logs - #8415
23.3.50; Extensible Emacs Registers

Previous Next

Package: emacs;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Sun, 3 Apr 2011 12:30:03 UTC

Severity: wishlist

Tags: patch

Found in version 23.3.50

Fixed in version 24.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #58 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#8415: 23.3.50; Extensible Emacs Registers
Date: Sat, 25 Jun 2011 09:19:50 -0400

> Is this patch OK?

Looks OK, yes.

> +     (jump-func (funcall jump-func (registerv-data val)))

But I'd pass `val' directly, so the function can use extra fields in
values that inherit from registerv.  You could drop the `data' field as
well, at that point.

This just makes it more OO, and maybe experience would show that it
actually makes things worse (just adds unused extra flexibility), so
I'll let you judge.  Either way is OK with me.


        Stefan
This bug report was last modified 13 years and 323 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.