From unknown Tue Jun 24 01:38:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8399 <8399@debbugs.gnu.org> To: bug#8399 <8399@debbugs.gnu.org> Subject: Status: 23.3; save-some-buffers ignores buffer names Reply-To: bug#8399 <8399@debbugs.gnu.org> Date: Tue, 24 Jun 2025 08:38:21 +0000 retitle 8399 23.3; save-some-buffers ignores buffer names reassign 8399 emacs submitter 8399 Uday S Reddy severity 8399 minor tag 8399 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 31 17:33:49 2011 Received: (at submit) by debbugs.gnu.org; 31 Mar 2011 21:33:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5PUz-0004E0-0W for submit@debbugs.gnu.org; Thu, 31 Mar 2011 17:33:49 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5PUw-0004Dn-Ap for submit@debbugs.gnu.org; Thu, 31 Mar 2011 17:33:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5PUp-00032E-IU for submit@debbugs.gnu.org; Thu, 31 Mar 2011 17:33:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:60739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5PUp-00032A-EI for submit@debbugs.gnu.org; Thu, 31 Mar 2011 17:33:39 -0400 Received: from [140.186.70.92] (port=52287 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5PUn-0004lW-ML for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 17:33:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5PUl-00031q-Rr for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 17:33:37 -0400 Received: from sun60.bham.ac.uk ([147.188.128.137]:51242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5PUl-00031U-JT for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 17:33:35 -0400 Received: from [147.188.128.127] (helo=bham.ac.uk) by sun60.bham.ac.uk with esmtp (Exim 4.72) (envelope-from ) id 1Q5PUi-0004HV-NR for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 22:33:32 +0100 Received: from mx1.cs.bham.ac.uk ([147.188.192.53]) by bham.ac.uk (envelope-from ) with esmtps (TLSv1:DES-CBC3-SHA:168) (Exim 4.72) id 1Q5PUi-0001oa-DO for bug-gnu-emacs@gnu.org using interface smart1.bham.ac.uk; Thu, 31 Mar 2011 22:33:32 +0100 Received: from gromit.cs.bham.ac.uk ([147.188.193.16] helo=MARUTI.cs.bham.ac.uk) by mx1.cs.bham.ac.uk with esmtp (Exim 4.51) id 1Q5PUi-0006PB-R2; Thu, 31 Mar 2011 22:33:33 +0100 From: Uday S Reddy To: bug-gnu-emacs@gnu.org Subject: 23.3; save-some-buffers ignores buffer names Date: Thu, 31 Mar 2011 22:33:19 +0100 Message-ID: <83y63vm0v4.fsf@cs.bham.ac.uk> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: submit Cc: U.S.Reddy@cs.bham.ac.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) --=-=-= The save-some-buffers command queries the user as to which buffers should be saved. However, if the buffer has a file-name, it uses the file-name in the dialogue instead of the buffer name. If the buffer name happens to differ from the buffer's file-name, this is confusing to the users. (It happens quite frequently in VM, which uses obscure file-names for the caches of POP/IMAP folders, but the buffer names are recognizable.) The attached patch (on Emacs-23 head) modifies the dialogue so that file-names are used in the dialogue only when they coincide with the buffer names. Otherwise, buffer names are used preferentially. Cheers, Uday In GNU Emacs 23.3.1 (i386-mingw-nt5.1.2600) of 2011-03-10 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.5) --no-opt --cflags -Ic:/imagesupport/include' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ENU value of $XMODIFIERS: nil locale-coding-system: cp1252 default enable-multibyte-characters: t Major mode: VM Presentation Minor modes in effect: diff-auto-refine-mode: t savehist-mode: t which-function-mode: t tooltip-mode: t mouse-wheel-mode: t use-hard-newlines: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t auto-encryption-mode: t line-number-mode: t visual-line-mode: t transient-mark-mode: t Recent input: y C-x C-f C-g C-x o C-x C-f C-g C-x o C-x C-f - d e v / b z r . l o SPC C-s f i l e s . e l C-a C-s 2 3 . 3 C-s C-s C-r C-r C-s C-s C-s C-r C-r C-r C-r C-r C-r C-r C-r C-r C-a C-x C-f N E SPC W SPC e t c / N E SPC C-l C-x k C-x o C-x b f i l e s . SPC C-g C-x o C-x C-r C-x , C-x o C-x b f i l e s . SPC C-x o M-x e d i f f - b u f n n n C-n C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-x o C-f C-f C-f C-f C-f C-f C-f C-f C-n C-f C-f C-f C-b C-b C-b C-b C-b C-a C-SPC C-n C-n C-n C-n C-n C-n C-n M-x u n t a b i f y q y C-x o M-x e d i f f - b u f n n n b q y C-x o C-x C-s C-a M-x r e p o r t - e m a c s - b u SPC Recent messages: Processing difference regions ... done Refining difference region 1 ... Refining difference region 2 ... Refining difference region 3 ... Saving old diff region #3 of buffer A. To recover, type `ra' [2 times] Only white-space differences in region 3 Quit this Ediff session? (y or n) Saving file d:/gnu/emacs-23-dev/lisp/files.el... Wrote d:/gnu/emacs-23-dev/lisp/files.el Mark set Load-path shadows: d:/Home/udr/share/emacs/sml-mode hides d:/gnu/emacs-23.3/../site-lisp/sml-mode d:/Home/udr/share/emacs/savehist-20+ hides d:/gnu/emacs-23.3/../site-lisp/savehist-20+ d:/gnu/emacs-23.3/../site-lisp/longlines hides d:/gnu/emacs-23.3/lisp/longlines d:/gnu/vm/trunk/lisp/cus-load hides d:/gnu/emacs-23.3/lisp/cus-load d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org hides d:/gnu/emacs-23.3/lisp/org/org d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-xoxo hides d:/gnu/emacs-23.3/lisp/org/org-xoxo d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-wl hides d:/gnu/emacs-23.3/lisp/org/org-wl d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-w3m hides d:/gnu/emacs-23.3/lisp/org/org-w3m d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-vm hides d:/gnu/emacs-23.3/lisp/org/org-vm d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-timer hides d:/gnu/emacs-23.3/lisp/org/org-timer d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-table hides d:/gnu/emacs-23.3/lisp/org/org-table d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-src hides d:/gnu/emacs-23.3/lisp/org/org-src d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-rmail hides d:/gnu/emacs-23.3/lisp/org/org-rmail d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-remember hides d:/gnu/emacs-23.3/lisp/org/org-remember d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-publish hides d:/gnu/emacs-23.3/lisp/org/org-publish d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-protocol hides d:/gnu/emacs-23.3/lisp/org/org-protocol d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-plot hides d:/gnu/emacs-23.3/lisp/org/org-plot d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-mouse hides d:/gnu/emacs-23.3/lisp/org/org-mouse d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-mobile hides d:/gnu/emacs-23.3/lisp/org/org-mobile d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-mhe hides d:/gnu/emacs-23.3/lisp/org/org-mhe d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-mew hides d:/gnu/emacs-23.3/lisp/org/org-mew d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-macs hides d:/gnu/emacs-23.3/lisp/org/org-macs d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-mac-message hides d:/gnu/emacs-23.3/lisp/org/org-mac-message d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-list hides d:/gnu/emacs-23.3/lisp/org/org-list d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-latex hides d:/gnu/emacs-23.3/lisp/org/org-latex d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-jsinfo hides d:/gnu/emacs-23.3/lisp/org/org-jsinfo d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-irc hides d:/gnu/emacs-23.3/lisp/org/org-irc d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-install hides d:/gnu/emacs-23.3/lisp/org/org-install d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-inlinetask hides d:/gnu/emacs-23.3/lisp/org/org-inlinetask d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-info hides d:/gnu/emacs-23.3/lisp/org/org-info d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-indent hides d:/gnu/emacs-23.3/lisp/org/org-indent d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-id hides d:/gnu/emacs-23.3/lisp/org/org-id d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-icalendar hides d:/gnu/emacs-23.3/lisp/org/org-icalendar d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-html hides d:/gnu/emacs-23.3/lisp/org/org-html d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-habit hides d:/gnu/emacs-23.3/lisp/org/org-habit d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-gnus hides d:/gnu/emacs-23.3/lisp/org/org-gnus d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-freemind hides d:/gnu/emacs-23.3/lisp/org/org-freemind d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-footnote hides d:/gnu/emacs-23.3/lisp/org/org-footnote d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-feed hides d:/gnu/emacs-23.3/lisp/org/org-feed d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-faces hides d:/gnu/emacs-23.3/lisp/org/org-faces d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-exp hides d:/gnu/emacs-23.3/lisp/org/org-exp d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-exp-blocks hides d:/gnu/emacs-23.3/lisp/org/org-exp-blocks d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-docbook hides d:/gnu/emacs-23.3/lisp/org/org-docbook d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-datetree hides d:/gnu/emacs-23.3/lisp/org/org-datetree d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-crypt hides d:/gnu/emacs-23.3/lisp/org/org-crypt d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-compat hides d:/gnu/emacs-23.3/lisp/org/org-compat d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-colview hides d:/gnu/emacs-23.3/lisp/org/org-colview d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-clock hides d:/gnu/emacs-23.3/lisp/org/org-clock d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-bibtex hides d:/gnu/emacs-23.3/lisp/org/org-bibtex d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-bbdb hides d:/gnu/emacs-23.3/lisp/org/org-bbdb d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-attach hides d:/gnu/emacs-23.3/lisp/org/org-attach d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-ascii hides d:/gnu/emacs-23.3/lisp/org/org-ascii d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-archive hides d:/gnu/emacs-23.3/lisp/org/org-archive d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-agenda hides d:/gnu/emacs-23.3/lisp/org/org-agenda d:/Home/udr/share/emacs/rnews hides d:/gnu/emacs-23.3/lisp/obsolete/rnews Features: (shadow sort message ecomplete mml mml-sec password-cache mm-decode mm-bodies mm-encode mailcap nnheader gmm-utils mailheader canlock hashcash mail-utils warnings emacsbug tabify smerge-mode diff-mode noutline outline multi-isearch ediff-merg ediff-diff ediff-wind ediff-help ediff-util ediff-mult ediff-init ediff cl-specs edebug find-func help-mode view vm-pop vm-mark vm-delete bbdb-hooks mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mm-util mail-prsvr longlines easy-mmode w3m-form w3m browse-url doc-view dired-x dired-aux mydired dired image-mode w3m-hist w3m-fb bookmark-w3m w3m-ems wid-edit w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util vm-w3m tapestry vm-sort vm-thread vm-crypto vm-imap easymenu u-vm-color my-vm vc-bzr sha1 hex-util etags ps-print ps-def lpr vm-save vm-ps-print vm-rfaddons vm-menu vm-window vm-toolbar vm-folder vm-mime vm-undo vm-virtual vm-summary-faces vm-mouse vm-page vm-minibuf vm-message vm-misc vm-macro bbdb-vm vm-summary vm-motion vm-autoload bbdb-snarf mail-extr rfc822 bbdb-com advice help-fns advice-preload mailabbrev cl cl-19 vm server w3m-load bbdb-autoloads bbdb timezone vm-autoloads vm-version vm-vars org-install savehist tex-site tex-mik telnet movement natural-space NatSpeak sendmail auth-source gnus-util netrc time-date epa-file epa epg epg-config ange-ftp regexp-opt comint ring echistory chistory ehelp electric derived which-func imenu edmacro kmacro jka-compr tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32 disp-table ls-lisp w32-win w32-vars tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process multi-tty emacs) -- --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=save-some-buffers.diff Content-Description: patch for save-some-buffers in files.el === modified file 'lisp/files.el' --- lisp/files.el 2011-03-11 12:19:08 +0000 +++ lisp/files.el 2011-03-31 21:23:03 +0000 @@ -4511,7 +4511,10 @@ (if arg t (setq queried t) - (if (buffer-file-name buffer) + (if (and (buffer-file-name buffer) + (equal (buffer-name buffer) + (file-name-nondirectory + (buffer-file-name buffer)))) (format "Save file %s? " (buffer-file-name buffer)) (format "Save buffer %s? " --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 31 21:01:14 2011 Received: (at 8399) by debbugs.gnu.org; 1 Apr 2011 01:01:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5Sji-0000KI-HA for submit@debbugs.gnu.org; Thu, 31 Mar 2011 21:01:14 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5Sjh-0000K6-2v for 8399@debbugs.gnu.org; Thu, 31 Mar 2011 21:01:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAHwilU1FxKsL/2dsb2JhbAClWXiIebgqhWsEli2DTA X-IronPort-AV: E=Sophos;i="4.63,279,1299474000"; d="scan'208";a="99403237" Received: from 69-196-171-11.dsl.teksavvy.com (HELO pastel.home) ([69.196.171.11]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 31 Mar 2011 21:01:06 -0400 Received: by pastel.home (Postfix, from userid 20848) id D417958F8C; Thu, 31 Mar 2011 21:01:05 -0400 (EDT) From: Stefan Monnier To: Uday S Reddy Subject: Re: bug#8399: 23.3; save-some-buffers ignores buffer names Message-ID: References: <83y63vm0v4.fsf@cs.bham.ac.uk> Date: Thu, 31 Mar 2011 21:01:05 -0400 In-Reply-To: <83y63vm0v4.fsf@cs.bham.ac.uk> (Uday S. Reddy's message of "Thu, 31 Mar 2011 22:33:19 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 8399 Cc: 8399@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > The attached patch (on Emacs-23 head) modifies the dialogue so that > file-names are used in the dialogue only when they coincide with the > buffer names. Otherwise, buffer names are used preferentially. I think the file-name is only useful when you have buffer "file", "file<2>", "file<3>", ... so your check is going in the right direction but it should also use file-name when the buffer name matches (concat "\\<" (regexp-quote (file-name-nondirectory buffer-file-name)) "<[0-9]+>\\'"), and it should never use file-names when uniquify is used. IMNSHO, Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 01 04:39:30 2011 Received: (at 8399) by debbugs.gnu.org; 1 Apr 2011 08:39:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5ZtC-0001pN-32 for submit@debbugs.gnu.org; Fri, 01 Apr 2011 04:39:30 -0400 Received: from sun60.bham.ac.uk ([147.188.128.137]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5ZtA-0001pA-0O for 8399@debbugs.gnu.org; Fri, 01 Apr 2011 04:39:28 -0400 Received: from [147.188.128.127] (helo=bham.ac.uk) by sun60.bham.ac.uk with esmtp (Exim 4.72) (envelope-from ) id 1Q5Zt3-0005w8-Mi; Fri, 01 Apr 2011 09:39:21 +0100 Received: from mx1.cs.bham.ac.uk ([147.188.192.53]) by bham.ac.uk (envelope-from ) with esmtps (TLSv1:DES-CBC3-SHA:168) (Exim 4.72) id 1Q5Zt2-0004yL-Fu using interface smart1.bham.ac.uk; Fri, 01 Apr 2011 09:39:20 +0100 Received: from gromit.cs.bham.ac.uk ([147.188.193.16] helo=MARUTI.cs.bham.ac.uk) by mx1.cs.bham.ac.uk with esmtp (Exim 4.51) id 1Q5Zt2-0001PP-Hg; Fri, 01 Apr 2011 09:39:20 +0100 Message-ID: <19861.36650.140000.470708@gargle.gargle.HOWL> Date: Fri, 1 Apr 2011 09:39:06 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Uday S Reddy To: Stefan Monnier Subject: Re: bug#8399: 23.3; save-some-buffers ignores buffer names In-Reply-To: References: <83y63vm0v4.fsf@cs.bham.ac.uk> X-Mailer: VM 8.1.93a under 23.3.1 (i386-mingw-nt5.1.2600) X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 8399 Cc: Uday S Reddy , 8399@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) Stefan Monnier writes: > I think the file-name is only useful when you have buffer "file", > "file<2>", "file<3>", ... so your check is going in the right direction > but it should also use file-name when the buffer name matches > (concat "\\<" (regexp-quote (file-name-nondirectory buffer-file-name)) > "<[0-9]+>\\'"), and it should never use file-names when uniquify > is used. Thanks Stefan. I didn't think of the file case. I will submit a revised patch. Is uniquifying file-names something that Emacs does? Or, were you just referring to the VM's cache folder names? Cheers, Uday From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 01 10:53:16 2011 Received: (at 8399) by debbugs.gnu.org; 1 Apr 2011 14:53:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5fiu-0002Zs-26 for submit@debbugs.gnu.org; Fri, 01 Apr 2011 10:53:16 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5fir-0002Zc-TQ for 8399@debbugs.gnu.org; Fri, 01 Apr 2011 10:53:14 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAFXmlU1FxKsL/2dsb2JhbAClVniIebkwhWsEljSDTA X-IronPort-AV: E=Sophos;i="4.63,282,1299474000"; d="scan'208";a="102484394" Received: from 69-196-171-11.dsl.teksavvy.com (HELO pastel.home) ([69.196.171.11]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 01 Apr 2011 10:53:08 -0400 Received: by pastel.home (Postfix, from userid 20848) id 13ABF58F8C; Fri, 1 Apr 2011 10:53:08 -0400 (EDT) From: Stefan Monnier To: Uday S Reddy Subject: Re: bug#8399: 23.3; save-some-buffers ignores buffer names Message-ID: References: <83y63vm0v4.fsf@cs.bham.ac.uk> <19861.36650.140000.470708@gargle.gargle.HOWL> Date: Fri, 01 Apr 2011 10:53:08 -0400 In-Reply-To: <19861.36650.140000.470708@gargle.gargle.HOWL> (Uday S. Reddy's message of "Fri, 1 Apr 2011 09:39:06 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 8399 Cc: 8399@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > Thanks Stefan. I didn't think of the file case. I will submit a > revised patch. Is uniquifying file-names something that Emacs does? Check uniquify-buffer-name-style. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 09:29:18 2020 Received: (at 8399) by debbugs.gnu.org; 25 Aug 2020 13:29:18 +0000 Received: from localhost ([127.0.0.1]:60752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZ0n-0005Lr-N3 for submit@debbugs.gnu.org; Tue, 25 Aug 2020 09:29:17 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZ0l-0005Le-KG for 8399@debbugs.gnu.org; Tue, 25 Aug 2020 09:29:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kj94ga1qBiEwfDCL89n70jfZTfAKaOwtI3w3+A81IAo=; b=nlnOe6hIVcbwdplHZXnejUuyJU weAcgFMA5C4LxtJC7z55M7xbbqQJkZIPcmqms+MrOjjpvpyYvN6zRkIIFtZr1kES14rcciiV6GnI6 cazH2sqoWznOM9VmMNwa5LQ4YIMuPao5UF2dMPmGMsPPFQhoBLhu1WS2T4wyfIMnU+9E=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAZ0a-00064K-Jq; Tue, 25 Aug 2020 15:29:08 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#8399: 23.3; save-some-buffers ignores buffer names References: <83y63vm0v4.fsf@cs.bham.ac.uk> X-Now-Playing: DACM's =?utf-8?B?X1N0w4PCqXLDg8Kpb3R5cGllXzo=?= "Birthday" Date: Tue, 25 Aug 2020 15:29:03 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 31 Mar 2011 21:01:05 -0400") Message-ID: <87imd697mo.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> The attached patch (on Emacs-23 head) modifies the dialogue so that >> file-names are used in the dialogue only when they coincide with the >> buffer names. Otherwise, buffer names are used prefere [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 8399 Cc: Uday S Reddy , 8399@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> The attached patch (on Emacs-23 head) modifies the dialogue so that >> file-names are used in the dialogue only when they coincide with the >> buffer names. Otherwise, buffer names are used preferentially. > > I think the file-name is only useful when you have buffer "file", > "file<2>", "file<3>", ... so your check is going in the right direction > but it should also use file-name when the buffer name matches > (concat "\\<" (regexp-quote (file-name-nondirectory buffer-file-name)) > "<[0-9]+>\\'"), and it should never use file-names when uniquify > is used. > IMNSHO, > > Stefan Did I get the gist right below? I'm not really sure about whether it's useful to prefer the buffer names in this way, though -- the use case here was VM, which has meaningful buffer names that visit obscure files... but is that normal? Isn't it more useful to know what files you're saving to, and not what buffers they're coming from? diff --git a/lisp/files.el b/lisp/files.el index b6abafa4bd..4110412b47 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -5565,7 +5565,20 @@ save-some-buffers (if arg t (setq queried t) - (if (buffer-file-name buffer) + (if (and + (buffer-file-name buffer) + (not uniquify-buffer-name-style) + (or + (equal (buffer-name buffer) + (file-name-nondirectory + (buffer-file-name buffer))) + (string-match + (concat "\\<" + (regexp-quote + (file-name-nondirectory + buffer-file-name)) + "<[0-9]+>\\'") + (buffer-name buffer)))) (format "Save file %s? " (buffer-file-name buffer)) (format "Save buffer %s? " -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 10:01:29 2020 Received: (at 8399) by debbugs.gnu.org; 25 Aug 2020 14:01:29 +0000 Received: from localhost ([127.0.0.1]:35500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZVx-0004D9-9k for submit@debbugs.gnu.org; Tue, 25 Aug 2020 10:01:29 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZVw-00048U-KJ for 8399@debbugs.gnu.org; Tue, 25 Aug 2020 10:01:28 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 025FE440781; Tue, 25 Aug 2020 10:01:23 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6EBE34406A0; Tue, 25 Aug 2020 10:01:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598364081; bh=8eJXenzTNo6ZGfdvSO2tuakC0V5KeWzBjgVtYRyUVY0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RH7rACw41o0nOjceyCKMfZq10FdwMEsBa7VrItMIV1/gWcQiOwK9Sq2tmaj5cCKgv KKumwUmC+79GK4tlfA/l/qsTn7eCKyYZwCWzUuVcjBXJdzMCnc13HJ27Vp5R4aJTup smp8B2moOx1NhJyxTYT0Uxr7WuiHdC3TdOjwfzR9bi296qDv0ovwxd1UNFvDe1Fpqk pUJ2AFq/Tq4ZvDw84aR9W1yFFtj2ASMyJucDkHGlOzsD0ZWLJDzewHux5sEv5dk0V6 g0GiwCvR2w+MeD6ZqBEeeE2ZKe2fS0+Era78P6b1FbNoEl6CBA7zT6k7V3tVyroZbv Qnttw4VAVLRZA== Received: from alfajor (unknown [45.72.246.108]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4543C12041B; Tue, 25 Aug 2020 10:01:21 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#8399: 23.3; save-some-buffers ignores buffer names Message-ID: References: <83y63vm0v4.fsf@cs.bham.ac.uk> <87imd697mo.fsf@gnus.org> Date: Tue, 25 Aug 2020 10:01:20 -0400 In-Reply-To: <87imd697mo.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 25 Aug 2020 15:29:03 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 8399 Cc: Uday S Reddy , 8399@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Did I get the gist right below? I'm not really sure about whether it's > useful to prefer the buffer names in this way, though -- the use case > here was VM, which has meaningful buffer names that visit obscure > files... but is that normal? I think it's rare for buffer-names to be different from its file name, and usually if there's a difference the buffer-name is more meaningful (as in the VM case). But I'd be surprised if we couldn't find counter examples. > Isn't it more useful to know what files you're saving to, and not what > buffers they're coming from? Maybe we should choose (i.e. display both)? Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 10:05:24 2020 Received: (at 8399) by debbugs.gnu.org; 25 Aug 2020 14:05:25 +0000 Received: from localhost ([127.0.0.1]:35505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZZk-0005GE-P1 for submit@debbugs.gnu.org; Tue, 25 Aug 2020 10:05:24 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZZj-0005Fz-5h for 8399@debbugs.gnu.org; Tue, 25 Aug 2020 10:05:23 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D144F1002C8; Tue, 25 Aug 2020 10:05:17 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3AD521000C9; Tue, 25 Aug 2020 10:05:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598364316; bh=CZyvI/TIMvBSAIad5dbj/f3p6PAlPIIxaiOAX0sTCNE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gK8vX6665rFMpdq+AKIGWtp0D6ybeSjb2PyC9TtFDvTu0Qtbb/ABLxwRhk2SVx+Ec ZwgewEgtflNWzlldjwtLJlxY4Go3mQD78J+xDo7/1dFyT8e2EDrudzAw10iz7htPtj dWo5i5vjPIvvpjN9jHOr+JRHF53aQYdf2nv8IuIfuqjkErYrI/FNZ/7kIlOTfksL8M hAor83524rXYsmXgAVlalRyPjS6wS8uAtJaWnPt8LEoWKhwrATeqZUKioopaQ3lhmK 4/SourMHvWTE0F/91QbN4jLw3HaqegJn2pmILjIQ4cpNYPtcvUwQN3z7a14484Zzqc Dm4xLvdDpAQEw== Received: from alfajor (unknown [45.72.246.108]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E2BCD12081C; Tue, 25 Aug 2020 10:05:15 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#8399: 23.3; save-some-buffers ignores buffer names Message-ID: References: <83y63vm0v4.fsf@cs.bham.ac.uk> <87imd697mo.fsf@gnus.org> Date: Tue, 25 Aug 2020 10:05:15 -0400 In-Reply-To: (Stefan Monnier's message of "Tue, 25 Aug 2020 10:01:20 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 8399 Cc: Uday S Reddy , 8399@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Maybe we should choose (i.e. display both)? ^^ n't Sorry 'bout that, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 10:42:53 2020 Received: (at 8399) by debbugs.gnu.org; 25 Aug 2020 14:42:53 +0000 Received: from localhost ([127.0.0.1]:35620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAaA0-0008RI-S0 for submit@debbugs.gnu.org; Tue, 25 Aug 2020 10:42:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAa9z-0008R6-1K for 8399@debbugs.gnu.org; Tue, 25 Aug 2020 10:42:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39478) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAa9r-0007Jl-NS; Tue, 25 Aug 2020 10:42:43 -0400 Received: from [176.228.60.248] (port=2805 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kAa9r-0002e7-4j; Tue, 25 Aug 2020 10:42:43 -0400 Date: Tue, 25 Aug 2020 17:42:26 +0300 Message-Id: <83wo1m4wj1.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87imd697mo.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 25 Aug 2020 15:29:03 +0200) Subject: Re: bug#8399: 23.3; save-some-buffers ignores buffer names References: <83y63vm0v4.fsf@cs.bham.ac.uk> <87imd697mo.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 8399 Cc: u.s.reddy@cs.bham.ac.uk, monnier@iro.umontreal.ca, 8399@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Tue, 25 Aug 2020 15:29:03 +0200 > Cc: Uday S Reddy , 8399@debbugs.gnu.org > > Isn't it more useful to know what files you're saving to, and not > what buffers they're coming from? In the usual case, i.e. where the file name is not something invented by a VM or somesuch, I think the file name is more useful, yes. Or at least it could be. So maybe we should offer this as an optional feature, as I presume the OP's use case is somewhat rare? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 10:47:33 2020 Received: (at control) by debbugs.gnu.org; 25 Aug 2020 14:47:33 +0000 Received: from localhost ([127.0.0.1]:35624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAaEX-0002E7-Fh for submit@debbugs.gnu.org; Tue, 25 Aug 2020 10:47:33 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAaEV-00028E-GO for control@debbugs.gnu.org; Tue, 25 Aug 2020 10:47:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mnUibixuNT8i3YWzkk499AsaZkmQTZYo0hFRo2J2IqI=; b=IC4dLbOJ0ikpKGCRsonEq0S10y Oig0zyqkz3oloBXwMxRUuxsyEin9CsXCKLE9AfA19PbOI5+6izPFrXvms2YIJiiqs6FnuqmhwCne2 9luLOJvrIUX9ZkuEHifT3GFdNFBg90aSZAldgXiLw153/pZefYKj1DBNpYlwWeeOYxp0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAaEM-0006ld-O4 for control@debbugs.gnu.org; Tue, 25 Aug 2020 16:47:25 +0200 Date: Tue, 25 Aug 2020 16:47:21 +0200 Message-Id: <87eenu7pfq.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #8399 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 8399 fixed close 8399 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 8399 fixed close 8399 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 10:48:06 2020 Received: (at 8399) by debbugs.gnu.org; 25 Aug 2020 14:48:06 +0000 Received: from localhost ([127.0.0.1]:35630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAaF3-0002Li-OK for submit@debbugs.gnu.org; Tue, 25 Aug 2020 10:48:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAaF1-0002Kp-Cu for 8399@debbugs.gnu.org; Tue, 25 Aug 2020 10:48:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=APLVA/O1BOzis00GtvAqIVH4Jxc3EvVq5qEN18x3wdQ=; b=Aoh+Y2ufYOq6ihGYhU5ytGr35a lw8BmbmNX1v6Ozxp6oBQPFe+fkcVp1BYLj9fvplobmiVBb0AtBtdqvbjxCh+Lw5w928yYdWFndQbX w7GiP805IG0o8d+GHfGy+HouPwWNLEa49e9KDVQILcRqApOBQw1c2LiWDwJ37iEuDfNM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAaEr-0006ln-SF; Tue, 25 Aug 2020 16:47:56 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#8399: 23.3; save-some-buffers ignores buffer names References: <83y63vm0v4.fsf@cs.bham.ac.uk> <87imd697mo.fsf@gnus.org> X-Now-Playing: Steve Hackett's _Voyage of the Acolyte_: "Ace of Wands" Date: Tue, 25 Aug 2020 16:47:52 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 25 Aug 2020 10:05:15 -0400") Message-ID: <87a6yi7pev.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> Maybe we should choose (i.e. display both)? > ^^ > n't > > Sorry 'bout that, Makes sense; I've now done this when the buffer/file names are dissimilar. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 8399 Cc: Uday S Reddy , 8399@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> Maybe we should choose (i.e. display both)? > ^^ > n't > > Sorry 'bout that, Makes sense; I've now done this when the buffer/file names are dissimilar. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 10:49:10 2020 Received: (at 8399) by debbugs.gnu.org; 25 Aug 2020 14:49:10 +0000 Received: from localhost ([127.0.0.1]:35634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAaG6-0002Ng-15 for submit@debbugs.gnu.org; Tue, 25 Aug 2020 10:49:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAaG3-0002N1-DR for 8399@debbugs.gnu.org; Tue, 25 Aug 2020 10:49:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AAhuJVFVJNNqlwR6jISTHQugiWmAcsOofpcWjskLBEA=; b=TY9p8NEWlYcyYLUH20bmcOyqAY CzKSfForkEu0FEWbM2aDRZAoPJI0fIAiZf3E93R075e63/0k55WeopQAzMxJUBJHR+dLER1+8Oria EbmiC3Jyb5iKiupjgt8CnWdOvlXMoEGHXg7uquSn4ody7au8/aURiPG3OAdQAXBdq43w=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAaFu-0006mP-MU; Tue, 25 Aug 2020 16:49:01 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#8399: 23.3; save-some-buffers ignores buffer names References: <83y63vm0v4.fsf@cs.bham.ac.uk> <87imd697mo.fsf@gnus.org> <83wo1m4wj1.fsf@gnu.org> X-Now-Playing: Steve Hackett's _Voyage of the Acolyte_: "Ace of Wands" Date: Tue, 25 Aug 2020 16:48:57 +0200 In-Reply-To: <83wo1m4wj1.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Aug 2020 17:42:26 +0300") Message-ID: <875z967pd2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > In the usual case, i.e. where the file name is not something invented > by a VM or somesuch, I think the file name is more useful, yes. Or at > least it could be. So maybe we should offer this as an [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 8399 Cc: u.s.reddy@cs.bham.ac.uk, monnier@iro.umontreal.ca, 8399@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > In the usual case, i.e. where the file name is not something invented > by a VM or somesuch, I think the file name is more useful, yes. Or at > least it could be. So maybe we should offer this as an optional > feature, as I presume the OP's use case is somewhat rare? Sorry; I didn't see this before I made the change. Does the new behaviour (showing both names if they're dissimilar) look OK to you? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 11:01:39 2020 Received: (at 8399) by debbugs.gnu.org; 25 Aug 2020 15:01:39 +0000 Received: from localhost ([127.0.0.1]:35667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAaSB-00045U-Bo for submit@debbugs.gnu.org; Tue, 25 Aug 2020 11:01:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAaSA-0003zm-8e for 8399@debbugs.gnu.org; Tue, 25 Aug 2020 11:01:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39883) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAaS3-0002QK-Ei; Tue, 25 Aug 2020 11:01:31 -0400 Received: from [176.228.60.248] (port=3951 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kAaS2-0002Pe-7p; Tue, 25 Aug 2020 11:01:30 -0400 Date: Tue, 25 Aug 2020 18:01:14 +0300 Message-Id: <83tuwq4vnp.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <875z967pd2.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 25 Aug 2020 16:48:57 +0200) Subject: Re: bug#8399: 23.3; save-some-buffers ignores buffer names References: <83y63vm0v4.fsf@cs.bham.ac.uk> <87imd697mo.fsf@gnus.org> <83wo1m4wj1.fsf@gnu.org> <875z967pd2.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 8399 Cc: u.s.reddy@cs.bham.ac.uk, monnier@iro.umontreal.ca, 8399@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: u.s.reddy@cs.bham.ac.uk, monnier@iro.umontreal.ca, 8399@debbugs.gnu.org > Date: Tue, 25 Aug 2020 16:48:57 +0200 > > Eli Zaretskii writes: > > > In the usual case, i.e. where the file name is not something invented > > by a VM or somesuch, I think the file name is more useful, yes. Or at > > least it could be. So maybe we should offer this as an optional > > feature, as I presume the OP's use case is somewhat rare? > > Sorry; I didn't see this before I made the change. Sorry, I had communications problems that prevented me from responding immediately. > Does the new behaviour (showing both names if they're dissimilar) > look OK to you? I guess it's okay, except that it makes the message longer, so could cause resizing of the echo-area more frequently. But since the additional text is only produced when there's more than one buffer with the same base-name of its visited file name, I guess that's not a disaster. Let's see if users complain. Thanks. From unknown Tue Jun 24 01:38:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 23 Sep 2020 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator