GNU bug report logs - #8385
24.0.50; rcirc auto-authentication slightly broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8385 in the body.
You can then email your comments to 8385 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; rcirc auto-authentication slightly broken
Date: Thu, 31 Mar 2011 02:21:11 +0200

Currently when the user connects to an IRC server, rcirc checks if
`rcirc-auto-authenticate-flag' is non-nil and
`rcirc-authenticate-before-join' is non-nil.  If they are, a hook is
added to join the user's channels after successfully authenticating.

However, this is done regardless of whether the user has set up any
authinfo for the server being connected to, i.e., regardless of whether
any of the entries in `rcirc-authinfo' matches the server address.

`rcirc-handler-001' needs to be modified so that it first checks whether
the server matches any `rcirc-authinfo' entry before it decides to wait
with auto-joining channels until after authentication.

-- 
Deniz Dogan

Message #8 received at 8385 <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
To: 8385 <at> debbugs.gnu.org
Subject: 24.0.50; rcirc auto-authentication slightly broken
Date: Thu, 31 Mar 2011 09:03:33 +0200

severity serious
thanks

Message #13 received at 8385 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tassilo <at> member.fsf.org>
To: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
Cc: 8385 <at> debbugs.gnu.org
Subject: Re: bug#8385: 24.0.50; rcirc auto-authentication slightly broken
Date: Thu, 31 Mar 2011 12:13:17 +0200

[Message part 1 (text/plain, inline)]

Deniz Dogan <deniz.a.m.dogan <at> gmail.com> writes:

> Currently when the user connects to an IRC server, rcirc checks if
> `rcirc-auto-authenticate-flag' is non-nil and
> `rcirc-authenticate-before-join' is non-nil.  If they are, a hook is
> added to join the user's channels after successfully authenticating.
>
> However, this is done regardless of whether the user has set up any
> authinfo for the server being connected to, i.e., regardless of
> whether any of the entries in `rcirc-authinfo' matches the server
> address.
>
> `rcirc-handler-001' needs to be modified so that it first checks whether
> the server matches any `rcirc-authinfo' entry before it decides to wait
> with auto-joining channels until after authentication.

Could you please check if this patch does the trick?

[rcirc-auth.patch (text/x-patch, inline)]

=== modified file 'lisp/net/rcirc.el'
--- lisp/net/rcirc.el	2011-03-22 11:51:48 +0000
+++ lisp/net/rcirc.el	2011-03-31 07:40:16 +0000
@@ -2454,7 +2454,14 @@
     (setq rcirc-nick (car args))
     (rcirc-update-prompt)
     (if rcirc-auto-authenticate-flag
-        (if rcirc-authenticate-before-join
+        (if (and rcirc-authenticate-before-join
+		 ;; We have to ensure that there's an authentication
+		 ;; entry for that server.  Else,
+		 ;; rcirc-authenticated-hook won't be triggered, and
+		 ;; autojoin won't happen at all.
+		 (dolist (s rcirc-authinfo ret)
+		   (when (string-match (car s) rcirc-server-name)
+		     (setq ret t))))
             (progn
 	      (add-hook 'rcirc-authenticated-hook 'rcirc-join-channels-post-auth t t)
               (rcirc-authenticate))

[Message part 3 (text/plain, inline)]

Bye,
Tassilo

Message #18 received at 8385-done <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
To: 8385-done <at> debbugs.gnu.org
Subject: Re: bug#8385: 24.0.50; rcirc auto-authentication slightly broken
Date: Thu, 31 Mar 2011 14:52:38 +0200

Tassilo pu;hed a fix. Thanks.

Message #21 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#8385: 24.0.50; rcirc auto-authentication slightly broken
Date: Thu, 31 Mar 2011 18:55:42 +0200

2011/3/31 Ted Zlatanov <tzz <at> lifelogs.com>:
> On Thu, 31 Mar 2011 12:13:17 +0200 Tassilo Horn <tassilo <at> member.fsf.org> wrote:
>
> TH> === modified file 'lisp/net/rcirc.el'
> ...
> TH> +            (dolist (s rcirc-authinfo ret)
> TH> +              (when (string-match (car s) rcirc-server-name)
>
> Would it be useful to wire rcirc.el to use auth-source.el?
>
> Ted
>

As I understand it, we are waiting for the FSF to review Neale
Pickett's copyright assignment papers. He has written a few patches
which we want to merge, one of which adds auth-source.el
compatibility.

https://github.com/nealey/rcirc

-- 
Deniz Dogan

Message #24 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#8385: 24.0.50; rcirc auto-authentication slightly broken
Date: Thu, 31 Mar 2011 18:59:12 +0200

2011/3/31 Deniz Dogan <deniz.a.m.dogan <at> gmail.com>:
> 2011/3/31 Ted Zlatanov <tzz <at> lifelogs.com>:
>> On Thu, 31 Mar 2011 12:13:17 +0200 Tassilo Horn <tassilo <at> member.fsf.org> wrote:
>>
>> TH> === modified file 'lisp/net/rcirc.el'
>> ...
>> TH> +            (dolist (s rcirc-authinfo ret)
>> TH> +              (when (string-match (car s) rcirc-server-name)
>>
>> Would it be useful to wire rcirc.el to use auth-source.el?
>>
>> Ted
>>
>
> As I understand it, we are waiting for the FSF to review Neale
> Pickett's copyright assignment papers. He has written a few patches
> which we want to merge, one of which adds auth-source.el
> compatibility.
>
> https://github.com/nealey/rcirc
>

Actually, my bad. Neale's patches have nothing to do with
auth-source.el. I don't know much about auth-source.el but if you feel
that it's easy to wire them together, feel free to write functionality
for it!

-- 
Deniz Dogan

Message #31 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#8385: 24.0.50; rcirc auto-authentication slightly broken
Date: Thu, 19 May 2011 08:48:51 -0500

On Tue, 05 Apr 2011 15:01:02 -0500 Ted Zlatanov <tzz <at> lifelogs.com> wrote: 

TZ> The attached patch will make rcirc.el look at your `auth-sources', which
TZ> by default is the list "~/.authinfo.gpg" "~/.authinfo" "~/.netrc".

Could I get an opinion on this?  I'd like to add it but don't use rcirc
myself so I can't test it or verify it's convenient.

Thanks
Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.