GNU bug report logs - #8373
why not give user an extra variable when compile emacs under windows?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8373 in the body.
You can then email your comments to 8373 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xu Jingtao <jingtaozf <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: why not give user an extra variable when compile emacs under
	windows?  
Date: Tue, 29 Mar 2011 22:45:09 +0800

hi emacs:

When compile emacs under windows, i want to specify some gcc flags like this:
==============================================================
call configure.bat --cflags -DSITELOAD_PURESIZE_EXTRA=10000
==============================================================
But under windows os,the "=" is treated as white space when passed to batch arguments.
So I have to modify this gcc definition in emacs's source tree which is not my pleasure.
Why not give user an extra variable when compile emacs under windows?
For example, named as "LOCAL_FLAGS_WIN",
so i could set this before call configure.bat like this
==============================================================
set LOCAL_FLAGS_WIN=-DSITELOAD_PURESIZE_EXTRA=10000
call configure.bat 
==============================================================
and nt/makefile in emacs source tree is modified to support this variable.
==============================================================
CFLAGS          = -I. $(ARCH_CFLAGS) $(DEBUG_CFLAGS) $(CHECKING_CFLAGS) $(PROFILE_CFLAGS) $(USER_CFLAGS) $(LOCAL_FLAGS) $(LOCAL_FLAGS_WIN)
==============================================================


best regards.
jingtao

Message #8 received at 8373 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Xu Jingtao <jingtaozf <at> gmail.com>
Cc: 8373 <at> debbugs.gnu.org
Subject: Re: bug#8373: why not give user an extra variable when compile emacs
	under windows?
Date: Tue, 29 Mar 2011 20:05:06 +0200

On Tue, Mar 29, 2011 at 16:45, Xu Jingtao <jingtaozf <at> gmail.com> wrote:

> But under windows os,the "=" is treated as white space when passed to batch arguments.
> So I have to modify this gcc definition in emacs's source tree which is not my pleasure.
> Why not give user an extra variable when compile emacs under windows?

I think the proper fix would be finding a way to pass arguments
containing "=" to configure.bat. That might prove difficult, though,
at least with command.com.

    Juanma

Message #11 received at 8373 <at> debbugs.gnu.org (full text, mbox):

From: Xu Jingtao <jingtaozf <at> gmail.com>
To: lekktu <at> gmail.com
Cc: 8373 <at> debbugs.gnu.org
Subject: Re: bug#8373: why not give user an extra variable when compile
	emacs under windows?
Date: Wed, 30 Mar 2011 10:09:49 +0800

parse "=" in dos batch script is very difficult,
because dos batch has poor native string process commands as i could see. 
I think the easy fix would be writing an extra console commands parsing command line 
or give user an extra variable to set the cflags as i have mentioned.

Best regards.
Jingtao
> On Tue, Mar 29, 2011 at 16:45, Xu Jingtao <jingtaozf <at> gmail.com> wrote:
> 
> > But under windows os,the "=" is treated as white space when passed to batch arguments.
> > So I have to modify this gcc definition in emacs's source tree which is not my pleasure.
> > Why not give user an extra variable when compile emacs under windows?
> 
> I think the proper fix would be finding a way to pass arguments
> containing "=" to configure.bat. That might prove difficult, though,
> at least with command.com.
> 
>     Juanma

Message #14 received at 8373 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Xu Jingtao <jingtaozf <at> gmail.com>
Cc: 8373 <at> debbugs.gnu.org
Subject: Re: bug#8373: why not give user an extra variable when compile emacs
	under windows?
Date: Sat, 23 Apr 2011 20:20:35 -0400

Xu Jingtao <jingtaozf <at> gmail.com> writes:

> When compile emacs under windows, i want to specify some gcc flags like this:
> ==============================================================
> call configure.bat --cflags -DSITELOAD_PURESIZE_EXTRA=10000
> ==============================================================
>
> But under windows os,the "=" is treated as white space when passed to
> batch arguments.  So I have to modify this gcc definition in emacs's
> source tree which is not my pleasure.  Why not give user an extra
> variable when compile emacs under windows?

With Ben Key's 2011-04-15 to trunk, the "=" character is supported in
configure.bat, so this should now be unnecessary, I believe.

Message #17 received at 8373-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 8373-done <at> debbugs.gnu.org, jingtaozf <at> gmail.com
Subject: Re: bug#8373: why not give user an extra variable when compile
	emacs	under windows?
Date: Sun, 24 Apr 2011 09:05:49 +0300

> From: Chong Yidong <cyd <at> stupidchicken.com>
> Date: Sat, 23 Apr 2011 20:20:35 -0400
> Cc: 8373 <at> debbugs.gnu.org
> 
> With Ben Key's 2011-04-15 to trunk, the "=" character is supported in
> configure.bat, so this should now be unnecessary, I believe.

Indeed.  This bug can be closed now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.