From unknown Wed Jun 25 09:06:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8360 <8360@debbugs.gnu.org> To: bug#8360 <8360@debbugs.gnu.org> Subject: Status: distcheck-hook never called Reply-To: bug#8360 <8360@debbugs.gnu.org> Date: Wed, 25 Jun 2025 16:06:22 +0000 retitle 8360 distcheck-hook never called reassign 8360 automake submitter 8360 pitamila@free.fr severity 8360 normal tag 8360 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 28 03:19:14 2011 Received: (at submit) by debbugs.gnu.org; 28 Mar 2011 07:19:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q46jJ-0004G3-U1 for submit@debbugs.gnu.org; Mon, 28 Mar 2011 03:19:14 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q46hZ-0004D8-8U for submit@debbugs.gnu.org; Mon, 28 Mar 2011 03:17:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q46hT-000718-CI for submit@debbugs.gnu.org; Mon, 28 Mar 2011 03:17:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:37273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q46hT-000714-AM for submit@debbugs.gnu.org; Mon, 28 Mar 2011 03:17:19 -0400 Received: from [140.186.70.92] (port=49772 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q46hS-0008Ca-8b for bug-automake@gnu.org; Mon, 28 Mar 2011 03:17:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q46hR-00070p-0i for bug-automake@gnu.org; Mon, 28 Mar 2011 03:17:18 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:53480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q46hQ-00070T-HG for bug-automake@gnu.org; Mon, 28 Mar 2011 03:17:16 -0400 Received: from spooler10-g27.priv.proxad.net (unknown [172.20.243.231]) by smtp2-g21.free.fr (Postfix) with ESMTP id CCFBC4B0124 for ; Mon, 28 Mar 2011 09:17:10 +0200 (CEST) Date: Mon, 28 Mar 2011 09:17:09 +0200 (CEST) From: pitamila@free.fr To: bug-automake@gnu.org Message-ID: <1513958581.3903861301296629526.JavaMail.root@spooler10-g27.priv.proxad.net> Subject: distcheck-hook never called MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [132.165.76.2] X-Mailer: Zimbra 5.0 (ZimbraWebClient - FF3.0 (Linux)/5.0.15_GA_2815.UBUNTU8_64) X-Authenticated-User: pitamila@free.fr X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 28 Mar 2011 03:19:12 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Hi, I'd like to make a rpm buildpackage in my distcheck-hook rule. My 'distcheck-hook' rule in my root Makefile.am is never called. I tryed to define a 'distcheck-local' too without success. Is there something more to know than 14.4 of automake manual? thx for support Pitamila PS: I use automake 1.9.6 on redhat 5.6 From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 28 13:55:51 2011 Received: (at 8360) by debbugs.gnu.org; 28 Mar 2011 17:55:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4GfP-0003HJ-7b for submit@debbugs.gnu.org; Mon, 28 Mar 2011 13:55:51 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Q4GfO-0003H7-6X for 8360@debbugs.gnu.org; Mon, 28 Mar 2011 13:55:50 -0400 Received: (qmail invoked by alias); 28 Mar 2011 17:55:35 -0000 Received: from xdsl-89-0-94-92.netcologne.de (EHLO localhost.localdomain) [89.0.94.92] by mail.gmx.net (mp045) with SMTP; 28 Mar 2011 19:55:35 +0200 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX1+hGIknov2hvPX+gsYkSN3C46RA5knrxIvhn/OMyH 6367ZPdZCzwp1B Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1Q4Gf3-0006gk-Ei; Mon, 28 Mar 2011 19:55:29 +0200 Date: Mon, 28 Mar 2011 19:55:29 +0200 From: Ralf Wildenhues To: pitamila@free.fr Subject: Re: bug#8360: distcheck-hook never called Message-ID: <20110328175529.GD13973@gmx.de> References: <1513958581.3903861301296629526.JavaMail.root@spooler10-g27.priv.proxad.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513958581.3903861301296629526.JavaMail.root@spooler10-g27.priv.proxad.net> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 8360 Cc: 8360@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Hello Pitamila, thanks for the report. * pitamila@free.fr wrote on Mon, Mar 28, 2011 at 09:17:09AM CEST: > I'd like to make a rpm buildpackage in my distcheck-hook rule. > My 'distcheck-hook' rule in my root Makefile.am is never called. > I tryed to define a 'distcheck-local' too without success. > Is there something more to know than 14.4 of automake manual? Can you show the Makefile.am file? distcheck-hook should work. > PS: I use automake 1.9.6 on redhat 5.6 Wow, that's six years old. Consider upgrading. Still, it should work even with that version. Cheers, Ralf From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 09 07:27:10 2011 Received: (at submit) by debbugs.gnu.org; 9 Apr 2011 11:27:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8WJq-0006vR-DK for submit@debbugs.gnu.org; Sat, 09 Apr 2011 07:27:10 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8WJo-0006vE-KX for submit@debbugs.gnu.org; Sat, 09 Apr 2011 07:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8WJi-0000Vg-1d for submit@debbugs.gnu.org; Sat, 09 Apr 2011 07:27:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,FREEMAIL_FROM, FREEMAIL_REPLY,RCVD_IN_DNSWL_NONE,T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:49595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8WJh-0000Uj-Vd for submit@debbugs.gnu.org; Sat, 09 Apr 2011 07:27:02 -0400 Received: from [140.186.70.92] (port=32797 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8W5U-0004Gw-U8 for bug-automake@gnu.org; Sat, 09 Apr 2011 07:13:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8W5C-00067u-5q for bug-automake@gnu.org; Sat, 09 Apr 2011 07:12:14 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:41103) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Q8W5B-00067i-OD for bug-automake@gnu.org; Sat, 09 Apr 2011 07:12:02 -0400 Received: (qmail invoked by alias); 09 Apr 2011 11:11:59 -0000 Received: from xdsl-89-0-74-23.netcologne.de (EHLO localhost.localdomain) [89.0.74.23] by mail.gmx.net (mp059) with SMTP; 09 Apr 2011 13:11:59 +0200 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX18WZm8KKvYWegiZSQEYI6LT/5y5h0UvjvFeaqY/06 VzA7OG1czUq9NB Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1Q8W59-0000ER-05; Sat, 09 Apr 2011 13:11:59 +0200 Date: Sat, 9 Apr 2011 13:11:58 +0200 From: Ralf Wildenhues To: pitamila@free.fr Subject: Re: bug#8360: distcheck-hook never called Message-ID: <20110409111158.GJ31779@gmx.de> Mail-Followup-To: pitamila@free.fr, bug-automake@gnu.org References: <486426664.5263691301925640434.JavaMail.root@spooler10-g27.priv.proxad.net> <1196405252.5264251301925773881.JavaMail.root@spooler10-g27.priv.proxad.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1196405252.5264251301925773881.JavaMail.root@spooler10-g27.priv.proxad.net> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit Cc: bug-automake@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) Hello Pitamila, let's keep the mailing list in Cc:, please. I would've seen your reply earlier then. * pitamila@free.fr wrote on Mon, Apr 04, 2011 at 04:02:53PM CEST: > ----- "Ralf Wildenhues" a écrit : > > > > thanks for the report. > > thanks for the support, I hope my answer is not too late. There's (almost) never a "too late" when giving useful feedback! > > * pitamila@free.fr wrote on Mon, Mar 28, 2011 at 09:17:09AM CEST: > > > I'd like to make a rpm buildpackage in my distcheck-hook rule. > > > My 'distcheck-hook' rule in my root Makefile.am is never called. > > > I tryed to define a 'distcheck-local' too without success. > > > Is there something more to know than 14.4 of automake manual? > > > > Can you show the Makefile.am file? distcheck-hook should work. > > Find attached the Makefile.am of my doc/ subdir > In fact I try to call a clean-local without success (I suppose > it's the same bug than my distcheck-local not beeing called > in my top Makefile.am) Yep. And you have indeed stumbled over a limitation in automake; I could call it a bug, but I'm inclined to document it rather than fix it as it is worked around easily. Quoting your Makefile.am: clean-local : -rm -rf html/* html @PACKAGE@.pdf latex/* latex There is a literal TAB after 'clean-local'. automake's parser is pretty dumb when it comes to distinguishing rule commands from rule lines from variable assignments, mostly because it is hard to get things right when hard-core GNU make code is used. Anyway, in this case it gets things wrong due to the TAB. Solution is to remove the TAB before the colon, maybe replacing it with a number of spaces. Then everything will work out fine. OK to add you to THANKS for the eventual documentation patch I've yet to write? Thanks again for the report, Ralf From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 09 07:27:16 2011 Received: (at submit) by debbugs.gnu.org; 9 Apr 2011 11:27:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8WJw-0006vi-Lk for submit@debbugs.gnu.org; Sat, 09 Apr 2011 07:27:16 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q8WJu-0006vQ-SH for submit@debbugs.gnu.org; Sat, 09 Apr 2011 07:27:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8WJp-0000Wt-9N for submit@debbugs.gnu.org; Sat, 09 Apr 2011 07:27:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:49730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8WJp-0000WM-5n for submit@debbugs.gnu.org; Sat, 09 Apr 2011 07:27:09 -0400 Received: from [140.186.70.92] (port=32796 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8W5s-0004M9-T7 for bug-automake@gnu.org; Sat, 09 Apr 2011 07:12:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8W5m-0006IP-9k for bug-automake@gnu.org; Sat, 09 Apr 2011 07:12:42 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:43507) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Q8W5l-0006Hg-PY for bug-automake@gnu.org; Sat, 09 Apr 2011 07:12:38 -0400 Received: (qmail invoked by alias); 09 Apr 2011 11:12:36 -0000 Received: from xdsl-89-0-74-23.netcologne.de (EHLO localhost.localdomain) [89.0.74.23] by mail.gmx.net (mp067) with SMTP; 09 Apr 2011 13:12:36 +0200 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX19DZAUlUzxDDOl38iII+wUCRHWG7/mPRBOzwTU7ya adlJFqLX60aA3W Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1Q8W5j-0000EW-Ua; Sat, 09 Apr 2011 13:12:35 +0200 Date: Sat, 9 Apr 2011 13:12:35 +0200 From: Ralf Wildenhues To: pitamila@free.fr Subject: Re: bug#8360: distcheck-hook never called Message-ID: <20110409111235.GK31779@gmx.de> Mail-Followup-To: pitamila@free.fr, bug-automake@gnu.org References: <486426664.5263691301925640434.JavaMail.root@spooler10-g27.priv.proxad.net> <1196405252.5264251301925773881.JavaMail.root@spooler10-g27.priv.proxad.net> <20110409111158.GJ31779@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110409111158.GJ31779@gmx.de> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit Cc: bug-automake@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) * Ralf Wildenhues wrote on Sat, Apr 09, 2011 at 01:11:58PM CEST: > OK to add you to THANKS for the eventual documentation patch I've yet to > write? Can we have a full name for that too? From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 14:58:20 2011 Received: (at submit) by debbugs.gnu.org; 1 Sep 2011 18:58:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QzCSu-00037R-Hi for submit@debbugs.gnu.org; Thu, 01 Sep 2011 14:58:20 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QzCSr-00037J-7o for submit@debbugs.gnu.org; Thu, 01 Sep 2011 14:58:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzCPZ-0008Bn-Ly for submit@debbugs.gnu.org; Thu, 01 Sep 2011 14:54:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, FREEMAIL_REPLY,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:49114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzCPZ-00085G-AH for submit@debbugs.gnu.org; Thu, 01 Sep 2011 14:54:49 -0400 Received: from eggs.gnu.org ([140.186.70.92]:57475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzBl3-0000Yk-4h for bug-automake@gnu.org; Thu, 01 Sep 2011 14:12:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzBl1-0008HU-4i for bug-automake@gnu.org; Thu, 01 Sep 2011 14:12:57 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:43129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzBl0-0008HN-L3; Thu, 01 Sep 2011 14:12:55 -0400 Received: by wwf10 with SMTP id 10so1868896wwf.30 for ; Thu, 01 Sep 2011 11:12:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:references:in-reply-to:cc :x-kmail-markup:mime-version:content-type:message-id; bh=ahmYwh99NQPD+/95Uo/M0XrG96KzZbOqIa6jAx13Dnk=; b=hrWzP8UoPxPkgHKmAn7yMEgx2SJl83ie6EHg1NWHm3HUmmJXXOWf6nvTRnGEz/PG52 enL9PeGRCTYLMCOsEQxZctzN5mkT4Jml8TWY9JqwSptDcqRJSt+Evoy9JDHGgQ7hYlrp k2o1rBPNjmuOlscTVZn0W5wEC+5odnxYPTNRI= Received: by 10.227.196.80 with SMTP id ef16mr146551wbb.27.1314900772371; Thu, 01 Sep 2011 11:12:52 -0700 (PDT) Received: from bigio.localnet (host64-30-dynamic.56-82-r.retail.telecomitalia.it [82.56.30.64]) by mx.google.com with ESMTPS id fj19sm239557wbb.15.2011.09.01.11.12.47 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 01 Sep 2011 11:12:48 -0700 (PDT) From: Stefano Lattarini To: pitamila@free.fr, bug-automake@gnu.org Subject: Re: bug#8360: distcheck-hook never called Date: Thu, 1 Sep 2011 20:12:37 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) References: <486426664.5263691301925640434.JavaMail.root@spooler10-g27.priv.proxad.net> <1196405252.5264251301925773881.JavaMail.root@spooler10-g27.priv.proxad.net> <20110409111158.GJ31779@gmx.de> In-Reply-To: <20110409111158.GJ31779@gmx.de> X-KMail-Markup: true MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_Ws8XOtaZ2Nmsl1/" Message-Id: <201109012012.38834.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Ralf Wildenhues , automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) --Boundary-00=_Ws8XOtaZ2Nmsl1/ Content-Type: multipart/alternative; boundary="Boundary-01=_Ws8XOBtyLUN2q7b" Content-Transfer-Encoding: 7bit --Boundary-01=_Ws8XOBtyLUN2q7b Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Resurrecting an old thread, for reference see: On Saturday 09 April 2011, Ralf Wildenhues wrote: > Hello Pitamila, >=20 > let's keep the mailing list in Cc:, please. I would've seen your reply > earlier then. >=20 > * pitamila@free.fr wrote on Mon, Apr 04, 2011 at 04:02:53PM CEST: > > ----- "Ralf Wildenhues" a =C3=A9crit : > > >=20 > > > thanks for the report. > >=20 > > thanks for the support, I hope my answer is not too late. >=20 > There's (almost) never a "too late" when giving useful feedback! >=20 > > > * pitamila@free.fr wrote on Mon, Mar 28, 2011 at 09:17:09AM CEST: > > > > I'd like to make a rpm buildpackage in my distcheck-hook rule. > > > > My 'distcheck-hook' rule in my root Makefile.am is never called. > > > > I tryed to define a 'distcheck-local' too without success. > > > > Is there something more to know than 14.4 of automake manual? > > >=20 > > > Can you show the Makefile.am file? distcheck-hook should work. > >=20 > > Find attached the Makefile.am of my doc/ subdir > > In fact I try to call a clean-local without success (I suppose > > it's the same bug than my distcheck-local not beeing called > > in my top Makefile.am) >=20 > Yep. And you have indeed stumbled over a limitation in automake; > I could call it a bug, but I'm inclined to document it rather than > fix it as it is worked around easily. >=20 > Quoting your Makefile.am: >=20 > clean-local : > -rm -rf html/* html @PACKAGE@.pdf latex/* latex >=20 > There is a literal TAB after 'clean-local'. automake's parser is pretty > dumb when it comes to distinguishing rule commands from rule lines from > variable assignments, mostly because it is hard to get things right when > hard-core GNU make code is used. >=20 > Anyway, in this case it gets things wrong due to the TAB. Solution is > to remove the TAB before the colon, maybe replacing it with a number of > spaces. Then everything will work out fine. >=20 I've ended up writing a documentation patch for this, as well for another unrelated limitation encountered by Roberto Bagnara in an older thread on the automake list, see: Since I was at it, I've written two tests verifying the documented behaviour. I will wait a few hours before pushing (to maint), to allow for reviews. Regards, Stefano --Boundary-01=_Ws8XOBtyLUN2q7b Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Resurrectin= g an old thread, for reference see:

<http:= //debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8360>


On Saturday= 09 April 2011, Ralf Wildenhues wrote:

> Hello = Pitamila,

>

> let's = keep the mailing list in Cc:, please. I would've seen your reply

> earlie= r then.

>

> * pita= mila@free.fr wrote on Mon, Apr 04, 2011 at 04:02:53PM CEST:

> > -= =2D--- "Ralf Wildenhues" a =C3=A9crit :

> > &= gt;

> > &= gt; thanks for the report.

> > <= /p>

> > t= hanks for the support, I hope my answer is not too late.

>

> There'= s (almost) never a "too late" when giving useful feedback!

>

> > &= gt; * pitamila@free.fr wrote on Mon, Mar 28, 2011 at 09:17:09AM CEST:

> > &= gt; > I'd like to make a rpm buildpackage in my distcheck-hook rule.

> > &= gt; > My 'distcheck-hook' rule in my root Makefile.am is never called.

> > &= gt; > I tryed to define a 'distcheck-local' too without success.

> > &= gt; > Is there something more to know than 14.4 of automake manual?

> > &= gt;

> > &= gt; Can you show the Makefile.am file? distcheck-hook should work.

> > <= /p>

> > F= ind attached the Makefile.am of my doc/ subdir

> > I= n fact I try to call a clean-local without success (I suppose

> > i= t's the same bug than my distcheck-local not beeing called

> > i= n my top Makefile.am)

>

> Yep. = And you have indeed stumbled over a limitation in automake;

> I coul= d call it a bug, but I'm inclined to document it rather than

> fix it= as it is worked around easily.

>

> Quotin= g your Makefile.am:

>

> clean-= local :

> -rm = =2Drf html/* html @PACKAGE@.pdf latex/* latex

>

> There = is a literal TAB after 'clean-local'. automake's parser is pretty

> dumb w= hen it comes to distinguishing rule commands from rule lines from

> variab= le assignments, mostly because it is hard to get things right when

> hard-c= ore GNU make code is used.

>

> Anyway= , in this case it gets things wrong due to the TAB. Solution is

> to rem= ove the TAB before the colon, maybe replacing it with a number of

> spaces= =2E Then everything will work out fine.

>

I've ended = up writing a documentation patch for this, as well for another

unrelated l= imitation encountered by Roberto Bagnara in an older thread on

the automak= e list, see:

<http:= //lists.gnu.org/archive/html/automake/2010-08/msg00074.html>

Since I was= at it, I've written two tests verifying the documented

behaviour.<= /p>


I will wait= a few hours before pushing (to maint), to allow for reviews.


Regards,

Stefano


--Boundary-01=_Ws8XOBtyLUN2q7b-- --Boundary-00=_Ws8XOtaZ2Nmsl1/ Content-Type: text/x-patch; charset="utf-8"; name="0001-docs-report-few-more-automake-parsing-limitations.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="0001-docs-report-few-more-automake-parsing-limitations.patch" =46rom 00e845afb826107a14db247a465eefea728f9bc5 Mon Sep 17 00:00:00 2001 Message-Id: <00e845afb826107a14db247a465eefea728f9bc5.1314900069.git.stefan= o.lattarini@gmail.com> =46rom: Stefano Lattarini Date: Thu, 1 Sep 2011 19:17:39 +0200 Subject: [PATCH] docs: report few more automake parsing limitations Partly motivated by automake bug#8360. * doc/automake.texi (General Operation): Report few more automake limitations w.r.t. parsing of unusual makefile constructs. Related minor reorderings. * tests/doc-parsing-buglets-colneq-subst.test: New test. * tests/doc-parsing-buglets-tabs.test: Likewise. * tests/Makefile.am (TESTS): Update. =2D-- ChangeLog | 11 +++++ doc/automake.texi | 26 +++++++++-- tests/Makefile.am | 2 + tests/Makefile.in | 2 + tests/doc-parsing-buglets-colneq-subst.test | 39 ++++++++++++++++ tests/doc-parsing-buglets-tabs.test | 64 +++++++++++++++++++++++= ++++ 6 files changed, 139 insertions(+), 5 deletions(-) create mode 100755 tests/doc-parsing-buglets-colneq-subst.test create mode 100755 tests/doc-parsing-buglets-tabs.test diff --git a/ChangeLog b/ChangeLog index 7c11ab3..5d0eda1 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +2011-09-01 Stefano Lattarini + + docs: report few more automake parsing limitations + Partly motivated by automake bug#8360. + * doc/automake.texi (General Operation): Report few more automake + limitations w.r.t. parsing of unusual makefile constructs. Related + minor reorderings. + * tests/doc-parsing-buglets-colneq-subst.test: New test. + * tests/doc-parsing-buglets-tabs.test: Likewise. + * tests/Makefile.am (TESTS): Update. + 2011-08-25 Stefano Lattarini =20 tests: list "forgotten" test script in TESTS diff --git a/doc/automake.texi b/doc/automake.texi index 49a6cd1..3be8578 100644 =2D-- a/doc/automake.texi +++ b/doc/automake.texi @@ -1813,14 +1813,30 @@ supported. This operator appends its right hand ar= gument to the variable specified on the left. Automake will translate the operator into an ordinary @samp{=3D} operator; @samp{+=3D} will thus work with any make = program. =20 =2D@cindex indentation =2DFurther note that variable assignments should not be indented with =2D@key{TAB} characters, use spaces if necessary. On the other hand, =2Drule commands should be indented with a leading @key{TAB} character. =2D Automake tries to keep comments grouped with any adjoining rules or variable definitions. =20 +@cindex Limitations of automake parser +@cindex Automake parser, limitations of +@cindex indentation in Makefile.am +Generally, Automake is not particularly smart in the parsing of unusual +Makefile constructs, so you're advised to avoid fancy constructs or +``creative'' use of whitespaces. +@c Keep this in sync with doc-parsing-buglets-tabs.test. +For example, @key{TAB} characters cannot be used between a target name +and the following ``@code{:}'' character, and variable assignments +shouldn't be indented with @key{TAB} characters. +@c Keep this in sync with doc-parsing-buglets-colneq-subst.test. +Also, using more complex macro in target names can cause trouble: + +@example +% @kbd{cat Makefile.am} +$(FOO:=3Dx): bar +% @kbd{automake} +Makefile.am:1: bad characters in variable name `$(FOO' +Makefile.am:1: `:=3D'-style assignments are not portable +@end example + @cindex Make targets, overriding @cindex Make rules, overriding @cindex Overriding make rules diff --git a/tests/Makefile.am b/tests/Makefile.am index a1c67ff..6101460 100644 =2D-- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -325,6 +325,8 @@ distcheck-configure-flags-subpkg.test \ distcheck-hook.test \ distcheck-hook2.test \ dmalloc.test \ +doc-parsing-buglets-colneq-subst.test \ +doc-parsing-buglets-tabs.test \ dollar.test \ dollarvar.test \ dollarvar2.test \ diff --git a/tests/Makefile.in b/tests/Makefile.in index 4b2d845..108672d 100644 =2D-- a/tests/Makefile.in +++ b/tests/Makefile.in @@ -603,6 +603,8 @@ distcheck-configure-flags-subpkg.test \ distcheck-hook.test \ distcheck-hook2.test \ dmalloc.test \ +doc-parsing-buglets-colneq-subst.test \ +doc-parsing-buglets-tabs.test \ dollar.test \ dollarvar.test \ dollarvar2.test \ diff --git a/tests/doc-parsing-buglets-colneq-subst.test b/tests/doc-parsin= g-buglets-colneq-subst.test new file mode 100755 index 0000000..685d2b6 =2D-- /dev/null +++ b/tests/doc-parsing-buglets-colneq-subst.test @@ -0,0 +1,39 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check a documented limitation of the Automake's Makefile parser +# w.r.t. POSIX variable substitutions used in the name of targets. +# See Section "General Operation" in the Automake manual. +# If you cause some parts of this test to fail, chances are that you've +# improved the Automake parser ;-) +# See: +# or: + +. ./defs || Exit 1 + +set -e + +cat > Makefile.am <<'END' +$(FOO:=3Dx): bar +END + +$ACLOCAL +AUTOMAKE_fails + +grep 'bad characters.*variable name.*\$(FOO' stderr +grep ':=3D.*assignments.*not portable' stderr + +: diff --git a/tests/doc-parsing-buglets-tabs.test b/tests/doc-parsing-buglet= s-tabs.test new file mode 100755 index 0000000..eee4a81 =2D-- /dev/null +++ b/tests/doc-parsing-buglets-tabs.test @@ -0,0 +1,64 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check the documented limitation of the Automake's Makefile parser w.r.t. +# use of TAB characters; see Section "General Operation" in the Automake +# manual, and automake bug#8360. +# If you cause some parts of this test to fail, chances are that you've +# improved the Automake parser ;-) + +. ./defs || Exit 1 + +set -e + +cat > Makefile.am <> configure.in + +$ACLOCAL +$AUTOMAKE + +$FGREP '$(EXEEEXT)' Makefile.in && Exit 1 +grep 'all:.*all-local' Makefile.in && Exit 1 +grep "^${tab}bin_PROGRAMS =3D foo" Makefile.in + +$AUTOCONF +./configure + +$MAKE test + +: =2D-=20 1.7.2.3 --Boundary-00=_Ws8XOtaZ2Nmsl1/-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 02 04:12:33 2011 Received: (at 8360) by debbugs.gnu.org; 2 Sep 2011 08:12:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QzOrY-0006OG-TX for submit@debbugs.gnu.org; Fri, 02 Sep 2011 04:12:33 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QzOrW-0006O5-EQ; Fri, 02 Sep 2011 04:12:31 -0400 Received: by wwg7 with SMTP id 7so2655936wwg.15 for ; Fri, 02 Sep 2011 01:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :x-kmail-markup:mime-version:content-type:content-transfer-encoding :message-id; bh=G222lCCsEE9LWXBNQVHPfKeqt5kReYF1XEG58xArJxk=; b=vBb/Zj7aWgPcFpiBvlnwMzxn5Ix5/mxjzWqgnHBgcbLdKYwG/z4T8Irfd+4fqXZOGd AyU6BkJT91HGsf6pgvPkJ4OCXCZfMHLY3aOw0Xtq74lrpf9Qj5mybUPxTy40jna1/AuK b7fHxjMuNpsHCmtWQGb+OWWA8JuU0xWkdTGIU= Received: by 10.216.54.140 with SMTP id i12mr1143915wec.16.1314950946587; Fri, 02 Sep 2011 01:09:06 -0700 (PDT) Received: from bigio.localnet (host109-95-dynamic.10-79-r.retail.telecomitalia.it [79.10.95.109]) by mx.google.com with ESMTPS id ex16sm816323wbb.4.2011.09.02.01.09.03 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 02 Sep 2011 01:09:04 -0700 (PDT) From: Stefano Lattarini To: pitamila@free.fr, automake-patches@gnu.org Subject: Re: bug#8360: distcheck-hook never called Date: Fri, 2 Sep 2011 10:08:48 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) References: <486426664.5263691301925640434.JavaMail.root@spooler10-g27.priv.proxad.net> <20110409111158.GJ31779@gmx.de> <201109012012.38834.stefano.lattarini@gmail.com> In-Reply-To: <201109012012.38834.stefano.lattarini@gmail.com> X-KMail-Markup: true MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="Boundary-01=_R8IYO0YJBuGUaS2" Content-Transfer-Encoding: 7bit Message-Id: <201109021008.49188.stefano.lattarini@gmail.com> X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 8360 Cc: Ralf Wildenhues , 8360@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) --Boundary-01=_R8IYO0YJBuGUaS2 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit tags 8360 + patch close 8360 thanks On Thursday 01 September 2011, Stefano Lattarini wrote: > Resurrecting an old thread, for reference see: > > > On Saturday 09 April 2011, Ralf Wildenhues wrote: > > Anyway, in this case it gets things wrong due to the TAB. Solution is > > to remove the TAB before the colon, maybe replacing it with a number of > > spaces. Then everything will work out fine. > > > I've ended up writing a documentation patch for this, as well for another > unrelated limitation encountered by Roberto Bagnara in an older thread on > the automake list, see: > > Since I was at it, I've written two tests verifying the documented > behaviour. > > I will wait a few hours before pushing (to maint), to allow for reviews. > > Regards, > Stefano > I've pushed the patch now: and I'm closing this bug report. Regards, Stefano --Boundary-01=_R8IYO0YJBuGUaS2 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

tags 8360 + patch

close 8360

thanks


On Thursday 01 September 2011, Stefano Lattarini wrote:

> Resurrecting an old thread, for reference see:

> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8360>

>

> On Saturday 09 April 2011, Ralf Wildenhues wrote:

> > Anyway, in this case it gets things wrong due to the TAB. Solution is

> > to remove the TAB before the colon, maybe replacing it with a number of

> > spaces. Then everything will work out fine.

> >

> I've ended up writing a documentation patch for this, as well for another

> unrelated limitation encountered by Roberto Bagnara in an older thread on

> the automake list, see:

> <http://lists.gnu.org/archive/html/automake/2010-08/msg00074.html>

> Since I was at it, I've written two tests verifying the documented

> behaviour.

>

> I will wait a few hours before pushing (to maint), to allow for reviews.

>

> Regards,

> Stefano

>

I've pushed the patch now:

<http://lists.gnu.org/archive/html/automake-patches/2011-09/msg00002.html>

and I'm closing this bug report.


Regards,

Stefano

--Boundary-01=_R8IYO0YJBuGUaS2-- From unknown Wed Jun 25 09:06:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 30 Sep 2011 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator