From unknown Sun Jun 15 08:41:22 2025 X-Loop: don@donarmstrong.com Subject: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode Reply-To: Markus Triska , 835@debbugs.gnu.org Resent-From: Markus Triska Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 31 Aug 2008 09:15:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 835 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122017372927072 (code B ref -1); Sun, 31 Aug 2008 09:15:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.0 required=4.0 tests=AWL,BAYES_00,FOURLA, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 31 Aug 2008 09:08:49 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7V98jfc026970 for ; Sun, 31 Aug 2008 02:08:46 -0700 Received: from mail.gnu.org ([199.232.76.166]:47601 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KZitr-0005jR-05 for emacs-pretest-bug@gnu.org; Sun, 31 Aug 2008 05:07:11 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KZivI-000137-4R for emacs-pretest-bug@gnu.org; Sun, 31 Aug 2008 05:08:44 -0400 Received: from mail.gmx.net ([213.165.64.20]:43021) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KZivH-00012V-BE for emacs-pretest-bug@gnu.org; Sun, 31 Aug 2008 05:08:39 -0400 Received: (qmail invoked by alias); 31 Aug 2008 09:08:35 -0000 Received: from v254-019.vps.tuwien.ac.at (EHLO v254-019.vps.tuwien.ac.at) [128.131.254.19] by mail.gmx.net (mp067) with SMTP; 31 Aug 2008 11:08:36 +0200 X-Authenticated: #4064391 X-Provags-ID: V01U2FsdGVkX18+0BUPg2s+nE4ekNJVKokq7UH+pd5DNGK/ssRgMA 97px/QzrI4EqJi Received: by v254-019.vps.tuwien.ac.at (Postfix, from userid 502) id 74CC0A46A03; Sun, 31 Aug 2008 05:08:14 -0400 (EDT) From: Markus Triska To: emacs-pretest-bug@gnu.org Date: Sun, 31 Aug 2008 05:08:14 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.53 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. When I do: $ emacs -Q -f view-mode and then "C-x * Q", nothing happens. ("C-x * *" works as expected.) In GNU Emacs 23.0.60.7 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9) of 2008-08-30 on v254-034.vps.tuwien.ac.at Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000 Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t From unknown Sun Jun 15 08:41:22 2025 X-Loop: don@donarmstrong.com Subject: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode Reply-To: martin rudalics , 835@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 31 Aug 2008 11:00:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 835 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 835-submit@emacsbugs.donarmstrong.com id=B835.122017991729317 (code B ref 835); Sun, 31 Aug 2008 11:00:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 835) by emacsbugs.donarmstrong.com; 31 Aug 2008 10:51:57 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m7VAprs3029311 for <835@emacsbugs.donarmstrong.com>; Sun, 31 Aug 2008 03:51:54 -0700 Received: (qmail invoked by alias); 31 Aug 2008 10:51:47 -0000 Received: from 62-47-56-216.adsl.highway.telekom.at (EHLO [62.47.56.216]) [62.47.56.216] by mail.gmx.net (mp034) with SMTP; 31 Aug 2008 12:51:47 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18FIU87vggF/fgTd7gT/Ov8eFeh6LqZd1z4BOysgw ZsZ63W7CeIsLQr Message-ID: <48BA7715.2030201@gmx.at> Date: Sun, 31 Aug 2008 12:48:53 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Markus Triska , 835@debbugs.gnu.org References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.71 > When I do: > > $ emacs -Q -f view-mode > > and then "C-x * Q", nothing happens. ("C-x * *" works as expected.) Does it work if you replace (when (string-match "abcdefhijklnopqrstuwxyz" (char-to-string (car x))) (define-key map (char-to-string (- (car x) ?a -1)) (cdr x))) by something like (when (string-match "[a-z]" (char-to-string (car x))) (define-key map (upcase (char-to-string (car x))) (cdr x))) in the definition of `calc-dispatch-map'? martin From unknown Sun Jun 15 08:41:22 2025 X-Loop: don@donarmstrong.com Subject: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode Reply-To: martin rudalics , 835@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 01 Sep 2008 18:10:06 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 835 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 835-submit@emacsbugs.donarmstrong.com id=B835.122029204116302 (code B ref 835); Mon, 01 Sep 2008 18:10:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.1 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MIXEDBDN,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 835) by emacsbugs.donarmstrong.com; 1 Sep 2008 18:00:41 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m81I0bv3016199 for <835@emacsbugs.donarmstrong.com>; Mon, 1 Sep 2008 11:00:38 -0700 Received: (qmail invoked by alias); 01 Sep 2008 18:00:29 -0000 Received: from 62-47-47-164.adsl.highway.telekom.at (EHLO [62.47.47.164]) [62.47.47.164] by mail.gmx.net (mp063) with SMTP; 01 Sep 2008 20:00:29 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/wotAzgErwGgjFrj9AOIQOSJFNceoaB0fHHNE98e eAQh9cAQPxbvby Message-ID: <48BC2AC8.5010905@gmx.at> Date: Mon, 01 Sep 2008 19:47:52 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: 835@debbugs.gnu.org CC: Markus Triska References: <48BA7715.2030201@gmx.at> In-Reply-To: <48BA7715.2030201@gmx.at> Content-Type: multipart/mixed; boundary="------------010007050603040505090004" X-Y-GMX-Trusted: 0 X-FuHaFi: 0.78,0.64 This is a multi-part message in MIME format. --------------010007050603040505090004 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > > When I do: > > > > $ emacs -Q -f view-mode > > > > and then "C-x * Q", nothing happens. ("C-x * *" works as expected.) Any objections against the attached patch? martin --------------010007050603040505090004 Content-Type: text/plain; name="835.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="835.diff" *** calc/calc.el.~1.115.~ 2008-08-23 09:41:44.515625000 +0200 --- calc/calc.el 2008-09-01 19:43:05.515625000 +0200 *************** *** 1097,1105 **** (let ((map (make-keymap))) (mapc (lambda (x) (define-key map (char-to-string (car x)) (cdr x)) ! (when (string-match "abcdefhijklnopqrstuwxyz" (char-to-string (car x))) ! (define-key map (char-to-string (- (car x) ?a -1)) (cdr x))) (define-key map (format "\e%c" (car x)) (cdr x))) '( ( ?a . calc-embedded-activate ) ( ?b . calc-big-or-small ) --- 1097,1105 ---- (let ((map (make-keymap))) (mapc (lambda (x) (define-key map (char-to-string (car x)) (cdr x)) ! (when (string-match "[abcdefhijklnopqrstuwxyz]" (char-to-string (car x))) ! (define-key map (upcase (char-to-string (car x))) (cdr x))) (define-key map (format "\e%c" (car x)) (cdr x))) '( ( ?a . calc-embedded-activate ) ( ?b . calc-big-or-small ) --------------010007050603040505090004-- From unknown Sun Jun 15 08:41:22 2025 X-Loop: don@donarmstrong.com Subject: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode Reply-To: Chong Yidong , 835@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 01 Sep 2008 19:00:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 835 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 835-submit@emacsbugs.donarmstrong.com id=B835.12202950771178 (code B ref 835); Mon, 01 Sep 2008 19:00:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 835) by emacsbugs.donarmstrong.com; 1 Sep 2008 18:51:17 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m81IpEmW001172 for <835@emacsbugs.donarmstrong.com>; Mon, 1 Sep 2008 11:51:15 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id DED2457E337; Mon, 1 Sep 2008 14:53:30 -0400 (EDT) To: martin rudalics Cc: Jay Belanger , 835@debbugs.gnu.org From: Chong Yidong Date: Mon, 01 Sep 2008 14:53:30 -0400 Message-ID: <87fxojg0k5.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii martin rudalics wrote: > Any objections against the attached patch? *** calc/calc.el.~1.115.~ 2008-08-23 09:41:44.515625000 +0200 --- calc/calc.el 2008-09-01 19:43:05.515625000 +0200 *************** *** 1097,1105 **** (let ((map (make-keymap))) (mapc (lambda (x) (define-key map (char-to-string (car x)) (cdr x)) ! (when (string-match "abcdefhijklnopqrstuwxyz" (char-to-string (car x))) ! (define-key map (char-to-string (- (car x) ?a -1)) (cdr x))) (define-key map (format "\e%c" (car x)) (cdr x))) '( ( ?a . calc-embedded-activate ) ( ?b . calc-big-or-small ) --- 1097,1105 ---- (let ((map (make-keymap))) (mapc (lambda (x) (define-key map (char-to-string (car x)) (cdr x)) ! (when (string-match "[abcdefhijklnopqrstuwxyz]" (char-to-string (car x))) ! (define-key map (upcase (char-to-string (car x))) (cdr x))) (define-key map (format "\e%c" (car x)) (cdr x))) '( ( ?a . calc-embedded-activate ) ( ?b . calc-big-or-small ) Indeed, the argument to string-match in the original code looks like a typo (fixed by the first line of the patch). The second part of the patch is not clear to me. What the original code does is the following: for a character such as "n", it adds "C-n" to the keymap as well (it's a hack that relies on the specific properties of the ASCII table, and needs at least a comment). That's not what the patched code does: it adds "N" to the keymap. Martin, what's the reason for this change? From unknown Sun Jun 15 08:41:22 2025 X-Loop: don@donarmstrong.com Subject: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode Reply-To: martin rudalics , 835@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 01 Sep 2008 21:20:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 835 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 835-submit@emacsbugs.donarmstrong.com id=B835.122030343517134 (code B ref 835); Mon, 01 Sep 2008 21:20:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 835) by emacsbugs.donarmstrong.com; 1 Sep 2008 21:10:35 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m81LAV7Z017128 for <835@emacsbugs.donarmstrong.com>; Mon, 1 Sep 2008 14:10:33 -0700 Received: (qmail invoked by alias); 01 Sep 2008 21:10:25 -0000 Received: from 62-47-37-200.adsl.highway.telekom.at (EHLO [62.47.37.200]) [62.47.37.200] by mail.gmx.net (mp006) with SMTP; 01 Sep 2008 23:10:25 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX180KIov1LM0+F1tTIVFyWZFT+LoL9QpiBhZtOsDEc AUHC2TlgSBI1MR Message-ID: <48BC59BB.5@gmx.at> Date: Mon, 01 Sep 2008 23:08:11 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Chong Yidong CC: Jay Belanger , 835@debbugs.gnu.org References: <87fxojg0k5.fsf@cyd.mit.edu> In-Reply-To: <87fxojg0k5.fsf@cyd.mit.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.65 > ! (define-key map (char-to-string (- (car x) ?a -1)) (cdr > x))) [...] > ! (define-key map (upcase (char-to-string (car x))) (cdr > x))) > What the original code > does is the following: for a character such as "n", it adds "C-n" to the > keymap as well (it's a hack that relies on the specific properties of > the ASCII table, and needs at least a comment). That's not what the > patched code does: it adds "N" to the keymap. Martin, what's the reason > for this change? That was my intention: AFAICT `view-mode' took `Q' (and, for example, `E') away from calc and I simply tried to give it back to calc. But maybe this part of the code really intended to add a "C-" ... martin From unknown Sun Jun 15 08:41:22 2025 X-Loop: don@donarmstrong.com Subject: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode Reply-To: Chong Yidong , 835@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 01 Sep 2008 21:55:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 835 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 835-submit@emacsbugs.donarmstrong.com id=B835.122030572429098 (code B ref 835); Mon, 01 Sep 2008 21:55:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 835) by emacsbugs.donarmstrong.com; 1 Sep 2008 21:48:44 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m81LmfHf029092 for <835@emacsbugs.donarmstrong.com>; Mon, 1 Sep 2008 14:48:42 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 57EC457E337; Mon, 1 Sep 2008 17:50:58 -0400 (EDT) To: martin rudalics Cc: Jay Belanger , 835@debbugs.gnu.org References: <87fxojg0k5.fsf@cyd.mit.edu> <48BC59BB.5@gmx.at> From: Chong Yidong Date: Mon, 01 Sep 2008 17:50:58 -0400 In-Reply-To: <48BC59BB.5@gmx.at> (martin rudalics's message of "Mon\, 01 Sep 2008 23\:08\:11 +0200") Message-ID: <87y72bilh9.fsf@cyd.mit.edu> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii martin rudalics writes: >> ! (define-key map (char-to-string (- (car x) ?a -1)) (cdr x))) > [...] >> ! (define-key map (upcase (char-to-string (car x))) (cdr x))) > >> What the original code does is the following: for a character such as >> "n", it adds "C-n" to the keymap as well (it's a hack that relies on >> the specific properties of the ASCII table, and needs at least a >> comment). That's not what the patched code does: it adds "N" to the >> keymap. Martin, what's the reason for this change? > > That was my intention: AFAICT `view-mode' took `Q' (and, for example, > `E') away from calc and I simply tried to give it back to calc. But > maybe this part of the code really intended to add a "C-" ... Yeah, it's somewhat opaque code. The way the ASCII table is set up is that character 1 is the character ^A, character 2 is the character ^B, and so forth, until character 65 is the unmodified character A. Hence (char-to-string (- ?n ?a -1)) gives 14 == ^N. (Also, ASCII control characters are case insensitive: there's no separate ^n character.) I suppose this means we have to find a separate fix for the original bug... From unknown Sun Jun 15 08:41:22 2025 X-Loop: don@donarmstrong.com Subject: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode Reply-To: martin rudalics , 835@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 01 Sep 2008 22:10:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 835 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 835-submit@emacsbugs.donarmstrong.com id=B835.12203065471474 (code B ref 835); Mon, 01 Sep 2008 22:10:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 835) by emacsbugs.donarmstrong.com; 1 Sep 2008 22:02:27 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m81M2Nh0001468 for <835@emacsbugs.donarmstrong.com>; Mon, 1 Sep 2008 15:02:24 -0700 Received: (qmail invoked by alias); 01 Sep 2008 22:02:17 -0000 Received: from 62-47-37-200.adsl.highway.telekom.at (EHLO [62.47.37.200]) [62.47.37.200] by mail.gmx.net (mp044) with SMTP; 02 Sep 2008 00:02:17 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+yvBxaHKyy8O9G90bclJoFNa4KbSd95nC+tpxpZb UBeW7TxMb3cXXv Message-ID: <48BC65E3.5010709@gmx.at> Date: Tue, 02 Sep 2008 00:00:03 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Chong Yidong CC: Jay Belanger , 835@debbugs.gnu.org References: <87fxojg0k5.fsf@cyd.mit.edu> <48BC59BB.5@gmx.at> <87y72bilh9.fsf@cyd.mit.edu> In-Reply-To: <87y72bilh9.fsf@cyd.mit.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.64 > Yeah, it's somewhat opaque code. The way the ASCII table is set up is > that character 1 is the character ^A, character 2 is the character ^B, > and so forth, until character 65 is the unmodified character A. Hence > (char-to-string (- ?n ?a -1)) gives 14 == ^N. (Also, ASCII control > characters are case insensitive: there's no separate ^n character.) This makes sense iff the designer wanted to correct an accidentally held down control key behavior (the code obviously never lived up to that due to the regexp bug). > I suppose this means we have to find a separate fix for the original > bug... ... well, nothing hinders us assigning n, C-n and N to the same key. But I'd like to hear Jay's comments first. martin From unknown Sun Jun 15 08:41:22 2025 X-Loop: don@donarmstrong.com Subject: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode Reply-To: jay.p.belanger@gmail.com, 835@debbugs.gnu.org Resent-From: Jay Belanger Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 02 Sep 2008 02:40:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 835 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 835-submit@emacsbugs.donarmstrong.com id=B835.122032284629482 (code B ref 835); Tue, 02 Sep 2008 02:40:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 835) by emacsbugs.donarmstrong.com; 2 Sep 2008 02:34:06 +0000 Received: from s7.cableone.net (s7.cableone.net [24.116.0.233]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m822Y3ka029468 for <835@emacsbugs.donarmstrong.com>; Mon, 1 Sep 2008 19:34:04 -0700 Received: from belanger (unverified [69.92.109.217]) by s7.cableone.net (CableOne SMTP Service s7) with ESMTP id 7079757-1872270 for multiple; Mon, 01 Sep 2008 19:33:50 -0700 From: Jay Belanger To: martin rudalics Cc: Chong Yidong , 835@debbugs.gnu.org References: <87fxojg0k5.fsf@cyd.mit.edu> <48BC59BB.5@gmx.at> <87y72bilh9.fsf@cyd.mit.edu> <48BC65E3.5010709@gmx.at> CC: jay.p.belanger@gmail.com Date: Mon, 01 Sep 2008 21:33:48 -0500 In-Reply-To: <48BC65E3.5010709@gmx.at> (martin rudalics's message of "Tue, 02 Sep 2008 00:00:03 +0200") Message-ID: <87fxoj46pf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Vpipe: Scanner said ok (av_avast) X-NotAscii: charset=us-ascii X-IP-stats: Incoming Last 6, First 67, in=20, out=0, spam=0 ip=69.92.109.217 X-Originating-IP: 69.92.109.217 X-Abuse-Info: Send abuse complaints to abuse@cableone.net martin rudalics writes: ... >> I suppose this means we have to find a separate fix for the original >> bug... > > ... well, nothing hinders us assigning n, C-n and N to the same key. > But I'd like to hear Jay's comments first. The Calc manual mentions that all three act the same in calc-dispatch-map, so they all should all be available. That's just a matter of adding one line to Martin's patch. To make it less opaque, perhaps C-letter could be handled with something like (define-key map (vector (list 'control (car x))) (cdr x))) (or something better) instead of (define-key map (char-to-string (- (car x) ?a -1)) (cdr x))) Jay From unknown Sun Jun 15 08:41:22 2025 X-Loop: don@donarmstrong.com Subject: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode Reply-To: martin rudalics , 835@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 02 Sep 2008 09:10:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 835 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 835-submit@emacsbugs.donarmstrong.com id=B835.122034627732113 (code B ref 835); Tue, 02 Sep 2008 09:10:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 835) by emacsbugs.donarmstrong.com; 2 Sep 2008 09:04:37 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8294OWs032106 for <835@emacsbugs.donarmstrong.com>; Tue, 2 Sep 2008 02:04:26 -0700 Received: (qmail invoked by alias); 02 Sep 2008 09:04:19 -0000 Received: from 62-47-58-42.adsl.highway.telekom.at (EHLO [62.47.58.42]) [62.47.58.42] by mail.gmx.net (mp001) with SMTP; 02 Sep 2008 11:04:19 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+VamUazjiVJhPtVybmMlrR0lznpFMYdZ7aWQbrMO MYPNMu8lRtoNOC Message-ID: <48BD010C.4050400@gmx.at> Date: Tue, 02 Sep 2008 11:02:04 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: jay.p.belanger@gmail.com CC: Chong Yidong , 835@debbugs.gnu.org References: <87fxojg0k5.fsf@cyd.mit.edu> <48BC59BB.5@gmx.at> <87y72bilh9.fsf@cyd.mit.edu> <48BC65E3.5010709@gmx.at> <87fxoj46pf.fsf@gmail.com> In-Reply-To: <87fxoj46pf.fsf@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.75 > The Calc manual mentions that all three act the same in > calc-dispatch-map, so they all should all be available. That's just a > matter of adding one line to Martin's patch. > To make it less opaque, perhaps C-letter could be handled with something > like > (define-key map (vector (list 'control (car x))) (cdr x))) > (or something better) instead of > (define-key map (char-to-string (- (car x) ?a -1)) (cdr x))) I checked in a fix along these lines. Please have a look. martin From unknown Sun Jun 15 08:41:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Markus Triska Subject: bug#835 closed by Chong Yidong (Re: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode) Message-ID: References: <87sksi5b7l.fsf@cyd.mit.edu> X-Emacs-PR-Message: they-closed 835 X-Emacs-PR-Package: emacs Reply-To: 835@debbugs.gnu.org Content-Type: multipart/mixed; boundary="----------=_1220401807-3467-1" This is a multi-part message in MIME format... ------------=_1220401807-3467-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #835: 23.0.60; Quick calc is quietly disabled in view-mode It has been closed by Chong Yidong . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Chong Yidong by replying to this email. --=20 835: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D835 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1220401807-3467-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From cyd@stupidchicken.com Tue Sep 2 17:21:06 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 835-done) by emacsbugs.donarmstrong.com; 3 Sep 2008 00:21:06 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m830L3At001037 for <835-done@emacsbugs.donarmstrong.com>; Tue, 2 Sep 2008 17:21:04 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 10BDA57E339; Tue, 2 Sep 2008 20:23:26 -0400 (EDT) To: martin rudalics Cc: jay.p.belanger@gmail.com, 835-done@debbugs.gnu.org Subject: Re: bug#835: 23.0.60; Quick calc is quietly disabled in view-mode References: <87fxojg0k5.fsf@cyd.mit.edu> <48BC59BB.5@gmx.at> <87y72bilh9.fsf@cyd.mit.edu> <48BC65E3.5010709@gmx.at> <87fxoj46pf.fsf@gmail.com> <48BD010C.4050400@gmx.at> From: Chong Yidong Date: Tue, 02 Sep 2008 20:23:26 -0400 In-Reply-To: <48BD010C.4050400@gmx.at> (martin rudalics's message of "Tue\, 02 Sep 2008 11\:02\:04 +0200") Message-ID: <87sksi5b7l.fsf@cyd.mit.edu> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii martin rudalics writes: > I checked in a fix along these lines. Please have a look. Looks good. Thanks. ------------=_1220401807-3467-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From markus.triska@gmx.at Sun Aug 31 02:08:48 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.0 required=4.0 tests=AWL,BAYES_00,FOURLA, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 31 Aug 2008 09:08:49 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7V98jfc026970 for ; Sun, 31 Aug 2008 02:08:46 -0700 Received: from mail.gnu.org ([199.232.76.166]:47601 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KZitr-0005jR-05 for emacs-pretest-bug@gnu.org; Sun, 31 Aug 2008 05:07:11 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KZivI-000137-4R for emacs-pretest-bug@gnu.org; Sun, 31 Aug 2008 05:08:44 -0400 Received: from mail.gmx.net ([213.165.64.20]:43021) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KZivH-00012V-BE for emacs-pretest-bug@gnu.org; Sun, 31 Aug 2008 05:08:39 -0400 Received: (qmail invoked by alias); 31 Aug 2008 09:08:35 -0000 Received: from v254-019.vps.tuwien.ac.at (EHLO v254-019.vps.tuwien.ac.at) [128.131.254.19] by mail.gmx.net (mp067) with SMTP; 31 Aug 2008 11:08:36 +0200 X-Authenticated: #4064391 X-Provags-ID: V01U2FsdGVkX18+0BUPg2s+nE4ekNJVKokq7UH+pd5DNGK/ssRgMA 97px/QzrI4EqJi Received: by v254-019.vps.tuwien.ac.at (Postfix, from userid 502) id 74CC0A46A03; Sun, 31 Aug 2008 05:08:14 -0400 (EDT) From: Markus Triska To: emacs-pretest-bug@gnu.org Subject: 23.0.60; Quick calc is quietly disabled in view-mode Date: Sun, 31 Aug 2008 05:08:14 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.53 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. When I do: $ emacs -Q -f view-mode and then "C-x * Q", nothing happens. ("C-x * *" works as expected.) In GNU Emacs 23.0.60.7 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9) of 2008-08-30 on v254-034.vps.tuwien.ac.at Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000 Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t ------------=_1220401807-3467-1--