From unknown Sat Aug 16 15:58:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8340 <8340@debbugs.gnu.org> To: bug#8340 <8340@debbugs.gnu.org> Subject: Status: 23.2; recompile does not retain compilation-environment needed by vc-git-grep Reply-To: bug#8340 <8340@debbugs.gnu.org> Date: Sat, 16 Aug 2025 22:58:26 +0000 retitle 8340 23.2; recompile does not retain compilation-environment needed= by vc-git-grep reassign 8340 emacs submitter 8340 Trevor Spiteri severity 8340 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 24 15:10:05 2011 Received: (at submit) by debbugs.gnu.org; 24 Mar 2011 19:10:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q2pv2-0001bd-Uc for submit@debbugs.gnu.org; Thu, 24 Mar 2011 15:10:05 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q2pXE-0007ue-As for submit@debbugs.gnu.org; Thu, 24 Mar 2011 14:45:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q2pX8-00078D-JP for submit@debbugs.gnu.org; Thu, 24 Mar 2011 14:45:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:36283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q2pX8-000789-H0 for submit@debbugs.gnu.org; Thu, 24 Mar 2011 14:45:22 -0400 Received: from [140.186.70.92] (port=51725 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2pX7-00079k-DS for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2011 14:45:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q2pX6-00077v-AO for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2011 14:45:21 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:52275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q2pX5-00077o-R1 for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2011 14:45:20 -0400 Received: by wwc33 with SMTP id 33so276534wwc.30 for ; Thu, 24 Mar 2011 11:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:subject:content-type:content-transfer-encoding; bh=xEcnYAiO5W2K8U69g/QQscirtpIez4xTgfo69/ArSlY=; b=JwrNeKwXHwJDzbO1ZrjiPHU2zo9e/UPqjtC1Azum7SQX/rbHYYXXp/EED3rwKSYTQx YanUQ7LLGKwv2+vks2d3rNyIxLEeKzJazVxIuoCUFSq5QpulsBidAzRj46fD82O4yz+W 4sAr7OtBhMhkVbTQHstrmxZJZlsVeBcwNkSPQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=n5tECKlAOFtxmYpoM23aIGREuKO+Ah8QTFS68fPYW3pH15dY1yLU3lre6OdDApv+vv Dl5OHxtf4bf7o5iAPpg/jLX8HFl2sod/oXaim/ZAjqfCqigOpv77S7w62qbgjAxuFYqE z/uyXVgAEItteTkCxKzAG7G66Oz9mSdNiwOkU= Received: by 10.227.59.210 with SMTP id m18mr7886495wbh.112.1300992318347; Thu, 24 Mar 2011 11:45:18 -0700 (PDT) Received: from [137.222.185.56] (een5056.een.bris.ac.uk [137.222.185.56]) by mx.google.com with ESMTPS id w25sm89895wbd.5.2011.03.24.11.45.16 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 Mar 2011 11:45:17 -0700 (PDT) Message-ID: <4D8B9138.5070701@ieee.org> Date: Thu, 24 Mar 2011 18:45:12 +0000 From: Trevor Spiteri User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 23.2; recompile does not retain compilation-environment needed by vc-git-grep Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 24 Mar 2011 15:10:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Version 23.2. In the function vc-git-grep inside vc-git.el, the compilation environment is set as (compilation-environment '("PAGER=")) because git grep needs that. If I use M-x recompile in the *grep* buffer after using M-x vc-git-grep, compilation-environment is not set, and a warning that the "terminal is not fully functional" is displayed, one page of results is shown, and git grep blocks waiting on standard input, since it is using more as a pager. To fix this, I applied the following patch to compile.el that stores compile-environment in a similar way to default-directory. It works for me, but I do not really know elisp. --- a/compile.el 2011-03-24 18:24:01.000000000 +0000 +++ b/compile.el 2011-03-24 18:27:44.000000000 +0000 @@ -511,6 +511,9 @@ (defvar compilation-directory nil "Directory to restore to when doing `recompile'.") +(defvar recompilation-environment nil + "Environment to restore when doing `recompile'.") + (defvar compilation-directory-matcher '("\\(?:Entering\\|Leavin\\(g\\)\\) directory `\\(.+\\)'$" (2 . 1)) "A list for tracking when directories are entered or left. @@ -1106,7 +1109,8 @@ If the optional argument `edit-command' is non-nil, the command can be edited." (interactive "P") (save-some-buffers (not compilation-ask-about-save) nil) - (let ((default-directory (or compilation-directory default-directory))) + (let ((default-directory (or compilation-directory default-directory)) + (compilation-environment (or recompilation-environment compilation-environment))) (when edit-command (setcar compilation-arguments (compilation-read-command (car compilation-arguments)))) @@ -1236,6 +1240,7 @@ ;; affected by the special handling of "cd ...;". ;; NB: must be fone after (funcall mode) as that resets local variables (set (make-local-variable 'compilation-directory) thisdir) + (set (make-local-variable 'recompilation-environment) compilation-environment) (if highlight-regexp (set (make-local-variable 'compilation-highlight-regexp) highlight-regexp)) From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 05 05:18:03 2011 Received: (at 8340) by debbugs.gnu.org; 5 Sep 2011 09:18:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0VJX-0000Mp-4l for submit@debbugs.gnu.org; Mon, 05 Sep 2011 05:18:03 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0VJR-0000Md-8h for 8340@debbugs.gnu.org; Mon, 05 Sep 2011 05:17:57 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id EE2696E8054; Mon, 5 Sep 2011 02:14:11 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id A0D69451C356; Mon, 5 Sep 2011 02:14:09 -0700 (PDT) From: Juri Linkov To: Trevor Spiteri Subject: Re: 23.2; recompile does not retain compilation-environment needed by vc-git-grep Organization: JURTA References: <4D8B9138.5070701@ieee.org> Date: Mon, 05 Sep 2011 12:10:05 +0300 In-Reply-To: <4D8B9138.5070701@ieee.org> (Trevor Spiteri's message of "Thu, 24 Mar 2011 18:45:12 +0000") Message-ID: <871uvvtkwi.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8340 Cc: 8340@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > In the function vc-git-grep inside vc-git.el, the compilation environment > is set as > > (compilation-environment '("PAGER=")) > > because git grep needs that. If I use M-x recompile in the *grep* buffer > after using M-x vc-git-grep, compilation-environment is not set, and > a warning that the "terminal is not fully functional" is displayed, one > page of results is shown, and git grep blocks waiting on standard input, > since it is using more as a pager. > > To fix this, I applied the following patch to compile.el that stores > compile-environment in a similar way to default-directory. It works for me, > but I do not really know elisp. Generally it would be better to reuse `compilation-environment' and set it buffer-locally in the *compilation* buffer, but there is another problem. Some users might want to set `compilation-environment' in .emacs like: (add-hook 'compilation-mode-hook (lambda () (setq compilation-environment '("LANG=C")))) See more in http://thread.gmane.org/gmane.emacs.devel/108353 But then let-binding (let ((compilation-environment '("PAGER=")))) in `vc-git-grep' is ineffective because `compilation-mode-hook' overrides it. So `compilation-environment' should be defcustom to avoid this problem. I don't know whether it's good for defcustom to be buffer-local. But this should fix both problems when `vc-git-grep' will add "PAGER=" to the default or customized value of `compilation-environment' like (let ((compilation-environment (cons "PAGER=" compilation-environment)))) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 05:39:38 2011 Received: (at 8340) by debbugs.gnu.org; 6 Sep 2011 09:39:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0s82-0006Sj-E6 for submit@debbugs.gnu.org; Tue, 06 Sep 2011 05:39:38 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R0s80-0006SZ-59 for 8340@debbugs.gnu.org; Tue, 06 Sep 2011 05:39:37 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id F026D6E805B; Tue, 6 Sep 2011 02:35:48 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9DCE3451C45D; Tue, 6 Sep 2011 02:35:47 -0700 (PDT) From: Juri Linkov To: Trevor Spiteri Subject: Re: bug#8340: 23.2; recompile does not retain compilation-environment needed by vc-git-grep Organization: JURTA References: <4D8B9138.5070701@ieee.org> <871uvvtkwi.fsf@mail.jurta.org> Date: Tue, 06 Sep 2011 12:27:19 +0300 In-Reply-To: <871uvvtkwi.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 05 Sep 2011 12:10:05 +0300") Message-ID: <87ehzukolk.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8340 Cc: 8340@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Generally it would be better to reuse `compilation-environment' and set > it buffer-locally in the *compilation* buffer, but there is another problem. > Some users might want to set `compilation-environment' in .emacs like: > > (add-hook 'compilation-mode-hook > (lambda () > (setq compilation-environment '("LANG=C")))) > > See more in http://thread.gmane.org/gmane.emacs.devel/108353 > > But then let-binding (let ((compilation-environment '("PAGER=")))) > in `vc-git-grep' is ineffective because `compilation-mode-hook' > overrides it. So `compilation-environment' should be defcustom > to avoid this problem. The following patch fixed all these problems: === modified file 'lisp/progmodes/compile.el' --- lisp/progmodes/compile.el 2011-09-02 16:38:40 +0000 +++ lisp/progmodes/compile.el 2011-09-06 09:23:31 +0000 @@ -637,11 +637,15 @@ (defvar compilation-exit-message-functio and exit message; it returns a cons (MESSAGE . MODELINE) of the strings to write into the compilation buffer, and to put in its mode line.") -(defvar compilation-environment nil - "*List of environment variables for compilation to inherit. +(defcustom compilation-environment nil + "List of environment variables for compilation to inherit. Each element should be a string of the form ENVVARNAME=VALUE. This list is temporarily prepended to `process-environment' prior to -starting the compilation process.") +starting the compilation process." + :type '(repeat (string :tag "ENVVARNAME=VALUE")) + :options '(("LANG=C")) + :group 'compilation + :version "24.1") ;; History of compile commands. (defvar compile-history nil) @@ -1482,6 +1491,7 @@ (defun compilation-start (command &optio "compilation" (replace-regexp-in-string "-mode\\'" "" (symbol-name mode)))) (thisdir default-directory) + (thisenv compilation-environment) outwin outbuf) (with-current-buffer (setq outbuf @@ -1530,6 +1541,7 @@ (defun compilation-start (command &optio ;; affected by the special handling of "cd ...;". ;; NB: must be fone after (funcall mode) as that resets local variables (set (make-local-variable 'compilation-directory) thisdir) + (set (make-local-variable 'compilation-environment) thisenv) (if highlight-regexp (set (make-local-variable 'compilation-highlight-regexp) highlight-regexp)) === modified file 'lisp/vc/vc-git.el' --- lisp/vc/vc-git.el 2011-09-01 07:29:56 +0000 +++ lisp/vc/vc-git.el 2011-09-06 09:19:48 +0000 @@ -998,7 +998,7 @@ (defun vc-git-grep (regexp &optional fil (add-to-history 'grep-history command)))) (when command (let ((default-directory dir) - (compilation-environment '("PAGER="))) + (compilation-environment (cons "PAGER=" compilation-environment))) ;; Setting process-setup-function makes exit-message-function work ;; even when async processes aren't supported. (compilation-start command 'grep-mode)) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 14:43:55 2011 Received: (at 8340) by debbugs.gnu.org; 6 Sep 2011 18:43:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R10ck-0001A6-A1 for submit@debbugs.gnu.org; Tue, 06 Sep 2011 14:43:54 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R10ce-00019u-AJ for 8340@debbugs.gnu.org; Tue, 06 Sep 2011 14:43:49 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p86IdwcY023027; Tue, 6 Sep 2011 14:39:58 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 270141300D2; Tue, 6 Sep 2011 14:39:58 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#8340: 23.2; recompile does not retain compilation-environment needed by vc-git-grep Message-ID: References: <4D8B9138.5070701@ieee.org> <871uvvtkwi.fsf@mail.jurta.org> <87ehzukolk.fsf@mail.jurta.org> Date: Tue, 06 Sep 2011 14:39:58 -0400 In-Reply-To: <87ehzukolk.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 06 Sep 2011 12:27:19 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3972=0 X-NAI-Spam-Version: 2.2.0.9286 : core <3972> : streams <679106> : uri <952943> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 8340 Cc: 8340@debbugs.gnu.org, Trevor Spiteri X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > -(defvar compilation-environment nil > - "*List of environment variables for compilation to inherit. > +(defcustom compilation-environment nil > + "List of environment variables for compilation to inherit. > Each element should be a string of the form ENVVARNAME=VALUE. > This list is temporarily prepended to `process-environment' prior to > -starting the compilation process.") > +starting the compilation process." > + :type '(repeat (string :tag "ENVVARNAME=VALUE")) > + :options '(("LANG=C")) > + :group 'compilation > + :version "24.1") What is this supposed to fix? > ;; History of compile commands. > (defvar compile-history nil) > @@ -1482,6 +1491,7 @@ (defun compilation-start (command &optio > "compilation" > (replace-regexp-in-string "-mode\\'" "" (symbol-name mode)))) > (thisdir default-directory) > + (thisenv compilation-environment) > outwin outbuf) > (with-current-buffer > (setq outbuf > @@ -1530,6 +1541,7 @@ (defun compilation-start (command &optio > ;; affected by the special handling of "cd ...;". > ;; NB: must be fone after (funcall mode) as that resets local variables > (set (make-local-variable 'compilation-directory) thisdir) > + (set (make-local-variable 'compilation-environment) thisenv) > (if highlight-regexp > (set (make-local-variable 'compilation-highlight-regexp) > highlight-regexp)) > === modified file 'lisp/vc/vc-git.el' > --- lisp/vc/vc-git.el 2011-09-01 07:29:56 +0000 > +++ lisp/vc/vc-git.el 2011-09-06 09:19:48 +0000 > @@ -998,7 +998,7 @@ (defun vc-git-grep (regexp &optional fil > (add-to-history 'grep-history command)))) > (when command > (let ((default-directory dir) > - (compilation-environment '("PAGER="))) > + (compilation-environment (cons "PAGER=" compilation-environment))) > ;; Setting process-setup-function makes exit-message-function work > ;; even when async processes aren't supported. > (compilation-start command 'grep-mode)) Mixing defcustom+bufferlocal+letbinding is really asking for trouble, although I think in this case it might just fall within the limits of what does work. The vc-git.el patch looks perfectly good and so does the (set...thisenv). But I'd prefer to refrain from making compilation-environment a defcustom for now, until we find a really good use for it. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 08:47:04 2011 Received: (at 8340) by debbugs.gnu.org; 7 Sep 2011 12:47:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R1HWv-00082q-VV for submit@debbugs.gnu.org; Wed, 07 Sep 2011 08:47:04 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R1HWu-00082d-EE for 8340@debbugs.gnu.org; Wed, 07 Sep 2011 08:47:01 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 71CAF6E804D; Wed, 7 Sep 2011 05:43:07 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 224B2451C430; Wed, 7 Sep 2011 05:43:05 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#8340: 23.2; recompile does not retain compilation-environment needed by vc-git-grep Organization: JURTA References: <4D8B9138.5070701@ieee.org> <871uvvtkwi.fsf@mail.jurta.org> <87ehzukolk.fsf@mail.jurta.org> Date: Wed, 07 Sep 2011 15:19:33 +0300 In-Reply-To: (Stefan Monnier's message of "Tue, 06 Sep 2011 14:39:58 -0400") Message-ID: <87pqjdqsz2.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8340 Cc: 8340@debbugs.gnu.org, Trevor Spiteri X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Mixing defcustom+bufferlocal+letbinding is really asking for trouble, > although I think in this case it might just fall within the limits of > what does work. > > The vc-git.el patch looks perfectly good and so does the (set...thisenv). Installed. > But I'd prefer to refrain from making compilation-environment a defcustom > for now, until we find a really good use for it. There have been requests to make it a defcustom, and you even agreed to that ;-) http://lists.gnu.org/archive/html/emacs-devel/2009-02/msg00118.html It will allow the users to find and change it more easily in cases like this: http://lists.gnu.org/archive/html/help-gnu-emacs/2011-02/msg00338.html From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 07 09:40:37 2011 Received: (at 8340) by debbugs.gnu.org; 7 Sep 2011 13:40:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R1IMn-0002sE-52 for submit@debbugs.gnu.org; Wed, 07 Sep 2011 09:40:37 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R1IMm-0002s8-9n for 8340@debbugs.gnu.org; Wed, 07 Sep 2011 09:40:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EALByZ064rwMJ/2dsb2JhbABDp2l5gUYBAQEBAgEBAlMjEAs0EhQUBA0kiAgEt2WGawSRIIwPgnSEQA X-IronPort-AV: E=Sophos;i="4.68,345,1312171200"; d="scan'208";a="134949215" Received: from 184-175-3-9.dsl.teksavvy.com (HELO ceviche.home) ([184.175.3.9]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 07 Sep 2011 09:36:42 -0400 Received: by ceviche.home (Postfix, from userid 20848) id AF47766246; Wed, 7 Sep 2011 09:36:42 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#8340: 23.2; recompile does not retain compilation-environment needed by vc-git-grep Message-ID: References: <4D8B9138.5070701@ieee.org> <871uvvtkwi.fsf@mail.jurta.org> <87ehzukolk.fsf@mail.jurta.org> <87pqjdqsz2.fsf@mail.jurta.org> Date: Wed, 07 Sep 2011 09:36:42 -0400 In-Reply-To: <87pqjdqsz2.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 07 Sep 2011 15:19:33 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 8340 Cc: 8340@debbugs.gnu.org, Trevor Spiteri X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) >> But I'd prefer to refrain from making compilation-environment a defcustom >> for now, until we find a really good use for it. > There have been requests to make it a defcustom, and you even agreed > to that ;-) > http://lists.gnu.org/archive/html/emacs-devel/2009-02/msg00118.html > It will allow the users to find and change it more easily in cases like this: > http://lists.gnu.org/archive/html/help-gnu-emacs/2011-02/msg00338.html OK, sounds fine, go ahead, Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 08:18:32 2011 Received: (at 8340-done) by debbugs.gnu.org; 8 Sep 2011 12:18:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R1dYq-00065r-BC for submit@debbugs.gnu.org; Thu, 08 Sep 2011 08:18:32 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R1dYk-00065f-In for 8340-done@debbugs.gnu.org; Thu, 08 Sep 2011 08:18:26 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 846F26E8056; Thu, 8 Sep 2011 05:14:23 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 30355451C432; Thu, 8 Sep 2011 05:14:21 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#8340: 23.2; recompile does not retain compilation-environment needed by vc-git-grep Organization: JURTA References: <4D8B9138.5070701@ieee.org> <871uvvtkwi.fsf@mail.jurta.org> <87ehzukolk.fsf@mail.jurta.org> <87pqjdqsz2.fsf@mail.jurta.org> Date: Thu, 08 Sep 2011 15:12:41 +0300 In-Reply-To: (Stefan Monnier's message of "Wed, 07 Sep 2011 09:36:42 -0400") Message-ID: <87zkiftepy.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8340-done Cc: 8340-done@debbugs.gnu.org, Trevor Spiteri X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >>> But I'd prefer to refrain from making compilation-environment a defcustom >>> for now, until we find a really good use for it. >> There have been requests to make it a defcustom, and you even agreed >> to that ;-) >> http://lists.gnu.org/archive/html/emacs-devel/2009-02/msg00118.html >> It will allow the users to find and change it more easily in cases like this: >> http://lists.gnu.org/archive/html/help-gnu-emacs/2011-02/msg00338.html > > OK, sounds fine, go ahead, Done. From unknown Sat Aug 16 15:58:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 07 Oct 2011 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator