From unknown Fri Aug 08 19:15:17 2025 X-Loop: don@donarmstrong.com Subject: bug#832: Compiling Emacs.app fails this afternoon. Reply-To: "Gilbert Harman" , 832@debbugs.gnu.org Resent-From: "Gilbert Harman" Original-Sender: gilbert.harman@gmail.com Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 30 Aug 2008 18:10:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 832 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122011921911503 (code B ref -1); Sat, 30 Aug 2008 18:10:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.0 tests=AWL,BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 30 Aug 2008 18:00:19 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7UI0FJh011497 for ; Sat, 30 Aug 2008 11:00:16 -0700 Received: from mx10.gnu.org ([199.232.76.166]:34083) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KZUif-0003h3-Sr for emacs-pretest-bug@gnu.org; Sat, 30 Aug 2008 13:58:41 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KZUk6-0006hl-Rg for emacs-pretest-bug@gnu.org; Sat, 30 Aug 2008 14:00:14 -0400 Received: from fg-out-1718.google.com ([72.14.220.159]:2720) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KZUk6-0006gE-EP for emacs-pretest-bug@gnu.org; Sat, 30 Aug 2008 14:00:10 -0400 Received: by fg-out-1718.google.com with SMTP id l26so827180fgb.30 for ; Sat, 30 Aug 2008 11:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:mime-version:content-type:x-google-sender-auth; bh=VzoLUym3UulhG1UYtINwCr0DgWhrHYoEVC92bGwzS2I=; b=VeZbumvsBjgQSD97j+iHvOqOBQJZrIFcFrR6sYUjkSTvukTNNAukVh3wUnBiATtOhw Cg1B4cqFj0dkWTAkuKOQSjQpnM3p/v35H6lceYzBpmFz506pFjIAXhW/ak449cTr5riH BwL3VaXu8YKdRehuf+tJIuqr7UvpM5ccSfs54= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:mime-version:content-type :x-google-sender-auth; b=P3tpyYHvFLUj1sVkpk9Fo8o5PpbCJ1tDUPrim6bGKFY2z5GcQoWIfaoyW9CIItZyWr hfU8/OWuI4A7OSqcGMarmR3kCboaqSLBh3fx4HQ6cLJy9SVU/eNoKwEBBi6psX8AbleN x93m7g1jnGfQdRVTwIAGyKf9nwg2kfa5zCUDQ= Received: by 10.86.74.15 with SMTP id w15mr3138244fga.42.1220119207424; Sat, 30 Aug 2008 11:00:07 -0700 (PDT) Received: by 10.86.31.20 with HTTP; Sat, 30 Aug 2008 11:00:07 -0700 (PDT) Message-ID: <5f089c510808301100ld667c2eh840fda0990e9f966@mail.gmail.com> Date: Sat, 30 Aug 2008 14:00:07 -0400 From: "Gilbert Harman" Sender: gilbert.harman@gmail.com To: "emacs.app dev list" , emacs-pretest-bug@gnu.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_19153_19146842.1220119207429" X-Google-Sender-Auth: ecfcd15b9034588a X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) ------=_Part_19153_19146842.1220119207429 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline After ./configure --with-ns .... make -j2 .... nsfont.m: In function 'nsfont_char_width': nsfont.m:481: warning: 'widthOfString:' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSFont.h:216) nsfont.m: In function 'nsfont_open': nsfont.m:726: warning: 'widthOfString:' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSFont.h:216) nsfont.m: In function 'nsfont_draw': nsfont.m:907: error: 'struct glyph_string' has no member named 'gidx' nsfont.m:908: error: 'struct glyph_string' has no member named 'gidx' nsfont.m:914: error: 'struct glyph_string' has no member named 'gidx' nsfont.m:1097: error: 'struct glyph_string' has no member named 'gidx' nsfont.m:1103: error: 'struct glyph_string' has no member named 'gidx' make[1]: *** [nsfont.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [src] Error 2 Gil (Intel Mac OS X 10.5.4) ------=_Part_19153_19146842.1220119207429 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
After ./configure --with-ns
....
make -j2

....
nsfont.m: In function 'nsfont_char_width':
nsfont.m:481: warning: 'widthOfString:' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSFont.h:216)
nsfont.m: In function 'nsfont_open':
nsfont.m:726: warning: 'widthOfString:' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSFont.h:216)
nsfont.m: In function 'nsfont_draw':
nsfont.m:907: error: 'struct glyph_string' has no member named 'gidx'
nsfont.m:908: error: 'struct glyph_string' has no member named 'gidx'
nsfont.m:914: error: 'struct glyph_string' has no member named 'gidx'
nsfont.m:1097: error: 'struct glyph_string' has no member named 'gidx'
nsfont.m:1103: error: 'struct glyph_string' has no member named 'gidx'
make[1]: *** [nsfont.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [src] Error 2

  Gil


(Intel Mac OS X 10.5.4)
------=_Part_19153_19146842.1220119207429-- From unknown Fri Aug 08 19:15:17 2025 X-Loop: don@donarmstrong.com Subject: bug#832: Compiling Emacs.app fails this afternoon. [PATCH] Reply-To: Daniel Koning , 832@debbugs.gnu.org Resent-From: Daniel Koning Original-Sender: news Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs , don@donarmstrong.com Resent-Date: Thu, 04 Sep 2008 06:40:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 832 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122050981512071 (code B ref -1); Thu, 04 Sep 2008 06:40:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 4 Sep 2008 06:30:15 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m846U9Y1011946 for ; Wed, 3 Sep 2008 23:30:11 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kb8M4-0002oD-IC for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 02:30:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kb8M3-0002nm-QP for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 02:30:07 -0400 Received: from [199.232.76.173] (port=58662 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kb8M3-0002nf-Ew for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 02:30:07 -0400 Received: from main.gmane.org ([80.91.229.2]:40897 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kb8M2-0004p7-V2 for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 02:30:07 -0400 Received: from root by ciao.gmane.org with local (Exim 4.43) id 1Kb8Ly-00060y-EX for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 06:30:02 +0000 Received: from adsl-69-148-82-147.dsl.rcsntx.swbell.net ([69.148.82.147]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Sep 2008 06:30:02 +0000 Received: from dkoning by adsl-69-148-82-147.dsl.rcsntx.swbell.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Sep 2008 06:30:02 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Daniel Koning Date: Thu, 4 Sep 2008 06:23:58 +0000 (UTC) Lines: 89 Message-ID: References: <5f089c510808301100ld667c2eh840fda0990e9f966@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: main.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 69.148.82.147 (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1) Sender: news X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Gilbert Harman princeton.edu> writes: > > After ./configure --with-ns....make -j2....nsfont.m: In function 'nsfont_char_width':nsfont.m:481: warning: 'widthOfString:' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSFont.h:216) > nsfont.m: In function 'nsfont_open':nsfont.m:726: warning: 'widthOfString:' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSFont.h:216)nsfont.m: In function 'nsfont_draw':nsfont.m:907: error: 'struct glyph_string' has no member named 'gidx' > nsfont.m:908: error: 'struct glyph_string' has no member named 'gidx'nsfont.m:914: error: 'struct glyph_string' has no member named 'gidx'nsfont.m:1097: error: 'struct glyph_string' has no member named 'gidx'nsfont.m:1103: error: 'struct glyph_string' has no member named 'gidx' > make[1]: *** [nsfont.o] Error 1make[1]: *** Waiting for unfinished jobs....make: *** [src] Error 2  Gil(Intel Mac OS X 10.5.4) > This appears to have been caused by nsfont_draw() not having been updated to use cmp_from instead of gidx. Here's a patch, which also updates a couple of out-of-date comments: Index: src/nsfont.m =================================================================== RCS file: /sources/emacs/emacs/src/nsfont.m,v retrieving revision 1.11 diff -u -r1.11 nsfont.m --- src/nsfont.m 21 Aug 2008 02:49:00 -0000 1.11 +++ src/nsfont.m 4 Sep 2008 06:23:03 -0000 @@ -904,14 +904,14 @@ int hi, lo; char isComposite = 0; /* s->first_glyph->type == COMPOSITE_GLYPH; */ /* FIXME: composition: no vertical displacement is considered. */ - t+= s->gidx; /* advance into composition */ - for (i =0; inchars - s->gidx; i++, t++) + t+= s->cmp_from; /* advance into composition */ + for (i =0; inchars - s->cmp_from; i++, t++) { hi = (*t & 0xFF00) >> 8; lo = *t & 0x00FF; if (isComposite) { - cwidth = s->cmp->offsets[s->gidx++ * 2] - twidth; + cwidth = s->cmp->offsets[s->cmp_from++ * 2] - twidth; } else { @@ -1094,13 +1094,13 @@ [col set]; CGContextSetTextPosition (gcontext, r.origin.x, r.origin.y); - CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->gidx, + CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->cmp_from, advances, len); if (face->overstrike) { CGContextSetTextPosition (gcontext, r.origin.x+0.5, r.origin.y); - CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->gidx, + CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->cmp_from, advances, len); } Index: src/xdisp.c =================================================================== RCS file: /sources/emacs/emacs/src/xdisp.c,v retrieving revision 1.1254 diff -u -r1.1254 xdisp.c --- src/xdisp.c 31 Aug 2008 08:27:25 -0000 1.1254 +++ src/xdisp.c 4 Sep 2008 06:23:21 -0000 @@ -19532,7 +19532,7 @@ /* Fill glyph string S with composition components specified by S->cmp. BASE_FACE is the base face of the composition. - S->gidx is the index of the first component for S. + S->cmp_from is the index of the first component for S. OVERLAPS non-zero means S should draw the foreground only, and use its physical height for clipping. See also draw_glyphs. @@ -19547,7 +19547,7 @@ { int i; /* For all glyphs of this composition, starting at the offset - S->gidx, until we reach the end of the definition or encounter a + S->cmp_from, until we reach the end of the definition or encounter a glyph that requires the different face, add it to S. */ struct face *face;