From unknown Sat Jun 14 19:02:54 2025 X-Loop: don@donarmstrong.com Subject: bug#831: 23.0.60; error in nsfonts.m Reply-To: Austin Frank , 831@debbugs.gnu.org Resent-From: Austin Frank Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 30 Aug 2008 17:40:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 831 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12201175652502 (code B ref -1); Sat, 30 Aug 2008 17:40:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.9 required=4.0 tests=BAYES_00,FOURLA, IMPRONONCABLE_2,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 30 Aug 2008 17:32:45 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7UHWfNY002496 for ; Sat, 30 Aug 2008 10:32:42 -0700 Received: from mx10.gnu.org ([199.232.76.166]:58230) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KZUHz-0001tx-O7 for emacs-pretest-bug@gnu.org; Sat, 30 Aug 2008 13:31:07 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KZUJR-0006qM-9O for emacs-pretest-bug@gnu.org; Sat, 30 Aug 2008 13:32:40 -0400 Received: from yx-out-1718.google.com ([74.125.44.152]:44191) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KZUJQ-0006ps-Ti for emacs-pretest-bug@gnu.org; Sat, 30 Aug 2008 13:32:37 -0400 Received: by yx-out-1718.google.com with SMTP id 34so683563yxf.66 for ; Sat, 30 Aug 2008 10:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:user-agent:mime-version:content-type; bh=ADgl4AybtEe+nyIY537k91mpvu1wHJ76SJy4X8tm/8k=; b=jqhmAYNNVJXP+A+LBnNw/TSz7lmZbpQtxFkNo/G7/9qHBTFyJ73YTbRoIIeZRhIWU3 O+/BM4qszQ1Vxeql3hRQqiGz4cBW0WjfjF1DUCtx4BGoUCZIhHLGBPUFyam6qfCiZdo5 ivntpsnopnXuYW/nyUk/3g/InI+CJqwRUfE04= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; b=WZtuy3DqfS7ol+Q5sqUyR8veJqdi2FR0biPugh3u36x/bMR8Er00T3M0jZrusvO7x9 prtRC836NHEZC65/cHOJS0dR44x3fCWKVAcoPryhYy9hb0DhRLlCiS1s1edmN9fnVZyQ SM4w5zxHnsNkREtYeQfNda5kyHoJq8DzMPv3k= Received: by 10.151.111.15 with SMTP id o15mr6104192ybm.93.1220117554625; Sat, 30 Aug 2008 10:32:34 -0700 (PDT) Received: from localhost ( [74.69.93.157]) by mx.google.com with ESMTPS id 7sm4344277ywo.7.2008.08.30.10.32.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 30 Aug 2008 10:32:33 -0700 (PDT) From: Austin Frank To: emacs-pretest-bug@gnu.org Date: Sat, 30 Aug 2008 13:32:39 -0400 Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (darwin) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= I'm trying to build emacs from a current CVS checkout on OSX 10.4.11 with the configure option --with-ns. Build fails because of error in nsfonts.m. That file references a variable called gidx, which is not defined in the relevant structure. The attached patch changes all instances of gidx to x, and allows emacs to build on my system. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=gidx.patch Content-Transfer-Encoding: quoted-printable diff --git a/src/nsfont.m b/src/nsfont.m index f49cd0f..10b1c90 100644 =2D-- a/src/nsfont.m +++ b/src/nsfont.m @@ -904,14 +904,14 @@ nsfont_draw (struct glyph_string *s, int from, int to= , int x, int y, int hi, lo; char isComposite =3D 0; /* s->first_glyph->type =3D=3D COMPOSITE_GLYPH= ; */ /* FIXME: composition: no vertical displacement is considered. */ =2D t+=3D s->gidx; /* advance into composition */ =2D for (i =3D0; inchars - s->gidx; i++, t++) + t+=3D s->x; /* advance into composition */ + for (i =3D0; inchars - s->x; i++, t++) { hi =3D (*t & 0xFF00) >> 8; lo =3D *t & 0x00FF; if (isComposite) { =2D cwidth =3D s->cmp->offsets[s->gidx++ * 2] - twidth; + cwidth =3D s->cmp->offsets[s->x++ * 2] - twidth; } else { @@ -1094,13 +1094,13 @@ nsfont_draw (struct glyph_string *s, int from, int = to, int x, int y, [col set]; =20 CGContextSetTextPosition (gcontext, r.origin.x, r.origin.y); =2D CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->gidx, + CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->x, advances, len); =20 if (face->overstrike) { CGContextSetTextPosition (gcontext, r.origin.x+0.5, r.origin.y); =2D CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->gidx, + CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->x, advances, len); } =20 --=-=-= Content-Transfer-Encoding: quoted-printable In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, X toolkit) of 2008-08-29 on malibu.local Important settings: value of $LC_ALL: en_US.UTF-8 value of $LC_COLLATE: nil value of $LC_CTYPE: en_US.UTF-8 value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t =2D-=20 Austin Frank http://aufrank.net GPG Public Key (D7398C2F): http://aufrank.net/personal.asc --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAki5hDgACgkQlHMl2/XbR4Gd2wCfVHK7wfQAv5do6+B7hsKoZJwR kTwAoLxR0MDYoUOD/iF25lh2t2n4/5F3 =xw6u -----END PGP SIGNATURE----- --==-=-=-- From unknown Sat Jun 14 19:02:54 2025 X-Loop: don@donarmstrong.com Subject: bug#831: 23.0.60; error in nsfonts.m Reply-To: Glenn Morris , 831@debbugs.gnu.org Resent-From: Glenn Morris Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs , don@donarmstrong.com Resent-Date: Sat, 30 Aug 2008 20:10:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 831 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: Received: via spool by 831-submit@emacsbugs.donarmstrong.com id=B831.122012646820328 (code B ref 831); Sat, 30 Aug 2008 20:10:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.0 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 831) by emacsbugs.donarmstrong.com; 30 Aug 2008 20:01:08 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7UK15VT020322 for <831@emacsbugs.donarmstrong.com>; Sat, 30 Aug 2008 13:01:06 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KZWba-0001Ni-67; Sat, 30 Aug 2008 15:59:30 -0400 From: Glenn Morris To: Austin Frank Cc: 831@debbugs.gnu.org, Kenichi Handa References: X-Spook: BRLO Armani COSCO Blowpipe Glock Fedayeen Fortezza Ansar X-Ran: wUWQmcukhz|B4B&n,t:XHviL%Zy5quMs+<2L2x'Nl-'uyoR!O"1;p>Y#u/RtqsJ"1ZPd+9 X-Hue: blue X-Attribution: GM Date: Sat, 30 Aug 2008 15:59:30 -0400 In-Reply-To: (Austin Frank's message of "Sat, 30 Aug 2008 13:32:39 -0400") Message-ID: <9oljyep93x.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Austin Frank wrote: > I'm trying to build emacs from a current CVS checkout on OSX 10.4.11 > with the configure option --with-ns. > > Build fails because of error in nsfonts.m. That file references a > variable called gidx, which is not defined in the relevant structure. > The attached patch changes all instances of gidx to x, and allows emacs > to build on my system. That may happen to build, but I don't believe it to be the correct fix. This is fallout from: 2008-08-29 Kenichi Handa * dispextern.h (struct glyph_string): Delete the member gidx. New members cmp_id, cmp_from, and cmp_to. (There are also some out-of-date comments in xdisp.c that still refer to gidx.) From unknown Sat Jun 14 19:02:54 2025 X-Loop: don@donarmstrong.com Subject: bug#831: 23.0.60; error in nsfonts.m Reply-To: "Austin Frank" , 831@debbugs.gnu.org Resent-From: "Austin Frank" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs , don@donarmstrong.com Resent-Date: Sun, 31 Aug 2008 17:55:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 831 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: Received: via spool by 831-submit@emacsbugs.donarmstrong.com id=B831.12202049768821 (code B ref 831); Sun, 31 Aug 2008 17:55:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-10.7 required=4.0 tests=BAYES_00,FVGT_m_MULTI_ODD, HAS_BUG_NUMBER,IMPRONONCABLE_2,MURPHY_DRUGS_REL8,MURPHY_WRONG_WORD1, MURPHY_WRONG_WORD2,PGPSIGNATURE autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 831) by emacsbugs.donarmstrong.com; 31 Aug 2008 17:49:36 +0000 Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.238]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7VHnWoE008815 for <831@emacsbugs.donarmstrong.com>; Sun, 31 Aug 2008 10:49:33 -0700 Received: by rv-out-0506.google.com with SMTP id k40so1521329rvb.1 for <831@emacsbugs.donarmstrong.com>; Sun, 31 Aug 2008 10:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=T3ySHGxRGMljOu0RtzutnoX7DTf8rV3KbNkz5ZHrYd4=; b=QUM6wVtuX7fJ21uYTKQRd2Ttz2IDdrT6CkSqkov1PCk3NWvuauaczTRdYuvOuht/qd wBLkOuz1a3VA0p4VMSfrTBj/LPQaNa+RaIPHIeqgXqoFp0SRa1IL2NucqaZiC0Pwbd2S q+77LAkQNc4NupXGvkTYFH0nKQL5q+sWG901c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=KOjP6LCEK+8bv/M4lbRe7DrYLzTLa7skVL0jOUJkCRROPeN9ONIOd7MUiEP+4vVUgi fUnb/Av5MnoSJJs1M4v+la/e0cY18nQmNZISTFHfXu9gUap7/bXX04fFxZ60VYmELHRJ b1GQQbwYwrL3+rSMCexZmSfWr0VcANhQanx9g= Received: by 10.114.192.3 with SMTP id p3mr4638745waf.112.1220204972122; Sun, 31 Aug 2008 10:49:32 -0700 (PDT) Received: by 10.115.75.1 with HTTP; Sun, 31 Aug 2008 10:49:32 -0700 (PDT) Message-ID: Date: Sun, 31 Aug 2008 13:49:32 -0400 From: "Austin Frank" To: "Glenn Morris" Cc: 831@debbugs.gnu.org, "Kenichi Handa" In-Reply-To: <9oljyep93x.fsf@fencepost.gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <9oljyep93x.fsf@fencepost.gnu.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Yes, you're right that this builds but doesn't actually work. Sorry that I didn't dive deeper in debugging! Unfortunately I don't have time to work on a patch-- apologies. I'll keep an eye on CVS for changes to nsfonts.m and xdisp.c. Thanks, /au -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) Comment: http://getfiregpg.org iEYEARECAAYFAki62bIACgkQlHMl2/XbR4HBWgCgsfk0mlSrjW62yhDGnJahQVZH XH8AoM+gZlh6I90lkZh/Xen3vb21mWJP =tyto -----END PGP SIGNATURE----- On Sat, Aug 30, 2008 at 3:59 PM, Glenn Morris wrote: > Austin Frank wrote: > >> I'm trying to build emacs from a current CVS checkout on OSX 10.4.11 >> with the configure option --with-ns. >> >> Build fails because of error in nsfonts.m. That file references a >> variable called gidx, which is not defined in the relevant structure. >> The attached patch changes all instances of gidx to x, and allows emacs >> to build on my system. > > That may happen to build, but I don't believe it to be the correct fix. > > This is fallout from: > > 2008-08-29 Kenichi Handa > > * dispextern.h (struct glyph_string): Delete the member gidx. > New members cmp_id, cmp_from, and cmp_to. > > (There are also some out-of-date comments in xdisp.c that still refer > to gidx.) > From unknown Sat Jun 14 19:02:54 2025 X-Loop: don@donarmstrong.com Subject: bug#831: 23.0.60; error in nsfonts.m Reply-To: Ted Zlatanov , 831@debbugs.gnu.org Resent-From: Ted Zlatanov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs , don@donarmstrong.com Resent-Date: Sun, 07 Sep 2008 20:35:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 831 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: patch Received: via spool by 831-submit@emacsbugs.donarmstrong.com id=B831.122081930530042 (code B ref 831); Sun, 07 Sep 2008 20:35:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-10.4 required=4.0 tests=AWL,BAYES_00,FOURLA,GMAIL, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 831) by emacsbugs.donarmstrong.com; 7 Sep 2008 20:28:25 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87KSL9M030036 for <831@emacsbugs.donarmstrong.com>; Sun, 7 Sep 2008 13:28:23 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KcQqD-0000qP-Pn for 831@emacsbugs.donarmstrong.com; Sun, 07 Sep 2008 16:26:37 -0400 Resent-To: 831@debbugs.gnu.org Resent-From: Glenn Morris Resent-Date: Sun, 07 Sep 2008 16:26:37 -0400 Resent-Message-ID: Resent-User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-From-Line: bug-gnu-emacs-bounces+rgm=gnu.org@gnu.org Sun Sep 7 07:38:54 2008 Received: from mx10.gnu.org ([199.232.76.166]:40097) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KcIbW-0004qU-33 for rgm@gnu.org; Sun, 07 Sep 2008 07:38:54 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KcId8-0005sU-75 for rgm@gnu.org; Sun, 07 Sep 2008 07:40:36 -0400 Received: from lists.gnu.org ([199.232.76.165]:59119) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KcId7-0005sK-PR for rgm@gnu.org; Sun, 07 Sep 2008 07:40:33 -0400 Received: from localhost ([127.0.0.1]:60517 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KcId7-0001iO-Me for rgm@gnu.org; Sun, 07 Sep 2008 07:40:33 -0400 Path: news.stanford.edu!newsfeed.stanford.edu!news.tele.dk!news.tele.dk!small.news.tele.dk!newsgate.cistron.nl!xs4all!news2.euro.net!newsfeed.freenet.de!news.albasani.net!not-for-mail From: Ted Zlatanov Newsgroups: gnu.emacs.bug Date: Sun, 07 Sep 2008 06:26:03 -0500 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: References: <9oljyep93x.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: news.albasani.net gY8IfhH2W99OiEVzjCw4rXt9jGoEVnZMzgQR8aDslUirl3N2nMBdifRMi8I5nHl9ANvifV38uuzGsy5gAnPLIj/G3Hd/zecXvaJm0bc4QLqG6Ov7Y1HTWnGl31BbzV1s X-Complaints-To: abuse@albasani.net NNTP-Posting-Date: Sun, 7 Sep 2008 11:26:03 +0000 (UTC) X-User-ID: SHPtLYOR0Vn4EIuxsf1MYDZvaKzoSWCrx9vrngNcJSM= X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Cancel-Lock: sha1:Buxq2vcUBB+wb2asCbP3kBQRQyA= sha1:grC6+MqYzpyqtq2FqeUuwmQg83E= X-NNTP-Posting-Host: ASjWsC5i3JE0bMUifJXDKTbZd7RQ2Q9JazlkXaBxXHk= To: bug-gnu-emacs@gnu.org Cc: emacs-app-dev-@lists.sourceforge.net, Kenichi Handa X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+rgm=gnu.org@gnu.org X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Lines: 44 User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Posted-To: gnu.emacs.bug Resent-Date: Sun, 07 Sep 2008 16:26:37 -0400 The following message is a courtesy copy of an article that has been posted to gnu.emacs.bug as well. On Sun, 31 Aug 2008 13:49:32 -0400 "Austin Frank" wrote: AF> On Sat, Aug 30, 2008 at 3:59 PM, Glenn Morris wrote: >> Austin Frank wrote: >> >>> I'm trying to build emacs from a current CVS checkout on OSX 10.4.11 >>> with the configure option --with-ns. >>> >>> Build fails because of error in nsfonts.m. That file references a >>> variable called gidx, which is not defined in the relevant structure. >>> The attached patch changes all instances of gidx to x, and allows emacs >>> to build on my system. >> >> That may happen to build, but I don't believe it to be the correct fix. >> >> This is fallout from: >> >> 2008-08-29 Kenichi Handa >> >> * dispextern.h (struct glyph_string): Delete the member gidx. >> New members cmp_id, cmp_from, and cmp_to. >> >> (There are also some out-of-date comments in xdisp.c that still refer >> to gidx.) AF> Yes, you're right that this builds but doesn't actually work. Sorry AF> that I didn't dive deeper in debugging! Unfortunately I don't have AF> time to work on a patch-- apologies. I'll keep an eye on CVS for AF> changes to nsfonts.m and xdisp.c. I used the data member rename patch Austin and others suggested for two days now without problems. It lets Emacs build on Mac OS X and despite being insufficient as a full fix, at least the users don't have to wait for the full fix to have a working compile. I comitted this change to the Emacs CVS HEAD, including fixing the references to gidx in the xdisp.c docs, and will back it out (or anyone else can back it out) if it's a problem. I apologize in advance if that's the case. All the gidx references are changed to cmp_from, that's all it does. Thanks Ted From unknown Sat Jun 14 19:02:54 2025 X-Loop: don@donarmstrong.com Subject: bug#831: 23.0.60; error in nsfonts.m Reply-To: Glenn Morris , 831@debbugs.gnu.org Resent-From: Glenn Morris Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs , don@donarmstrong.com Resent-Date: Sun, 07 Sep 2008 20:50:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 831 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: patch Received: via spool by 831-submit@emacsbugs.donarmstrong.com id=B831.12208200652449 (code B ref 831); Sun, 07 Sep 2008 20:50:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-10.4 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,UNRESOLVED_TEMPLATE, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 831) by emacsbugs.donarmstrong.com; 7 Sep 2008 20:41:05 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87Kf1Nc002443 for <831@emacsbugs.donarmstrong.com>; Sun, 7 Sep 2008 13:41:03 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KcR2T-0001NL-KE for 831@emacsbugs.donarmstrong.com; Sun, 07 Sep 2008 16:39:18 -0400 Resent-Message-ID: <18628.15349.403548.86250@fencepost.gnu.org> Resent-Date: Sun, 7 Sep 2008 16:39:17 -0400 Resent-From: Glenn Morris Resent-To: 831@debbugs.gnu.org References: <9oljyep93x.fsf@fencepost.gnu.org> X-Ran: FY)C4;x{\Gt\L+Zb/A+;8Ai]H<{ZrM~PMFUu6!TGc;[)Z|fg?lmbz%BN/f^:GreChyt[AA X-Hue: red X-Attribution: GM Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 07 Sep 2008 16:37:14 -0400 From: Glenn Morris To: Ted Zlatanov Cc: 381@debbugs.gnu.org X-Spook: strategic Firefly KGB beanpole Islam Abduganievich User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Resent-Date: Sun, 07 Sep 2008 16:39:17 -0400 [Sent this to bug 381 instead of 831 the first time, sigh] Would you mind not using the newsgroup interface? It seems to break the bug tracker, in that your posts don't appear there (I have forwarded some there). This is some bug, not your fault. Ted Zlatanov wrote: > I used the data member rename patch Austin and others suggested for two > days now without problems. It lets Emacs build on Mac OS X and despite > being insufficient as a full fix, at least the users don't have to wait > for the full fix to have a working compile. > > I comitted this change to the Emacs CVS HEAD, including fixing the > references to gidx in the xdisp.c docs, and will back it out (or anyone > else can back it out) if it's a problem. Can you give it the correct attribution in the ChangeLog? Maybe you came up with it independently, in which case it's correct as is. I thought it was Daniel Koning's. > I apologize in advance if that's the case. All the gidx references > are changed to cmp_from, that's all it does. I left it alone partly because obviously wrong is better than subtly wrong. (Not that I can say if it is right or wrong). And also partly to see how many duplicate reports were received. :) About 13 I think, none apart from the first and the one with the patch conveying any useful information. And most saying "is this known?" :) (I'm not saying you should take it out.) From unknown Sat Jun 14 19:02:54 2025 X-Loop: don@donarmstrong.com Subject: bug#831: 23.0.60; error in nsfonts.m Reply-To: Ted Zlatanov , 831@debbugs.gnu.org Resent-From: Ted Zlatanov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs , don@donarmstrong.com Resent-Date: Mon, 08 Sep 2008 21:20:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 831 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: patch Received: via spool by 831-submit@emacsbugs.donarmstrong.com id=B831.12209084745659 (code B ref 831); Mon, 08 Sep 2008 21:20:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.1 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 831) by emacsbugs.donarmstrong.com; 8 Sep 2008 21:14:34 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m88LEUPZ005653 for <831@emacsbugs.donarmstrong.com>; Mon, 8 Sep 2008 14:14:31 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Kco2P-0003Xa-82 for 831@emacsbugs.donarmstrong.com; Mon, 08 Sep 2008 17:12:45 -0400 Resent-To: 831@debbugs.gnu.org Resent-From: Glenn Morris Resent-Date: Mon, 08 Sep 2008 17:12:45 -0400 Resent-Message-ID: <0sabeiqr3m.fsf@fencepost.gnu.org> Resent-User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-From-Line: tzz@lifelogs.com Mon Sep 8 06:56:06 2008 Received: from mail.gnu.org ([199.232.76.166]:42837 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KcePd-00038C-Hc for rgm@gnu.org; Mon, 08 Sep 2008 06:56:06 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KceRE-0000O5-Pn for rgm@gnu.org; Mon, 08 Sep 2008 06:57:48 -0400 Received: from ip114.208-100-47.static.steadfast.net ([208.100.47.114]:42112 helo=mail.blockstar.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KceRE-0000NE-34 for rgm@gnu.org; Mon, 08 Sep 2008 06:57:44 -0400 Received: from mungo (c-68-60-254-123.hsd1.il.comcast.net [68.60.254.123]) by mail.blockstar.com (Postfix) with ESMTP id E2C633F86B1; Mon, 8 Sep 2008 03:29:40 -0700 (PDT) From: Ted Zlatanov To: Glenn Morris Cc: 381@debbugs.gnu.org Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: <9oljyep93x.fsf@fencepost.gnu.org> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Date: Mon, 08 Sep 2008 05:29:37 -0500 In-Reply-To: (Glenn Morris's message of "Sun, 07 Sep 2008 16:37:14 -0400") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-Greylist: delayed 1680 seconds by postgrey-1.27 at monty-python; Mon, 08 Sep 2008 06:57:42 EDT Lines: 51 User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Resent-Date: Mon, 08 Sep 2008 17:12:45 -0400 X-CrossAssassin-Score: 2 On Sun, 07 Sep 2008 16:37:14 -0400 Glenn Morris wrote: GM> Would you mind not using the newsgroup interface? It seems to break GM> the bug tracker, in that your posts don't appear there (I have GM> forwarded some there). This is some bug, not your fault. I'll try to CC correctly. I have to use that interface, unfortunately. GM> Ted Zlatanov wrote: >> I used the data member rename patch Austin and others suggested for two >> days now without problems. It lets Emacs build on Mac OS X and despite >> being insufficient as a full fix, at least the users don't have to wait >> for the full fix to have a working compile. >> >> I comitted this change to the Emacs CVS HEAD, including fixing the >> references to gidx in the xdisp.c docs, and will back it out (or anyone >> else can back it out) if it's a problem. GM> Can you give it the correct attribution in the ChangeLog? Maybe you GM> came up with it independently, in which case it's correct as is. GM> I thought it was Daniel Koning's. There were 2 suggestions plus I looked at it myself (with a `grep gidx'). I'll gladly attribute it to Daniel but Austin has a claim to it as well, and I don't know how to do mulitple authors. >> I apologize in advance if that's the case. All the gidx references >> are changed to cmp_from, that's all it does. GM> I left it alone partly because obviously wrong is better than subtly wrong. GM> (Not that I can say if it is right or wrong). I figured wrong is OK, broken is not OK for most Emacs users. Testing it for 2 days gave me confidence it would not be annoying. GM> And also partly to see how many duplicate reports were received. :) GM> About 13 I think, none apart from the first and the one with the patch GM> conveying any useful information. And most saying "is this known?" :) GM> (I'm not saying you should take it out.) OK. Kenichi Handa thinks it's a lot of work to make it work correctly with composition, so I think this should be documented as a TODO item. I don't know the right place to document this; it's not FOR-RELEASE since it probably won't block a release. Thanks for all your help with this and other issues. Ted From unknown Sat Jun 14 19:02:54 2025 X-Loop: don@donarmstrong.com Subject: bug#831: 23.0.60; error in nsfonts.m Reply-To: Glenn Morris , 831@debbugs.gnu.org Resent-From: Glenn Morris Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs , don@donarmstrong.com Resent-Date: Mon, 08 Sep 2008 21:25:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 831 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: patch Received: via spool by 831-submit@emacsbugs.donarmstrong.com id=B831.12209087537291 (code B ref 831); Mon, 08 Sep 2008 21:25:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.0 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 831) by emacsbugs.donarmstrong.com; 8 Sep 2008 21:19:13 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m88LJA4u007285 for <831@emacsbugs.donarmstrong.com>; Mon, 8 Sep 2008 14:19:11 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Kco6p-0003gu-H8; Mon, 08 Sep 2008 17:17:19 -0400 From: Glenn Morris To: Ted Zlatanov Cc: 831@debbugs.gnu.org References: <9oljyep93x.fsf@fencepost.gnu.org> X-Spook: credit card lock picking gamma eternity server John Kerry X-Ran: ns+JXSDa9Te#~`dycVkgvpjx+}.F1BlJ,@# (Ted Zlatanov's message of "Mon, 08 Sep 2008 05:29:37 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Ted Zlatanov wrote: > I'll try to CC correctly. I have to use that interface, unfortunately. Of course, I went and cc'd the wrong bug number, sigh. :( It should have been 831, not 381. Perhaps you should just continue to do what is convenient for you. It's not your fault we have a broken system. > There were 2 suggestions plus I looked at it myself (with a `grep > gidx'). I'll gladly attribute it to Daniel but Austin has a claim to > it as well, and I don't know how to do mulitple authors. The first suggestion (from #831 "replace gidx with x") was just wrong. The #832 patch was the one applied. It should be marked (tiny change). (See eg 2008-06-20, textmodes/rst.el in lisp/ChangeLog for how to do multiple authors.)