From unknown Tue Aug 19 06:31:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8309: 24.0.50; Remove leftover (require 'wid-edit) Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: cyd@stupidchicken.com, bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2011 06:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8309 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8309@debbugs.gnu.org Cc: Chong Yidong X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Chong Yidong Received: via spool by submit@debbugs.gnu.org id=B.130068934312009 (code B ref -1); Mon, 21 Mar 2011 06:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Mar 2011 06:35:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1YiN-00037e-Ee for submit@debbugs.gnu.org; Mon, 21 Mar 2011 02:35:43 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1YiL-00037S-Rs for submit@debbugs.gnu.org; Mon, 21 Mar 2011 02:35:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1YiF-0002Ud-N5 for submit@debbugs.gnu.org; Mon, 21 Mar 2011 02:35:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:45187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1YiF-0002UZ-Kz for submit@debbugs.gnu.org; Mon, 21 Mar 2011 02:35:35 -0400 Received: from [140.186.70.92] (port=38857 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1YiE-000099-K5 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 02:35:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1YiD-0002U3-6d for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 02:35:34 -0400 Received: from mail-iy0-f169.google.com ([209.85.210.169]:54020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1YiD-0002Ty-3H for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 02:35:33 -0400 Received: by iyf13 with SMTP id 13so7665584iyf.0 for ; Sun, 20 Mar 2011 23:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:x-debbugs-cc:date:message-id :mime-version:content-type; bh=A5uHNAzdquj1HX5M8lp+j5hZQuRIZg8yZepYZBF5DsE=; b=bjvlezwuLL/K+P/m3I/ujPqZSetS85+wa150Q3Jwkqczv3/v369v3ggdYcvCh9qsx1 nfqpkwZWlCl3UQkyEkPmILxsKRYKPYVrJGhOyo1KYfvQW3Zyi2A/FtPP2Gc5zbtBnxZl 6asknFZNOmSZV02rOGbfyA+rhxtI/zR3O9QZs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; b=BLSMINCqXgBKd9cVURvHbbJYLBJBivgiRcy7wcXmqcQ5ghbwfVTr3GKElKtc6XNmTX jFli6akFCzBZ5dhg0lbXrdtCoU976V98xUiAWceiJ8HMP5+XeGMImZoFvMLr2t6nZDs7 XZQJailPNZ0UwxPXhkwXCi8QYJYJOGsEn7Gzk= Received: by 10.43.69.201 with SMTP id yd9mr6410863icb.92.1300689332424; Sun, 20 Mar 2011 23:35:32 -0700 (PDT) Received: from localhost ([114.249.16.245]) by mx.google.com with ESMTPS id s40sm3497549ibg.43.2011.03.20.23.35.28 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 20 Mar 2011 23:35:31 -0700 (PDT) From: Leo Date: Mon, 21 Mar 2011 14:35:20 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) It looks to me since revno: 103251: ,----[ 103251 ] | message: | Use simple buttons, instead of widget buttons, in vc-log. | | * lisp/vc/vc.el (vc-print-log-setup-buttons): Instead of using the | widget library for buttons, just use button.el. | | * lisp/vc/log-view.el (log-view-mode-map): Don't inherit from | widget-keymap. `---- (require 'wid-edit) is no longer needed for log-view.el. Any objection to this patch: === modified file 'lisp/vc/log-view.el' --- lisp/vc/log-view.el 2011-02-14 01:49:24 +0000 +++ lisp/vc/log-view.el 2011-03-21 06:34:34 +0000 @@ -121,9 +121,6 @@ :group 'pcl-cvs :prefix "log-view-") -;; Needed because log-view-mode-map inherits from widget-keymap. (Bug#5311) -(require 'wid-edit) - (easy-mmode-defmap log-view-mode-map '( ;; FIXME: (copy-keymap special-mode-map) instead Leo From unknown Tue Aug 19 06:31:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8309: 24.0.50; Remove leftover (require 'wid-edit) Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2011 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8309 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Cc: Chong Yidong , 8309@debbugs.gnu.org Received: via spool by 8309-submit@debbugs.gnu.org id=B8309.130071908130816 (code B ref 8309); Mon, 21 Mar 2011 14:52:02 +0000 Received: (at 8309) by debbugs.gnu.org; 21 Mar 2011 14:51:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1gS0-00080z-Mo for submit@debbugs.gnu.org; Mon, 21 Mar 2011 10:51:20 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1gRy-00080o-Pz for 8309@debbugs.gnu.org; Mon, 21 Mar 2011 10:51:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEADsCh01Ld/X5/2dsb2JhbAClcnjARoVjBJVp X-IronPort-AV: E=Sophos;i="4.63,219,1299474000"; d="scan'208";a="97413975" Received: from 75-119-245-249.dsl.teksavvy.com (HELO pastel.home) ([75.119.245.249]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 21 Mar 2011 10:51:13 -0400 Received: by pastel.home (Postfix, from userid 20848) id 10D0558AF5; Mon, 21 Mar 2011 10:51:13 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Mon, 21 Mar 2011 10:51:13 -0400 In-Reply-To: (Leo's message of "Mon, 21 Mar 2011 14:35:20 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > === modified file 'lisp/vc/log-view.el' > --- lisp/vc/log-view.el 2011-02-14 01:49:24 +0000 > +++ lisp/vc/log-view.el 2011-03-21 06:34:34 +0000 > @@ -121,9 +121,6 @@ > :group 'pcl-cvs > :prefix "log-view-") > -;; Needed because log-view-mode-map inherits from widget-keymap. (Bug#5311) > -(require 'wid-edit) > - > (easy-mmode-defmap log-view-mode-map > '( > ;; FIXME: (copy-keymap special-mode-map) instead Please install, yes, thanks, Stefan From unknown Tue Aug 19 06:31:11 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Subject: bug#8309: closed (Re: bug#8309: 24.0.50; Remove leftover (require 'wid-edit)) Message-ID: References: X-Gnu-PR-Message: they-closed 8309 X-Gnu-PR-Package: emacs Reply-To: 8309@debbugs.gnu.org Date: Mon, 21 Mar 2011 15:29:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1300721342-8623-1" This is a multi-part message in MIME format... ------------=_1300721342-8623-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #8309: 24.0.50; Remove leftover (require 'wid-edit) which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 8309@debbugs.gnu.org. --=20 8309: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8309 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1300721342-8623-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 8309-done) by debbugs.gnu.org; 21 Mar 2011 15:28:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1h1y-0002DJ-6O for submit@debbugs.gnu.org; Mon, 21 Mar 2011 11:28:30 -0400 Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1h1w-0002Cr-U2 for 8309-done@debbugs.gnu.org; Mon, 21 Mar 2011 11:28:29 -0400 Received: by iyi12 with SMTP id 12so6153293iyi.3 for <8309-done@debbugs.gnu.org>; Mon, 21 Mar 2011 08:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=zJrQMC2S8lADBz1JFsb4x/eQ9kWUzz5q3HJDi8aR/Cc=; b=HoyU8QFa6O08ocqcToukz237/TsQjFIKb/x3JJHb3VEl/pBol9BJ6sQXu2aqvVCF9/ x6pZuzKoRqIIAY1KvVVmwurOJ36CDalfUxb9Ogc9dSnqwnzbnSWmNhn6qQXJS31pOSX7 PgFIXyaGvncVfMAzjNXNYwpaVmOXwLNybQK+Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; b=xwIADOYRkCO32F9Au2AqQgswUZWZGj8OLMfwBM5VnI7DSqyB4MQd6xb2RQw3UjD7Ic CHtDTZEMdovg/gBgWLhNxf7EvaRxYJXCJH+0V7L7gYDxOq2gISmw1ZL097aYgm4AFt0F 02zHOgh2W459Gn8Lo1UCJMgLziVuDFeK+jP3Y= Received: by 10.231.43.133 with SMTP id w5mr4391590ibe.13.1300721303050; Mon, 21 Mar 2011 08:28:23 -0700 (PDT) Received: from localhost (th041135.ip.tsinghua.edu.cn [59.66.41.135]) by mx.google.com with ESMTPS id he40sm3784217ibb.67.2011.03.21.08.28.19 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Mar 2011 08:28:21 -0700 (PDT) From: Leo To: 8309-done@debbugs.gnu.org Subject: Re: bug#8309: 24.0.50; Remove leftover (require 'wid-edit) References: Date: Mon, 21 Mar 2011 23:28:15 +0800 In-Reply-To: (Stefan Monnier's message of "Mon, 21 Mar 2011 10:51:13 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (Mac OS X 10.6.6) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 8309-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) Version: 24.1. ------------=_1300721342-8623-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Mar 2011 06:35:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1YiN-00037e-Ee for submit@debbugs.gnu.org; Mon, 21 Mar 2011 02:35:43 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1YiL-00037S-Rs for submit@debbugs.gnu.org; Mon, 21 Mar 2011 02:35:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1YiF-0002Ud-N5 for submit@debbugs.gnu.org; Mon, 21 Mar 2011 02:35:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:45187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1YiF-0002UZ-Kz for submit@debbugs.gnu.org; Mon, 21 Mar 2011 02:35:35 -0400 Received: from [140.186.70.92] (port=38857 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1YiE-000099-K5 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 02:35:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1YiD-0002U3-6d for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 02:35:34 -0400 Received: from mail-iy0-f169.google.com ([209.85.210.169]:54020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1YiD-0002Ty-3H for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 02:35:33 -0400 Received: by iyf13 with SMTP id 13so7665584iyf.0 for ; Sun, 20 Mar 2011 23:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:x-debbugs-cc:date:message-id :mime-version:content-type; bh=A5uHNAzdquj1HX5M8lp+j5hZQuRIZg8yZepYZBF5DsE=; b=bjvlezwuLL/K+P/m3I/ujPqZSetS85+wa150Q3Jwkqczv3/v369v3ggdYcvCh9qsx1 nfqpkwZWlCl3UQkyEkPmILxsKRYKPYVrJGhOyo1KYfvQW3Zyi2A/FtPP2Gc5zbtBnxZl 6asknFZNOmSZV02rOGbfyA+rhxtI/zR3O9QZs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; b=BLSMINCqXgBKd9cVURvHbbJYLBJBivgiRcy7wcXmqcQ5ghbwfVTr3GKElKtc6XNmTX jFli6akFCzBZ5dhg0lbXrdtCoU976V98xUiAWceiJ8HMP5+XeGMImZoFvMLr2t6nZDs7 XZQJailPNZ0UwxPXhkwXCi8QYJYJOGsEn7Gzk= Received: by 10.43.69.201 with SMTP id yd9mr6410863icb.92.1300689332424; Sun, 20 Mar 2011 23:35:32 -0700 (PDT) Received: from localhost ([114.249.16.245]) by mx.google.com with ESMTPS id s40sm3497549ibg.43.2011.03.20.23.35.28 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 20 Mar 2011 23:35:31 -0700 (PDT) From: Leo To: bug-gnu-emacs@gnu.org Subject: 24.0.50; Remove leftover (require 'wid-edit) X-Debbugs-CC: Chong Yidong Date: Mon, 21 Mar 2011 14:35:20 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) It looks to me since revno: 103251: ,----[ 103251 ] | message: | Use simple buttons, instead of widget buttons, in vc-log. | | * lisp/vc/vc.el (vc-print-log-setup-buttons): Instead of using the | widget library for buttons, just use button.el. | | * lisp/vc/log-view.el (log-view-mode-map): Don't inherit from | widget-keymap. `---- (require 'wid-edit) is no longer needed for log-view.el. Any objection to this patch: === modified file 'lisp/vc/log-view.el' --- lisp/vc/log-view.el 2011-02-14 01:49:24 +0000 +++ lisp/vc/log-view.el 2011-03-21 06:34:34 +0000 @@ -121,9 +121,6 @@ :group 'pcl-cvs :prefix "log-view-") -;; Needed because log-view-mode-map inherits from widget-keymap. (Bug#5311) -(require 'wid-edit) - (easy-mmode-defmap log-view-mode-map '( ;; FIXME: (copy-keymap special-mode-map) instead Leo ------------=_1300721342-8623-1--