GNU bug report logs - #8304
23.2; ad-read-advised-function default to func at point

Previous Next

Full log

Message #8 received at 8304 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 8304 <at> debbugs.gnu.org
Subject: Re: bug#8304: 23.2; ad-read-advised-function default to func at point
Date: Mon, 21 Mar 2011 10:40:38 -0400

> 	* emacs-lisp/advice.el (ad-read-advised-function): Use
> 	`function-called-at-point' as the default default, if the func at
> 	point has advice, and passes PREDICATE.

Sounds like a fine change.

> -plays the same role as for `try-completion' (which see).  DEFAULT will
> -be returned on empty input (defaults to the first advised function for
> -which PREDICATE returns non-nil)."
> +plays the same role as for `try-completion' (which see).
> +
> +DEFAULT is returned on empty input.  DEFAULT defaults to the
> +function name at point if it's advised and passes PREDICATE,
> +otherwise to the first advised function which passes PREDICATE."

Actually, I don't think the docstring should document what `default' will
default to.  Actually, AFAICT the `default' argument is never used.

> +	    ;; prefer func name at point, if it's in ad-advised-functions etc

Comments should start with a capital and end with a "." or some other
appropriate punctuation.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.