From unknown Sun Jun 15 08:42:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8295: coreutils 8.10 portability fixes Resent-From: Andreas Stolcke Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 19 Mar 2011 20:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8295 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 8295@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.130056503627063 (code B ref -1); Sat, 19 Mar 2011 20:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Mar 2011 20:03:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q12NP-00072R-Bl for submit@debbugs.gnu.org; Sat, 19 Mar 2011 16:03:56 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q11SS-0005o4-Kj for submit@debbugs.gnu.org; Sat, 19 Mar 2011 15:05:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q11SM-0007sE-F2 for submit@debbugs.gnu.org; Sat, 19 Mar 2011 15:04:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:52164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q11SM-0007sA-CI for submit@debbugs.gnu.org; Sat, 19 Mar 2011 15:04:58 -0400 Received: from [140.186.70.92] (port=44544 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q11SL-00023l-7H for bug-coreutils@gnu.org; Sat, 19 Mar 2011 15:04:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q11SK-0007rO-2U for bug-coreutils@gnu.org; Sat, 19 Mar 2011 15:04:57 -0400 Received: from friend.speech.sri.com ([130.107.33.199]:42587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q11SJ-0007qz-R2 for bug-coreutils@gnu.org; Sat, 19 Mar 2011 15:04:56 -0400 Received: from huge (huge.speech.sri.com [130.107.33.186]) by friend.speech.sri.com (8.13.7+Sun/8.13.7) with ESMTP id p2JJ4klc010946 for ; Sat, 19 Mar 2011 12:04:48 -0700 (PDT) Received: from huge.speech.sri.com (localhost [127.0.0.1]) by huge (8.11.7p1+Sun/$Revision: 1.11 $) with ESMTP id p2JJ4ks00150 for ; Sat, 19 Mar 2011 12:04:46 -0700 (PDT) Message-Id: <201103191904.p2JJ4ks00150@huge> Date: Sat, 19 Mar 2011 12:04:46 -0700 From: Andreas Stolcke X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -6.6 (------) X-Mailman-Approved-At: Sat, 19 Mar 2011 16:03:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Two sets of fixes: - Several places where iterator variables are declared inside for(), failing compiles on systems that support c99. - The inclusion of has to be protected by #if HAVE_NL_LANGINFO instead of #if HAVE_LANGINFO_CODESET to match the piece of code later where the langinfo is actually used. These problems surfaced when building on an old IRIX5.3 system with gcc 3.4.6. --Andreas *** src/csplit.c.dist Mon Jan 31 04:40:38 2011 --- src/csplit.c Thu Mar 17 20:07:05 2011 *************** *** 1200,1207 **** get_format_flags (char const *format, int *flags_ptr) { int flags = 0; ! for (size_t count = 0; ; count++) { switch (format[count]) { --- 1200,1208 ---- get_format_flags (char const *format, int *flags_ptr) { int flags = 0; + size_t count; ! for (count = 0; ; count++) { switch (format[count]) { *************** *** 1275,1282 **** max_out (char *format) { bool percent = false; ! for (char *f = format; *f; f++) if (*f == '%' && *++f != '%') { if (percent) --- 1276,1284 ---- max_out (char *format) { bool percent = false; + char *f; ! for (f = format; *f; f++) if (*f == '%' && *++f != '%') { if (percent) *** src/ls.c.dist Mon Jan 31 04:40:38 2011 --- src/ls.c Thu Mar 17 20:12:24 2011 *************** *** 60,66 **** #include #include ! #if HAVE_LANGINFO_CODESET # include #endif --- 60,66 ---- #include #include ! #if HAVE_NL_LANGINFO # include #endif *************** *** 1036,1044 **** size_t curr_max_width; do { curr_max_width = required_mon_width; required_mon_width = 0; ! for (int i = 0; i < 12; i++) { size_t width = curr_max_width; --- 1036,1045 ---- size_t curr_max_width; do { + int i; curr_max_width = required_mon_width; required_mon_width = 0; ! for (i = 0; i < 12; i++) { size_t width = curr_max_width; *** src/sort.c.dist Thu Feb 3 02:24:35 2011 --- src/sort.c Thu Mar 17 20:23:49 2011 *************** *** 67,73 **** proper_name ("Mike Haertel"), \ proper_name ("Paul Eggert") ! #if HAVE_LANGINFO_CODESET # include #endif --- 67,73 ---- proper_name ("Mike Haertel"), \ proper_name ("Paul Eggert") ! #if HAVE_NL_LANGINFO # include #endif *** src/stat.c.dist Mon Jan 31 04:40:38 2011 --- src/stat.c Thu Mar 17 20:53:00 2011 *************** *** 586,592 **** if (1 < w) { char *dst = pformat; ! for (char const *src = dst; src < p; src++) { if (*src == '-') frac_left_adjust = true; --- 586,593 ---- if (1 < w) { char *dst = pformat; ! char const *src; ! for (src = dst; src < p; src++) { if (*src == '-') frac_left_adjust = true; *************** *** 603,609 **** } int divisor = 1; ! for (int i = precision; i < 9; i++) divisor *= 10; int frac_sec = arg.tv_nsec / divisor; int int_len; --- 604,611 ---- } int divisor = 1; ! int i; ! for (i = precision; i < 9; i++) divisor *= 10; int frac_sec = arg.tv_nsec / divisor; int int_len; From unknown Sun Jun 15 08:42:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8295: coreutils 8.10 portability fixes Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 20 Mar 2011 02:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8295 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Andreas Stolcke Cc: 8295@debbugs.gnu.org Received: via spool by 8295-submit@debbugs.gnu.org id=B8295.130058636924227 (code B ref 8295); Sun, 20 Mar 2011 02:00:03 +0000 Received: (at 8295) by debbugs.gnu.org; 20 Mar 2011 01:59:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q17vV-0006Ii-8Q for submit@debbugs.gnu.org; Sat, 19 Mar 2011 21:59:29 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q17vT-0006IV-My for 8295@debbugs.gnu.org; Sat, 19 Mar 2011 21:59:28 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id BE97339E8116; Sat, 19 Mar 2011 18:59:21 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RhN-6nn2FJEr; Sat, 19 Mar 2011 18:59:21 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 6583839E80DB; Sat, 19 Mar 2011 18:59:21 -0700 (PDT) Message-ID: <4D855F74.3070604@cs.ucla.edu> Date: Sat, 19 Mar 2011 18:59:16 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 MIME-Version: 1.0 References: <201103191904.p2JJ4ks00150@huge> In-Reply-To: <201103191904.p2JJ4ks00150@huge> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.9 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On 03/19/2011 12:04 PM, Andreas Stolcke wrote: > - Several places where iterator variables are declared inside for(), failing compiles > on systems that support c99. I assume you meant "systems that don't support c99". The README file has a section "Pre-C99 build failure" about that. Which compiler were you using, and why didn't "configure" successfully put it into c99 mode? From unknown Sun Jun 15 08:42:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8295: coreutils 8.10 portability fixes Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 20 Mar 2011 03:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8295 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Andreas Stolcke Cc: 8295@debbugs.gnu.org Received: via spool by 8295-submit@debbugs.gnu.org id=B8295.130058997829179 (code B ref 8295); Sun, 20 Mar 2011 03:00:03 +0000 Received: (at 8295) by debbugs.gnu.org; 20 Mar 2011 02:59:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q18rh-0007aY-Ki for submit@debbugs.gnu.org; Sat, 19 Mar 2011 22:59:37 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q18rg-0007aN-1G for 8295@debbugs.gnu.org; Sat, 19 Mar 2011 22:59:36 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id DCFF939E8116; Sat, 19 Mar 2011 19:59:29 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LEt3x93XTzvU; Sat, 19 Mar 2011 19:59:29 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 7858439E80DB; Sat, 19 Mar 2011 19:59:29 -0700 (PDT) Message-ID: <4D856D90.1050408@cs.ucla.edu> Date: Sat, 19 Mar 2011 19:59:28 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 MIME-Version: 1.0 References: <201103200244.p2K2iGWU011867@fruitcake.ICSI.Berkeley.EDU> In-Reply-To: <201103200244.p2K2iGWU011867@fruitcake.ICSI.Berkeley.EDU> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.9 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On 03/19/2011 07:44 PM, Andreas Stolcke wrote: > Good question, i don't know why configure didn't add -std=c99 to the CFLAGS. Could you please take a look at config.log, or send a (compressed) copy to the mailing list? That should say why; look for the string "option to accept ISO C99". To be honest, though, if this is merely a torture test for coreutils (to see whether coreutils runs on a museum piece), it's probably low priority. From unknown Sun Jun 15 08:42:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8295: coreutils 8.10 portability fixes References: <201103191904.p2JJ4ks00150@huge> Resent-From: Andreas Stolcke Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 20 Mar 2011 03:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8295 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert Cc: 8295@debbugs.gnu.org Received: via spool by 8295-submit@debbugs.gnu.org id=B8295.130059047429847 (code B ref 8295); Sun, 20 Mar 2011 03:08:02 +0000 Received: (at 8295) by debbugs.gnu.org; 20 Mar 2011 03:07:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q18zh-0007lL-1K for submit@debbugs.gnu.org; Sat, 19 Mar 2011 23:07:53 -0400 Received: from fruitcake.icsi.berkeley.edu ([192.150.186.11]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q18cx-0007Gc-U3 for 8295@debbugs.gnu.org; Sat, 19 Mar 2011 22:44:24 -0400 Received: from jack.ICSI.Berkeley.EDU (jack.ICSI.Berkeley.EDU [192.150.186.73]) by fruitcake.ICSI.Berkeley.EDU (8.12.11.20060614/8.12.11) with ESMTP id p2K2iGWU011867; Sat, 19 Mar 2011 19:44:16 -0700 (PDT) Message-Id: <201103200244.p2K2iGWU011867@fruitcake.ICSI.Berkeley.EDU> In-reply-to: Your message of Sat, 19 Mar 2011 18:59:16 -0700. <4D855F74.3070604@cs.ucla.edu> Date: Sat, 19 Mar 2011 19:44:16 -0700 From: Andreas Stolcke X-Spam-Score: -6.6 (------) X-Mailman-Approved-At: Sat, 19 Mar 2011 23:07:52 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) In message <4D855F74.3070604@cs.ucla.edu>you wrote: > On 03/19/2011 12:04 PM, Andreas Stolcke wrote: > > - Several places where iterator variables are declared inside for(), failing compiles > > on systems that support c99. > > I assume you meant "systems that don't support c99". right. > > The README file has a section "Pre-C99 build failure" > about that. Which compiler were you using, and why > didn't "configure" successfully put it into c99 mode? gcc-3.4.6 on mips-sgi-irix5.3, the last version i was able build on this old box. Good question, i don't know why configure didn't add -std=c99 to the CFLAGS. That would be the easier fix. --Andreas From unknown Sun Jun 15 08:42:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8295: coreutils 8.10 portability fixes Resent-From: Andreas Stolcke Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 20 Mar 2011 04:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8295 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert Cc: 8295@debbugs.gnu.org Received: via spool by 8295-submit@debbugs.gnu.org id=B8295.13005963775455 (code B ref 8295); Sun, 20 Mar 2011 04:47:02 +0000 Received: (at 8295) by debbugs.gnu.org; 20 Mar 2011 04:46:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1AWu-0001Pu-2E for submit@debbugs.gnu.org; Sun, 20 Mar 2011 00:46:17 -0400 Received: from friend.speech.sri.com ([130.107.33.199]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q191Z-0007nv-Ap for 8295@debbugs.gnu.org; Sat, 19 Mar 2011 23:09:50 -0400 Received: from [IPv6:::1] (huge.speech.sri.com [130.107.33.186]) by friend.speech.sri.com (8.13.7+Sun/8.13.7) with ESMTP id p2K39YU5011995; Sat, 19 Mar 2011 20:09:35 -0700 (PDT) Message-ID: <4D856FEE.60007@icsi.berkeley.edu> Date: Sat, 19 Mar 2011 20:09:34 -0700 From: Andreas Stolcke User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 References: <201103200244.p2K2iGWU011867@fruitcake.ICSI.Berkeley.EDU> <4D856D90.1050408@cs.ucla.edu> In-Reply-To: <4D856D90.1050408@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.0 (--) X-Mailman-Approved-At: Sun, 20 Mar 2011 00:46:14 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) Paul Eggert wrote: > On 03/19/2011 07:44 PM, Andreas Stolcke wrote: > >> Good question, i don't know why configure didn't add -std=c99 to the CFLAGS. >> > > Could you please take a look at config.log, or send a (compressed) > copy to the mailing list? That should say why; look for the > string "option to accept ISO C99". To be honest, > though, if this is merely a torture test for coreutils (to > see whether coreutils runs on a museum piece), it's probably low > priority. > We have this machine to run some legacy code. We need coreutils because the system-supplied Unix tools have hardcoded limits, missing options, etc. Andreas From unknown Sun Jun 15 08:42:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8295: coreutils 8.10 portability fixes Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 17 Apr 2011 06:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8295 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Andreas Stolcke Cc: Paul Eggert , 8295@debbugs.gnu.org Received: via spool by 8295-submit@debbugs.gnu.org id=B8295.130302266519411 (code B ref 8295); Sun, 17 Apr 2011 06:45:03 +0000 Received: (at 8295) by debbugs.gnu.org; 17 Apr 2011 06:44:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QBLia-000531-Gy for submit@debbugs.gnu.org; Sun, 17 Apr 2011 02:44:25 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QBLiZ-00052q-6c for 8295@debbugs.gnu.org; Sun, 17 Apr 2011 02:44:23 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 9E4F96012A; Sun, 17 Apr 2011 08:44:17 +0200 (CEST) From: Jim Meyering In-Reply-To: <201103200244.p2K2iGWU011867@fruitcake.ICSI.Berkeley.EDU> (Andreas Stolcke's message of "Sat, 19 Mar 2011 19:44:16 -0700") References: <201103191904.p2JJ4ks00150@huge> <201103200244.p2K2iGWU011867@fruitcake.ICSI.Berkeley.EDU> Date: Sun, 17 Apr 2011 08:44:17 +0200 Message-ID: <87ipudfkce.fsf@rho.meyering.net> Lines: 26 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) tags 8295 moreinfo tags 8295 notabug thanks Andreas Stolcke wrote: > In message <4D855F74.3070604@cs.ucla.edu>you wrote: >> On 03/19/2011 12:04 PM, Andreas Stolcke wrote: >> > - Several places where iterator variables are declared inside >> > for(), failing compiles >> > on systems that support c99. >> >> I assume you meant "systems that don't support c99". > > right. > >> >> The README file has a section "Pre-C99 build failure" >> about that. Which compiler were you using, and why >> didn't "configure" successfully put it into c99 mode? > > gcc-3.4.6 on mips-sgi-irix5.3, the last version i was able build on this old box. > Good question, i don't know why configure didn't add -std=c99 to the CFLAGS. > That would be the easier fix. I've marked this as notabug for now, presuming the probmem is due to your compiler. Please let us know if you learn otherwise. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 07 12:56:23 2011 Received: (at control) by debbugs.gnu.org; 7 Aug 2011 16:56:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qq6eF-0003SR-IX for submit@debbugs.gnu.org; Sun, 07 Aug 2011 12:56:23 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qq6eE-0003SL-9w for control@debbugs.gnu.org; Sun, 07 Aug 2011 12:56:22 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 3D0C8601D8 for ; Sun, 7 Aug 2011 18:55:24 +0200 (CEST) From: Jim Meyering To: control@debbugs.gnu.org Subject: tag 8295 as notabug/moreinfo Date: Sun, 07 Aug 2011 18:55:23 +0200 Message-ID: <87sjpdgo04.fsf@rho.meyering.net> Lines: 2 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) tags 8295 + moreinfo notabug thanks From unknown Sun Jun 15 08:42:49 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Andreas Stolcke Subject: bug#8295: closed (Re: bug#8295: coreutils 8.10 portability fixes) Message-ID: References: <20140408172928.GA23663@hysteria.proulx.com> <201103191904.p2JJ4ks00150@huge> X-Gnu-PR-Message: they-closed 8295 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: notabug moreinfo Reply-To: 8295@debbugs.gnu.org Date: Tue, 08 Apr 2014 17:29:55 +0000 Content-Type: multipart/mixed; boundary="----------=_1396978195-2230-1" This is a multi-part message in MIME format... ------------=_1396978195-2230-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #8295: coreutils 8.10 portability fixes which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 8295@debbugs.gnu.org. --=20 8295: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8295 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1396978195-2230-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 8295-done) by debbugs.gnu.org; 8 Apr 2014 17:29:32 +0000 Received: from localhost ([127.0.0.1]:38019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXZpz-0000ZC-RI for submit@debbugs.gnu.org; Tue, 08 Apr 2014 13:29:32 -0400 Received: from joseki.proulx.com ([216.17.153.58]:59673) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXZpx-0000Z4-4I for 8295-done@debbugs.gnu.org; Tue, 08 Apr 2014 13:29:30 -0400 Received: from hysteria.proulx.com (hysteria.proulx.com [192.168.230.119]) by joseki.proulx.com (Postfix) with ESMTP id 578F021228; Tue, 8 Apr 2014 11:29:28 -0600 (MDT) Received: by hysteria.proulx.com (Postfix, from userid 1000) id 3480D2DC9A; Tue, 8 Apr 2014 11:29:28 -0600 (MDT) Date: Tue, 8 Apr 2014 11:29:28 -0600 From: Bob Proulx To: 8295-done@debbugs.gnu.org, Andreas Stolcke Subject: Re: bug#8295: coreutils 8.10 portability fixes Message-ID: <20140408172928.GA23663@hysteria.proulx.com> References: <201103191904.p2JJ4ks00150@huge> <201103200244.p2K2iGWU011867@fruitcake.ICSI.Berkeley.EDU> <87ipudfkce.fsf@rho.meyering.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ipudfkce.fsf@rho.meyering.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 8295-done Cc: Paul Eggert , Jim Meyering X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 8295@debbugs.gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Jim Meyering wrote: > tags 8295 moreinfo > tags 8295 notabug > thanks > > Andreas Stolcke wrote: > > In message you wrote: > >> On 03/19/2011 12:04 PM, Andreas Stolcke wrote: > >> > - Several places where iterator variables are declared inside > >> > for(), failing compiles > >> > on systems that support c99. > >> > >> I assume you meant "systems that don't support c99". > > > > right. > > > >> The README file has a section "Pre-C99 build failure" > >> about that. Which compiler were you using, and why > >> didn't "configure" successfully put it into c99 mode? > > > > gcc-3.4.6 on mips-sgi-irix5.3, the last version i was able build on this old box. > > Good question, i don't know why configure didn't add -std=c99 to the CFLAGS. > > That would be the easier fix. > > I've marked this as notabug for now, presuming the probmem is due > to your compiler. Please let us know if you learn otherwise. Several years have passed and also several coreutils releases. Nothing additional has been heard to this bug log concerning this in that time. Assuming that all is good and resolved. Closing this bug in the bug tracker. Bob ------------=_1396978195-2230-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Mar 2011 20:03:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q12NP-00072R-Bl for submit@debbugs.gnu.org; Sat, 19 Mar 2011 16:03:56 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q11SS-0005o4-Kj for submit@debbugs.gnu.org; Sat, 19 Mar 2011 15:05:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q11SM-0007sE-F2 for submit@debbugs.gnu.org; Sat, 19 Mar 2011 15:04:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:52164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q11SM-0007sA-CI for submit@debbugs.gnu.org; Sat, 19 Mar 2011 15:04:58 -0400 Received: from [140.186.70.92] (port=44544 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q11SL-00023l-7H for bug-coreutils@gnu.org; Sat, 19 Mar 2011 15:04:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q11SK-0007rO-2U for bug-coreutils@gnu.org; Sat, 19 Mar 2011 15:04:57 -0400 Received: from friend.speech.sri.com ([130.107.33.199]:42587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q11SJ-0007qz-R2 for bug-coreutils@gnu.org; Sat, 19 Mar 2011 15:04:56 -0400 Received: from huge (huge.speech.sri.com [130.107.33.186]) by friend.speech.sri.com (8.13.7+Sun/8.13.7) with ESMTP id p2JJ4klc010946 for ; Sat, 19 Mar 2011 12:04:48 -0700 (PDT) Received: from huge.speech.sri.com (localhost [127.0.0.1]) by huge (8.11.7p1+Sun/$Revision: 1.11 $) with ESMTP id p2JJ4ks00150 for ; Sat, 19 Mar 2011 12:04:46 -0700 (PDT) Message-Id: <201103191904.p2JJ4ks00150@huge> To: bug-coreutils@gnu.org Subject: coreutils 8.10 portability fixes Date: Sat, 19 Mar 2011 12:04:46 -0700 From: Andreas Stolcke X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 19 Mar 2011 16:03:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Two sets of fixes: - Several places where iterator variables are declared inside for(), failing compiles on systems that support c99. - The inclusion of has to be protected by #if HAVE_NL_LANGINFO instead of #if HAVE_LANGINFO_CODESET to match the piece of code later where the langinfo is actually used. These problems surfaced when building on an old IRIX5.3 system with gcc 3.4.6. --Andreas *** src/csplit.c.dist Mon Jan 31 04:40:38 2011 --- src/csplit.c Thu Mar 17 20:07:05 2011 *************** *** 1200,1207 **** get_format_flags (char const *format, int *flags_ptr) { int flags = 0; ! for (size_t count = 0; ; count++) { switch (format[count]) { --- 1200,1208 ---- get_format_flags (char const *format, int *flags_ptr) { int flags = 0; + size_t count; ! for (count = 0; ; count++) { switch (format[count]) { *************** *** 1275,1282 **** max_out (char *format) { bool percent = false; ! for (char *f = format; *f; f++) if (*f == '%' && *++f != '%') { if (percent) --- 1276,1284 ---- max_out (char *format) { bool percent = false; + char *f; ! for (f = format; *f; f++) if (*f == '%' && *++f != '%') { if (percent) *** src/ls.c.dist Mon Jan 31 04:40:38 2011 --- src/ls.c Thu Mar 17 20:12:24 2011 *************** *** 60,66 **** #include #include ! #if HAVE_LANGINFO_CODESET # include #endif --- 60,66 ---- #include #include ! #if HAVE_NL_LANGINFO # include #endif *************** *** 1036,1044 **** size_t curr_max_width; do { curr_max_width = required_mon_width; required_mon_width = 0; ! for (int i = 0; i < 12; i++) { size_t width = curr_max_width; --- 1036,1045 ---- size_t curr_max_width; do { + int i; curr_max_width = required_mon_width; required_mon_width = 0; ! for (i = 0; i < 12; i++) { size_t width = curr_max_width; *** src/sort.c.dist Thu Feb 3 02:24:35 2011 --- src/sort.c Thu Mar 17 20:23:49 2011 *************** *** 67,73 **** proper_name ("Mike Haertel"), \ proper_name ("Paul Eggert") ! #if HAVE_LANGINFO_CODESET # include #endif --- 67,73 ---- proper_name ("Mike Haertel"), \ proper_name ("Paul Eggert") ! #if HAVE_NL_LANGINFO # include #endif *** src/stat.c.dist Mon Jan 31 04:40:38 2011 --- src/stat.c Thu Mar 17 20:53:00 2011 *************** *** 586,592 **** if (1 < w) { char *dst = pformat; ! for (char const *src = dst; src < p; src++) { if (*src == '-') frac_left_adjust = true; --- 586,593 ---- if (1 < w) { char *dst = pformat; ! char const *src; ! for (src = dst; src < p; src++) { if (*src == '-') frac_left_adjust = true; *************** *** 603,609 **** } int divisor = 1; ! for (int i = precision; i < 9; i++) divisor *= 10; int frac_sec = arg.tv_nsec / divisor; int int_len; --- 604,611 ---- } int divisor = 1; ! int i; ! for (i = precision; i < 9; i++) divisor *= 10; int frac_sec = arg.tv_nsec / divisor; int int_len; ------------=_1396978195-2230-1--