From unknown Wed Jun 25 10:48:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8289 <8289@debbugs.gnu.org> To: bug#8289 <8289@debbugs.gnu.org> Subject: Status: distcheck and make dvi Reply-To: bug#8289 <8289@debbugs.gnu.org> Date: Wed, 25 Jun 2025 17:48:40 +0000 retitle 8289 distcheck and make dvi reassign 8289 automake submitter 8289 karl@freefriends.org (Karl Berry) severity 8289 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 18 19:33:35 2011 Received: (at submit) by debbugs.gnu.org; 18 Mar 2011 23:33:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0jAl-0004vD-IZ for submit@debbugs.gnu.org; Fri, 18 Mar 2011 19:33:35 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0jAi-0004v0-Ta for submit@debbugs.gnu.org; Fri, 18 Mar 2011 19:33:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0jAb-0005sN-Tx for submit@debbugs.gnu.org; Fri, 18 Mar 2011 19:33:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:43755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0jAb-0005s5-Rx for submit@debbugs.gnu.org; Fri, 18 Mar 2011 19:33:25 -0400 Received: from [140.186.70.92] (port=43012 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0jAa-00073O-Ov for bug-automake@gnu.org; Fri, 18 Mar 2011 19:33:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0jAW-0005pS-E8 for bug-automake@gnu.org; Fri, 18 Mar 2011 19:33:24 -0400 Received: from b0.f7.net ([66.148.120.132]:42327 helo=freefriends.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0jAW-0005pE-4Y for bug-automake@gnu.org; Fri, 18 Mar 2011 19:33:20 -0400 X-Envelope-From: karl@freefriends.org X-Envelope-To: Received: from freefriends.org (sls-af11p1 [127.0.0.1]) by freefriends.org (8.14.4/8.14.4) with ESMTP id p2INXEa5019091 for ; Fri, 18 Mar 2011 19:33:17 -0400 Received: (from nobody@localhost) by freefriends.org (8.14.4/8.14.4/submit) id p2INXEv9019090; Fri, 18 Mar 2011 23:33:14 GMT Date: Fri, 18 Mar 2011 23:33:14 GMT Message-Id: <201103182333.p2INXEv9019090@freefriends.org> X-Authentication-Warning: localhost.localdomain: nobody set sender to karl@freefriends.org using -f From: karl@freefriends.org (Karl Berry) To: bug-automake@gnu.org Subject: distcheck and make dvi X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) Hi Ralf and all, make distcheck runs make dvi. If an author has only made .pdf's with images, this will cause a surprising error that .eps files are missing. (Someone just wrote me about this.) I see the issue has been noted before, e.g.: http://comments.gmane.org/gmane.comp.sysutils.automake.general/10304 I suggest that the workaround Ralf suggests there -- an empty make rule for dvi: -- be explicitly documented. Another (often preferable) option is to create and distribute the .eps files, of course. Another possible change, in addition to messing with the documentation, would be to make the "dvi" a variable that such non-dvi-generating people can override with "pdf" if they wish. Then they could get the benefit of the check in a clean way without forcing .eps. Or maybe dvi: pdf would have the same effect? I'm not sure. Thanks, Karl From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 08:27:17 2011 Received: (at 8289) by debbugs.gnu.org; 20 Mar 2011 12:27:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1Hj2-0003la-NA for submit@debbugs.gnu.org; Sun, 20 Mar 2011 08:27:16 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Q1Hj0-0003lM-5R for 8289@debbugs.gnu.org; Sun, 20 Mar 2011 08:27:15 -0400 Received: (qmail invoked by alias); 20 Mar 2011 12:27:07 -0000 Received: from xdsl-89-0-191-160.netcologne.de (EHLO localhost.localdomain) [89.0.191.160] by mail.gmx.net (mp063) with SMTP; 20 Mar 2011 13:27:07 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX1+RTl8NdoORyltT2d1ZGGP21kn+PY3EWDsYdi75CS VOJzdDq4nU0vwL Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1Q1HCa-0002jR-3c; Sun, 20 Mar 2011 12:53:44 +0100 Date: Sun, 20 Mar 2011 12:53:44 +0100 From: Ralf Wildenhues To: Karl Berry Subject: Re: bug#8289: distcheck and make dvi Message-ID: <20110320115343.GL3541@gmx.de> References: <201103182333.p2INXEv9019090@freefriends.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201103182333.p2INXEv9019090@freefriends.org> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 8289 Cc: 8289@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Hi Karl, thanks for the bug report. * Karl Berry wrote on Sat, Mar 19, 2011 at 12:33:14AM CET: > http://comments.gmane.org/gmane.comp.sysutils.automake.general/10304 > > I suggest that the workaround Ralf suggests there -- an empty make rule > for dvi: -- be explicitly documented. Another (often preferable) option > is to create and distribute the .eps files, of course. Agreed on all accounts. However, there are cases where dvi output just isn't feasible in practice. Reuben Thomas has suggested more general latex support in bug 8099, which also touches this area. > Another possible change, in addition to messing with the documentation, > would be to make the "dvi" a variable that such non-dvi-generating > people can override with "pdf" if they wish. Then they could get the > benefit of the check in a clean way without forcing .eps. Or maybe > dvi: pdf > would have the same effect? I'm not sure. Well, 'dvi: pdf' might help the distcheck to succeed, but generally, if I run 'make dvi' then what I'd like is DVI not PDF output. The latter is not convertible into the former. Enhancing distcheck to just not bother checking dvi output and rather test PDF output seems like another good alternative. Thanks, Ralf From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 14:02:35 2011 Received: (at 8289) by debbugs.gnu.org; 20 Mar 2011 18:02:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1MxW-0002g0-PH for submit@debbugs.gnu.org; Sun, 20 Mar 2011 14:02:34 -0400 Received: from mail-vw0-f44.google.com ([209.85.212.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1MxV-0002fp-1w for 8289@debbugs.gnu.org; Sun, 20 Mar 2011 14:02:33 -0400 Received: by vws12 with SMTP id 12so4298583vws.3 for <8289@debbugs.gnu.org>; Sun, 20 Mar 2011 11:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=thSRWqvpe0ByyqiV1m5uGENC6iy4SDU9MfEtZCrX4wU=; b=VBPjQi2dxUnptvn/TXGcQ7R1IryNyTCMG+4Qybiga6IKJaRe89qseYRy75bqbak2pZ 6MIy6+1rA5ZhNfeVuR/nNVarz8K2Grw5WuHMYtWh+MyQb0pBVJ/kttEoTAfq9kLTuHGf y4Pw+tw3k1GvuWykspo1zj8WmXPEdKgvNSk88= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=McZUx5+Y34gmekM5on+NtUMMH91qFZOS/k4vcSKFLwYxnZA8Wik4Fw6/NyOxnHA/zp 6usuzk7w7pPmbnSgLyFOj1zjqsfhHKPvwaM6cs5RJzIAtV7/T+hq+E6x9I+3W0rrjwXj U6/7KA1N3wcr2sssK8b3X7Z05QN/8PyrcIue8= MIME-Version: 1.0 Received: by 10.220.122.39 with SMTP id j39mr959328vcr.78.1300644147347; Sun, 20 Mar 2011 11:02:27 -0700 (PDT) Received: by 10.220.188.75 with HTTP; Sun, 20 Mar 2011 11:02:27 -0700 (PDT) In-Reply-To: <20110320115343.GL3541@gmx.de> References: <201103182333.p2INXEv9019090@freefriends.org> <20110320115343.GL3541@gmx.de> Date: Mon, 21 Mar 2011 05:02:27 +1100 X-Google-Sender-Auth: S2YjASOuku9UrMYjlj6JWTgRMpE Message-ID: Subject: Re: bug#8289: distcheck and make dvi From: Jack Kelly To: Ralf Wildenhues Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: 8289 Cc: 8289@debbugs.gnu.org, Karl Berry X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) On Sun, Mar 20, 2011 at 10:53 PM, Ralf Wildenhues wrote: >> Another possible change, in addition to messing with the documentation, >> would be to make the "dvi" a variable that such non-dvi-generating >> people can override with "pdf" if they wish. =A0Then they could get the >> benefit of the check in a clean way without forcing .eps. =A0Or maybe >> dvi: pdf >> would have the same effect? =A0I'm not sure. > > Well, 'dvi: pdf' might help the distcheck to succeed, but generally, if > I run 'make dvi' then what I'd like is DVI not PDF output. =A0The latter > is not convertible into the former. =A0Enhancing distcheck to just not > bother checking dvi output and rather test PDF output seems like another > good alternative. Not only does this feel like a hack, but I'd worry that it might violate the GNU coding standards, to which automake-generated makefiles are meant to comply? -- Jack From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 17:29:09 2011 Received: (at 8289) by debbugs.gnu.org; 20 Mar 2011 21:29:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1QBR-00081Z-HR for submit@debbugs.gnu.org; Sun, 20 Mar 2011 17:29:09 -0400 Received: from b0.f7.net ([66.148.120.132] helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1QBQ-00081N-FT for 8289@debbugs.gnu.org; Sun, 20 Mar 2011 17:29:08 -0400 X-Envelope-From: karl@freefriends.org X-Envelope-To: <8289@debbugs.gnu.org> Received: from freefriends.org (sls-af11p1 [127.0.0.1]) by freefriends.org (8.14.4/8.14.4) with ESMTP id p2KLSxiE002191 for <8289@debbugs.gnu.org>; Sun, 20 Mar 2011 17:29:02 -0400 Received: (from nobody@localhost) by freefriends.org (8.14.4/8.14.4/submit) id p2KLSxdi002190; Sun, 20 Mar 2011 21:28:59 GMT Date: Sun, 20 Mar 2011 21:28:59 GMT Message-Id: <201103202128.p2KLSxdi002190@freefriends.org> X-Authentication-Warning: localhost.localdomain: nobody set sender to karl@freefriends.org using -f From: karl@freefriends.org (Karl Berry) To: 8289@debbugs.gnu.org Subject: Re: bug#8289: distcheck and make dvi In-Reply-To: X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 8289 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) However, there are cases where dvi output just isn't feasible in practice. Yep. Therein lies the essence of the problem. not bother checking dvi output and rather test PDF output seems like another good alternative. I can't agree with that. That's trading DVI-generation problems for PDF-generation problems. Believe me, there will be just as many if not more. Any manual which has *only* eps files, for starters. All together, for a general fix, my suggestion is to simply replace the hardwired "dvi" string with a new variable name, like $(AM_DISTCHECK_DOC) or some such (no idea if that's a reasonable name, but you get the idea), which defaults to dvi and which users can override either with "pdf" or with some no-op target. Which in turn would need to be created/documented if one doesn't exist already. How does that sound? jack> violate the GNU coding standards, to which automake-generated makefiles are meant to comply? The dvi: pdf kludge was a user override. The coding standards aren't an issue in that case. Thanks, k From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 18:34:16 2011 Received: (at 8289) by debbugs.gnu.org; 20 Mar 2011 22:34:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1RCR-0001Ap-Hx for submit@debbugs.gnu.org; Sun, 20 Mar 2011 18:34:15 -0400 Received: from mail-vx0-f172.google.com ([209.85.220.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1RCP-0001Ad-If for 8289@debbugs.gnu.org; Sun, 20 Mar 2011 18:34:14 -0400 Received: by vxg33 with SMTP id 33so4311809vxg.3 for <8289@debbugs.gnu.org>; Sun, 20 Mar 2011 15:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=9YCMuZmIMSdGAEOpgMNZjywlAvRrh1Z8uhmpm3hhcog=; b=gCpfPFCnORRioRFJ5e5dHmev8l4afHE3m3q7H+1s8FN4wCPhKlVGtORCs6nJlidCLC /3A2ZZKuJMiuJ53yD/5dtecQM9qQ0tA61w5tRfFTE2q1qPxGFKzjl6Vx98ltPpuiDREJ rN55708GO255v3zRHZp6w7m2jmCuWX+kcX+Is= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=PEUvEC3P/XwChj6h1qJ7K08pDastZjuGmzqbbubiA+nLM+vYo2eLoNa6daWRLjoRcZ 1hiNQtrsFVnjVWasgycZWdA3bVgnctkYYUwV+H8N1DdslBrB6qRwOEiDH8MT3LOXok+Z vbEhJyEmVT+ulVpKFJCzxZp3339GHFWJB9X6g= MIME-Version: 1.0 Received: by 10.220.124.144 with SMTP id u16mr998556vcr.113.1300660447884; Sun, 20 Mar 2011 15:34:07 -0700 (PDT) Received: by 10.220.188.75 with HTTP; Sun, 20 Mar 2011 15:34:07 -0700 (PDT) In-Reply-To: <201103202128.p2KLSxdi002190@freefriends.org> References: <201103182333.p2INXEv9019090@freefriends.org> <201103202128.p2KLSxdi002190@freefriends.org> Date: Mon, 21 Mar 2011 09:34:07 +1100 X-Google-Sender-Auth: f6U0B1F_ekYVE-EBLTpgVtmhtAk Message-ID: Subject: Re: bug#8289: distcheck and make dvi From: Jack Kelly To: Karl Berry Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8289 Cc: 8289@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) On Mon, Mar 21, 2011 at 8:28 AM, Karl Berry wrote: > All together, for a general fix, my suggestion is to simply replace the > hardwired "dvi" string with a new variable name, like > $(AM_DISTCHECK_DOC) or some such (no idea if that's a reasonable name, > but you get the idea), which defaults to dvi and which users can > override either with "pdf" or with some no-op target. =A0Which in turn > would need to be created/documented if one doesn't exist already. New automake options? Something like: AM_INIT_AUTOMAKE([foreign distcheck-doc-pdf no-distcheck-doc-dvi]) > =A0 =A0jack> violate the GNU coding standards, to which automake-generate= d > =A0 =A0makefiles are meant to comply? > > The dvi: pdf kludge was a user override. =A0The coding standards aren't a= n > issue in that case. Good to know. -- Jack From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 18:35:39 2011 Received: (at 8289) by debbugs.gnu.org; 20 Mar 2011 22:35:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1RDl-0001Ch-Uy for submit@debbugs.gnu.org; Sun, 20 Mar 2011 18:35:38 -0400 Received: from b0.f7.net ([66.148.120.132] helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1RDk-0001CV-1C for 8289@debbugs.gnu.org; Sun, 20 Mar 2011 18:35:36 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (sls-af11p1 [127.0.0.1]) by freefriends.org (8.14.4/8.14.4) with ESMTP id p2KMZRev005987; Sun, 20 Mar 2011 18:35:30 -0400 Received: (from karl@localhost) by freefriends.org (8.14.4/8.14.4/submit) id p2KMZROL005984; Sun, 20 Mar 2011 22:35:27 GMT Date: Sun, 20 Mar 2011 22:35:27 GMT Message-Id: <201103202235.p2KMZROL005984@freefriends.org> From: karl@freefriends.org (Karl Berry) To: jack@jackkelly.name Subject: Re: bug#8289: distcheck and make dvi In-Reply-To: X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8289 Cc: 8289@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) Hi Jack, New automake options? Something like: I like my idea of a variable better :). Seems simpler/less intrusive/more general. Best, k From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 23:51:41 2011 Received: (at 8289) by debbugs.gnu.org; 21 Mar 2011 03:51:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1W9c-00081h-Ma for submit@debbugs.gnu.org; Sun, 20 Mar 2011 23:51:40 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Q1W9Z-00081U-BC for 8289@debbugs.gnu.org; Sun, 20 Mar 2011 23:51:38 -0400 Received: (qmail invoked by alias); 21 Mar 2011 03:51:31 -0000 Received: from xdsl-78-35-56-64.netcologne.de (EHLO localhost.localdomain) [78.35.56.64] by mail.gmx.net (mp052) with SMTP; 21 Mar 2011 04:51:31 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX19ORFNSPhJONEr3shNzY/TmdHnt2vwi20k3URfgsv GkN+yyHSMo94m8 Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1Q1W9S-0004Ii-D4; Mon, 21 Mar 2011 04:51:30 +0100 Date: Mon, 21 Mar 2011 04:51:30 +0100 From: Ralf Wildenhues To: Karl Berry Subject: Re: bug#8289: distcheck and make dvi Message-ID: <20110321035130.GC16028@gmx.de> References: <201103182333.p2INXEv9019090@freefriends.org> <201103202128.p2KLSxdi002190@freefriends.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201103202128.p2KLSxdi002190@freefriends.org> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 8289 Cc: 8289@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) * Karl Berry wrote on Sun, Mar 20, 2011 at 10:28:59PM CET: > not bother checking dvi output and rather test PDF output seems > like another good alternative. > > I can't agree with that. That's trading DVI-generation problems for > PDF-generation problems. Believe me, there will be just as many if not > more. Any manual which has *only* eps files, for starters. Right, I'm on the same page as you here: such a trade should be at the developer's discretion. > All together, for a general fix, my suggestion is to simply replace the > hardwired "dvi" string with a new variable name, like > $(AM_DISTCHECK_DOC) or some such (no idea if that's a reasonable name, > but you get the idea), which defaults to dvi and which users can > override either with "pdf" or with some no-op target. Which in turn > would need to be created/documented if one doesn't exist already. Something like that sounds sensible. Incidentally, Stefano already has a pending patch for some distcheck generalizations using variables; the change for this PR could look to use similar style. Cheers, Ralf From debbugs-submit-bounces@debbugs.gnu.org Sun May 17 12:43:31 2020 Received: (at 8289) by debbugs.gnu.org; 17 May 2020 16:43:32 +0000 Received: from localhost ([127.0.0.1]:44487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaMNv-0008Er-LF for submit@debbugs.gnu.org; Sun, 17 May 2020 12:43:31 -0400 Received: from freefriends.org ([96.88.95.60]:46742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaMNt-0008Ej-Vv for 8289@debbugs.gnu.org; Sun, 17 May 2020 12:43:30 -0400 X-Envelope-From: karl@freefriends.org X-Envelope-To: <8289@debbugs.gnu.org> Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 04HGhSWA013450 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <8289@debbugs.gnu.org>; Sun, 17 May 2020 10:43:29 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 04HGhSjg013449; Sun, 17 May 2020 10:43:28 -0600 Date: Sun, 17 May 2020 10:43:28 -0600 Message-Id: <202005171643.04HGhSjg013449@freefriends.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ej7RrmrjIA" Content-Transfer-Encoding: 7bit From: Karl Berry To: 8289@debbugs.gnu.org Subject: Re: bug#8289: distcheck and make dvi In-Reply-To: <20110321035130.GC16028@gmx.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 8289 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --ej7RrmrjIA Content-Type: text/plain; charset=us-ascii Content-Description: message body text Content-Transfer-Encoding: 7bit I've attempted to construct a patch [attached] following my own suggestion :), to create a new variable to allow overriding the "make dvi" which is done as part of distcheck with another target. I named the variable AM_DISTCHECK_DVI_TARGET (if something else seems better, fine). The actual functional change is one line, in distdir.am: - && $(MAKE) $(AM_MAKEFLAGS) dvi \ + && $(MAKE) $(AM_MAKEFLAGS) $(AM_DISTCHECK_DVI_TARGET) \ All else is overhead. My biggest question is about naming. I simply AM_DISTCHECK_DVI_TARGET = dvi for the default also in distdir.am. This necessitated adding it to the list of AM_* variables allowed to be defined, in Variable.pm: - (AM_MAKEINFOHTMLFLAGS => 1, + (AM_DISTCHECK_DVI_TARGET => 1, + AM_MAKEINFOHTMLFLAGS => 1, Would it be better to use a separate variable, like am__distcheck_dvi_target? But then how to know if the user has defined AM_DISTCHECK_DVI_TARGET? Of course any and all comments welcome ... Jim? Anyone? --thanks, karl. --ej7RrmrjIA Content-Type: application/octet-stream Content-Disposition: attachment; filename="distcheck-dvi.patch" Content-Transfer-Encoding: base64 RnJvbSAwNDU2N2JlNmU5MGJlYjYyZDA3YWFmOTgxMzAwYThkMmU4MzFmZTkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYXJsIEJlcnJ5IDxrYXJsQGZyZWVmcmllbmRzLm9yZz4KRGF0 ZTogU3VuLCAxNyBNYXkgMjAyMCAwOTozNjoxNSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGF1dG9t YWtlOiBuZXcgdmFyaWFibGUgQU1fRElTVENIRUNLX0RWSV9UQVJHRVQgdG8gb3ZlcnJpZGUKICJk dmkiLgoKVGhpcyBjaGFuZ2UgZml4ZXMgaHR0cHM6Ly9idWdzLmdudS5vcmcvODI4OS4KCiogbGli L2FtL2Rpc3RkaXIuYW0gKEFNX0RJU1RDSEVDS19EVklfVEFSR0VUKTogZGVmaW5lIGFzIGR2aS4K KGRpc3RjaGVjayk6IHVzZSBpdCwgaXNudGVhZCBvZiBoYXJkY29kaW5nIGR2aS4KKiBsaWIvQXV0 b21ha2UvVmFyaWFibGUucG0gKCVfc2lsZW50X3ZhcmlhYmxlX292ZXJyaWRlKTogYWRkCkFNX0RJ U1RDSEVDS19EVklfVEFSR0VULgoqIHQvZGlzdGNoZWNrLW92ZXJyaWRlLWR2aS5zaDogbmV3IHRl c3QuCiogdC9saXN0LW9mLXRlc3RzLm1rIChoYW5kd3JpdHRlbl9URVNUUyk6IGFkZCBpdC4KKiBk b2MvYXV0b21ha2UudGV4aSAoQ2hlY2tpbmcgdGhlIERpc3RyaWJ1dGlvbik6IGRvY3VtZW50IHRo aXMuCihUaGlyZC1QYXJ0eSBNYWtlZmlsZXMpOiBleHBsaWNpdGx5IG1lbnRpb24gdGhhdApFTVBU WV9BVVRPTUFLRV9UQVJHRVRTIGlzIG5vdCBhIGJ1aWx0LWluIG9yIHNwZWNpYWwgbmFtZS4KVmFy aW91cyBvdGhlciBpbmRleCBlbnRyaWVzIGFuZCB3b3JkaW5nIHR3ZWFrcy4KKiBORVdTIChEaXN0 cmlidXRpb24pOiBtZW50aW9uIHRoaXMuCi0tLQogTkVXUyAgICAgICAgICAgICAgICAgICAgICAg IHwgIDUgKysrKwogZG9jL2F1dG9tYWtlLnRleGkgICAgICAgICAgIHwgNjUgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCiBsaWIvQXV0b21ha2UvVmFyaWFibGUu cG0gICAgfCAgMyArKy0KIGxpYi9hbS9kaXN0ZGlyLmFtICAgICAgICAgICB8ICA1ICsrKy0KIHQv ZGlzdGNoZWNrLW92ZXJyaWRlLWR2aS5zaCB8IDU2ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrCiB0L2xpc3Qtb2YtdGVzdHMubWsgICAgICAgICAgfCAgMSArCiA2IGZpbGVz IGNoYW5nZWQsIDExOCBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2Rl IDEwMDY0NCB0L2Rpc3RjaGVjay1vdmVycmlkZS1kdmkuc2gKCmRpZmYgLS1naXQgYS9ORVdTIGIv TkVXUwppbmRleCAxNzIyNjVhLi5mYzNmMmRlIDEwMDY0NAotLS0gYS9ORVdTCisrKyBiL05FV1MK QEAgLTcyLDYgKzcyLDExIEBAIE5ldyBpbiA/Lj8uPzoKIAogICAtIHZhbGFjIGFyZ3VtZW50IG1h dGNoaW5nIG1vcmUgcHJlY2lzZSwgdG8gYXZvaWQgZ2FyYmFnZSBpbiBESVNUX0NPTU1PTi4KIAor KiBEaXN0cmlidXRpb24KKworICAtIG5ldyB2YXJpYWJsZSBBTV9ESVNUQ0hFQ0tfRFZJX1RBUkdF VCwgdG8gYWxsb3cgb3ZlcnJpZGluZyB0aGUKKyAgICAibWFrZSBkdmkiIHRoYXQgaXMgZG9uZSBh cyBwYXJ0IG9mIGRpc3RjaGVjay4KKwogKiBNaXNjZWxsYW5lb3VzIGNoYW5nZXMKIAogICAtIFJl bW92ZWQgZnVuY3Rpb24gdXBfdG9fZGF0ZV9wIGluIGxpYi9BdXRvbWFrZS9GaWxlVXRpbHMucG0u CmRpZmYgLS1naXQgYS9kb2MvYXV0b21ha2UudGV4aSBiL2RvYy9hdXRvbWFrZS50ZXhpCmluZGV4 IGFkYzQ0ZjUuLjdjYzdiY2IgMTAwNjQ0Ci0tLSBhL2RvYy9hdXRvbWFrZS50ZXhpCisrKyBiL2Rv Yy9hdXRvbWFrZS50ZXhpCkBAIC0xMjMxLDcgKzEyMzEsNyBAQCB3b3JrOgogQGl0ZW1pemUgQGJ1 bGxldAogQGl0ZW0KIEl0IGF0dGVtcHRzIGEgZnVsbCBjb21waWxhdGlvbiBvZiB0aGUgcGFja2Fn ZSAoQHB4cmVme0Jhc2ljCi1JbnN0YWxsYXRpb259KSwgdW5wYWNraW5nIHRoZSBuZXdseSBjb25z dHJ1Y3RlZCB0YXJiYWxsLCBydW5uaW5nCitJbnN0YWxsYXRpb259KTogdW5wYWNraW5nIHRoZSBu ZXdseSBjb25zdHJ1Y3RlZCB0YXJiYWxsLCBydW5uaW5nCiBAY29kZXttYWtlfSwgQGNvZGV7bWFr ZSBkdml9LCBAY29kZXttYWtlIGNoZWNrfSwgQGNvZGV7bWFrZSBpbnN0YWxsfSwKIGFzIHdlbGwg YXMgQGNvZGV7bWFrZSBpbnN0YWxsY2hlY2t9LCBhbmQgZXZlbiBAY29kZXttYWtlIGRpc3R9LAog QGl0ZW0KQEAgLTEyNDMsMTIgKzEyNDMsMTMgQEAgdW5pbnN0YWxsfSBkbyBub3Qgb21pdCBhbnkg ZmlsZSAoQHB4cmVme1N0YW5kYXJkIFRhcmdldHN9KSwKIGFuZCBpdCBjaGVja3MgdGhhdCBAY29k ZXtERVNURElSfSBpbnN0YWxsYXRpb25zIHdvcmsgKEBweHJlZntERVNURElSfSkuCiBAZW5kIGl0 ZW1pemUKIAotQWxsIG9mIHRoZXNlIGFjdGlvbnMgYXJlIHBlcmZvcm1lZCBpbiBhIHRlbXBvcmFy eSBkaXJlY3RvcnksIHNvIHRoYXQgbm8KLXJvb3QgcHJpdmlsZWdlcyBhcmUgcmVxdWlyZWQuICBQ bGVhc2Ugbm90ZSB0aGF0IHRoZSBleGFjdCBsb2NhdGlvbiBhbmQgdGhlCi1leGFjdCBzdHJ1Y3R1 cmUgb2Ygc3VjaCBhIHN1YmRpcmVjdG9yeSAod2hlcmUgdGhlIGV4dHJhY3RlZCBzb3VyY2VzIGFy ZQotcGxhY2VkLCBob3cgdGhlIHRlbXBvcmFyeSBidWlsZCBhbmQgaW5zdGFsbCBkaXJlY3Rvcmll cyBhcmUgbmFtZWQgYW5kIGhvdwotZGVlcGx5IHRoZXkgYXJlIG5lc3RlZCwgZXRjLikgaXMgdG8g YmUgY29uc2lkZXJlZCBhbiBpbXBsZW1lbnRhdGlvbiBkZXRhaWwsCi13aGljaCBjYW4gY2hhbmdl IGF0IGFueSB0aW1lOyBzbyBkbyBub3QgcmVseSBvbiBpdC4KK0FsbCBvZiB0aGVzZSBhY3Rpb25z IGFyZSBwZXJmb3JtZWQgaW4gYSB0ZW1wb3JhcnkgZGlyZWN0b3J5LCBzbyB0aGF0CitubyByb290 IHByaXZpbGVnZXMgYXJlIHJlcXVpcmVkLiAgVGhlIGV4YWN0IGxvY2F0aW9uIGFuZCB0aGUgZXhh Y3QKK3N0cnVjdHVyZSBvZiBzdWNoIGEgc3ViZGlyZWN0b3J5ICh3aGVyZSB0aGUgZXh0cmFjdGVk IHNvdXJjZXMgYXJlCitwbGFjZWQsIGhvdyB0aGUgdGVtcG9yYXJ5IGJ1aWxkIGFuZCBpbnN0YWxs IGRpcmVjdG9yaWVzIGFyZSBuYW1lZCBhbmQKK2hvdyBkZWVwbHkgdGhleSBhcmUgbmVzdGVkLCBl dGMuKSBpcyB0byBiZSBjb25zaWRlcmVkIGFuCitpbXBsZW1lbnRhdGlvbiBkZXRhaWwsIHdoaWNo IGNhbiBjaGFuZ2UgYXQgYW55IHRpbWU7IHNvIGRvIG5vdCByZWx5IG9uCitpdC4KIAogUmVsZWFz aW5nIGEgcGFja2FnZSB0aGF0IGZhaWxzIEBjb2Rle21ha2UgZGlzdGNoZWNrfSBtZWFucyB0aGF0 IG9uZSBvZgogdGhlIHNjZW5hcmlvcyB3ZSBwcmVzZW50ZWQgd2lsbCBub3Qgd29yayBhbmQgc29t ZSB1c2VycyB3aWxsIGJlCkBAIC04MDQ1LDcgKzgwNDYsNiBAQCBUaGUgbmFtZSBvZiB0aGUgY29t bWFuZCB0aGF0IGJ1aWxkcyBhIEBmaWxley5wc30gZmlsZSBvdXQgb2YgYQogQGZpbGV7LmR2aX0g ZmlsZS4gIFRoaXMgZGVmYXVsdHMgdG8gQHNhbXB7ZHZpcHN9LgogCiBAaXRlbSBURVhJTkZPX1RF WAotCiBJZiB5b3VyIHBhY2thZ2UgaGFzIFRleGluZm8gZmlsZXMgaW4gbWFueSBkaXJlY3Rvcmll cywgeW91IGNhbiB1c2UgdGhlCiB2YXJpYWJsZSBAY29kZXtURVhJTkZPX1RFWH0gdG8gdGVsbCBB dXRvbWFrZSB3aGVyZSB0byBmaW5kIHRoZSBjYW5vbmljYWwKIEBmaWxle3RleGluZm8udGV4fSBm b3IgeW91ciBwYWNrYWdlLiAgVGhlIHZhbHVlIG9mIHRoaXMgdmFyaWFibGUgc2hvdWxkCkBAIC04 NTY5LDEyICs4NTY5LDE0IEBAIGRpc3R9IHdhcyBydW4sIG5vdCB0byBhbnkgc3ViLXBhY2thZ2Vz IGludm9sdmVkLgogQXV0b21ha2UgYWxzbyBnZW5lcmF0ZXMgYSBAY29kZXtkaXN0Y2hlY2t9IHJ1 bGUgdGhhdCBjYW4gYmUgb2YgaGVscAogdG8gZW5zdXJlIHRoYXQgYSBnaXZlbiBkaXN0cmlidXRp b24gd2lsbCBhY3R1YWxseSB3b3JrLiAgU2ltcGxpZnlpbmcKIGEgYml0LCB3ZSBjYW4gc2F5IHRo aXMgcnVsZSBmaXJzdCBtYWtlcyBhIGRpc3RyaWJ1dGlvbiwgYW5kIHRoZW4sCi1AZW1waHtvcGVy YXRpbmcgZnJvbSBpdH0sIHRha2VzIHRoZSBmb2xsb3dpbmcgc3RlcHM6CitAZW1waHtvcGVyYXRp bmcgZnJvbSBpdH0sIHRha2VzIHRoZSBmb2xsb3dpbmcgc3RlcHMgKGluIHRoaXMgb3JkZXIpOgog QGl0ZW1pemUKIEBpdGVtCiB0cmllcyB0byBkbyBhIEBjb2Rle1ZQQVRIfSBidWlsZCAoQHB4cmVm e1ZQQVRIIEJ1aWxkc30pLCB3aXRoIHRoZQogQGNvZGV7c3JjZGlyfSBhbmQgYWxsIGl0cyBjb250 ZW50IG1hZGUgQGVtcGh7cmVhZC1vbmx5fTsKIEBpdGVtCit0cmllcyB0byBtYWtlIHRoZSBwcmlu dGFibGUgZG9jdW1lbnRhdGlvbiwgaWYgYW55ICh3aXRoIEBjb21tYW5ke21ha2UgZHZpfSksCitA aXRlbQogcnVucyB0aGUgdGVzdCBzdWl0ZSAod2l0aCBAY29tbWFuZHttYWtlIGNoZWNrfSkgb24g dGhpcyBmcmVzaCBidWlsZDsKIEBpdGVtCiBpbnN0YWxscyB0aGUgcGFja2FnZSBpbiBhIHRlbXBv cmFyeSBkaXJlY3RvcnkgKHdpdGggQGNvbW1hbmR7bWFrZQpAQCAtODU4OCwxMiArODU5MCwxMiBA QCBmaW5hbGx5LCBtYWtlcyBhbm90aGVyIHRhcmJhbGwgdG8gZW5zdXJlIHRoZSBkaXN0cmlidXRp b24gaXMKIHNlbGYtY29udGFpbmVkLgogQGVuZCBpdGVtaXplCiAKLUFsbCBvZiB0aGVzZSBhY3Rp b25zIGFyZSBwZXJmb3JtZWQgaW4gYSB0ZW1wb3JhcnkgZGlyZWN0b3J5LiAgUGxlYXNlCi1ub3Rl IHRoYXQgdGhlIGV4YWN0IGxvY2F0aW9uIGFuZCB0aGUgZXhhY3Qgc3RydWN0dXJlIG9mIHN1Y2gg YSBkaXJlY3RvcnkKLSh3aGVyZSB0aGUgcmVhZC1vbmx5IHNvdXJjZXMgYXJlIHBsYWNlZCwgaG93 IHRoZSB0ZW1wb3JhcnkgYnVpbGQgYW5kCi1pbnN0YWxsIGRpcmVjdG9yaWVzIGFyZSBuYW1lZCBh bmQgaG93IGRlZXBseSB0aGV5IGFyZSBuZXN0ZWQsIGV0Yy4pIGlzCi10byBiZSBjb25zaWRlcmVk IGFuIGltcGxlbWVudGF0aW9uIGRldGFpbCwgd2hpY2ggY2FuIGNoYW5nZSBhdCBhbnkgdGltZTsK LXNvIGRvIG5vdCByZWx5IG9uIGl0LgorQWxsIG9mIHRoZXNlIGFjdGlvbnMgYXJlIHBlcmZvcm1l ZCBpbiBhIHRlbXBvcmFyeSBkaXJlY3RvcnkuICBUaGUKK2V4YWN0IGxvY2F0aW9uIGFuZCB0aGUg ZXhhY3Qgc3RydWN0dXJlIG9mIHN1Y2ggYSBkaXJlY3RvcnkgKHdoZXJlIHRoZQorcmVhZC1vbmx5 IHNvdXJjZXMgYXJlIHBsYWNlZCwgaG93IHRoZSB0ZW1wb3JhcnkgYnVpbGQgYW5kIGluc3RhbGwK K2RpcmVjdG9yaWVzIGFyZSBuYW1lZCBhbmQgaG93IGRlZXBseSB0aGV5IGFyZSBuZXN0ZWQsIGV0 Yy4pIGlzIHRvIGJlCitjb25zaWRlcmVkIGFuIGltcGxlbWVudGF0aW9uIGRldGFpbCwgd2hpY2gg Y2FuIGNoYW5nZSBhdCBhbnkgdGltZTsgc28KK2RvIG5vdCByZWx5IG9uIGl0LgogCiBAdmluZGV4 IEFNX0RJU1RDSEVDS19DT05GSUdVUkVfRkxBR1MKIEB2aW5kZXggRElTVENIRUNLX0NPTkZJR1VS RV9GTEFHUwpAQCAtODYyNyw2ICs4NjI5LDMwIEBAIG9uZSBwb2ludCB0aGUgQGNvbW1hbmR7bTR9 IGJ1aWxkIHN5c3RlbSBoYWQgYSBidWcgd2hlcmUgQGNvbW1hbmR7bWFrZQogaW5zdGFsbGNoZWNr fSB3YXMgd3JvbmdseSBhc3N1bWluZyBpdCBjb3VsZCBibGluZGx5IHRlc3QgIkBjb21tYW5ke200 fSIsCiByYXRoZXIgdGhhbiB0aGUganVzdC1pbnN0YWxsZWQgIkBjb21tYW5ke2dtNH0iLgogCitA dHJpbmRleCBkdmkKK0BzdWJoZWFkaW5nIGR2aSBhbmQgZGlzdGNoZWNrCitAY2luZGV4IEBjb2Rl e2Vwc30gaW1hZ2VzCitPcmRpbmFyaWx5LCBAY29tbWFuZHttYWtlIGRpc3RjaGVja30gcnVucyBA Y29tbWFuZHttYWtlIGR2aX0uICBJdCBkb2VzCitub3RoaW5nIGlmIHRoZSBkaXN0cmlidXRpb24g Y29udGFpbnMgbm8gVGV4aW5mbyBzb3VyY2VzLiAgSWYgdGhlCitkaXN0cmlidXRpb24gZG9lcyBj b250YWluIGEgVGV4aW5mbyBtYW51YWwsIGJ5IGRlZmF1bHQgdGhlIEBjb2Rle2R2aX0KK3Rhcmdl dCB3aWxsIHJ1biBAVGVYe30gdG8gbWFrZSBzdXJlIGl0IGNhbiBiZSBzdWNjZXNzZnVsbHkgcHJv Y2Vzc2VkCisoQHB4cmVme1RleGluZm99KS4KKworSG93ZXZlciwgeW91IG1heSB3aXNoIHRvIHRl c3QgdGhlIG1hbnVhbCBieSBwcm9kdWNpbmcgQGNvZGV7cGRmfQorKGUuZy4sIGlmIHlvdXIgbWFu dWFsIHVzZXMgaW1hZ2VzIGluIGZvcm1hdHMgb3RoZXIgdGhhbiBAY29kZXtlcHN9KSwKK0Bjb2Rl e2h0bWx9IChpZiB5b3UgZG9uJ3QgaGF2ZSBAVGVYe30gYXQgYWxsKSwgc29tZSBvdGhlciBmb3Jt YXQsIG9yCitqdXN0IHNraXAgdGhlIHRlc3QgZW50aXJlbHkgKG5vdCByZWNvbW1lbmRlZCkuICBZ b3UgY2FuIGNoYW5nZSB0aGUKK3RhcmdldCB0aGF0IGlzIHJ1biBieSBzZXR0aW5nIHRoZSB2YXJp YWJsZQorQGNvZGV7QU1fRElTVENIRUNLX0RWSV9UQVJHRVR9IGluIHlvdXIgQGNvZGV7TWFrZWZp bGUuYW19OyBmb3IKK2V4YW1wbGUsCisKK0BleGFtcGxlCitBTV9ESVNUQ0hFQ0tfRFZJX1RBUkdF VCA9IHBkZgorQGVuZCBleGFtcGxlCisKK1RvIG1ha2UgQGNvZGV7ZHZpfSBpbnRvIGEgZG8tbm90 aGluZyB0YXJnZXQsIHNlZSB0aGUgZXhhbXBsZSBmb3IKK0Bjb2Rle0VNUFRZX0FVVE9NQUtFX1RB UkdFVFN9IGluIEByZWZ7VGhpcmQtUGFydHkgTWFrZWZpbGVzfS4KKwogQHRyaW5kZXggZGlzdGNo ZWNrLWhvb2sKIEBzdWJoZWFkaW5nIGRpc3RjaGVjay1ob29rCiBJZiB0aGUgQGNvZGV7ZGlzdGNo ZWNrLWhvb2t9IHJ1bGUgaXMgZGVmaW5lZCBpbiB5b3VyIHRvcC1sZXZlbApAQCAtMTE0NDAsMTIg KzExNDY2LDIxIEBAIE9LIHRvIGhhdmUgYSBydWxlIHRoYXQgZG9lcyBub3RoaW5nLCBzbyBpZiB5 b3UgYXJlIGludGVncmF0aW5nIGEKIHRoaXJkLXBhcnR5IHByb2plY3Qgd2l0aCBubyBkb2N1bWVu dGF0aW9uIG9yIHRhZyBzdXBwb3J0LCB5b3UgY291bGQKIHNpbXBseSBhdWdtZW50IGl0cyBAZmls ZXtNYWtlZmlsZX0gYXMgZm9sbG93czoKIAorQHZpbmRleCBFTVBUWV9BVVRPTUFLRV9UQVJHRVRT CitAY2luZGV4IEF1dG9tYWtlIHRhcmdldHMsIG5vLW9wCitAY2luZGV4IGRvLW5vdGhpbmcgQXV0 b21ha2UgdGFyZ2V0cworQGNpbmRleCBlbXB0eSBBdXRvbWFrZSB0YXJnZXRzCitAY2luZGV4IG5v LW9wIEF1dG9tYWtlIHRhcmdldHMKK0BjaW5kZXggdGFyZ2V0cywgbWFraW5nIGludG8gbm8tb3AK IEBleGFtcGxlCiBFTVBUWV9BVVRPTUFLRV9UQVJHRVRTID0gZHZpIHBkZiBwcyBpbmZvIGh0bWwg dGFncyBjdGFncwogLlBIT05ZOiAkKEVNUFRZX0FVVE9NQUtFX1RBUkdFVFMpCiAkKEVNUFRZX0FV VE9NQUtFX1RBUkdFVFMpOgogQGVuZCBleGFtcGxlCiAKK1RvIGJlIGNsZWFyLCB0aGVyZSBpcyBu b3RoaW5nIHNwZWNpYWwgYWJvdXQgdGhlIHZhcmlhYmxlIG5hbWUKK0Bjb2Rle0VNUFRZX0FVVE9N QUtFX1RBUkdFVFN9OyB0aGUgbmFtZSBjb3VsZCBiZSBhbnl0aGluZy4KKwogQW5vdGhlciBhc3Bl Y3Qgb2YgaW50ZWdyYXRpbmcgdGhpcmQtcGFydHkgYnVpbGQgc3lzdGVtcyBpcyB3aGV0aGVyCiB0 aGV5IHN1cHBvcnQgVlBBVEggYnVpbGRzIChAcHhyZWZ7VlBBVEggQnVpbGRzfSkuICBPYnZpb3Vz bHkgaWYgdGhlCiBzdWJwYWNrYWdlIGRvZXMgbm90IHN1cHBvcnQgVlBBVEggYnVpbGRzIHRoZSB3 aG9sZSBwYWNrYWdlIHdpbGwgbm90CmRpZmYgLS1naXQgYS9saWIvQXV0b21ha2UvVmFyaWFibGUu cG0gYi9saWIvQXV0b21ha2UvVmFyaWFibGUucG0KaW5kZXggNzI4NzJhMy4uMzYzYTNlMCAxMDA2 NDQKLS0tIGEvbGliL0F1dG9tYWtlL1ZhcmlhYmxlLnBtCisrKyBiL2xpYi9BdXRvbWFrZS9WYXJp YWJsZS5wbQpAQCAtMTk4LDcgKzE5OCw4IEBAIG15ICRjb25maWd1cmVfYWM7CiAKICMgVmFyaWFi bGVzIHRoYXQgY2FuIGJlIG92ZXJyaWRkZW4gd2l0aG91dCBjb21wbGFpbnQgZnJvbSAtV292ZXJy aWRlCiBteSAlX3NpbGVudF92YXJpYWJsZV9vdmVycmlkZSA9Ci0gIChBTV9NQUtFSU5GT0hUTUxG TEFHUyA9PiAxLAorICAoQU1fRElTVENIRUNLX0RWSV9UQVJHRVQgPT4gMSwKKyAgIEFNX01BS0VJ TkZPSFRNTEZMQUdTID0+IDEsCiAgICBBUiA9PiAxLAogICAgQVJGTEFHUyA9PiAxLAogICAgREVK QVRPT0wgPT4gMSwKZGlmZiAtLWdpdCBhL2xpYi9hbS9kaXN0ZGlyLmFtIGIvbGliL2FtL2Rpc3Rk aXIuYW0KaW5kZXggMjYyMTI0MS4uNzc0ZDA4YiAxMDA2NDQKLS0tIGEvbGliL2FtL2Rpc3RkaXIu YW0KKysrIGIvbGliL2FtL2Rpc3RkaXIuYW0KQEAgLTQyNSw2ICs0MjUsOSBAQCBpZiAlP1NVQkRJ UlMlCiBBTV9SRUNVUlNJVkVfVEFSR0VUUyArPSBkaXN0Y2hlY2sKIGVuZGlmICU/U1VCRElSUyUK IAorIyBFeGlzdHMgb25seSB0byBiZSBvdmVycmlkZGVuIGJ5IHRoZSB1c2VyIGlmIGRlc2lyZWQu CitBTV9ESVNUQ0hFQ0tfRFZJX1RBUkdFVCA9IGR2aQorCiAjIFRoaXMgdGFyZ2V0IHVudGFycyB0 aGUgZGlzdCBmaWxlIGFuZCB0cmllcyBhIFZQQVRIIGNvbmZpZ3VyYXRpb24uICBUaGVuCiAjIGl0 IGd1YXJhbnRlZXMgdGhhdCB0aGUgZGlzdHJpYnV0aW9uIGlzIHNlbGYtY29udGFpbmVkIGJ5IG1h a2luZyBhbm90aGVyCiAjIHRhcmZpbGUuCkBAIC00OTAsNyArNDkzLDcgQEAgZGlzdGNoZWNrOiBk aXN0CiAjIyAoaW4gY29ybmVyLWNhc2UgdXNhZ2VzKTsgc2VlIGF1dG9tYWtlIGJ1ZyMxNDk5MS4K IAkgICAgLS1zcmNkaXI9Li4vLi4gLS1wcmVmaXg9IiQkZGNfaW5zdGFsbF9iYXNlIiBcCiAJICAm JiAkKE1BS0UpICQoQU1fTUFLRUZMQUdTKSBcCi0JICAmJiAkKE1BS0UpICQoQU1fTUFLRUZMQUdT KSBkdmkgXAorCSAgJiYgJChNQUtFKSAkKEFNX01BS0VGTEFHUykgJChBTV9ESVNUQ0hFQ0tfRFZJ X1RBUkdFVCkgXAogCSAgJiYgJChNQUtFKSAkKEFNX01BS0VGTEFHUykgY2hlY2sgXAogCSAgJiYg JChNQUtFKSAkKEFNX01BS0VGTEFHUykgaW5zdGFsbCBcCiAJICAmJiAkKE1BS0UpICQoQU1fTUFL RUZMQUdTKSBpbnN0YWxsY2hlY2sgXApkaWZmIC0tZ2l0IGEvdC9kaXN0Y2hlY2stb3ZlcnJpZGUt ZHZpLnNoIGIvdC9kaXN0Y2hlY2stb3ZlcnJpZGUtZHZpLnNoCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLjhkODNkN2UKLS0tIC9kZXYvbnVsbAorKysgYi90L2Rpc3RjaGVjay1v dmVycmlkZS1kdmkuc2gKQEAgLTAsMCArMSw1NiBAQAorIyEgL2Jpbi9zaAorIyBDb3B5cmlnaHQg KEMpIDIwMTEtMjAyMCBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKyMKKyMgVGhpcyBw cm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBt b2RpZnkKKyMgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGlj ZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyMgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0 aGVyIHZlcnNpb24gMiwgb3IgKGF0IHlvdXIgb3B0aW9uKQorIyBhbnkgbGF0ZXIgdmVyc2lvbi4K KyMKKyMgVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2ls bCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRo ZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBB IFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vu c2UgZm9yIG1vcmUgZGV0YWlscy4KKyMKKyMgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29w eSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyMgYWxvbmcgd2l0aCB0aGlzIHBy b2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cHM6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LgorCisj IENoZWNrIHRoYXQgd2UgY2FuIG92ZXJyaWRlIHRoZSAnZHZpJyB0YXJnZXQgcnVuIGFzIHBhcnQg b2YgZGlzdGNoZWNrLAorIyBzcGVjaWZpY2FsbHkgdG8gYmUgJ2h0bWwnLCBzbyB0aGF0IFRlWCBp cyBub3QgcmVxdWlyZWQuCisjIFJlbGF0ZWQgdG8gYXV0b21ha2UgYnVnIzgyODkuCisKKyMgVGVY IGFuZCB0ZXhpMmR2aSBzaG91bGQgbm90IGJlIG5lZWRlZCBvciBpbnZva2VkLgorVEVYPWZhbHNl IFRFWEkyRFZJPWZhbHNlCitleHBvcnQgVEVYIFRFWEkyRFZJCisKK3JlcXVpcmVkPSdtYWtlaW5m bycKKy4gdGVzdC1pbml0LnNoCisKK2NhdCA+PiBjb25maWd1cmUuYWMgPDwgJ0VORCcKK0FDX09V VFBVVAorRU5ECisKK2NhdCA+IE1ha2VmaWxlLmFtIDw8ICdFTkQnCitBTV9ESVNUQ0hFQ0tfRFZJ X1RBUkdFVCA9IGh0bWwKK2luZm9fVEVYSU5GT1MgPSBtYWluLnRleGkKK0VORAorCisjIFByb3Rl Y3Qgd2l0aCBsZWFkaW5nICIgIyAiIHRvIGF2b2lkIHNwdXJpb3VzIG1haW50YWluZXItY2hlY2sg ZmFpbHVyZXMuCitzZWQgJ3MvXiAqIyAqLy8nID4gbWFpbi50ZXhpIDw8ICdFTkQnCisgIyBcaW5w dXQgdGV4aW5mbworICMgQHNldGZpbGVuYW1lIG1haW4uaW5mbworICMgQHNldHRpdGxlIG1haW4K KyAjCisgIyBAbm9kZSBUb3AKKyAjIEhlbGxvLgorICMgQGJ5ZQorRU5ECisKKyRBQ0xPQ0FMCisk QVVUT01BS0UgLWEKKyRBVVRPQ09ORgorCisuL2NvbmZpZ3VyZQorJE1BS0UKKyRNQUtFIGRpc3Rj aGVjaworCis6CmRpZmYgLS1naXQgYS90L2xpc3Qtb2YtdGVzdHMubWsgYi90L2xpc3Qtb2YtdGVz dHMubWsKaW5kZXggYWFiMzNkYy4uNDNlYTI0NSAxMDA2NDQKLS0tIGEvdC9saXN0LW9mLXRlc3Rz Lm1rCisrKyBiL3QvbGlzdC1vZi10ZXN0cy5tawpAQCAtNDMxLDYgKzQzMSw3IEBAIHQvZGlzdGNo ZWNrLXdyaXRhYmxlLXNyY2Rpci5zaCBcCiB0L2Rpc3RjaGVjay1taXNzaW5nLW00LnNoIFwKIHQv ZGlzdGNoZWNrLW91dGRhdGVkLW00LnNoIFwKIHQvZGlzdGNoZWNrLW5vLXByZWZpeC1vci1zcmNk aXItb3ZlcnJpZGUuc2ggXAordC9kaXN0Y2hlY2stb3ZlcnJpZGUtZHZpLnNoIFwKIHQvZGlzdGNo ZWNrLW92ZXJyaWRlLWluZm9kaXIuc2ggXAogdC9kaXN0Y2hlY2stcHI5NTc5LnNoIFwKIHQvZGlz dGNoZWNrLXByMTA0NzAuc2ggXAotLSAKMS44LjMuMQoKCg== --ej7RrmrjIA-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 22 21:23:38 2020 Received: (at 8289) by debbugs.gnu.org; 23 May 2020 01:23:38 +0000 Received: from localhost ([127.0.0.1]:33138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcIt0-0007Ao-HK for submit@debbugs.gnu.org; Fri, 22 May 2020 21:23:38 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:38634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcIsy-0007Ab-4C for 8289@debbugs.gnu.org; Fri, 22 May 2020 21:23:36 -0400 Received: by mail-wm1-f50.google.com with SMTP id u12so6950111wmd.3 for <8289@debbugs.gnu.org>; Fri, 22 May 2020 18:23:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QcCmHkyInYzUz9aZGxkcSLKJ+JbViAceK/GBi2KA27E=; b=bI/qVmRMSF6exAEvtM4OkNkRydVNPXnE42DN0hmVdrRnriVu6cnISkuCqRitAgtPaL QZkBbGktzeolhaARneLPDUWVzBHojIOBX2yV3g+1M+hxjayyTxOuF47Bb+7qEd10YLHp 9p2jwHyULe5RlQkTVzZYDL/AmlaHljqMYThUWi7naHaH7/92OMo+NTR0GZhQgOj1Vrqy Ux3DcrubSIsNwJ+Lj0qP3CjlCPdtMdXDsFryyvCr3q79P2t12sXd2ocQKe4d/Bp5Ao6W kC5dgWQVCBNrfZgyBO59c6n4mO306QDe5dCj9DI4i22jVrJ+1zqowJ0cS9S8JjTxLDpD GDtg== X-Gm-Message-State: AOAM5305bt9vnM3VKNQEMmu7nSGZcKgB/jGwJVebUR1UUKL8gh7Ohp50 aJiPgWqKZySYhdnMUDwjHlVjDrYjiyN/VtIYH3k= X-Google-Smtp-Source: ABdhPJzLu3vjz+5lEu9ssuC9JmfwJgbwGaRztaSXZ8X9Wb7RrFcb4fbuoSsXFl9XIvrwtw7bUGXySkpg7ywdwUEFIVc= X-Received: by 2002:a1c:720d:: with SMTP id n13mr15216561wmc.130.1590197010133; Fri, 22 May 2020 18:23:30 -0700 (PDT) MIME-Version: 1.0 References: <201103182333.p2INXEv9019090@freefriends.org> <20110321035130.GC16028@gmx.de> <202005171643.04HGhSjg013449@freefriends.org> In-Reply-To: <202005171643.04HGhSjg013449@freefriends.org> From: Jim Meyering Date: Fri, 22 May 2020 18:23:17 -0700 Message-ID: Subject: Re: bug#8289: distcheck and make dvi To: Karl Berry Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 8289 Cc: 8289@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sun, May 17, 2020 at 9:44 AM Karl Berry wrote: > I've attempted to construct a patch [attached] following my own > suggestion :), to create a new variable to allow overriding the "make > dvi" which is done as part of distcheck with another target. I named the > variable AM_DISTCHECK_DVI_TARGET (if something else seems better, > fine). The actual functional change is one line, in distdir.am: > > - && $(MAKE) $(AM_MAKEFLAGS) dvi \ > + && $(MAKE) $(AM_MAKEFLAGS) $(AM_DISTCHECK_DVI_TARGET) \ > > All else is overhead. My biggest question is about naming. I simply > AM_DISTCHECK_DVI_TARGET = dvi > for the default also in distdir.am. This necessitated adding it to the > list of AM_* variables allowed to be defined, in Variable.pm: > - (AM_MAKEINFOHTMLFLAGS => 1, > + (AM_DISTCHECK_DVI_TARGET => 1, > + AM_MAKEINFOHTMLFLAGS => 1, > > > Would it be better to use a separate variable, like > am__distcheck_dvi_target? But then how to know if the user has defined > AM_DISTCHECK_DVI_TARGET? > > Of course any and all comments welcome ... Jim? Anyone? --thanks, karl. Hi Karl, That looks fine to me. Sorry it took so long to reply. From debbugs-submit-bounces@debbugs.gnu.org Mon May 25 21:31:20 2020 Received: (at 8289-done) by debbugs.gnu.org; 26 May 2020 01:31:20 +0000 Received: from localhost ([127.0.0.1]:42845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdOR5-00015V-Rq for submit@debbugs.gnu.org; Mon, 25 May 2020 21:31:20 -0400 Received: from freefriends.org ([96.88.95.60]:49254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdOR3-00015E-Dw for 8289-done@debbugs.gnu.org; Mon, 25 May 2020 21:31:17 -0400 X-Envelope-From: karl@freefriends.org X-Envelope-To: <8289-done@debbugs.gnu.org> Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 04Q1VF4I022398 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <8289-done@debbugs.gnu.org>; Mon, 25 May 2020 19:31:16 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 04Q1VFAB022397; Mon, 25 May 2020 19:31:15 -0600 Date: Mon, 25 May 2020 19:31:15 -0600 Message-Id: <202005260131.04Q1VFAB022397@freefriends.org> From: Karl Berry To: 8289-done@debbugs.gnu.org Subject: Re: bug#8289: distcheck and make dvi In-Reply-To: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 8289-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From unknown Wed Jun 25 10:48:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 23 Jun 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator