From unknown Mon Aug 18 15:38:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8284: 24.0.50; M-q badly bound in diff-mode Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Mar 2011 14:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8284 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8284@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13004579191725 (code B ref -1); Fri, 18 Mar 2011 14:19:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Mar 2011 14:18:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0aVi-0000Rm-8A for submit@debbugs.gnu.org; Fri, 18 Mar 2011 10:18:38 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0aVg-0000Rb-Aa for submit@debbugs.gnu.org; Fri, 18 Mar 2011 10:18:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0aVa-0002Kh-1i for submit@debbugs.gnu.org; Fri, 18 Mar 2011 10:18:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:52517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0aVZ-0002I2-JR for submit@debbugs.gnu.org; Fri, 18 Mar 2011 10:18:30 -0400 Received: from [140.186.70.92] (port=43058 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0aVI-0006Xw-Hh for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2011 10:18:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0aVC-0002GB-8r for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2011 10:18:07 -0400 Received: from prometheus.naquadah.org ([212.85.154.174]:45581 helo=mx1.naquadah.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0aVC-0002Fq-4H for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2011 10:18:06 -0400 Received: by mx1.naquadah.org (Postfix, from userid 8) id 4AEF35C0E7; Fri, 18 Mar 2011 15:18:04 +0100 (CET) Received: from cigue.easter-eggs.fr (coquelicot-s.easter-eggs.com [213.215.37.94]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 69A905C0D7 for ; Fri, 18 Mar 2011 15:18:02 +0100 (CET) From: Julien Danjou Date: Fri, 18 Mar 2011 15:18:01 +0100 Message-ID: User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.2 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) Hi there, The `diff-mode' keymap `diff-mode-shared-map' inherit from `special-mode-map' which defines M-q as `quit-window'. This is *very* annoying when editing diff file build with git-format-patch. I sometimes add some text/comments in it, and press M-q to run `fill-paragraph'. But this calls `quit-window' and pisses me off. I don't know what is the best way to fix this, therefore I'm not including any patch in this report, but would do it if possible. :-) --=20 Julien Danjou =E2=9D=B1 http://julien.danjou.info From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 18 13:06:47 2011 Received: (at control) by debbugs.gnu.org; 18 Mar 2011 17:06:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0d8Q-00047f-Tf for submit@debbugs.gnu.org; Fri, 18 Mar 2011 13:06:47 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0d8P-00047T-JU for control@debbugs.gnu.org; Fri, 18 Mar 2011 13:06:45 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Q0d8K-0008AQ-5d for control@debbugs.gnu.org; Fri, 18 Mar 2011 13:06:40 -0400 Date: Fri, 18 Mar 2011 13:06:40 -0400 Message-Id: Subject: control message for bug 8284 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) forcemerge 2919 8284 From unknown Mon Aug 18 15:38:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8284: 24.0.50; M-q badly bound in diff-mode Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Mar 2011 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8284 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Julien Danjou Cc: 8284@debbugs.gnu.org Received: via spool by 8284-submit@debbugs.gnu.org id=B8284.130047597030117 (code B ref 8284); Fri, 18 Mar 2011 19:20:02 +0000 Received: (at 8284) by debbugs.gnu.org; 18 Mar 2011 19:19:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0fCr-0007pi-1h for submit@debbugs.gnu.org; Fri, 18 Mar 2011 15:19:29 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0fCp-0007pV-CF for 8284@debbugs.gnu.org; Fri, 18 Mar 2011 15:19:27 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p2IJJJKB002990; Fri, 18 Mar 2011 15:19:20 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id ACA26130010; Fri, 18 Mar 2011 15:19:19 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Fri, 18 Mar 2011 15:19:19 -0400 In-Reply-To: (Julien Danjou's message of "Fri, 18 Mar 2011 15:18:01 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3800=0 X-NAI-Spam-Version: 2.2.0.9286 : core <3800> : streams <609962> : uri <830195> X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > The `diff-mode' keymap `diff-mode-shared-map' inherit from > `special-mode-map' which defines M-q as `quit-window'. > This is *very* annoying when editing diff file build with > git-format-patch. I sometimes add some text/comments in it, and press > M-q to run `fill-paragraph'. But this calls `quit-window' and pisses > me off. > I don't know what is the best way to fix this, therefore I'm not > including any patch in this report, but would do it if possible. :-) When editing the buffer, diff-mode should not be considered as a special-mode. But I see that what you write is not quite what happens: M-q is not inherited from special-mode-map, it's that `q' is inherited from special-mode-map into diff-mode-shared-map which is bound to ESC, thus giving us a binding for M-q. So I think that diff-mode-map should shadow diff-mode-shared-map's q binding. I think the patch below does it. Stefan === modified file 'lisp/vc/diff-mode.el' --- lisp/vc/diff-mode.el 2011-03-14 03:40:18 +0000 +++ lisp/vc/diff-mode.el 2011-03-18 19:18:38 +0000 @@ -122,8 +122,7 @@ ("\C-m" . diff-goto-source) ([mouse-2] . diff-goto-source) ;; From XEmacs' diff-mode. - ;; Standard M-w is useful, so don't change M-W. - ;;("W" . widen) + ("W" . widen) ;;("." . diff-goto-source) ;display-buffer ;;("f" . diff-goto-source) ;find-file ("o" . diff-goto-source) ;other-window @@ -135,17 +134,21 @@ ;; Not useful if you have to metafy them. ;;(" " . scroll-up) ;;("\177" . scroll-down) - ;; Standard M-a is useful, so don't change M-A. - ;;("A" . diff-ediff-patch) - ;; Standard M-r is useful, so don't change M-r or M-R. - ;;("r" . diff-restrict-view) - ;;("R" . diff-reverse-direction) - ) + ("A" . diff-ediff-patch) + ("r" . diff-restrict-view) + ("R" . diff-reverse-direction)) "Basic keymap for `diff-mode', bound to various prefix keys." :inherit special-mode-map) (easy-mmode-defmap diff-mode-map - `(("\e" . ,diff-mode-shared-map) + `(("\e" . ,(let ((map (make-sparse-keymap))) + ;; We want to inherit most bindings from diff-mode-shared-map, + ;; but not all since they may hide useful M- global + ;; bindings when editing. + (set-keymap-parent map diff-mode-shared-map) + (dolist (key '("A" "r" "R" "g" "q" "W")) + (define-key map key nil)) + map)) ;; From compilation-minor-mode. ("\C-c\C-c" . diff-goto-source) ;; By analogy with the global C-x 4 a binding. From unknown Mon Aug 18 15:38:49 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Julien Danjou Subject: bug#8284: closed (Re: bug#8284: 24.0.50; M-q badly bound in diff-mode) Message-ID: References: X-Gnu-PR-Message: they-closed 8284 X-Gnu-PR-Package: emacs Reply-To: 8284@debbugs.gnu.org Date: Fri, 18 Mar 2011 19:54:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1300478042-519-1" This is a multi-part message in MIME format... ------------=_1300478042-519-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #8284: 24.0.50; M-q badly bound in diff-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 8284@debbugs.gnu.org. --=20 8284: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8284 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1300478042-519-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 8284-done) by debbugs.gnu.org; 18 Mar 2011 19:53:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0fjL-00007I-I7 for submit@debbugs.gnu.org; Fri, 18 Mar 2011 15:53:03 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0fjJ-00006o-Fz for 8284-done@debbugs.gnu.org; Fri, 18 Mar 2011 15:53:01 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p2IJrxDm014153; Fri, 18 Mar 2011 15:53:59 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 839A4B4095; Fri, 18 Mar 2011 15:52:54 -0400 (EDT) From: Stefan Monnier To: Julien Danjou Subject: Re: bug#8284: 24.0.50; M-q badly bound in diff-mode Message-ID: References: Date: Fri, 18 Mar 2011 15:52:54 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 18 Mar 2011 15:19:19 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3800=0 X-NAI-Spam-Version: 2.2.0.9286 : core <3800> : streams <609973> : uri <830195> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 8284-done Cc: 8284-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > q binding. I think the patch below does it. It appears to fix it, indeed. Installed, Stefan ------------=_1300478042-519-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Mar 2011 14:18:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0aVi-0000Rm-8A for submit@debbugs.gnu.org; Fri, 18 Mar 2011 10:18:38 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0aVg-0000Rb-Aa for submit@debbugs.gnu.org; Fri, 18 Mar 2011 10:18:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0aVa-0002Kh-1i for submit@debbugs.gnu.org; Fri, 18 Mar 2011 10:18:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:52517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0aVZ-0002I2-JR for submit@debbugs.gnu.org; Fri, 18 Mar 2011 10:18:30 -0400 Received: from [140.186.70.92] (port=43058 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0aVI-0006Xw-Hh for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2011 10:18:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0aVC-0002GB-8r for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2011 10:18:07 -0400 Received: from prometheus.naquadah.org ([212.85.154.174]:45581 helo=mx1.naquadah.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0aVC-0002Fq-4H for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2011 10:18:06 -0400 Received: by mx1.naquadah.org (Postfix, from userid 8) id 4AEF35C0E7; Fri, 18 Mar 2011 15:18:04 +0100 (CET) Received: from cigue.easter-eggs.fr (coquelicot-s.easter-eggs.com [213.215.37.94]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 69A905C0D7 for ; Fri, 18 Mar 2011 15:18:02 +0100 (CET) From: Julien Danjou To: bug-gnu-emacs@gnu.org Subject: 24.0.50; M-q badly bound in diff-mode Date: Fri, 18 Mar 2011 15:18:01 +0100 Message-ID: User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) Hi there, The `diff-mode' keymap `diff-mode-shared-map' inherit from `special-mode-map' which defines M-q as `quit-window'. This is *very* annoying when editing diff file build with git-format-patch. I sometimes add some text/comments in it, and press M-q to run `fill-paragraph'. But this calls `quit-window' and pisses me off. I don't know what is the best way to fix this, therefore I'm not including any patch in this report, but would do it if possible. :-) --=20 Julien Danjou =E2=9D=B1 http://julien.danjou.info ------------=_1300478042-519-1-- From unknown Mon Aug 18 15:38:49 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Matthieu Moy Subject: bug#2919: closed (Re: bug#8284: 24.0.50; M-q badly bound in diff-mode) Message-ID: References: X-Gnu-PR-Message: they-closed 2919 X-Gnu-PR-Package: emacs Reply-To: 2919@debbugs.gnu.org Date: Fri, 18 Mar 2011 19:54:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1300478042-519-3" This is a multi-part message in MIME format... ------------=_1300478042-519-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #8284: 23.0.91; diff-mode redefines M-q to some harmfull command which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 2919@debbugs.gnu.org. --=20 8284: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8284 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1300478042-519-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 8284-done) by debbugs.gnu.org; 18 Mar 2011 19:53:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0fjL-00007I-I7 for submit@debbugs.gnu.org; Fri, 18 Mar 2011 15:53:03 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0fjJ-00006o-Fz for 8284-done@debbugs.gnu.org; Fri, 18 Mar 2011 15:53:01 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p2IJrxDm014153; Fri, 18 Mar 2011 15:53:59 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 839A4B4095; Fri, 18 Mar 2011 15:52:54 -0400 (EDT) From: Stefan Monnier To: Julien Danjou Subject: Re: bug#8284: 24.0.50; M-q badly bound in diff-mode Message-ID: References: Date: Fri, 18 Mar 2011 15:52:54 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 18 Mar 2011 15:19:19 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3800=0 X-NAI-Spam-Version: 2.2.0.9286 : core <3800> : streams <609973> : uri <830195> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 8284-done Cc: 8284-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > q binding. I think the patch below does it. It appears to fix it, indeed. Installed, Stefan ------------=_1300478042-519-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 7 Apr 2009 13:00:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n37D0LrY025904 for ; Tue, 7 Apr 2009 06:00:22 -0700 Received: from mail.gnu.org ([199.232.76.166]:58274 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LrAuZ-0007Ql-Jx for emacs-pretest-bug@gnu.org; Tue, 07 Apr 2009 09:00:19 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LrAuV-0006Ka-Au for emacs-pretest-bug@gnu.org; Tue, 07 Apr 2009 09:00:19 -0400 Received: from harmonie.imag.fr ([147.171.130.40]:57257) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LrAuU-0006Ja-Oz for emacs-pretest-bug@gnu.org; Tue, 07 Apr 2009 09:00:15 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by harmonie.imag.fr (8.13.8/8.13.8) with ESMTP id n37CvsFR024919; Tue, 7 Apr 2009 14:57:55 +0200 (CEST) Received: from bauges.imag.fr ([129.88.43.5]) by mail-veri.imag.fr with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1LrAsE-0000Jg-5F; Tue, 07 Apr 2009 14:57:54 +0200 Received: from moy by bauges.imag.fr with local (Exim 4.63) (envelope-from ) id 1LrAsE-0005aW-33; Tue, 07 Apr 2009 14:57:54 +0200 To: emacs-pretest-bug@gnu.org Subject: 23.0.91; diff-mode redefines M-q to some harmfull command From: Matthieu Moy Date: Tue, 07 Apr 2009 14:57:54 +0200 Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: Matthieu Moy X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (harmonie.imag.fr [147.171.130.40]); Tue, 07 Apr 2009 14:57:55 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: moy@imag.fr X-detected-operating-system: by monty-python.gnu.org: Solaris 9 Hi, Emacs's diff-mode redefines M-q, which I normally use for fill-paragraph (the standard binding), since: revision 1.54 date: 2004-02-02 22:08:37 +0100; author: uid69204; state: Exp; lines: +2 -1; Bind q to `quit-window'. I often use diff-mode to edit patches, (created by Git with git send-email --anotate) and add comments to them before I send them by email, and therefore fill my paragraphs (like in any other emails). Having M-q rebound to quit-window there is harmfull. It should definitely not be the default. This is especially frustrating since the code says: (easy-mmode-defmap diff-mode-shared-map [...] ;; Standard M-a is useful, so don't change M-A. ;;("A" . diff-ediff-patch) ;; Standard M-r is useful, so don't change M-r or M-R. ;;("r" . diff-restrict-view) ;;("R" . diff-reverse-direction) ("q" . quit-window)) so, some care has been taken not to override M-A, M-r and M-R, but M-q still is. Thanks, In GNU Emacs 23.0.91.2 (i686-pc-linux-gnu, GTK+ Version 2.8.20) of 2009-03-17 on bauges Windowing system distributor `The X.Org Foundation', version 11.0.70101000 configured using `configure '--prefix=/home/moy/local/usr/'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: auto-fill-function: do-auto-fill erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t shell-dirtrack-mode: t diff-auto-refine-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t recentf-mode: t global-whitespace-mode: t global-hl-line-mode: t icomplete-mode: t auto-image-file-mode: t which-function-mode: t show-paren-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t Recent input: a t c h C-x k C-x b . p a t c h M-x f o M-p f i l l C-k - r e f i l l r e p a r C-_ C-n C-e C-a C-p M-x C-n C-n C-e : : C-e SPC SPC a n d SPC b e f o r e SPC + . C-x C-s C-x # C-l C-x b s c r a M-> M-y M-y M-y C-a C-k C-_ C-y C-x b A r C-x o y g s n n n q g s g q g s p c s C-x C-f / t m p / f o o . t p a t c h M-q C-x b . p a t c h C-s C-h k M-q C-x o C-n C-h m C-s m - q C-h v d i f f - m o m a C-n C-p C-e C-s M - q C-s C-s C-p M-< C-s q u i t - w i n d o w C-x 1 M-x v c - m o a n n C-s C-s C-s C-s C-s C-p M-x r e p o r b u Recent messages: Saving file /home/moy/.newsrc.eld... Wrote /home/moy/.newsrc.eld Saving /home/moy/.newsrc.eld...done (New file) Type C-x 4 C-o RET to restore the other window. Mark saved where search started uncompressing diff-mode.el.gz...done Mark saved where search started Mark set Mark saved where search started vc-ensure-vc-buffer: File /net/bauges/local/moy/usr/share/emacs/23.0.91/lisp/diff-mode.el.gz is not under version control -- Matthieu ------------=_1300478042-519-3--