From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 16 20:14:02 2011 Received: (at submit) by debbugs.gnu.org; 17 Mar 2011 00:14:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q00qn-0007jb-Ko for submit@debbugs.gnu.org; Wed, 16 Mar 2011 20:14:02 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q00qj-0007jP-TF for submit@debbugs.gnu.org; Wed, 16 Mar 2011 20:13:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q00qd-0006D9-Lh for submit@debbugs.gnu.org; Wed, 16 Mar 2011 20:13:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:55773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q00qd-0006D3-In for submit@debbugs.gnu.org; Wed, 16 Mar 2011 20:13:51 -0400 Received: from [140.186.70.92] (port=59383 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q00qc-0003dp-4l for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2011 20:13:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q00qa-0006Cm-IF for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2011 20:13:50 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:49212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q00qa-0006CR-5v for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2011 20:13:48 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 1097539E810F for ; Wed, 16 Mar 2011 17:13:47 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LdPNlT6mFd8E for ; Wed, 16 Mar 2011 17:13:45 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id DE5BE39E80F2 for ; Wed, 16 Mar 2011 17:13:45 -0700 (PDT) Message-ID: <4D815239.3080509@cs.ucla.edu> Date: Wed, 16 Mar 2011 17:13:45 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: unexec FIXME in src/emacs.c Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Severity: minor There's a longstanding FIXME in src/emacs.c that gcc 4.5.2 is also warning about. I'd like to install the following to address the problem. This fix adds a file src/unexec.h, which contains just the declaration for unexec. Another plausible fix would be to put the unexec declaration into lisp.h and have the unexec modules that don't already include lisp.h, include lisp.h. Either way would work fine, but this way is a tad cleaner. === modified file 'src/ChangeLog' --- src/ChangeLog 2011-03-16 21:47:59 +0000 +++ src/ChangeLog 2011-03-17 00:03:31 +0000 @@ -1,5 +1,14 @@ 2011-03-16 Paul Eggert + New file unexec.h, the (simple) interface for unexec. + * unexec.h: New file. + * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o): + (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o): + Depend on unexec.h. + * emacs.c [!defined CANNOT_DUMP]: Include unexec.h. + * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c: + * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h. + * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid shadowing. (back_comment, skip_chars): Mark vars as initialized. === modified file 'src/deps.mk' --- src/deps.mk 2011-03-13 06:43:00 +0000 +++ src/deps.mk 2011-03-16 23:59:54 +0000 @@ -93,7 +93,7 @@ emacs.o: emacs.c commands.h systty.h syssignal.h blockinput.h process.h \ termhooks.h buffer.h atimer.h systime.h $(INTERVALS_H) lisp.h $(config_h) \ globals.h ../lib/unistd.h window.h dispextern.h keyboard.h keymap.h \ - frame.h coding.h gnutls.h msdos.h + frame.h coding.h gnutls.h msdos.h unexec.h fileio.o: fileio.c window.h buffer.h systime.h $(INTERVALS_H) character.h \ coding.h msdos.h blockinput.h atimer.h lisp.h $(config_h) frame.h \ commands.h globals.h ../lib/unistd.h @@ -200,15 +200,15 @@ tparam.o: tparam.c tparam.h lisp.h $(config_h) undo.o: undo.c buffer.h commands.h window.h dispextern.h msdos.h \ lisp.h globals.h $(config_h) -unexaix.o: unexaix.c lisp.h $(config_h) +unexaix.o: unexaix.c lisp.h unexec.h $(config_h) unexalpha.o: unexalpha.c $(config_h) -unexcw.o: unexcw.c lisp.h $(config_h) -unexcoff.o: unexcoff.c lisp.h $(config_h) -unexelf.o: unexelf.c ../lib/unistd.h $(config_h) -unexhp9k800.o: unexhp9k800.c $(config_h) -unexmacosx.o: unexmacosx.c $(config_h) -unexsol.o: unexsol.c lisp.h $(config_h) -unexw32.o: unexw32.c $(config_h) +unexcw.o: unexcw.c lisp.h unexec.h $(config_h) +unexcoff.o: unexcoff.c lisp.h unexec.h $(config_h) +unexelf.o: unexelf.c unexec.h ../lib/unistd.h $(config_h) +unexhp9k800.o: unexhp9k800.c unexec.h $(config_h) +unexmacosx.o: unexmacosx.c unexec.h $(config_h) +unexsol.o: unexsol.c lisp.h unexec.h $(config_h) +unexw32.o: unexw32.c unexec.h $(config_h) w16select.o: w16select.c dispextern.h frame.h blockinput.h atimer.h systime.h \ msdos.h buffer.h charset.h coding.h composite.h lisp.h $(config_h) widget.o: widget.c xterm.h frame.h dispextern.h widgetprv.h \ === modified file 'src/emacs.c' --- src/emacs.c 2011-03-14 05:36:36 +0000 +++ src/emacs.c 2011-03-16 23:59:54 +0000 @@ -2085,9 +2085,7 @@ #ifndef CANNOT_DUMP -/* FIXME: maybe this should go into header file, config.h seems the - only one appropriate. */ -extern int unexec (const char *, const char *); +#include "unexec.h" DEFUN ("dump-emacs", Fdump_emacs, Sdump_emacs, 2, 2, 0, doc: /* Dump current state of Emacs into executable file FILENAME. === modified file 'src/unexaix.c' --- src/unexaix.c 2011-01-25 04:08:28 +0000 +++ src/unexaix.c 2011-03-16 23:59:54 +0000 @@ -40,6 +40,8 @@ */ #include +#include "unexec.h" + #define PERROR(file) report_error (file, new) #include /* Define getpagesize () if the system does not. === modified file 'src/unexcoff.c' --- src/unexcoff.c 2011-01-25 04:08:28 +0000 +++ src/unexcoff.c 2011-03-16 23:59:54 +0000 @@ -50,6 +50,8 @@ */ #include +#include "unexec.h" + #define PERROR(file) report_error (file, new) #ifndef CANNOT_DUMP /* all rest of file! */ === modified file 'src/unexcw.c' --- src/unexcw.c 2011-01-25 04:08:28 +0000 +++ src/unexcw.c 2011-03-16 23:59:54 +0000 @@ -19,6 +19,8 @@ along with GNU Emacs. If not, see . */ #include +#include "unexec.h" + #include #include #include @@ -299,4 +301,3 @@ return (0); } - === added file 'src/unexec.h' --- src/unexec.h 1970-01-01 00:00:00 +0000 +++ src/unexec.h 2011-03-17 00:03:31 +0000 @@ -0,0 +1,1 @@ +void unexec (const char *, const char *); === modified file 'src/unexelf.c' --- src/unexelf.c 2011-01-25 04:08:28 +0000 +++ src/unexelf.c 2011-03-16 23:59:54 +0000 @@ -386,6 +386,8 @@ Instead we read the whole file, modify it, and write it out. */ #include +#include + extern void fatal (const char *msgid, ...); #include === modified file 'src/unexhp9k800.c' --- src/unexhp9k800.c 2011-01-15 23:16:57 +0000 +++ src/unexhp9k800.c 2011-03-16 23:59:54 +0000 @@ -50,6 +50,8 @@ */ #include +#include "unexec.h" + #include #include #include @@ -319,4 +321,3 @@ hdr->unloadable_sp_location, hdr->unloadable_sp_size); } #endif /* DEBUG */ - === modified file 'src/unexmacosx.c' --- src/unexmacosx.c 2011-03-12 19:19:47 +0000 +++ src/unexmacosx.c 2011-03-16 23:59:54 +0000 @@ -95,6 +95,9 @@ #undef malloc #undef realloc #undef free + +#include "unexec.h" + #include #include #include === modified file 'src/unexsol.c' --- src/unexsol.c 2011-01-15 23:16:57 +0000 +++ src/unexsol.c 2011-03-16 23:59:54 +0000 @@ -1,6 +1,8 @@ /* Trivial unexec for Solaris. */ #include +#include "unexec.h" + #include #include === modified file 'src/unexw32.c' --- src/unexw32.c 2011-01-25 04:08:28 +0000 +++ src/unexw32.c 2011-03-16 23:59:54 +0000 @@ -21,6 +21,7 @@ */ #include +#include "unexec.h" #include #include From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 17 12:54:24 2011 Received: (at 8267-done) by debbugs.gnu.org; 17 Mar 2011 16:54:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0GSu-00053y-0H for submit@debbugs.gnu.org; Thu, 17 Mar 2011 12:54:24 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0GSs-00053l-5Q for 8267-done@debbugs.gnu.org; Thu, 17 Mar 2011 12:54:23 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 351D939E8113 for <8267-done@debbugs.gnu.org>; Thu, 17 Mar 2011 09:54:16 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PECOTu8QN2X1 for <8267-done@debbugs.gnu.org>; Thu, 17 Mar 2011 09:54:15 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id D9D7E39E80DB for <8267-done@debbugs.gnu.org>; Thu, 17 Mar 2011 09:54:15 -0700 (PDT) Message-ID: <4D823CB7.3000209@cs.ucla.edu> Date: Thu, 17 Mar 2011 09:54:15 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: 8267-done@debbugs.gnu.org Subject: Re: bug#8267: Acknowledgement (unexec FIXME in src/emacs.c) References: <4D815239.3080509@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 8267-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) I've committed a patch for this in bzr103679. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 17 13:33:58 2011 Received: (at 8267) by debbugs.gnu.org; 17 Mar 2011 17:33:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0H5B-0005wa-Pm for submit@debbugs.gnu.org; Thu, 17 Mar 2011 13:33:58 -0400 Received: from mail-out.m-online.net ([212.18.0.9]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0H59-0005wN-HM for 8267@debbugs.gnu.org; Thu, 17 Mar 2011 13:33:56 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3B4111C01F0A; Thu, 17 Mar 2011 18:33:48 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id 94FBD1C0015C; Thu, 17 Mar 2011 18:33:48 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id UTYNf3B3AZaE; Thu, 17 Mar 2011 18:33:48 +0100 (CET) Received: from igel.home (ppp-88-217-110-97.dynamic.mnet-online.de [88.217.110.97]) by mail.mnet-online.de (Postfix) with ESMTP; Thu, 17 Mar 2011 18:33:47 +0100 (CET) Received: by igel.home (Postfix, from userid 501) id 7CF58CA2A0; Thu, 17 Mar 2011 18:33:47 +0100 (CET) From: Andreas Schwab To: Paul Eggert Subject: Re: bug#8267: unexec FIXME in src/emacs.c References: <4D815239.3080509@cs.ucla.edu> X-Yow: NOW, I'm supposed to SCRAMBLE two, and HOLD th' MAYO!! Date: Thu, 17 Mar 2011 18:33:47 +0100 In-Reply-To: <4D815239.3080509@cs.ucla.edu> (Paul Eggert's message of "Wed, 16 Mar 2011 17:13:45 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8267 Cc: 8267@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Paul Eggert writes: > === modified file 'src/ChangeLog' > --- src/ChangeLog 2011-03-16 21:47:59 +0000 > +++ src/ChangeLog 2011-03-17 00:03:31 +0000 > @@ -1,5 +1,14 @@ > 2011-03-16 Paul Eggert > + New file unexec.h, the (simple) interface for unexec. > + * unexec.h: New file. When sending patches you should not use format=flowed. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 17 14:02:48 2011 Received: (at 8267) by debbugs.gnu.org; 17 Mar 2011 18:02:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0HX5-0006bF-Q2 for submit@debbugs.gnu.org; Thu, 17 Mar 2011 14:02:48 -0400 Received: from granite1.mail.cornell.edu ([128.253.83.141] helo=authusersmtp.mail.cornell.edu) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0HX3-0006b2-47 for 8267@debbugs.gnu.org; Thu, 17 Mar 2011 14:02:46 -0400 Received: from [128.84.234.248] (dhcp248.math.cornell.edu [128.84.234.248]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id p2HI2ano009843 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Thu, 17 Mar 2011 14:02:36 -0400 (EDT) Message-ID: <4D824CBA.5000703@cornell.edu> Date: Thu, 17 Mar 2011 14:02:34 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: 8267@debbugs.gnu.org, eggert@cs.ucla.edu Subject: Re: bug#8267: Acknowledgement (unexec FIXME in src/emacs.c) References: <4D815239.3080509@cs.ucla.edu> <4D823CB7.3000209@cs.ucla.edu> In-Reply-To: <4D823CB7.3000209@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 8267 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.8 (-----) On 3/17/2011 12:54 PM, Paul Eggert wrote: > I've committed a patch for this in bzr103679. In unexec.h you declare unexec() to return void, but in several of the unexec*.c files it has a return type of int. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 17 14:45:28 2011 Received: (at 8267) by debbugs.gnu.org; 17 Mar 2011 18:45:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0ICN-0007Z5-F2 for submit@debbugs.gnu.org; Thu, 17 Mar 2011 14:45:27 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0ICL-0007Ys-2W for 8267@debbugs.gnu.org; Thu, 17 Mar 2011 14:45:26 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 474AD39E80F2; Thu, 17 Mar 2011 11:45:19 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x8E55Cdxktq8; Thu, 17 Mar 2011 11:45:18 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id C458E39E80DB; Thu, 17 Mar 2011 11:45:18 -0700 (PDT) Message-ID: <4D8256BE.4060309@cs.ucla.edu> Date: Thu, 17 Mar 2011 11:45:18 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: Ken Brown Subject: Re: bug#8267: Acknowledgement (unexec FIXME in src/emacs.c) References: <4D815239.3080509@cs.ucla.edu> <4D823CB7.3000209@cs.ucla.edu> <4D824CBA.5000703@cornell.edu> In-Reply-To: <4D824CBA.5000703@cornell.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 8267 Cc: 8267@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On 03/17/2011 11:02 AM, Ken Brown wrote: > On 3/17/2011 12:54 PM, Paul Eggert wrote: >> I've committed a patch for this in bzr103679. > > In unexec.h you declare unexec() to return void, but in several of the unexec*.c files it has a return type of int. Thanks for catching that. I didn't notice that, since I built on an implementation where it returns void. I changed the other implementations to match the new header (bzr 103680). It might make sense for unexec to return an int, so that Emacs can report an error (presumably from errno) if unexec fails, but if this is done it should be done consistently on all platforms. The previous code was inconsistent. The implementations that returned an int sometimes returned 0 even when there were problems. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 17 15:01:13 2011 Received: (at 8267) by debbugs.gnu.org; 17 Mar 2011 19:01:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0IRd-0007uM-Es for submit@debbugs.gnu.org; Thu, 17 Mar 2011 15:01:13 -0400 Received: from granite1.mail.cornell.edu ([128.253.83.141] helo=authusersmtp.mail.cornell.edu) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0IRa-0007u9-QD for 8267@debbugs.gnu.org; Thu, 17 Mar 2011 15:01:12 -0400 Received: from [128.84.234.248] (dhcp248.math.cornell.edu [128.84.234.248]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id p2HJ14OB021263 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Thu, 17 Mar 2011 15:01:04 -0400 (EDT) Message-ID: <4D825A6D.6070402@cornell.edu> Date: Thu, 17 Mar 2011 15:01:01 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: Paul Eggert Subject: Re: bug#8267: Acknowledgement (unexec FIXME in src/emacs.c) References: <4D815239.3080509@cs.ucla.edu> <4D823CB7.3000209@cs.ucla.edu> <4D824CBA.5000703@cornell.edu> <4D8256BE.4060309@cs.ucla.edu> In-Reply-To: <4D8256BE.4060309@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -5.8 (-----) X-Debbugs-Envelope-To: 8267 Cc: "8267@debbugs.gnu.org" <8267@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.8 (-----) On 3/17/2011 2:45 PM, Paul Eggert wrote: > On 03/17/2011 11:02 AM, Ken Brown wrote: >> On 3/17/2011 12:54 PM, Paul Eggert wrote: >>> I've committed a patch for this in bzr103679. >> >> In unexec.h you declare unexec() to return void, but in several of the unexec*.c files it has a return type of int. > > Thanks for catching that. I didn't notice that, since I built > on an implementation where it returns void. I changed the > other implementations to match the new header (bzr 103680). OK, but your change removes a lot of "returns" that shouldn't be removed. I think the function should still return in those places; it's just that it shouldn't return a value. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 17 16:20:59 2011 Received: (at 8267) by debbugs.gnu.org; 17 Mar 2011 20:20:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0Jgo-0001HT-HS for submit@debbugs.gnu.org; Thu, 17 Mar 2011 16:20:58 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0Jgl-0001HH-VC for 8267@debbugs.gnu.org; Thu, 17 Mar 2011 16:20:57 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id DFBD639E810E; Thu, 17 Mar 2011 13:20:49 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KsUu2ctEQMnI; Thu, 17 Mar 2011 13:20:49 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 78C9E39E80F2; Thu, 17 Mar 2011 13:20:49 -0700 (PDT) Message-ID: <4D826D21.50904@cs.ucla.edu> Date: Thu, 17 Mar 2011 13:20:49 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: Ken Brown Subject: Re: bug#8267: Acknowledgement (unexec FIXME in src/emacs.c) References: <4D815239.3080509@cs.ucla.edu> <4D823CB7.3000209@cs.ucla.edu> <4D824CBA.5000703@cornell.edu> <4D8256BE.4060309@cs.ucla.edu> <4D825A6D.6070402@cornell.edu> In-Reply-To: <4D825A6D.6070402@cornell.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 8267 Cc: "8267@debbugs.gnu.org" <8267@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On 03/17/2011 12:01 PM, Ken Brown wrote: > OK, but your change removes a lot of "returns" that shouldn't be removed. Right you are again, and thanks again. I restored the "return"s to unexaix.c, unexcoff.c, and unexcw.c (bzr 103682). From unknown Wed Aug 20 02:46:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 15 Apr 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator