From unknown Sat Aug 16 20:58:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8261 <8261@debbugs.gnu.org> To: bug#8261 <8261@debbugs.gnu.org> Subject: Status: Perl mode imenu index ignores my/our variables Reply-To: bug#8261 <8261@debbugs.gnu.org> Date: Sun, 17 Aug 2025 03:58:32 +0000 retitle 8261 Perl mode imenu index ignores my/our variables reassign 8261 emacs submitter 8261 Ralph Schleicher severity 8261 normal tag 8261 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 15 16:34:43 2011 Received: (at submit) by debbugs.gnu.org; 15 Mar 2011 20:34:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pzax1-0002ch-4y for submit@debbugs.gnu.org; Tue, 15 Mar 2011 16:34:43 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pzawz-0002cV-1w for submit@debbugs.gnu.org; Tue, 15 Mar 2011 16:34:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pzaws-0005Eg-Ow for submit@debbugs.gnu.org; Tue, 15 Mar 2011 16:34:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:34616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pzaws-0005Ec-Mw for submit@debbugs.gnu.org; Tue, 15 Mar 2011 16:34:34 -0400 Received: from [140.186.70.92] (port=39543 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pzawq-0005A1-KZ for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 16:34:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pzawn-0005Ci-V7 for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 16:34:32 -0400 Received: from dd24230.kasserver.com ([85.13.143.176]:42976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pzawn-0005Bc-OE for bug-gnu-emacs@gnu.org; Tue, 15 Mar 2011 16:34:29 -0400 Received: from bravo.mueller-schleicher.de (p57ADB606.dip.t-dialin.net [87.173.182.6]) by dd24230.kasserver.com (Postfix) with ESMTPA id B97394A80AF for ; Tue, 15 Mar 2011 21:34:27 +0100 (CET) Received: by bravo.mueller-schleicher.de (Postfix, from userid 1000) id 2DBC15C251; Tue, 15 Mar 2011 21:34:27 +0100 (CET) From: Ralph Schleicher To: bug-gnu-emacs@gnu.org Subject: Perl mode imenu index ignores my/our variables Organization: Ralph Schleicher Date: Tue, 15 Mar 2011 21:34:27 +0100 Message-ID: <87y64gi0mk.fsf@bravo.mueller-schleicher.i> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Hi, in Perl mode the imenu index does not list variables declared via 'my' and 'our'. Below is a patch together with a change log entry to fix it. Please note that the regular expression is "\\(?:my\\|our\\))\\s-+" and not "\\(?:\\(?:my\\|our\\))\\s-+\\)?" (optional match). Not declaring global variables properly is generally considered bad Perl style. 2011-03-11 Ralph Schleicher * progmodes/perl-mode.el (perl-imenu-generic-expression): Only match variables declared via `my' or `our'. --- emacs-23.3/lisp/progmodes/perl-mode.el.orig 2011-01-08 12:45:14 +0100 +++ emacs-23.3/lisp/progmodes/perl-mode.el 2011-03-11 11:39:42 +0100 @@ -167,7 +167,7 @@ '(;; Functions (nil "^sub\\s-+\\([-A-Za-z0-9+_:]+\\)" 1) ;;Variables - ("Variables" "^\\([$@%][-A-Za-z0-9+_:]+\\)\\s-*=" 1) + ("Variables" "^\\(?:my\\|our\\)\\s-+\\([$@%][-A-Za-z0-9+_:]+\\)\\s-*=" 1) ("Packages" "^package\\s-+\\([-A-Za-z0-9+_:]+\\);" 1) ("Doc sections" "^=head[0-9][ \t]+\\(.*\\)" 1)) "Imenu generic expression for Perl mode. See `imenu-generic-expression'.") -- Ralph From debbugs-submit-bounces@debbugs.gnu.org Sun May 08 14:25:14 2011 Received: (at 8261) by debbugs.gnu.org; 8 May 2011 18:25:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ8fJ-0002j3-OZ for submit@debbugs.gnu.org; Sun, 08 May 2011 14:25:13 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ8fE-0002ip-Qk for 8261@debbugs.gnu.org; Sun, 08 May 2011 14:25:13 -0400 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p48IP2hL026617 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 8 May 2011 14:25:02 -0400 Received: by furball (Postfix, from userid 1000) id 14CBF1604EB; Sun, 8 May 2011 14:25:02 -0400 (EDT) From: Chong Yidong To: Ralph Schleicher Subject: Re: bug#8261: Perl mode imenu index ignores my/our variables References: <87y64gi0mk.fsf@bravo.mueller-schleicher.i> Date: Sun, 08 May 2011 14:25:01 -0400 In-Reply-To: <87y64gi0mk.fsf@bravo.mueller-schleicher.i> (Ralph Schleicher's message of "Tue, 15 Mar 2011 21:34:27 +0100") Message-ID: <87oc3d6oea.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8261 Cc: 8261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Ralph Schleicher writes: > in Perl mode the imenu index does not list variables declared via 'my' > and 'our'. Below is a patch together with a change log entry to fix it. > Please note that the regular expression is "\\(?:my\\|our\\))\\s-+" and > not "\\(?:\\(?:my\\|our\\))\\s-+\\)?" (optional match). Not declaring > global variables properly is generally considered bad Perl style. Committed; thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun May 08 14:25:21 2011 Received: (at control) by debbugs.gnu.org; 8 May 2011 18:25:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ8fR-0002jK-7R for submit@debbugs.gnu.org; Sun, 08 May 2011 14:25:21 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ8fP-0002jA-Po for control@debbugs.gnu.org; Sun, 08 May 2011 14:25:20 -0400 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p48IPEhZ026652 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 8 May 2011 14:25:14 -0400 Received: by furball (Postfix, from userid 1000) id 152C61604EB; Sun, 8 May 2011 14:25:14 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 8261 Date: Sun, 08 May 2011 14:25:13 -0400 Message-ID: <87zkmx59ti.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) close 8261 thanks From unknown Sat Aug 16 20:58:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Jun 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator