GNU bug report logs - #8258
INFOPATH bug on Windows

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8258 in the body.
You can then email your comments to 8258 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ralph Schleicher <ralph <at> mueller-schleicher.de>
To: bug-gnu-emacs <at> gnu.org
Subject: INFOPATH bug on Windows
Date: Tue, 15 Mar 2011 20:44:40 +0100

Hi,

on Windows, Emacs 23.3 fails to parse INFOPATH due to a hard-coded
colon as path separator.  Below is a patch together with a change
log entry.


2011-03-11  Ralph Schleicher  <rs <at> ralph-schleicher.de>

	* info.el (info-initialize): Replace all uses of `:' with
	path-separator for compatibility with non-Unix systems.
	Cache quoting of path-separator.


--- emacs-23.3/lisp/info.el.orig	2011-01-08 12:45:14 +0100
+++ emacs-23.3/lisp/info.el	2011-03-11 11:45:14 +0100
@@ -588,15 +588,15 @@
 (defun info-initialize ()
   "Initialize `Info-directory-list', if that hasn't been done yet."
   (unless Info-directory-list
-    (let ((path (getenv "INFOPATH")))
+    (let ((path (getenv "INFOPATH"))
+	  (sep (regexp-quote path-separator)))
       (setq Info-directory-list
 	    (prune-directory-list
 	     (if path
-		 (if (string-match ":\\'" path)
-		     (append (split-string (substring path 0 -1)
-					   (regexp-quote path-separator))
+		 (if (string-match (concat sep "\\'") path)
+		     (append (split-string (substring path 0 -1) sep)
 			     (Info-default-dirs))
-		   (split-string path (regexp-quote path-separator)))
+		   (split-string path sep))
 	       (Info-default-dirs)))))))
 
 ;;;###autoload


-- 
Ralph

Message #10 received at 8258-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Ralph Schleicher <ralph <at> mueller-schleicher.de>
Cc: 8258-done <at> debbugs.gnu.org
Subject: Re: bug#8258: INFOPATH bug on Windows
Date: Wed, 16 Mar 2011 01:04:05 +0100

> on Windows, Emacs 23.3 fails to parse INFOPATH due to a hard-coded
> colon as path separator.

In fact, the current code parses INFOPATH (quite by accident), but
fails to take into account the case where INFOPATH should be appended
to Info-default-directory-list.

So, yours is a valid fix and I've committed it to the emacs-23 branch.

Thanks,

    Juanma

Message #13 received at 8258 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Ralph Schleicher <ralph <at> mueller-schleicher.de>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, 8258 <at> debbugs.gnu.org
Subject: Re: bug#8258: INFOPATH bug on Windows
Date: Fri, 08 Apr 2011 13:49:57 -0400

Hi,

I noticed that we do not have a copyright assignment from you that would
cover these changes (we only have ones specifically for libc.el and
battery.el). The current change is small enough not to need an
assignment, but I notice you have sent a few other patches recently (not
yet applied), plus you seem to have some old changes installed for
info-look.el.

The simplest solution is if you just complete one more, general
assignment for all of Emacs. Are you willing to do that?
If so, let me know and I will send you the form to get started.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.