From unknown Fri Sep 05 08:41:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8229: possibly uninitialized variable in load_charset Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Mar 2011 00:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8229 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8229@debbugs.gnu.org Cc: Kenichi Handa X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.129980307331564 (code B ref -1); Fri, 11 Mar 2011 00:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Mar 2011 00:24:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pxq9g-0008D3-S4 for submit@debbugs.gnu.org; Thu, 10 Mar 2011 19:24:33 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pxq9e-0008Co-JL for submit@debbugs.gnu.org; Thu, 10 Mar 2011 19:24:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pxq9Y-0001ar-E7 for submit@debbugs.gnu.org; Thu, 10 Mar 2011 19:24:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:56992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pxq9Y-0001am-3V for submit@debbugs.gnu.org; Thu, 10 Mar 2011 19:24:24 -0500 Received: from [140.186.70.92] (port=57562 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pxq9R-0007Xa-Dt for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2011 19:24:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pxq9Q-0001aH-1u for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2011 19:24:16 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:49872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pxq9P-0001a9-Pi for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2011 19:24:16 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 15C5439E80F8; Thu, 10 Mar 2011 16:24:14 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id clze-G0w4o5s; Thu, 10 Mar 2011 16:24:13 -0800 (PST) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id A3F1B39E80DF; Thu, 10 Mar 2011 16:24:13 -0800 (PST) Message-ID: <4D796BAD.3060400@cs.ucla.edu> Date: Thu, 10 Mar 2011 16:24:13 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Severity: minor I found this problem by compiling Emacs with GCC's -Wuninitialized flag. The following code in the Emacs trunk src/charset.c's load_charset function is suspicious, because as written it appears that it might be using an uninitialized variable: if (CHARSET_METHOD (charset) == CHARSET_METHOD_MAP) map = CHARSET_MAP (charset); else if (CHARSET_UNIFIED_P (charset)) map = CHARSET_UNIFY_MAP (charset); if (STRINGP (map)) ... The last if-test uses "map", but it's not clear from the previous tests that "map" must be initialized. I'm filing a bug report so that someone who is more expert in this code can take a look at it. In the meantime, I plan to work around the problem by replacing: else if (CHARSET_UNIFIED_P (charset)) map = CHARSET_UNIFY_MAP (charset); with: else { if (! CHARSET_UNIFIED_P (charset)) abort (); map = CHARSET_UNIFY_MAP (charset); } I'm CC'ing this to Kenichi Handa, who committed the code in question. From unknown Fri Sep 05 08:41:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8229: committed the workaround References: <4D796BAD.3060400@cs.ucla.edu> In-Reply-To: <4D796BAD.3060400@cs.ucla.edu> Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Mar 2011 23:20:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8229 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8229@debbugs.gnu.org, 8215@debbugs.gnu.org, 8211@debbugs.gnu.org Received: via spool by 8229-submit@debbugs.gnu.org id=B8229.13009223754361 (code B ref 8229); Wed, 23 Mar 2011 23:20:05 +0000 Received: (at 8229) by debbugs.gnu.org; 23 Mar 2011 23:19:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q2XKw-00018H-UO for submit@debbugs.gnu.org; Wed, 23 Mar 2011 19:19:35 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q2XKt-00017n-J7; Wed, 23 Mar 2011 19:19:32 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 6E24D39E80E0; Wed, 23 Mar 2011 16:19:25 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rtc05Tc4HYDm; Wed, 23 Mar 2011 16:19:25 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 1D12839E80B1; Wed, 23 Mar 2011 16:19:25 -0700 (PDT) Message-ID: <4D8A7FFC.60405@cs.ucla.edu> Date: Wed, 23 Mar 2011 16:19:24 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.2 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) I committed my abovementioned workaround into the Emacs trunk on 2011-03-11 (bzr 103589). I don't consider this a fix, though, so I'm leaving this bug report open. From unknown Fri Sep 05 08:41:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8229: possibly uninitialized variable in load_charset Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Jun 2021 08:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8229 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: 8211@debbugs.gnu.org, 8229@debbugs.gnu.org, 8215@debbugs.gnu.org Received: via spool by 8229-submit@debbugs.gnu.org id=B8229.162262102417491 (code B ref 8229); Wed, 02 Jun 2021 08:04:02 +0000 Received: (at 8229) by debbugs.gnu.org; 2 Jun 2021 08:03:44 +0000 Received: from localhost ([127.0.0.1]:38725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loLqm-0004Xu-4h for submit@debbugs.gnu.org; Wed, 02 Jun 2021 04:03:44 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loLqY-0004XF-6d; Wed, 02 Jun 2021 04:03:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Slq47nx2PG3ZnEGfhMdK2/Kq5kusfvZq0WUeHx6yGpk=; b=W4P+umwFKL/IO84Ny++k6n78U9 xo5FNMCASdHi6WSuQsS7yw3wawU0u3c7nKYrYOs+tVNlzneSijaP5bmb7M9N7qkElUkV4yh2rCEWZ Oaz1GOcHd8Egs8d/HDPgeLBvRM4fLXNWjoeV6gaTva5lzqVMupycc3H0ztKKqLLFk6pM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loLqN-0003bg-FT; Wed, 02 Jun 2021 10:03:19 +0200 From: Lars Ingebrigtsen References: <4D796BAD.3060400@cs.ucla.edu> <4D8A7FFC.60405@cs.ucla.edu> X-Now-Playing: Nobukazu Takemura's _Child's View_: "Pastral Waltz" Date: Wed, 02 Jun 2021 10:03:14 +0200 In-Reply-To: <4D8A7FFC.60405@cs.ucla.edu> (Paul Eggert's message of "Wed, 23 Mar 2011 16:19:24 -0700") Message-ID: <87o8coelrx.fsf_-_@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Paul Eggert writes: > I committed my abovementioned workaround into the > Emacs trunk on 2011-03-11 (bzr 103589). I don't > consider this a fix, though, so I'm leaving this > bug report open. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Paul Eggert writes: > I committed my abovementioned workaround into the > Emacs trunk on 2011-03-11 (bzr 103589). I don't > consider this a fix, though, so I'm leaving this > bug report open. This was ten years ago: commit 0ac2c2991c1cba4e3c6e5f7b62c7d61b01d69994 Author: Paul Eggert AuthorDate: Mon Mar 7 16:46:23 2011 -0800 Commit: Paul Eggert CommitDate: Mon Mar 7 16:46:23 2011 -0800 * charset.c (load_charset): Abort instead of using uninitialized var. The code is still pretty much identical, as far as I can tell. Should this report be closed now? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Sep 05 08:41:25 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#8229: closed (Re: bug#8215: bug#8229: possibly uninitialized variable in load_charset) Message-ID: References: <83v96wxwet.fsf@gnu.org> <4D796BAD.3060400@cs.ucla.edu> X-Gnu-PR-Message: they-closed 8229 X-Gnu-PR-Package: emacs Reply-To: 8229@debbugs.gnu.org Date: Wed, 02 Jun 2021 12:52:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1622638322-32566-1" This is a multi-part message in MIME format... ------------=_1622638322-32566-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #8229: possibly uninitialized variable in load_charset which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 8229@debbugs.gnu.org. --=20 8229: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8229 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1622638322-32566-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 8229-done) by debbugs.gnu.org; 2 Jun 2021 12:51:16 +0000 Received: from localhost ([127.0.0.1]:39196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loQL2-0008R1-A1 for submit@debbugs.gnu.org; Wed, 02 Jun 2021 08:51:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loQKx-0008Qn-Sx for 8229-done@debbugs.gnu.org; Wed, 02 Jun 2021 08:51:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46726) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loQKr-0007IU-FP; Wed, 02 Jun 2021 08:51:02 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2672 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loQKr-0001dF-2T; Wed, 02 Jun 2021 08:51:01 -0400 Date: Wed, 02 Jun 2021 15:50:50 +0300 Message-Id: <83v96wxwet.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87o8coelrx.fsf_-_@gnus.org> (message from Lars Ingebrigtsen on Wed, 02 Jun 2021 10:03:14 +0200) Subject: Re: bug#8215: bug#8229: possibly uninitialized variable in load_charset References: <4D796BAD.3060400@cs.ucla.edu> <4D8A7FFC.60405@cs.ucla.edu> <87o8coelrx.fsf_-_@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 8229-done Cc: 8229-done@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Wed, 02 Jun 2021 10:03:14 +0200 > Cc: 8211@debbugs.gnu.org, 8229@debbugs.gnu.org, 8215@debbugs.gnu.org > > Paul Eggert writes: > > > I committed my abovementioned workaround into the > > Emacs trunk on 2011-03-11 (bzr 103589). I don't > > consider this a fix, though, so I'm leaving this > > bug report open. > > This was ten years ago: > > commit 0ac2c2991c1cba4e3c6e5f7b62c7d61b01d69994 > Author: Paul Eggert > AuthorDate: Mon Mar 7 16:46:23 2011 -0800 > Commit: Paul Eggert > CommitDate: Mon Mar 7 16:46:23 2011 -0800 > > * charset.c (load_charset): Abort instead of using uninitialized var. > > The code is still pretty much identical, as far as I can tell. Should > this report be closed now? I'm closing it. I think non-unified charsets are rarely if ever used in Emacs these days, but in any case, we have emacs_abort there, so if the problem ever rears its ugly head, we will catch it. ------------=_1622638322-32566-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Mar 2011 00:24:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pxq9g-0008D3-S4 for submit@debbugs.gnu.org; Thu, 10 Mar 2011 19:24:33 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pxq9e-0008Co-JL for submit@debbugs.gnu.org; Thu, 10 Mar 2011 19:24:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pxq9Y-0001ar-E7 for submit@debbugs.gnu.org; Thu, 10 Mar 2011 19:24:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:56992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pxq9Y-0001am-3V for submit@debbugs.gnu.org; Thu, 10 Mar 2011 19:24:24 -0500 Received: from [140.186.70.92] (port=57562 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pxq9R-0007Xa-Dt for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2011 19:24:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pxq9Q-0001aH-1u for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2011 19:24:16 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:49872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pxq9P-0001a9-Pi for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2011 19:24:16 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 15C5439E80F8; Thu, 10 Mar 2011 16:24:14 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id clze-G0w4o5s; Thu, 10 Mar 2011 16:24:13 -0800 (PST) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id A3F1B39E80DF; Thu, 10 Mar 2011 16:24:13 -0800 (PST) Message-ID: <4D796BAD.3060400@cs.ucla.edu> Date: Thu, 10 Mar 2011 16:24:13 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: possibly uninitialized variable in load_charset Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Kenichi Handa X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Severity: minor I found this problem by compiling Emacs with GCC's -Wuninitialized flag. The following code in the Emacs trunk src/charset.c's load_charset function is suspicious, because as written it appears that it might be using an uninitialized variable: if (CHARSET_METHOD (charset) == CHARSET_METHOD_MAP) map = CHARSET_MAP (charset); else if (CHARSET_UNIFIED_P (charset)) map = CHARSET_UNIFY_MAP (charset); if (STRINGP (map)) ... The last if-test uses "map", but it's not clear from the previous tests that "map" must be initialized. I'm filing a bug report so that someone who is more expert in this code can take a look at it. In the meantime, I plan to work around the problem by replacing: else if (CHARSET_UNIFIED_P (charset)) map = CHARSET_UNIFY_MAP (charset); with: else { if (! CHARSET_UNIFIED_P (charset)) abort (); map = CHARSET_UNIFY_MAP (charset); } I'm CC'ing this to Kenichi Handa, who committed the code in question. ------------=_1622638322-32566-1--