GNU bug report logs - #8184
23.1.90; `menu-bar-non-minibuffer-window-p' error in calls to `kill-this-buffer'

Previous Next

Package: emacs;

Reported by: tlh <thunkout <at> gmail.com>

Date: Sun, 6 Mar 2011 05:29:02 UTC

Severity: normal

Found in version 23.1.90

Done: martin rudalics <rudalics <at> gmx.at>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 8184 <at> debbugs.gnu.org, tlh <thunkout <at> gmail.com>
Subject: bug#8184: 23.1.90;	`menu-bar-non-minibuffer-window-p' error in calls to	`kill-this-buffer'
Date: Sun, 06 Mar 2011 19:19:13 +0100

> ??? This function is bound to the "Close" item in the "File" menu, so
> it is definitely related to the menu bar.

Am I right that the time for executing `kill-this-buffer-enabled-p' is
currently always proportional to the number of live buffers?  In that
case I'd rewrite his function as

(defun kill-this-buffer-enabled-p ()
  (or (not (menu-bar-non-minibuffer-window-p))
      (let (found-1)
	(catch 'found-2
	  (dolist (buffer (buffer-list))
	    (unless (string-match-p "^ " (buffer-name buffer))
	      (if (not found-1)
		  (setq found-1 t)
		(throw 'found-2 t))))))))

martin
This bug report was last modified 12 years and 235 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.