GNU bug report logs - #8178
[PATCH] vc-dir.el -- Use different color for state edited

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8178 in the body.
You can then email your comments to 8178 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jari Aalto <jari.aalto <at> cante.net>
To: submit <at> debbugs.gnu.org
Subject: [PATCH] vc-dir.el -- Use different color for state edited
Date: Sat, 05 Mar 2011 13:39:30 +0200

[Message part 1 (text/plain, inline)]

Package: emacs
Version: Version Control as 2011-03-05 13:39 UTC of git 607177f
Severity: wishlist

When files marked with "edited" are shown in different color, it's easier
to find those that need to be committed.

2011-03-05  Jari Aalto  <jari.aalto <at> cante.net>

	* vc-dir.el (vc-default-dir-printer): For state "edited", use
	`font-lock-constant-face'.

-- System Information
Debian Release: wheezy/sid
  APT Prefers testing
  APT policy: (990, testing) (500, unstable) (1, experimental)
Architecture: amd64
Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Wed Jan 12 03:40:32 UTC 2011 x86_64 GNU/Linux
Locale: LANG=en_DK.UTF-8

-- Versions of packages `emacs depends on'.
Depends:
emacs23         23.2+1-7        GNU Emacs is the extensible self-documenting 
emacs23-lucid   23.2+1-7        GNU Emacs is the extensible self-documenting 
emacs23-nox     23.2+1-7        GNU Emacs is the extensible self-documenting 

[0001-lisp-vc-dir.el-Use-font-lock-constant-face-for-state.patch (text/x-diff, inline)]

From 607177fd88616a21075d57831dfd77a296b70aa3 Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Sat, 5 Mar 2011 13:35:13 +0200
Subject: [PATCH] lisp/vc-dir.el: Use font-lock-constant-face for state edited
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 lisp/vc-dir.el |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lisp/vc-dir.el b/lisp/vc-dir.el
index 61cc857..1b2352c 100644
--- a/lisp/vc-dir.el
+++ b/lisp/vc-dir.el
@@ -1190,6 +1190,7 @@ These are the commands available for use in the file status buffer:
       (format "%-20s" state)
       'face (cond ((eq state 'up-to-date) 'font-lock-builtin-face)
 		  ((memq state '(missing conflict)) 'font-lock-warning-face)
+		  ((eq state 'edited) 'font-lock-constant-face)
 		  (t 'font-lock-variable-name-face))
       'mouse-face 'highlight)
      " "
-- 
1.7.2.3

Message #8 received at 8178 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: 8178 <at> debbugs.gnu.org
Subject: Re: bug#8178: [PATCH] vc-dir.el -- Use different color for state
	edited
Date: Sun, 22 May 2011 15:36:25 -0400

Jari Aalto <jari.aalto <at> cante.net> writes:

> When files marked with "edited" are shown in different color, it's easier
> to find those that need to be committed.
>
> 2011-03-05  Jari Aalto  <jari.aalto <at> cante.net>
>
> 	* vc-dir.el (vc-default-dir-printer): For state "edited", use
> 	`font-lock-constant-face'.

Looks reasonable.  Committed to trunk, thanks.

Message #17 received at 8178 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: 8178 <at> debbugs.gnu.org
Cc: Chong Yidong <cyd <at> stupidchicken.com>, Jari Aalto <jari.aalto <at> cante.net>
Subject: [PATCH] vc-dir.el -- Use different color for state edited
Date: Sat, 30 Jan 2021 15:46:55 +0200

Hi all,

I'm looking at this change now (a bit late, yeah), and it seems 
inconsistent.

If the idea is to "find those that need to be committed", then what 
about the 'added' state? Or 'removed'?

Won't that leave out only 'ignored' and 'unregistered' then? With 
'conflict' and 'missing' being highlighted with 'warning'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.