From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 03:05:11 2011 Received: (at submit) by debbugs.gnu.org; 5 Mar 2011 08:05:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvmUB-0004vB-20 for submit@debbugs.gnu.org; Sat, 05 Mar 2011 03:05:11 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvmU9-0004uz-6q for submit@debbugs.gnu.org; Sat, 05 Mar 2011 03:05:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PvmU3-0003Rp-2I for submit@debbugs.gnu.org; Sat, 05 Mar 2011 03:05:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:60801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PvmU3-0003Rl-0C for submit@debbugs.gnu.org; Sat, 05 Mar 2011 03:05:03 -0500 Received: from [140.186.70.92] (port=47349 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PvmU1-0007eI-T2 for bug-gnu-emacs@gnu.org; Sat, 05 Mar 2011 03:05:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PvmU0-0003QU-RQ for bug-gnu-emacs@gnu.org; Sat, 05 Mar 2011 03:05:01 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:32852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PvmU0-0003QN-MS for bug-gnu-emacs@gnu.org; Sat, 05 Mar 2011 03:05:00 -0500 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p2584uQo013833 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 5 Mar 2011 08:04:57 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p257tQ5p008281 for ; Sat, 5 Mar 2011 08:04:56 GMT Received: from abhmt019.oracle.com by acsmt353.oracle.com with ESMTP id 1111421091299312231; Sat, 05 Mar 2011 00:03:51 -0800 Received: from dradamslap1 (/10.159.51.176) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 05 Mar 2011 00:03:51 -0800 From: "Drew Adams" To: Subject: 24.0.50; `find-file' 2nd time for image file - regression Date: Sat, 5 Mar 2011 00:03:51 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcvbC9zz6x8TXzN9QVa+bN17k3FW/A== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4D71EEA8.00BF,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) 1. This is a regression; it works fine in Emacs 22 and Emacs 23. M-: (find-file "...foo.jpg") where `...foo.jpg' is an absolute file name of an image file (of a type that is supported). The image is displayed - no problem. Good. Now repeat it: M-: (find-file "...foo.jpg") This time you get an annoying dialog. You should just see the image again. Similarly, if you hit RET on the file name in Dired - first time is OK, second time you get sent down the rabbit hole. 2. In addition (but this is *not* the main point of this bug report), the annoying dialog you get uses multiple lines of text (6!) to prompt in the minibuffer (or in a popup, depending on how you invoke the function) for a y-or-n answer. The prompt text is *far* too long and pretty much incomprehensible to an average user. This is the `y-or-n-p' prompt (including its line breaks): "The file maybe-a-very-long-file-name.jpg is already visited literally, meaning no coding system decoding, format conversion, or local variables. You have asked to visit it normally, but Emacs can only visit a file in one way at a time. Do you want to revisit the file normally now? (y or n) " That is _ridiculously_ long and confusing. It is horribly user unfriendly. `find-file-noselect' is now filled to the gills with such gobbledygook prompts, each more twisted and verbose than the next. It's hard to believe that we have been prompting users this way since Emacs 22 (the prompts for this are much shorter in Emacs 21). Fortunately, these prompts not encountered very often. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-02-28 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include' From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 03:56:44 2011 Received: (at 8177-done) by debbugs.gnu.org; 5 Mar 2011 08:56:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvnI3-00061Z-Sv for submit@debbugs.gnu.org; Sat, 05 Mar 2011 03:56:44 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvnI1-00061L-Fb for 8177-done@debbugs.gnu.org; Sat, 05 Mar 2011 03:56:43 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LHK00300U2DE200@a-mtaout23.012.net.il> for 8177-done@debbugs.gnu.org; Sat, 05 Mar 2011 10:56:34 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.183.216]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LHK00394U69D440@a-mtaout23.012.net.il>; Sat, 05 Mar 2011 10:56:34 +0200 (IST) Date: Sat, 05 Mar 2011 10:54:35 +0200 From: Eli Zaretskii Subject: Re: bug#8177: 24.0.50; `find-file' 2nd time for image file - regression In-reply-to: X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83ipvyhrqs.fsf@gnu.org> References: X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 8177-done Cc: 8177-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.7 (-) > From: "Drew Adams" > Date: Sat, 5 Mar 2011 00:03:51 -0800 > Cc: > > 1. This is a regression; it works fine in Emacs 22 and Emacs 23. > > M-: (find-file "...foo.jpg") > > where `...foo.jpg' is an absolute file name of an image file (of a type > that is supported). The image is displayed - no problem. Good. > > Now repeat it: > M-: (find-file "...foo.jpg") > > This time you get an annoying dialog. You should just see the image > again. Similarly, if you hit RET on the file name in Dired - first time > is OK, second time you get sent down the rabbit hole. My bad; fixed now. If you want to try the change, but cannot dump Emacs, apply the patch below, recompile files.el, and manually load files.elc (followed by ls-lisp.elc) into Emacs. > 2. In addition (but this is *not* the main point of this bug report), > the annoying dialog you get uses multiple lines of text (6!) to prompt > in the minibuffer (or in a popup, depending on how you invoke the > function) for a y-or-n answer. The prompt text is *far* too long and > pretty much incomprehensible to an average user. I didn't do anything about this part; suggest a separate bug report, as it's unrelated. === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2011-03-05 04:11:05 +0000 +++ lisp/ChangeLog 2011-03-05 08:48:52 +0000 @@ -1,3 +1,9 @@ +2011-03-05 Eli Zaretskii + + * files.el (find-file-noselect): Don't ask about re-visiting + non-literally if the file is already visited in image-mode. + (Bug#8177) + 2011-03-05 Glenn Morris * eshell/esh-mode.el (eshell-kill-buffer-function): New function. === modified file 'lisp/files.el' --- lisp/files.el 2011-03-03 08:10:52 +0000 +++ lisp/files.el 2011-03-05 08:48:52 +0000 @@ -1894,8 +1894,8 @@ the various files." (not nonexistent) ;; It is confusing to ask whether to visit ;; non-literally if they have the file in - ;; hexl-mode. - (not (eq major-mode 'hexl-mode))) + ;; hexl-mode or image-mode. + (not (memq major-mode '(hexl-mode image-mode)))) (if (buffer-modified-p) (if (y-or-n-p (format From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 10:09:20 2011 Received: (at 8177-done) by debbugs.gnu.org; 5 Mar 2011 15:09:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pvt6e-0006er-4g for submit@debbugs.gnu.org; Sat, 05 Mar 2011 10:09:20 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pvt6c-0006ef-Mq for 8177-done@debbugs.gnu.org; Sat, 05 Mar 2011 10:09:19 -0500 Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p25F9BW2021278 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 5 Mar 2011 15:09:12 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p25F9AxG002049; Sat, 5 Mar 2011 15:09:10 GMT Received: from abhmt003.oracle.com by acsmt353.oracle.com with ESMTP id 1060548581299337734; Sat, 05 Mar 2011 07:08:54 -0800 Received: from dradamslap1 (/10.159.51.176) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 05 Mar 2011 07:08:54 -0800 From: "Drew Adams" To: "'Eli Zaretskii'" References: <83ipvyhrqs.fsf@gnu.org> Subject: RE: bug#8177: 24.0.50; `find-file' 2nd time for image file - regression Date: Sat, 5 Mar 2011 07:08:54 -0800 Message-ID: <9CD6FF7E3F3C4E149771D00CC35DF531@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <83ipvyhrqs.fsf@gnu.org> Thread-Index: AcvbEzy7a3TE6FWKSeCuSOdhSR7l7QAM8uAg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.4D725217.012D,ss=1,fgs=0 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 8177-done Cc: 8177-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > My bad; fixed now. Wow, that was quick. Thank you. > If you want to try the change, but cannot dump > Emacs, apply the patch below, recompile files.el, and manually load > files.elc (followed by ls-lisp.elc) into Emacs. I'll wait until I can get another Windows binary from Sean. > I didn't do anything about this part; suggest a separate bug report, > as it's unrelated. OK. From unknown Fri Aug 15 21:21:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Apr 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator