From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 02 17:31:28 2011 Received: (at submit) by debbugs.gnu.org; 2 Mar 2011 22:31:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuuZr-0005Qr-IQ for submit@debbugs.gnu.org; Wed, 02 Mar 2011 17:31:27 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuuZo-0005Qe-W0 for submit@debbugs.gnu.org; Wed, 02 Mar 2011 17:31:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuuZj-0004Ow-4D for submit@debbugs.gnu.org; Wed, 02 Mar 2011 17:31:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:34106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuuZj-0004Os-1O for submit@debbugs.gnu.org; Wed, 02 Mar 2011 17:31:19 -0500 Received: from [140.186.70.92] (port=38967 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuuZi-00011p-0X for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2011 17:31:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuuZg-0004Oe-ST for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2011 17:31:17 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:32910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuuZg-0004Oa-R0 for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2011 17:31:16 -0500 Received: from eggs.gnu.org ([140.186.70.92]:46628) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1PuuZg-00051M-H7 for bug-emacs@gnu.org; Wed, 02 Mar 2011 17:31:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuuZf-0004OR-1y for bug-emacs@gnu.org; Wed, 02 Mar 2011 17:31:16 -0500 Received: from exprod7og127.obsmtp.com ([64.18.2.210]:35840) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PuuZe-0004O2-QZ for bug-emacs@gnu.org; Wed, 02 Mar 2011 17:31:15 -0500 Received: from source ([209.85.160.41]) (using TLSv1) by exprod7ob127.postini.com ([64.18.6.12]) with SMTP ID DSNKTW7FMHs7O26pn87B/numw3mccQ0xSi+u@postini.com; Wed, 02 Mar 2011 14:31:14 PST Received: by pwi10 with SMTP id 10so121327pwi.28 for ; Wed, 02 Mar 2011 14:31:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.142.242.9 with SMTP id p9mr208178wfh.291.1299105072195; Wed, 02 Mar 2011 14:31:12 -0800 (PST) Received: by 10.142.199.21 with HTTP; Wed, 2 Mar 2011 14:31:12 -0800 (PST) Date: Wed, 2 Mar 2011 22:31:12 +0000 Message-ID: Subject: file-name-sans-version fails for some git files From: Reuben Thomas To: bug-emacs Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) filenames like foo.js.~HEAD~1~ aren't handled properly because of the internal tilde. This is easily fixable by adding tilde to the character class matched against (in emacs-23 it's in the source of file-name-sans-version; in the trunk it's in the more accessible file-name-version-regexp). It seems to me that git is commonly-enough used that this is probably worth fixing in the source rather than leaving to users who notice the problem (especially in emacs-23, where it means redefining file-name-sans-version). -- http://rrt.sc3d.org From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 02 23:00:40 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 04:00:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuziS-0004BH-Ng for submit@debbugs.gnu.org; Wed, 02 Mar 2011 23:00:40 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Puzi5-0004Ak-Pn for 8159@debbugs.gnu.org; Wed, 02 Mar 2011 23:00:38 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LHG00D00R2UF500@a-mtaout22.012.net.il> for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 06:00:11 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.183.216]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LHG00CLDR47ZRD0@a-mtaout22.012.net.il>; Thu, 03 Mar 2011 06:00:10 +0200 (IST) Date: Thu, 03 Mar 2011 05:58:06 +0200 From: Eli Zaretskii Subject: Re: bug#8159: file-name-sans-version fails for some git files In-reply-to: X-012-Sender: halo1@inter.net.il To: Reuben Thomas Message-id: <83zkpcx3ch.fsf@gnu.org> References: X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 8159 Cc: 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > Date: Wed, 2 Mar 2011 22:31:12 +0000 > From: Reuben Thomas > Cc: > > filenames like foo.js.~HEAD~1~ aren't handled properly because of the > internal tilde. What would be the "proper" handling of such a file name? What is the "version" here? > This is easily fixable by adding tilde to the character class matched > against (in emacs-23 it's in the source of file-name-sans-version; in > the trunk it's in the more accessible file-name-version-regexp). > > It seems to me that git is commonly-enough used that this is probably > worth fixing in the source rather than leaving to users who notice the > problem (especially in emacs-23, where it means redefining > file-name-sans-version). file-name-sans-versions is used by Emacs to produce backup file names. The file name you mention is not in the format of backup file names that Emacs uses. Extending file-name-sans-versions in the way you suggest is not enough; we need also extend the format of backup file names to support this. Otherwise, removing the "version", then adding another one will not produce a file name in this format. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 07:03:03 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 12:03:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv7FH-0007HW-31 for submit@debbugs.gnu.org; Thu, 03 Mar 2011 07:03:03 -0500 Received: from exprod7og114.obsmtp.com ([64.18.2.215]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Pv7FE-0007H1-BM for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 07:03:01 -0500 Received: from source ([209.85.214.179]) (using TLSv1) by exprod7ob114.postini.com ([64.18.6.12]) with SMTP ID DSNKTW+DbWkFhXq/FHUc09sZgVP7AHAyNKCZ@postini.com; Thu, 03 Mar 2011 04:03:00 PST Received: by mail-iw0-f179.google.com with SMTP id 10so866323iwc.10 for <8159@debbugs.gnu.org>; Thu, 03 Mar 2011 04:02:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.42.241.193 with SMTP id lf1mr1373074icb.441.1299153773240; Thu, 03 Mar 2011 04:02:53 -0800 (PST) Received: by 10.231.30.203 with HTTP; Thu, 3 Mar 2011 04:02:53 -0800 (PST) In-Reply-To: <83zkpcx3ch.fsf@gnu.org> References: <83zkpcx3ch.fsf@gnu.org> Date: Thu, 3 Mar 2011 12:02:53 +0000 Message-ID: Subject: Re: bug#8159: file-name-sans-version fails for some git files From: Reuben Thomas To: Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 8159 Cc: 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) On 3 March 2011 03:58, Eli Zaretskii wrote: >> Date: Wed, 2 Mar 2011 22:31:12 +0000 >> From: Reuben Thomas >> Cc: >> >> filenames like foo.js.~HEAD~1~ aren't handled properly because of the >> internal tilde. > > What would be the "proper" handling of such a file name? =A0What is the > "version" here? The version is HEAD~1, so the only difference from supported version formats is the internal tilde. I can't see (yet) how this doesn't work with backup file names. In particular, it can't be mistaken for a numbered backup file, since it doesn't end `.~%d~'; on the other hand, both the simple backup suffix ~ and numeric backups suffix `.~%d~' are still correctly stripped by my modified file-name-sans-versions. --=20 http://rrt.sc3d.org From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 08:36:43 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 13:36:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv8hv-0001dM-0l for submit@debbugs.gnu.org; Thu, 03 Mar 2011 08:36:43 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv8ht-0001dC-EF for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 08:36:41 -0500 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Pv8hn-00073w-G4; Thu, 03 Mar 2011 08:36:35 -0500 Date: Thu, 03 Mar 2011 08:36:35 -0500 Message-Id: From: Eli Zaretskii To: Reuben Thomas In-reply-to: (message from Reuben Thomas on Thu, 3 Mar 2011 12:02:53 +0000) Subject: Re: bug#8159: file-name-sans-version fails for some git files References: <83zkpcx3ch.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 8159 Cc: 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) > Date: Thu, 3 Mar 2011 12:02:53 +0000 > From: Reuben Thomas > Cc: 8159@debbugs.gnu.org > > On 3 March 2011 03:58, Eli Zaretskii wrote: > >> Date: Wed, 2 Mar 2011 22:31:12 +0000 > >> From: Reuben Thomas > >> Cc: > >> > >> filenames like foo.js.~HEAD~1~ aren't handled properly because of the > >> internal tilde. > > > > What would be the "proper" handling of such a file name?  What is the > > "version" here? > > The version is HEAD~1, so the only difference from supported version > formats is the internal tilde. If you don't want the version to be "~1~", then I guess this is okay. It wasn't clear from your original message that you don't consider this form a numbered backup file. > I can't see (yet) how this doesn't work with backup file names. In > particular, it can't be mistaken for a numbered backup file, since it > doesn't end `.~%d~'; on the other hand, both the simple backup suffix > ~ and numeric backups suffix `.~%d~' are still correctly stripped by > my modified file-name-sans-versions. If you are okay with having foo.js~ as a simple backup file name of foo.js.~HEAD~1~ and foo.js.~3~ as its numbered backup, then I see no issues here. I just wonder if that would surprise git users (I don't use it too much, so I don't know). From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 08:39:53 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 13:39:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv8kz-0001j0-Is for submit@debbugs.gnu.org; Thu, 03 Mar 2011 08:39:53 -0500 Received: from exprod7og116.obsmtp.com ([64.18.2.219]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Pv8kw-0001ii-2r for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 08:39:51 -0500 Received: from source ([209.85.161.48]) (using TLSv1) by exprod7ob116.postini.com ([64.18.6.12]) with SMTP ID DSNKTW+aH4F0k0XnIrMEoo+fZXPaAFiiTDzt@postini.com; Thu, 03 Mar 2011 05:39:49 PST Received: by fxm2 with SMTP id 2so1213174fxm.21 for <8159@debbugs.gnu.org>; Thu, 03 Mar 2011 05:39:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.72.9 with SMTP id k9mr1466604faj.93.1299159572471; Thu, 03 Mar 2011 05:39:32 -0800 (PST) Received: by 10.223.73.201 with HTTP; Thu, 3 Mar 2011 05:39:32 -0800 (PST) In-Reply-To: References: <83zkpcx3ch.fsf@gnu.org> Date: Thu, 3 Mar 2011 13:39:32 +0000 Message-ID: Subject: Re: bug#8159: file-name-sans-version fails for some git files From: Reuben Thomas To: Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 8159 Cc: 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) On 3 March 2011 13:36, Eli Zaretskii wrote: > > If you are okay with having foo.js~ as a simple backup file name of > foo.js.~HEAD~1~ and foo.js.~3~ as its numbered backup, then I see no > issues here. =A0I just wonder if that would surprise git users (I don't > use it too much, so I don't know). Why would you have a backup of such a file? It's a file visited with vc-revision-other-window, which is by default read-only. The question arises equally for other VC systems, it's just that not all of them allow version numbers that contain tildes. --=20 http://rrt.sc3d.org From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 08:57:33 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 13:57:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv925-000278-4w for submit@debbugs.gnu.org; Thu, 03 Mar 2011 08:57:33 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv923-00026y-SU for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 08:57:32 -0500 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Pv91x-0007zE-PA; Thu, 03 Mar 2011 08:57:25 -0500 Date: Thu, 03 Mar 2011 08:57:25 -0500 Message-Id: From: Eli Zaretskii To: Reuben Thomas In-reply-to: (message from Reuben Thomas on Thu, 3 Mar 2011 13:39:32 +0000) Subject: Re: bug#8159: file-name-sans-version fails for some git files References: <83zkpcx3ch.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 8159 Cc: 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) > Date: Thu, 3 Mar 2011 13:39:32 +0000 > From: Reuben Thomas > Cc: 8159@debbugs.gnu.org > > On 3 March 2011 13:36, Eli Zaretskii wrote: > > > > If you are okay with having foo.js~ as a simple backup file name of > > foo.js.~HEAD~1~ and foo.js.~3~ as its numbered backup, then I see no > > issues here.  I just wonder if that would surprise git users (I don't > > use it too much, so I don't know). > > Why would you have a backup of such a file? Because vc-make-backup-files is set non-nil? > It's a file visited with > vc-revision-other-window, which is by default read-only. Is that the only way to visit files with such names? Anyway, your change is not limited to this particular situation, it is more general. It will affect any file of that form, anywhere. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 09:00:57 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 14:00:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv95M-0002CP-Sf for submit@debbugs.gnu.org; Thu, 03 Mar 2011 09:00:57 -0500 Received: from exprod7og115.obsmtp.com ([64.18.2.217]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Pv95K-0002C8-3U for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 09:00:55 -0500 Received: from source ([209.85.161.49]) (using TLSv1) by exprod7ob115.postini.com ([64.18.6.12]) with SMTP ID DSNKTW+fD2aqFn7Agda2m4LxE5JJIqV9GsAi@postini.com; Thu, 03 Mar 2011 06:00:53 PST Received: by mail-fx0-f49.google.com with SMTP id 16so1207857fxm.36 for <8159@debbugs.gnu.org>; Thu, 03 Mar 2011 06:00:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.78.138 with SMTP id l10mr1535168fak.17.1299160847370; Thu, 03 Mar 2011 06:00:47 -0800 (PST) Received: by 10.223.73.201 with HTTP; Thu, 3 Mar 2011 06:00:47 -0800 (PST) In-Reply-To: References: <83zkpcx3ch.fsf@gnu.org> Date: Thu, 3 Mar 2011 14:00:47 +0000 Message-ID: Subject: Re: bug#8159: file-name-sans-version fails for some git files From: Reuben Thomas To: Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 8159 Cc: 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) On 3 March 2011 13:57, Eli Zaretskii wrote: > Anyway, your change is not limited to this particular situation, it is > more general. =A0It will affect any file of that form, anywhere. Sure. What I am trying to understand is why this change should be any more of a problem than the currently-accepted suffixes for VC systems. You said earlier: > If you are okay with having foo.js~ as a simple backup file name of > foo.js.~HEAD~1~ and foo.js.~3~ as its numbered backup, > then I see no issues here Indeed, I don't have a problem with this; I was just trying to point out that because of the way these suffixes normally arise, they rarely have backups. --=20 http://rrt.sc3d.org From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 09:33:41 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 14:33:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv9b3-0002vW-G3 for submit@debbugs.gnu.org; Thu, 03 Mar 2011 09:33:41 -0500 Received: from mail-out.m-online.net ([212.18.0.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv9b0-0002vJ-8X for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 09:33:39 -0500 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 4B993188A197; Thu, 3 Mar 2011 15:33:32 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id 65A801C001BE; Thu, 3 Mar 2011 15:33:32 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id xld8aBYmTEj4; Thu, 3 Mar 2011 15:33:31 +0100 (CET) Received: from hase (ppp-93-104-156-198.dynamic.mnet-online.de [93.104.156.198]) by mail.mnet-online.de (Postfix) with ESMTP; Thu, 3 Mar 2011 15:33:31 +0100 (CET) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#8159: file-name-sans-version fails for some git files References: <83zkpcx3ch.fsf@gnu.org> X-Yow: Mary Tyler Moore's SEVENTH HUSBAND is wearing my DACRON TANK TOP in a cheap hotel in HONOLULU! Date: Thu, 03 Mar 2011 15:33:30 +0100 In-Reply-To: (Eli Zaretskii's message of "Thu, 03 Mar 2011 08:36:35 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8159 Cc: 8159@debbugs.gnu.org, Reuben Thomas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Eli Zaretskii writes: >> Date: Thu, 3 Mar 2011 12:02:53 +0000 >> From: Reuben Thomas >> Cc: 8159@debbugs.gnu.org >>=20 >> On 3 March 2011 03:58, Eli Zaretskii wrote: >> >> Date: Wed, 2 Mar 2011 22:31:12 +0000 >> >> From: Reuben Thomas >> >> Cc: >> >> >> >> filenames like foo.js.~HEAD~1~ aren't handled properly because of the >> >> internal tilde. >> > >> > What would be the "proper" handling of such a file name? =C2=A0What is= the >> > "version" here? >>=20 >> The version is HEAD~1, so the only difference from supported version >> formats is the internal tilde. > > If you don't want the version to be "~1~", then I guess this is okay. It cannot be the version because it lacks the period. Andreas. --=20 Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 09:35:18 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 14:35:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv9cb-0002xw-QV for submit@debbugs.gnu.org; Thu, 03 Mar 2011 09:35:17 -0500 Received: from exprod7og124.obsmtp.com ([64.18.2.26]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Pv9cZ-0002xg-R3 for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 09:35:16 -0500 Received: from source ([209.85.161.51]) (using TLSv1) by exprod7ob124.postini.com ([64.18.6.12]) with SMTP ID DSNKTW+nHYbUL4qelT1U+SdtXnxi95jFPz68@postini.com; Thu, 03 Mar 2011 06:35:15 PST Received: by fxm11 with SMTP id 11so1133345fxm.10 for <8159@debbugs.gnu.org>; Thu, 03 Mar 2011 06:35:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.78.138 with SMTP id l10mr1576668fak.17.1299162905502; Thu, 03 Mar 2011 06:35:05 -0800 (PST) Received: by 10.223.73.201 with HTTP; Thu, 3 Mar 2011 06:35:05 -0800 (PST) In-Reply-To: References: <83zkpcx3ch.fsf@gnu.org> Date: Thu, 3 Mar 2011 14:35:05 +0000 Message-ID: Subject: Re: bug#8159: file-name-sans-version fails for some git files From: Reuben Thomas To: Andreas Schwab Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 8159 Cc: Eli Zaretskii , 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) On 3 March 2011 14:33, Andreas Schwab wrote: > > It cannot be the version because it lacks the period. I think you're confusing two things: the VC version and the backup version. Eli was talking (if I understood correctly) about the VC version (which could be ~1~, e.g. in Subversion). -- http://rrt.sc3d.org From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 09:45:12 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 14:45:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv9mB-0003Cb-RV for submit@debbugs.gnu.org; Thu, 03 Mar 2011 09:45:12 -0500 Received: from mail-out.m-online.net ([212.18.0.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv9m8-0003CO-FB for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 09:45:09 -0500 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id B7E60186DED1; Thu, 3 Mar 2011 15:45:02 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id C18821C001A5; Thu, 3 Mar 2011 15:45:02 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id xXbxiNMe+uD9; Thu, 3 Mar 2011 15:45:02 +0100 (CET) Received: from hase (ppp-93-104-156-198.dynamic.mnet-online.de [93.104.156.198]) by mail.mnet-online.de (Postfix) with ESMTP; Thu, 3 Mar 2011 15:45:01 +0100 (CET) From: Andreas Schwab To: Reuben Thomas Subject: Re: bug#8159: file-name-sans-version fails for some git files References: <83zkpcx3ch.fsf@gnu.org> X-Yow: I'm EXCITED!! I want a FLANK STEAK WEEK-END!! I think I'm JULIA CHILD!! Date: Thu, 03 Mar 2011 15:45:01 +0100 In-Reply-To: (Reuben Thomas's message of "Thu, 3 Mar 2011 14:35:05 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8159 Cc: Eli Zaretskii , 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Reuben Thomas writes: > On 3 March 2011 14:33, Andreas Schwab wrote: >> >> It cannot be the version because it lacks the period. > > I think you're confusing two things: the VC version and the backup > version. Eli was talking (if I understood correctly) about the VC > version (which could be ~1~, e.g. in Subversion). No, it would be ".~1~". A version suffix will always start with a period. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 09:56:29 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 14:56:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv9x7-0003a5-2P for submit@debbugs.gnu.org; Thu, 03 Mar 2011 09:56:29 -0500 Received: from exprod7og102.obsmtp.com ([64.18.2.157]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Pv9x5-0003Zr-4m for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 09:56:28 -0500 Received: from source ([209.85.161.42]) (using TLSv1) by exprod7ob102.postini.com ([64.18.6.12]) with SMTP ID DSNKTW+sFEitKDyG7MBJLNfhU6jLQJKeXsCJ@postini.com; Thu, 03 Mar 2011 06:56:26 PST Received: by fxm20 with SMTP id 20so1453130fxm.15 for <8159@debbugs.gnu.org>; Thu, 03 Mar 2011 06:56:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.72.9 with SMTP id k9mr1558718faj.93.1299164014330; Thu, 03 Mar 2011 06:53:34 -0800 (PST) Received: by 10.223.73.201 with HTTP; Thu, 3 Mar 2011 06:53:34 -0800 (PST) In-Reply-To: References: <83zkpcx3ch.fsf@gnu.org> Date: Thu, 3 Mar 2011 14:53:34 +0000 Message-ID: Subject: Re: bug#8159: file-name-sans-version fails for some git files From: Reuben Thomas To: Andreas Schwab Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 8159 Cc: Eli Zaretskii , 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) On 3 March 2011 14:45, Andreas Schwab wrote: > Reuben Thomas writes: > >> On 3 March 2011 14:33, Andreas Schwab wrote: >>> >>> It cannot be the version because it lacks the period. >> >> I think you're confusing two things: the VC version and the backup >> version. Eli was talking (if I understood correctly) about the VC >> version (which could be ~1~, e.g. in Subversion). > > No, it would be ".~1~". =A0A version suffix will always start with a > period. Sorry, I see what you mean, and that's why it's not ambiguous. --=20 http://rrt.sc3d.org From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 10:09:47 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 15:09:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvA9z-0003rx-Jk for submit@debbugs.gnu.org; Thu, 03 Mar 2011 10:09:47 -0500 Received: from mail-out.m-online.net ([212.18.0.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvA9x-0003rj-Us for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 10:09:46 -0500 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 59C8E1853BBB; Thu, 3 Mar 2011 16:09:40 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id 737F01C0019B; Thu, 3 Mar 2011 16:09:40 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id BgNPBweUoBrd; Thu, 3 Mar 2011 16:09:38 +0100 (CET) Received: from hase (ppp-93-104-156-198.dynamic.mnet-online.de [93.104.156.198]) by mail.mnet-online.de (Postfix) with ESMTP; Thu, 3 Mar 2011 16:09:38 +0100 (CET) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#8159: file-name-sans-version fails for some git files References: <83zkpcx3ch.fsf@gnu.org> X-Yow: I'm wet! I'm wild! Date: Thu, 03 Mar 2011 16:09:37 +0100 In-Reply-To: (Eli Zaretskii's message of "Thu, 03 Mar 2011 08:57:25 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8159 Cc: 8159@debbugs.gnu.org, Reuben Thomas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Eli Zaretskii writes: > Anyway, your change is not limited to this particular situation, it is > more general. It will affect any file of that form, anywhere. file-name-version-regexp is already very general. But one problem is that by adding ~ it would match backups of backups. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 10:26:45 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 15:26:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvAQO-0004FB-Qn for submit@debbugs.gnu.org; Thu, 03 Mar 2011 10:26:45 -0500 Received: from exprod7og122.obsmtp.com ([64.18.2.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PvAQM-0004Ee-K3 for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 10:26:43 -0500 Received: from source ([209.85.161.54]) (using TLSv1) by exprod7ob122.postini.com ([64.18.6.12]) with SMTP ID DSNKTW+zHRYM1T+DivPIovlSnSAqjuOrfjqN@postini.com; Thu, 03 Mar 2011 07:26:27 PST Received: by mail-fx0-f54.google.com with SMTP id 19so1356781fxm.13 for <8159@debbugs.gnu.org>; Thu, 03 Mar 2011 07:26:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.101.131 with SMTP id c3mr1659555fao.5.1299165965452; Thu, 03 Mar 2011 07:26:05 -0800 (PST) Received: by 10.223.74.140 with HTTP; Thu, 3 Mar 2011 07:26:05 -0800 (PST) In-Reply-To: References: <83zkpcx3ch.fsf@gnu.org> Date: Thu, 3 Mar 2011 15:26:05 +0000 Message-ID: Subject: Re: bug#8159: file-name-sans-version fails for some git files From: Reuben Thomas To: Andreas Schwab Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 8159 Cc: Eli Zaretskii , 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) On 3 March 2011 15:09, Andreas Schwab wrote: > Eli Zaretskii writes: > >> Anyway, your change is not limited to this particular situation, it is >> more general. =A0It will affect any file of that form, anywhere. > > file-name-version-regexp is already very general. =A0But one problem is > that by adding ~ it would match backups of backups. To be precise, it would match non-numbered backups of non-numbered backups of non-numbered backups, and non-numbered backups of numbered backups: the current pattern requires either a single ~, or two tildes with at least one other character between them. To fix this would require specifying that an internal tilde is preceded and followed by at least one character from the rest of the character class [-[:alnum:]:#@^._] (or, if you just want to cope with git notation, then preceded by one such character, and followed by a digit), i.e. something like \\(?:~\\|\\.~[-[:alnum:]:#@^._]+\\([-[:alnum:]:#@^._~]*[-[:alnum:]:#@^._]+\= \)?~\\) --=20 http://rrt.sc3d.org From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 11:23:55 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 16:23:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvBJj-0005gy-BH for submit@debbugs.gnu.org; Thu, 03 Mar 2011 11:23:55 -0500 Received: from mail-out.m-online.net ([212.18.0.9]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvBJg-0005gk-RO for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 11:23:53 -0500 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id C4C941C0F580; Thu, 3 Mar 2011 17:23:46 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id A785F1C00149; Thu, 3 Mar 2011 17:23:46 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id BZjOZfyq077n; Thu, 3 Mar 2011 17:23:46 +0100 (CET) Received: from hase (ppp-93-104-156-198.dynamic.mnet-online.de [93.104.156.198]) by mail.mnet-online.de (Postfix) with ESMTP; Thu, 3 Mar 2011 17:23:45 +0100 (CET) From: Andreas Schwab To: Reuben Thomas Subject: Re: bug#8159: file-name-sans-version fails for some git files References: <83zkpcx3ch.fsf@gnu.org> X-Yow: I just had my entire INTESTINAL TRACT coated with TEFLON! Date: Thu, 03 Mar 2011 17:23:45 +0100 In-Reply-To: (Reuben Thomas's message of "Thu, 3 Mar 2011 15:26:05 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 8159 Cc: 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Reuben Thomas writes: > \\(?:~\\|\\.~[-[:alnum:]:#@^._]+\\([-[:alnum:]:#@^._~]*[-[:alnum:]:#@^._]+\\)?~\\) That still matches ".~1~.~2~". Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 17:58:24 2011 Received: (at 8159) by debbugs.gnu.org; 3 Mar 2011 22:58:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvHTU-0006od-6e for submit@debbugs.gnu.org; Thu, 03 Mar 2011 17:58:24 -0500 Received: from exprod7og125.obsmtp.com ([64.18.2.28]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PvHTR-0006oQ-Ba for 8159@debbugs.gnu.org; Thu, 03 Mar 2011 17:58:22 -0500 Received: from source ([209.85.161.46]) (using TLSv1) by exprod7ob125.postini.com ([64.18.6.12]) with SMTP ID DSNKTXAdBitU7Lj4s+AzB5gsK8h/e/zMBuwN@postini.com; Thu, 03 Mar 2011 14:58:21 PST Received: by mail-fx0-f46.google.com with SMTP id 17so1627538fxm.19 for <8159@debbugs.gnu.org>; Thu, 03 Mar 2011 14:58:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.101.136 with SMTP id c8mr2173000fao.100.1299193094691; Thu, 03 Mar 2011 14:58:14 -0800 (PST) Received: by 10.223.74.140 with HTTP; Thu, 3 Mar 2011 14:58:14 -0800 (PST) In-Reply-To: References: <83zkpcx3ch.fsf@gnu.org> Date: Thu, 3 Mar 2011 22:58:14 +0000 Message-ID: Subject: Re: bug#8159: file-name-sans-version fails for some git files From: Reuben Thomas To: Andreas Schwab Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 8159 Cc: 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) On 3 March 2011 16:23, Andreas Schwab wrote: > Reuben Thomas writes: > >> \\(?:~\\|\\.~[-[:alnum:]:#@^._]+\\([-[:alnum:]:#@^._~]*[-[:alnum:]:#@^._]+\\)?~\\) > > That still matches ".~1~.~2~". \\(?:~\\|\\.~[-[:alnum:]:#@^._]+\\(~[[:digit:]]+\\)?~\\) would cope with just the git version scheme, while not swallowing multiple backup suffixes. -- http://rrt.sc3d.org From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 04 02:59:00 2011 Received: (at 8159) by debbugs.gnu.org; 4 Mar 2011 07:59:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvPue-0002Tg-GW for submit@debbugs.gnu.org; Fri, 04 Mar 2011 02:59:00 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvPuc-0002TS-MB for 8159@debbugs.gnu.org; Fri, 04 Mar 2011 02:59:00 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LHI00A00WRQBB00@a-mtaout22.012.net.il> for 8159@debbugs.gnu.org; Fri, 04 Mar 2011 09:57:52 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.183.216]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LHI008NMWSEX5F0@a-mtaout22.012.net.il>; Fri, 04 Mar 2011 09:57:52 +0200 (IST) Date: Fri, 04 Mar 2011 09:55:51 +0200 From: Eli Zaretskii Subject: Re: bug#8159: file-name-sans-version fails for some git files In-reply-to: X-012-Sender: halo1@inter.net.il To: Reuben Thomas Message-id: <83pqq7iak8.fsf@gnu.org> References: <83zkpcx3ch.fsf@gnu.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 8159 Cc: schwab@linux-m68k.org, 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > Date: Thu, 3 Mar 2011 22:58:14 +0000 > From: Reuben Thomas > Cc: 8159@debbugs.gnu.org > > \\(?:~\\|\\.~[-[:alnum:]:#@^._]+\\(~[[:digit:]]+\\)?~\\) > > would cope with just the git version scheme, while not swallowing > multiple backup suffixes. I would suggest a comment mentioning the git case with an example. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 11:42:51 2011 Received: (at 8159) by debbugs.gnu.org; 5 Mar 2011 16:42:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvuZ9-0000GT-F3 for submit@debbugs.gnu.org; Sat, 05 Mar 2011 11:42:51 -0500 Received: from exprod7og125.obsmtp.com ([64.18.2.28]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PvuZ6-0000GG-Co for 8159@debbugs.gnu.org; Sat, 05 Mar 2011 11:42:49 -0500 Received: from source ([209.85.161.50]) (using TLSv1) by exprod7ob125.postini.com ([64.18.6.12]) with SMTP ID DSNKTXJoAg7L0yBiiNP2YFicV0JCUgosmkSv@postini.com; Sat, 05 Mar 2011 08:42:48 PST Received: by fxm18 with SMTP id 18so2775450fxm.9 for <8159@debbugs.gnu.org>; Sat, 05 Mar 2011 08:42:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.2.205 with SMTP id 13mr2436903fak.138.1299343360647; Sat, 05 Mar 2011 08:42:40 -0800 (PST) Received: by 10.223.74.140 with HTTP; Sat, 5 Mar 2011 08:42:40 -0800 (PST) In-Reply-To: <83pqq7iak8.fsf@gnu.org> References: <83zkpcx3ch.fsf@gnu.org> <83pqq7iak8.fsf@gnu.org> Date: Sat, 5 Mar 2011 16:42:40 +0000 Message-ID: Subject: Re: bug#8159: file-name-sans-version fails for some git files From: Reuben Thomas To: Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 8159 Cc: schwab@linux-m68k.org, 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) On 4 March 2011 07:55, Eli Zaretskii wrote: >> Date: Thu, 3 Mar 2011 22:58:14 +0000 >> From: Reuben Thomas >> Cc: 8159@debbugs.gnu.org >> >> \\(?:~\\|\\.~[-[:alnum:]:#@^._]+\\(~[[:digit:]]+\\)?~\\) >> >> would cope with just the git version scheme, while not swallowing >> multiple backup suffixes. > > I would suggest a comment mentioning the git case with an example. So, something like: (defvar file-name-version-regexp "\\(?:~\\|\\.~[-[:alnum:]:#@^._]+\\(~[[:digit:]]+\\)?~\\)" ;; The optional ~[[:digit]]+ matches relative versions in git like `HEAD~2' "Regular expression matching the backup/version part of a file name. Used by `file-name-sans-versions'.") ? -- http://rrt.sc3d.org From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 12:02:09 2011 Received: (at 8159) by debbugs.gnu.org; 5 Mar 2011 17:02:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pvuro-0000gt-Q8 for submit@debbugs.gnu.org; Sat, 05 Mar 2011 12:02:08 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pvurn-0000gQ-82 for 8159@debbugs.gnu.org; Sat, 05 Mar 2011 12:02:08 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LHL00B00GMD9Q00@a-mtaout21.012.net.il> for 8159@debbugs.gnu.org; Sat, 05 Mar 2011 19:02:00 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.58.59]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LHL00BMPGNA9820@a-mtaout21.012.net.il>; Sat, 05 Mar 2011 19:02:00 +0200 (IST) Date: Sat, 05 Mar 2011 19:00:01 +0200 From: Eli Zaretskii Subject: Re: bug#8159: file-name-sans-version fails for some git files In-reply-to: X-012-Sender: halo1@inter.net.il To: Reuben Thomas Message-id: <8362rxiju6.fsf@gnu.org> References: <83zkpcx3ch.fsf@gnu.org> <83pqq7iak8.fsf@gnu.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 8159 Cc: schwab@linux-m68k.org, 8159@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > Date: Sat, 5 Mar 2011 16:42:40 +0000 > From: Reuben Thomas > Cc: schwab@linux-m68k.org, 8159@debbugs.gnu.org > > >> \\(?:~\\|\\.~[-[:alnum:]:#@^._]+\\(~[[:digit:]]+\\)?~\\) > >> > >> would cope with just the git version scheme, while not swallowing > >> multiple backup suffixes. > > > > I would suggest a comment mentioning the git case with an example. > > So, something like: > > (defvar file-name-version-regexp > "\\(?:~\\|\\.~[-[:alnum:]:#@^._]+\\(~[[:digit:]]+\\)?~\\)" > ;; The optional ~[[:digit]]+ matches relative versions in git like `HEAD~2' > "Regular expression matching the backup/version part of a file name. > Used by `file-name-sans-versions'.") > > ? Yes, that's fine. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 17:02:25 2011 Received: (at 8159) by debbugs.gnu.org; 5 Mar 2011 22:02:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvzYP-00088w-7m for submit@debbugs.gnu.org; Sat, 05 Mar 2011 17:02:25 -0500 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvzYG-00087L-JG for 8159@debbugs.gnu.org; Sat, 05 Mar 2011 17:02:18 -0500 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p25M2Aih017914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 5 Mar 2011 17:02:10 -0500 Received: by furball (Postfix, from userid 1000) id 64F0C160783; Sat, 5 Mar 2011 15:36:07 -0500 (EST) From: Chong Yidong To: Eli Zaretskii Subject: Re: bug#8159: file-name-sans-version fails for some git files References: <83zkpcx3ch.fsf@gnu.org> <83pqq7iak8.fsf@gnu.org> <8362rxiju6.fsf@gnu.org> Date: Sat, 05 Mar 2011 15:36:07 -0500 In-Reply-To: <8362rxiju6.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Mar 2011 19:00:01 +0200") Message-ID: <87zkp9fgp4.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 8159 Cc: schwab@linux-m68k.org, 8159@debbugs.gnu.org, Reuben Thomas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Eli Zaretskii writes: >> So, something like: >> >> (defvar file-name-version-regexp >> "\\(?:~\\|\\.~[-[:alnum:]:#@^._]+\\(~[[:digit:]]+\\)?~\\)" >> ;; The optional ~[[:digit]]+ matches relative versions in git like `HEAD~2' >> "Regular expression matching the backup/version part of a file name. >> Used by `file-name-sans-versions'.") > > Yes, that's fine. Thanks. Committed to trunk. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 17:02:22 2011 Received: (at control) by debbugs.gnu.org; 5 Mar 2011 22:02:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvzYM-00088a-6T for submit@debbugs.gnu.org; Sat, 05 Mar 2011 17:02:22 -0500 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvzYF-00087D-Um for control@debbugs.gnu.org; Sat, 05 Mar 2011 17:02:18 -0500 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id p25M2AiX030968 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 5 Mar 2011 17:02:10 -0500 Received: by furball (Postfix, from userid 1000) id 016F2160789; Sat, 5 Mar 2011 15:36:18 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 8159 Date: Sat, 05 Mar 2011 15:36:18 -0500 Message-ID: <87tyfhz4n1.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 8159 thanks From unknown Sun Jun 22 19:06:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Apr 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator