GNU bug report logs - #8154
du: issue with `--files0-from=DIR'

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>
Cc: 8154 <at> debbugs.gnu.org, bug-gnulib <bug-gnulib <at> gnu.org>, Stefan Vargyas <stvar <at> yahoo.com>, Eric Blake <eblake <at> redhat.com>
Subject: bug#8154: du: issue with `--files0-from=DIR'
Date: Wed, 02 Mar 2011 09:10:32 -0800

On 03/02/2011 07:09 AM, Jim Meyering wrote:
> -  struct argv_iterator *ai = malloc (sizeof *ai);
> +  struct argv_iterator *ai;
> +  struct stat st;
> +
> +  if (fstat (fileno (fp),&st) == 0&&  S_ISDIR (st.st_mode))
> +    {
> +      errno = EISDIR;
> +      return NULL;
> +    }
> +
> +  ai = malloc (sizeof *ai);

My kneejerk reaction is that this part of the patch
should not be needed (though other fixes obviously are).
There are lots of reasons that the stream could fail:
why check for directories specially?  Just let the
stream fail in the way that it normally would; this
keeps the code smaller and simpler.  On an ancient
host where "cat dir/" works, "du --files0-from=dir/"
should not arbitrarily fail.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.